GitLab

When building using jumbo, files gets merged and
the compiler gets a larger scope. AddressField is
defined in both autofill::AddressField and
::i18n::addressinput::AddressField and the
reference is ambiguous. That is the reason
the namespace autofill:: needs to be specified
even though the call is made within that namespace.

Bug: 869381
Change-Id: I3ac8813403e04b37b7936397e617aab436214056
Reviewed-on: https://chromium-review.googlesource.com/1169012Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#581864}

https://chromium.googlesource.com/catapult.git/+log/8fa35d11d312..b04cdc9bc5e1


git log 8fa35d11d312..b04cdc9bc5e1 --date=short --no-merges --format='%ad %ae %s'
2018-08-09 wangge@google.com Fix Minor Path Issue.
2018-08-08 achuith@chromium.org Disable testSmokeIsBrowserRunningReturnFalse on chromeos.


Created with:
  gclient setdep -r src/third_party/catapult@b04cdc9bc5e1

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863390
TBR=sullivan@chromium.org

Change-Id: I1275ee52b09f04b678a1e7460a766d501df143af
Reviewed-on: https://chromium-review.googlesource.com/1168926Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581863}

https://pdfium.googlesource.com/pdfium.git/+log/f765805983d1..60627d6eafd0


git log f765805983d1..60627d6eafd0 --date=short --no-merges --format='%ad %ae %s'
2018-08-09 thestig@chromium.org Change CPDF_Font::GetNextChar()'s in-out parameter to pass by pointer.
2018-08-09 thestig@chromium.org Revert "Rework of CPDF_Parser::GetLastObjNum."


Created with:
  gclient setdep -r src/third_party/pdfium@60627d6eafd0

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I444c631e6a75fba79aa1f5f916966062272514cc
Reviewed-on: https://chromium-review.googlesource.com/1168925Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581862}

This method was used for style sharing which was removed for issue
721517. Removed unit tests for ScopedStyleResolver which only tested
this API.

Bug: 721517
Change-Id: Idebecd6b6b66bbf6a229bcf35669e6c4c5bda055
Reviewed-on: https://chromium-review.googlesource.com/1169015Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581861}

Bug: 871266
Change-Id: Ie6e0075b343b6035ab29d8e23d5d2fe065a7f62e
Reviewed-on: https://chromium-review.googlesource.com/1165549Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581860}

Bug:827156
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ic2fbf6e01d967fb64d5b0de03d8d5fa860243628
TBR=jbudorick@chromium.org

NOTRY=true # flake

Change-Id: Ic2fbf6e01d967fb64d5b0de03d8d5fa860243628
Reviewed-on: https://chromium-review.googlesource.com/1168661
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581859}

Using wpt-import in Chromium cc03e427.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22573

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources
kojii@chromium.org:
  external/wpt/css/css-text/overflow-wrap
mtrofin@chromium.org:
  external/wpt/wasm
rego@igalia.com:
  external/wpt/css/css-grid
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
worker-dev@chromium.org:
  external/wpt/workers
  external/wpt/worklets

NOAUTOREVERT=true
TBR=kereliuk

No-Export: true
Change-Id: I33dd7b8c510c2676d1635335e33ebfa607eca47c
Reviewed-on: https://chromium-review.googlesource.com/1168738
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581858}

I *think* this was added for "associated URL loaders" in
https://crrev.com/fe95d9b23ae824, which was reversed, so
I'm thinking DelegatingURLLoader isn't needed. At least, the tests
seem to pass.

We were holding on to the delegating loader on the browser side for
lifetime in URLLoaderAssets, but it looks like the renderer holds
on to its loader anyway while the nav preload is ongoing in
ServiceWorkerContextClient::NavigationPreloadRequest, so it looks
correct to rely on the renderer to do it.

This was inspired by the linked bug, but not expected to solve it.

Bug: 866335
Change-Id: I3b87887e72613e089b99b9d4a91cc76ebc0d620d
Reviewed-on: https://chromium-review.googlesource.com/1168943
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581857}

Static WebView methods are implemented using the class
WebViewFactoryProvider.Statics, in this CL we implement the
corresponding class for the WebView support library.

Bug: 851995
Change-Id: I2f9ed164d3b468acf77feaff4b0f192724ff511e
Reviewed-on: https://chromium-review.googlesource.com/1148384
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581856}

It records, when configuring the data types, whether we're configuring
the full Sync feature or only the Sync transport layer.

Bug: 856179
Change-Id: I8b1453c30dcbb96c7d1028d0c5de467b5fdb2197
Reviewed-on: https://chromium-review.googlesource.com/1167061Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581855}

The unittest still requires knowledge of SigninManager, as the IdentityManager testing facilities
being used require passing in the SigninManager.
Affects media_router_contextual_menu_unittest.cc

Bug: 797897
Change-Id: I94d3fd68cff3143e461dc9ece3ae860d28d1f3ae
Reviewed-on: https://chromium-review.googlesource.com/1139061
Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581854}

fast/events/middleClickAutoscroll-nested-divs.html

TBR=sahel@chromium.org
NOTRY=true

Bug: 851090
Change-Id: Iead1902129d55753ed00ebf4c3d4d7ee1e6fbc71
Reviewed-on: https://chromium-review.googlesource.com/1169048Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581853}

I neglected to flush one of the interfaces in r581387.

Bug: 862294
Change-Id: Ifaa93c99b160916f34520fa6f840976e0847ae97
Reviewed-on: https://chromium-review.googlesource.com/1168956
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581852}

SetNextDelayedDoWork() now disregarded in most cases because DoWork()
can schedule delayed wake-ups.
ScheduleWork() now directly delegates to MessagePump because it's
cheaper than testing that we're inside of DoWork().

Bug: 828835
Change-Id: I8417607d73f695099b37bc1066ccdd317b6e190a
Reviewed-on: https://chromium-review.googlesource.com/1167508Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581851}

This is a reland of 76c395e0

Reason for reland: slider initial position was broken.

Original change's description:
> Fix UnifiedVolumeView asan failure during closing.
>
> This CL fixes UnifiedVolumeView asan failure when
> 1. the slider is in unified system tray main bubble
> 2. volume key is pressed during bubble fade out animation
>
> This is because controllers are deleted before views are deleted. This
> is intented because usually controllers are called only when a user
> makes mouse event in the bubble. Slider is an exception because
> it also notifies controller that value is changed by API although
> it's ignored on controller side. Other possible fixes are:
>
> * Make controller ptr in the view WeakPtr.
> * UnifiedSliderView implement Slider listener and not forward changes
>   caused by API.
>
> The CL is the least verbose fix.
>
> TEST=manual
> BUG=871005
>
> Change-Id: Ifb40b4107e1a04936bf6cd6e0649139498e15746
> Reviewed-on: https://chromium-review.googlesource.com/1164962
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581759}

Bug: 871005
Change-Id: I24691cfe371e08251ed13c24b3a60db1e1b2cb9f
Reviewed-on: https://chromium-review.googlesource.com/1168882
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581850}

Do not attempt connection migration with probes when path degrading is triggered before handshake complete.

Bug: 790547
Change-Id: I430eeb2741c430a241feddb69e468dbe33bdc368
Reviewed-on: https://chromium-review.googlesource.com/1163997
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581849}

This improves the response from drive to UI when there are several team
drives.

Drive sync adds one job per Team Drive to this queue, which causes the
queue to be busy with team drive operations and not responsive to
operations to respond to user interactions.

Bug: 852934
Change-Id: I215bd5fffe60efe576e9b82e4d4737f0ea2d27de
Reviewed-on: https://chromium-review.googlesource.com/1168946Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581848}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7b17cdf98449..5570c88a3dce


git log 7b17cdf98449..5570c88a3dce --date=short --no-merges --format='%ad %ae %s'
2018-08-09 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@5570c88a3dce

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I4649c5ec815fa7554a6ef531b4054c6a05408169
Reviewed-on: https://chromium-review.googlesource.com/1168822Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581847}

Bug: 841886
Bug: b/69370942
Test: browser_tests
Change-Id: I2e054dfb2e78032cecceb55c8998f0ee64259cc8
Reviewed-on: https://chromium-review.googlesource.com/1156202
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581846}

https://skia.googlesource.com/skia.git/+log/057c39025a93..8af4c40014e3


git log 057c39025a93..8af4c40014e3 --date=short --no-merges --format='%ad %ae %s'
2018-08-09 caryclark@skia.org use atomic for global test counters
2018-08-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c86c8b0cecf0..c43cdad25851 (6 commits)
2018-08-08 herb@google.com Performance: Move GPU code to GlyphRun and inline - v3
2018-08-08 brianosman@google.com Remove ContextRect::DstType
2018-08-08 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 5b1292eaeda5..f1e2b45d18fa (1 commits)
2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-08 fmalita@chromium.org [skottie] Animator tweaks
2018-08-08 reed@google.com switch SkTDArray from push to push_back
2018-08-08 egdaniel@google.com Add iOS Metal Build job.
2018-08-08 timliang@google.com made GrMtlBuffer compatible with iOS
2018-08-08 caryclark@skia.org dump pathops tests as hex json
2018-08-08 benjaminwagner@google.com [infra] Update Skolo Win NVIDIA drivers.
2018-08-08 timliang@google.com created GrMtlPipelineStateDataManager for metal gpu backend
2018-08-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c93eeaab1526..c86c8b0cecf0 (1 commits)
2018-08-08 csmartdalton@google.com Allow SkChopCubicAt to have the same src and dst
2018-08-08 herb@google.com Revert "Performance: Move GPU code to GlyphRun and inline - v2"
2018-08-08 bsalomon@google.com Add ability to specify different GP textures for each mesh in a draw.
2018-08-08 herb@google.com Performance: Move GPU code to GlyphRun and inline - v2
2018-08-08 robertphillips@google.com Add fast path for tail insertion in GrResourceAllocator::IntervalList
2018-08-08 bsalomon@google.com Allow GrOps to chain themselves together instead of merging.
2018-08-08 robertphillips@google.com Revert "Performance: Move GPU code to GlyphRun and inline"


Created with:
  gclient setdep -r src/third_party/skia@8af4c40014e3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I718049be406ff104d91df5009054ca85d2a45e79
Reviewed-on: https://chromium-review.googlesource.com/1168690Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581845}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I763f30df55c00de5870cca5010a9d86b330cff44
Reviewed-on: https://chromium-review.googlesource.com/1168737Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581844}

Currently updates to permission change subscriptions in
PermissionManager won't use the RenderFrameHost to determine the
permission value. This results in incorrect permission updates being
sent in some cases. This changes updates to query
GetPermissionStatusForFrame when possible. This is only not possible
when the request is from a worker in which case we just use the worker's
origin.

Tbr: slan@chromium.org, asanka@chromium.org
Bug: 802945
Change-Id: Ia69f7de8f166000661b5560a2f430b3787872b75
Reviewed-on: https://chromium-review.googlesource.com/979735
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581843}

This CL adds accessibility (larger fonts and VoiceOver) to the Unified
Consent and the Consent Bump.

Bug: 872277
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie6699132fe395b34717a8097d66ee97bf9406e13
Reviewed-on: https://chromium-review.googlesource.com/1167504Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581842}

Bug: 872291
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I062a4ca293704affc19743191b10ebf2e48864b0
Reviewed-on: https://chromium-review.googlesource.com/1167506Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581841}

Related to crrev.com/c/1166902
Adding a comment to explain why the fix was needed. And also
increasing the scroll distance to 300. There is no need to do
small steps.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8dd7c4bd7cedf9dfe5cdd6d2fb2df1c341493813
Reviewed-on: https://chromium-review.googlesource.com/1167510
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581840}

virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html

TBR=hta@chromium.org
NOTRY=true

Bug: 832842,872632
Change-Id: If9522e93d1851b762c67005aa8fdcd83a71631fd
Reviewed-on: https://chromium-review.googlesource.com/1169016Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581839}

It turns out that video/webm mime type is not always available
(depending on the python version?) So this Cl adds it statically.

Bug: 852038
Change-Id: Ic8cb19a777131df96df6c5794598ea8c8d0d312a
Reviewed-on: https://chromium-review.googlesource.com/1168655Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581838}

media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html

TBR=mlamouri@chromium.org
NOTRY=true

Bug: 746128,872632
Change-Id: Ib6d822f0a6ddfed1604ca1358f141b3b38ca8d35
Reviewed-on: https://chromium-review.googlesource.com/1169013Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581837}

Currently, empty CSSStyleSheets can be constructed either with a constructor or with Document.createEmptyCSSStyleSheet.
This CL deletes the constructor so that they can only be produced by Document.createEmptyCSSStyleSheet.

Document.createEmptyCSSStyleSheet is considered to be more desirable, as CSSStyleSheets produced by Document.createEmptyCSSStyleSheet can be tied to documents in the future. This means that their use can be limited in the documents where they were produced, resulting in higher security.

Note:
The constructed CSSStyleSheet is not currently tied to the Document yet

Link to related comments in discussion:
https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786
https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056

Bug: 807560
Change-Id: I767e15e83e1f31eb278bc81233c8b579d0f511c7
Reviewed-on: https://chromium-review.googlesource.com/1164876Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Momoko Sumida <momon@google.com>
Cr-Commit-Position: refs/heads/master@{#581836}

Now it registers thread as a sequence and accepts MessagePump
as a constructor argument.

Bug: 828835
Change-Id: Ibbfd674a5c7f739e30baaa8a026e30827d521a87
Reviewed-on: https://chromium-review.googlesource.com/1167482Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581835}

"Play files/Download" is an alias to Chrome OS's Downloads volume.
It is convenient in Android file picker, but can be confusing in
Chrome OS Files app.
This CL hides the 'Play files/Download" only in Chrome OS Files app.

Bug: 848661
Test: Manually tested on arc-enabled Kevin.

Change-Id: I6c9bed8ff7f72b7c1fe6b2abe1c6194f8eeb3b6d
Reviewed-on: https://chromium-review.googlesource.com/1166922
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581834}

BUG=859429

Change-Id: Iaa998db509f9c9b4a38c2af1fa3c6be576e2d27f
Reviewed-on: https://chromium-review.googlesource.com/1160068
Commit-Queue: Kyoko Muto <kymuto@google.com>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581833}

TBR=sahel@chromium.org
NOTRY=true

Bug: 872635,872632
Change-Id: I59bb656ad0047c7391d96a6b59e1358af91a7b17
Reviewed-on: https://chromium-review.googlesource.com/1169002Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581832}

NULL blocks scoped_refptr to support nullptr, and eventually blocks it
to remove its implicit raw-pointer conversion.

This CL replaces all relevant NULL in //storage with nullptr.

Change-Id: Ia3662d7bd022fa7ae3619de3f28cea968c0f858b
Reviewed-on: https://chromium-review.googlesource.com/1168710Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581831}

crrev.com/c/1160133 introduced MimeSniffingThrottle which may
defer a request. Since URLLoaderClientImplTest has a (probably
wrong) assumption that the request wouldn't be deferred, these
tests were failing when S13nServiceWorker/Network is on.
To work around the assumption this CL sets
|fetch_request_context_type| to REQUEST_CONTEXT_TYPE_FETCH so
that ResourceDispatcher won't install MimeSniffingThrottle.

Bug: 860361
Change-Id: I6dab15515089a46f1b1c2a7501c826b9433e46b3
Reviewed-on: https://chromium-review.googlesource.com/1168705Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581830}

Gives a better name to <GoogleServicesSettingsCommandHandler> and
renames it to GoogleServicesSettings.
The delegate is to handle changes for all services from the VC
This is related to crrev.com/c/1163521

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic952a98d659c92a355f0cb8eb4bc56e0c75af33e
Reviewed-on: https://chromium-review.googlesource.com/1166964
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581829}

blink::ServiceWorkerUtils::IsServicificationEnabled() checks
whether NetworkService is enabled, so we don't need the check
in ResourceDispatcher::StartAsync().

Bug: N/A
Change-Id: I06bab175489f42dc0cefa2a257806db29192eba1
Reviewed-on: https://chromium-review.googlesource.com/1168707Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581828}

Extract all the low-level skia/gfx/color_util stuff as
ResizeIconsAndGenerateMissing function.

This is a cut-and-paste CL, no behavior changes.

Notes:
- WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL:
Merge IconInfo and BitmapAndSource - they are essentially the same.

- BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test
was always broken (a bug in ValidateAllIconsWithURLsArePresent helper)
https://codereview.chromium.org/1066623008/patch/80001/90005

Bug: 860581
Change-Id: I0d866ac323f8dfdb409b69b22fac796155b1da23
Reviewed-on: https://chromium-review.googlesource.com/1166751
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581827}

In UnifiedSystemTray, we only optimize expand/collapse transform when
there is no notification. We should update the layer transform state
when a notification is created during dragging system tray.

TEST=manual
BUG=863577

Change-Id: Iaff5438a9e8f50b621a48cff5c9f197f48d7617e
Reviewed-on: https://chromium-review.googlesource.com/1168709Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581826}

We stopped traversal flat tree when Node didn't have a LayoutObject
but Slot elements appear in the tree w/o LayoutObject.
This patch enables LayoutSelection to visit children of
such elements.

Bug: 870734
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Id4f7c135fceead131f37485ecb8fa326834d72c3
Reviewed-on: https://chromium-review.googlesource.com/1164724Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581825}