- 17 Jul, 2020 40 commits
-
-
Noel Gordon authored
Patch 1 / 3: in the code flow that shows submenu, we must position the submenu using getComputedStyle. Just before that style recalc, set the submenu margin-top to 0 using inline style. The inline style overrides all CSS and all submenu's of files-app have 0 margin-top as a result. In particular, #tasks-menu, #share-menu will no longer accidently get 8px margin-top (issue 1066727#c23). Bug: 1066727 Change-Id: I7620d88b5026a436a94b2d1cdefed5acfa3851f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301610Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789334}
-
Brian Sheedy authored
Follow-up to crrev.com/c/2300801, where it was discovered that the --enable-experimental-web-platform-features flag was no longer necessary in _ContextLost_WorkerRAFAFterGPUCrash* tests. TBR=kbr@chromium.org Bug: 1090480 Change-Id: Iac0c596d83dd9973dfcd71c5777c94e0d188b274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304090Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789333}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I74f0d1fe088c91fd11c8a708baf085ac5436c463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303601Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789332}
-
Noah Rose Ledesma authored
This CL adds a method to the view class called IsRTL that replaces calls to base::i18n::IsRTL() in the view impl. The result of View::IsRTL may be overridden with View::SetIsRTL(). The purpose of this change is to allow views that should always be presented in left-to-right do so with ease. For reference, see the next CL in the relation chain. Bug: 1106037 Change-Id: Ieee3b1667979f9f010ac971bcca3ea4d902f9d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300799 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789331}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None Change-Id: Ia65bacff95aed253d5ef7fd1bb286d0f19723e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302737 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#789330}
-
Jesse Schettler authored
In preparation for updating the API to use a new browser service to interact with connected scanners, move the API to /chrome. Bug: None Test: Perform a scan using the Scan extension No-Presubmit: true Change-Id: Ia19882b349eeec1b33eb14d72337de7849a227ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298043Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#789329}
-
Kelvin Jiang authored
Headers enums are borrowed from WebRequest header enums. Bug: 1088103 Change-Id: I1fecac37718a701c2e9e6cf1407505cd203de845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280730Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789328}
-
Evan Stade authored
Bug: 1071603 Change-Id: I03d8549704afe97b13d6b0f421c0110f5a28d3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287949 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789327}
-
Yutaka Hirano authored
ExecutionContext::CompleteURL returns a KURL, but CSSFontFaceSrcValue::RestoreCachedResourceIfNeeded converts it to a String and then convert it back to a KURL. Fix that. Bug: None Change-Id: Ibe6a2cfa8c8944df1adb628f73c37d59323d0b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301557Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#789326}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/442d424a7287..3164b4494fba 2020-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from c21106442079 to f73242142ce5 (1 revision) 2020-07-16 reed@google.com Revert "Revert "Serialize mipmaps"" 2020-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 403d32176ebc to c21106442079 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I81d22f4455eb0e52a81a7f6348465a9301e95c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303180Reviewed-by:
-
Brandon Wylie authored
Bug: 967960 Change-Id: I29fd49d9c4a1a38a686e50a7dac58481c64e5938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303996Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789324}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/82359f926f81..45f54928a628 2020-07-16 xinyi.he@arm.com Vulkan: Fix capturing arrays using VK_EXT_transform_feedback 2020-07-16 lehoangq@gmail.com Metal: fix max point size and RGB565 renderbuffer bug. 2020-07-16 lehoangq@gmail.com Metal: Prevent vertex shader's inactive varying from being removed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Idd985e0f46af673b9a9aa0f1909e544f3142abd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303097 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dale Curtis authored
This replaces the two booleans that were present with a single GetContentColorUsage() function which is more coherent. It also changes the IsHDR() check to something cheaper and puts it behind a !isSRGB() block to address performance regressions. R=ccameron, khushalsagar Bug: 1105602, 960620, 1076568 Test: Updated unittests. Change-Id: Ib00ac8f068ddf90bd75c8199385fdffad58b08cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303972 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#789322}
-
Rakib M. Hasan authored
When this script is run as part of a recipe, it should get the chromium version from //chrome/VERSION. TBR=jam@chromium.org Bug: 1058968 Change-Id: I29ea24399aeb8a94f7bd69a91932725d405253b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302741 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789321}
-
Clark DuVall authored
The perf bots were not able to run pinpoint jobs using SystemWebViewGoogle.apk because it was not being built. Bug: 1105096 Change-Id: Id2b5b1f8952eaf1cef742d78fde59855699b7e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300636Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789320}
-
Sylvain Defresne authored
The Info.plist of XCTRunner.app may change if the version of Xcode changes, but the timestamp and the input paths may not be reliable signals to determine whether the target is dirty. Force the command-line of build/config/mac/plist_util.py to be different if the version of Xcode changes. This will force ninja to consider the target as dirty and will force using the correct version of the binary (even if older than current output). Bug: 1101531 Change-Id: I20f0a21c418fdd20e223390ad6c7c89063b88ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302850 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594922139-2e74d5a60ec66c9d9f020f69b34f84d613c708fd.profdata to chrome-mac-master-1594943787-51a385cad6026d977d7d0e8c786de56f21cce493.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6ec5afa1591727fd846e3a8a0f0a6115b601bfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304131Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/78a6bf63710d..233589f2e73f 2020-07-16 nodir@chromium.org [dirmd] Roll to the latest version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106176 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I70910a1113bd4e2aa43fc58f74784429f77ace1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303179Reviewed-by:
-
Mohamed Heikal authored
We migrated into an inheritance based R.java files that means that each R.java file has access to all resources without manually specifying each resource individually. This means the extra_r_text_files option is no longer needed/used since we no longer need to know exactly what is in each R.java file separately. Change-Id: I71ebabda0d998a53a0ae54b8a3fd6cd84311105d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302933 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789316}
-
Sean Topping authored
This forces autoplay on for all main frames, and turns on the autoplay delegation mechanism via <iframe allow="autoplay" />. This turns off the previous behavior of unconditionally allowing autoplay on all pages and frames. Bug: internal b/160651728 Test: Launch AMP Viewer via web sender, verify only the screen reader is active while videos/ads remain paused. Change-Id: If570ca3911596bf27bcceb56360fad674a9236c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296360Reviewed-by:Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#789315}
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: 1047909 Change-Id: Ic5e1ef207e8483ae1a56a4ee090d7ad6317a3a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303859 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#789314}
-
Minggang Wang authored
This CL converts base::Callback and base::Closure to Once/Repeating in //chrome/browser/task_manager/. With this CL, there should be no base::Callback, base::Closure and base::Bind anymore. Bug: 1007635 Change-Id: I2bbe393b8e76b861a000d4c58d99ed1e0f63d90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290051Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#789313}
-
Jimmy Gong authored
Previously was set at the default size of 24px, this change reduces its size to 20px. Bug: 1106551 Change-Id: I34f2faff0799b6125c05a683d9619b2c59579534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303231Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#789312}
-
Peter Boström authored
Adds SetHighlight calls to BrowserAppMenuButton::UpdateIcon(), as the colors used depend on theme and severity as well. Bug: 1001731 Change-Id: Id5cd21e74affbcc7fbb5570dac49eaba08d95f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302944Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#789311}
-
chrome://flagsCarlos IL authored
Exposes existing feature flags for mixed forms interstitials and disabling autofill on mixed forms in chrome://flags. Bug: 1093102, 1093103 Change-Id: I5d8fef15579b9321148fb893e9881cdc3a68f22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303990 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#789310}
-
Anders Hartvoll Ruud authored
There is code to resolve variables in this function, but we should not reach it with CSSCascade enabled. Change-Id: I39580db63b1f48114210b2ac59d3d29253a8eb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302056 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#789309}
-
Antonio Gomes authored
... instead of content/renderer/media. Today, content/renderer/media/media_factory.cc calls out to blink::CreateWebMediaStreamRendererFactory() (from t_p/blink/public/web/modules/mediastream/web_media_stream_renderer_factory.h) and passes the object to Blink. This CL moves this call within WebMediaPlayerMS's ctor, in webmediaplayer_ms.cc (blink). For tests, it adds an override method. This will allow: - merged of WebMediaStreamRendererFactory and MediaStreamRendererFactoryImpl classes. - removal of web_media_stream_renderer_factory.h. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I368f9063cfa9a361b603d35f9c9b30d31b488837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302711 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#789308}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e79c319a. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" 6afc7d8c "Make sure all methods have a correct name." 9334a341 "Add image loading=lazy data: and Blob URL WPTs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I9d4c405c675f8d6dd9cf462388d51a8769104eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303570Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789307}
-
manuk authored
Adds 2 params to restrict title and non-prefix autocompletion respectively. RichAutocompletionAutocompleteTitlesMinChar RichAutocompletionAutocompleteNonPrefixMinChar Bug: 1062446 Change-Id: I9df7c8138d0586a2b2e4d3506f951c9ecd134f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300928 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#789306}
-
Charlene Yan authored
Bug: 1099376 Change-Id: I8d88e6ef7d4e0911ea85715c334915a11d7aa3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303971 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#789305}
-
Martin Kreichgauer authored
This reverts commit 02303ee2. Reason for revert: Original CL did not cause the test failure Original change's description: > Revert "fido: make AuthenticatorTestBase set the MOCK_TIME TaskEnvironment trait" > > This reverts commit f55cd37e. > > Reason for revert: The tests testAuthenticatorImplGetAssertionBridge_resultCanceled and testAuthenticatorImplGetAssertionBridgeWithUvmRequestedWithUvmResponded_success in org.chromium.chrome.browser.webauth.Fido2CredentialRequestTest consistently fail on android-pie-x86-rel since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1498. > This CL is the only one that touches authenticator_impl around that time. Revert it to see if it can fix the failure > > Original change's description: > > fido: make AuthenticatorTestBase set the MOCK_TIME TaskEnvironment trait > > > > This allows us to get rid of base::Timer injection into > > AuthenticatorCommon, which tests used to wait for requests to time out. > > > > Also get remove a number of superfluous RunUntilIdle() calls, and of > > calls to OverrideLastCommittedOrigin() where SimulateNavigation() would > > suffice. > > > > Change-Id: I8cb4980d51efe43f59d828cde5f34ce67d38d928 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299630 > > Auto-Submit: Martin Kreichgauer <martinkr@google.com> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Reviewed-by: Adam Langley <agl@chromium.org> > > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > > Cr-Commit-Position: refs/heads/master@{#788885} > > TBR=agl@chromium.org,jsaul@google.com,martinkr@google.com > > Change-Id: I47c8796582f40f1946811b5eca4ae3cdfe5aac0f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303030 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#789079} TBR=agl@chromium.org,jsaul@google.com,martinkr@google.com,hypan@google.com # Not skipping CQ checks because this is a reland. Change-Id: I0a07662127df43624d7fa69c165d2503107514aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303567Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#789304}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I04e1a6ac9005b9f6220d6801a85f1be3c838cefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303454Reviewed-by:
-
dpapad authored
<dialog> instances by default are absolutely positioned with respect to the <html> element. Moreover, it seems that setting "position: relative" on any of its parents does not have any effect. Using "position: fixed" fixes both issues (scroll position flashing and action menu scrolling away after opening). Fixed: 1105643 Change-Id: I1b0a5ca653b37b5455c237b2917ca79e4556af1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302747 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#789302}
-
Justin DeWitt authored
Client is responsible for closing the menu when it system-back is pressed, but our configuration of the bottom sheet swallows the back event and does nothing. Bug: 1106425, b/161381371 Change-Id: Ide491bd1f59cfd15e148ee9454e93a0785b33e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300882 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#789301}
-
Cammie Smith Barnes authored
Currently, the AdsPageLoadMetricObserver only records the FCP of the root ad frame in FrameData and ignores FCP of any child frames except for an ephemeral check while computing the Creative Origin Status. This can lead to an situation where a child frame receives an First Eligible to Paint and then an FCP, allowing calculation of the Creative Origin Status, but the root ad frame has not yet received an FCP, so the FrameData's timing object still holds a null value for the FCP. Then, if a request to nullify the First Eligible to Paint value for the frame tree arrives, under the current setup it will succeed, and then a DCHECK for a non-null FEtP will subsequently fail. Further changes to fix the related bug in the FCP ads metric will be in a follow-up CL. Bug: 1103610,1103782 Change-Id: I4234ada8a6d0d98e2cf153522bd15e0d86efd8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290775 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789300}
-
Michael Spang authored
We can't use GPU compositing without a GPU process. This fixes a problem in cast_shell_internal_browsertests that's occurring after 966e62f6 ("[scheduler] Enable prioritize until begin main frame by default."). Change-Id: I36eb9f615775e19f81fe24f8a532085fb9483ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303874 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#789299}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia028635352bd4b9893718049b659fcb669d1bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303870Reviewed-by:
-
Fletcher Woodruff authored
Adds the DocumentScan.SaneBackend enum, as well as the DocumentScan.{ScanRequested,ScanSucceeded,ScanFailed} metrics. These are used to track which SANE backend a user requested when a scan is started, as well as the backend used when a scan finished successfully or unsuccessfully. Metrics are added by https://crrev.com/c/2281282 Obsoletes the ScanResult metrics since it is superseded by the new metrics. Bug: b:160472550 Change-Id: I5eae8fb99ee7d09ce39688648a6b6828d9122190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281207 Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by: -
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ifbf63c8eb210128226b78c64e569e28c8f64732b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303776Reviewed-by:
-
Federico Paredes authored
This CL[1] removed the logic that allowed screen readers to focus into menus. This[2] other CL re-added functionality for generic menu items. However, buttons within menu items (like those in the Zoom MenuItemView) weren't fixed. This CL fixes hot button focus with screen readers. This only fixes the issue with keyboard navigation, and not with mouse navigation. If you use your mouse to navigate to a button, it will still select the entire container. Bug: 1105917 Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91 [1] c22c3a2a [2] 7750c6d5 Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295787Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789295}
-
