GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c319d07..0692c5f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/889173003

Cr-Commit-Position: refs/heads/master@{#315201}

Track the number of "early" frames received in a QUIC stream.

This will help measure the amount of head of line blocking of the
headers stream that QUIC sees.

Merge internal change: 85643187
https://codereview.chromium.org/893323004/

Remove QUIC's ReceiveAlgorithmInterface now that it does nothing.
No functionality change.

Merge internal change: 85621906
https://codereview.chromium.org/908673002/

Fixing a bug where 0-round-trip connection establishment was conflated
with zero-second-round-trip-time in faster.

Chromium side change is only a comment change.

Merge internal change: 85554888
https://codereview.chromium.org/904993004/

Remove FLAGS_quic_allow_silent_close.

Merge internal change: 85387940
https://codereview.chromium.org/902243003/

Keep an instance of QuicAckFrame in QuicConnection in order to reduce
memory allocations.

Saves 1.5% of the CPU according to profiles.  May be slightly more on
clients.

Merge internal change: 85351635
https://codereview.chromium.org/876313009/

Fix compile errors introduced when editing QuicFramerTest during the
presubmit.

Merge internal change: 85182632
https://codereview.chromium.org/905033002/

Move is_fec_packet from QuicPacket to SerializedPacket in order to allow
QuicSerializedPacket to contain a QuicEncryptedPacket instead in a future CL.

Merge internal change: 85181879
https://codereview.chromium.org/887243005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/908493004

Cr-Commit-Position: refs/heads/master@{#315200}

As a follow-up for filesystem: URL patch:
https://code.google.com/p/chromium/issues/detail?id=453982

As of http://src.chromium.org/viewvc/blink?view=revision&revision=189570
we started to check non-HTTP(s) schemes in renderer process, so
any requests for registering non-HTTP(s) schemes in the browser
should be considererd malicious / invalid and we should just do
BadMessageReceived().

BUG=455115
TEST=ServiceWorkerDispatcherHostTest.*
TEST=no layout tests should crash swith this change

Review URL: https://codereview.chromium.org/906453002

Cr-Commit-Position: refs/heads/master@{#315199}

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs is assuming that DOM attributes are own properties on a JS obejct, which is not correct.  Blink (binding) team is working to move DOM attributes from own properties to properties on prototype chains, and then this test will break.

This CL fixes the test so that it stringifies not only own properties but also attributes on prototype chains.

BUG=43394

Review URL: https://codereview.chromium.org/904823002

Cr-Commit-Position: refs/heads/master@{#315198}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/551f72a..9c87e95

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/905903004

Cr-Commit-Position: refs/heads/master@{#315197}

Design doc: https://docs.google.com/document/d/1Bv-I1yM9AjgY3t27ixdyWHCAW9IpVx02YQ-nSbIqccc

BUG=

Review URL: https://codereview.chromium.org/888923004

Cr-Commit-Position: refs/heads/master@{#315196}

This makes InfoBarLayout more flexible and uses that flexibility to
implement the app banner view.

BUG=442690

Review URL: https://codereview.chromium.org/868663009

Cr-Commit-Position: refs/heads/master@{#315195}

BUG=None
TEST=no functional changes
R=sky@chromium.org

Review URL: https://codereview.chromium.org/867493003

Cr-Commit-Position: refs/heads/master@{#315194}

The banner can fail to be shown for any number of reasons,
from a user navigation to a failed icon fetch.  Record that
the banner could have been shown only right before the
infobar is created.

This fixes situations where a user already had a native app
installed and the website requested a banner for it, which
permanently fills a slot in app dictionary for the site --
even if the Play Store tells the AppBannerManager that the
app is installed and no banner should be shown.

BUG=453170,452825

Review URL: https://codereview.chromium.org/905913002

Cr-Commit-Position: refs/heads/master@{#315193}

Revert of Removing silence trimming from WebRTC quality test. (patchset #5 id:80001 of https://codereview.chromium.org/890893004/)

Reason for revert:
This actually made the score worse by about 0.4 on all bots except one, and one bot is still not helped by this. I will try to solve this through other means, like forcing the volume to the right level on the bots where we get bad scores.

Original issue's description:
> Removing silence trimming from WebRTC quality test
>
> It turns out PESQ can deal with delays, so we don't need to
> silence-trim the files to get them to line up. This solves another
> problem where the silence-trimming becomes too aggressive on Windows
> with the new ref file.
>
> I also need to monitor if the new ref file, which is a lot lower
> in volume than the old one, unfairly punishes the score. The
> speaker volume is a bit random on the bots so the recording could
> end up being quite low. Tests on my workstation suggests that PESQ
> is actually pretty good about ignoring that too though. There will
> be a slight effect on the score (like 0.4 MOS), which I think is
> acceptable. Otherwise we need to find a way to control the speaker
> volume on the bots much more stringently.
>
> BUG=446859
>
> Committed: https://crrev.com/36d358e0cdff201a99501e9c986a8a26f8965a40
> Cr-Commit-Position: refs/heads/master@{#314797}

TBR=henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446859

Review URL: https://codereview.chromium.org/908703002

Cr-Commit-Position: refs/heads/master@{#315192}

Revert of Added bluetooth LE support on Mac platform (patchset #13 id:340001 of https://codereview.chromium.org/791763005/)

Reason for revert:
Breaks compile:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/17750

../../device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm:119:30: error: class method '+UUIDWithString:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
      CBUUID* uuid = [CBUUID UUIDWithString:uuidString];
                             ^~~~~~~~~~~~~~

../../device/bluetooth/bluetooth_low_energy_device_mac.mm:82:39: error: use of undeclared identifier 'CBAdvertisementDataIsConnectable'
      [advertisementData objectForKey:CBAdvertisementDataIsConnectable];
                                      ^
../../device/bluetooth/bluetooth_low_energy_device_mac.mm:85:39: error: use of undeclared identifier 'CBAdvertisementDataServiceDataKey'
      [advertisementData objectForKey:CBAdvertisementDataServiceDataKey];
                                      ^
2 errors generated.

Original issue's description:
> Added bluetooth LE support on Mac platform
>
> BUG=449682
>
> Committed: https://crrev.com/42f79f8b08a99190627f3a67e86a378987104a4a
> Cr-Commit-Position: refs/heads/master@{#315190}

TBR=armansito@chromium.org,avi@chromium.org,groby@chromium.org,dvh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449682

Review URL: https://codereview.chromium.org/871843009

Cr-Commit-Position: refs/heads/master@{#315191}

BUG=449682

Review URL: https://codereview.chromium.org/791763005

Cr-Commit-Position: refs/heads/master@{#315190}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d9e63a2..551f72a

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/907523004

Cr-Commit-Position: refs/heads/master@{#315189}

Add an API to extract a color transform lookup table in BGRA format, with
(z,y,x) sampling order (B changes the slowest, R the fastest).

See r314425 for speed results, noting that qcms_chain_transform takes 8ms
for a 32-cube since floating-point is used to compute the color transform
to maintain transform precision.

The float data produced by qcms_chain_transform() is stored in the output
in BGRA order (color components are rounded to the nearest 8-bit integer)
with time cost 0.000031 secs. Note that if the data needed re-indexing to
(x,y,z) sampled, RGBA order on writing to the output, the time cost would
be 0.00056 secs (18 times slower) [1].

[1] See r314425 review comments about sampling and pixel order.

BUG=443863

Review URL: https://codereview.chromium.org/892413005

Cr-Commit-Position: refs/heads/master@{#315188}

1. Renamed the CastInitializationStatus enum to OperationalStatus.
2. Renamed CastInitializationCallback to StatusChangeCallback.
3. Documented use of enum and callback.
4. Callbacks may now be run repeatedly to indicate when codec reinit
   occurs (e.g., for a frame size change), and whether runtime errors
   occur after initialization.

BUG=451277

Review URL: https://codereview.chromium.org/901833004

Cr-Commit-Position: refs/heads/master@{#315187}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d231f16..d9e63a2

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/904033009

Cr-Commit-Position: refs/heads/master@{#315186}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/908683002

Cr-Commit-Position: refs/heads/master@{#315185}

This change bundles together a few minor UI improvements to the bookmark
app creation flow:
- The language for opening as a window vs. a tab is now always 'open as
window', instead of sometimes being 'open as tab'.
- The menu item is now called 'Add to XXXX' where XXXX is the platform
specific shelf / dock / taskbar / desktop.
- The app is now added to the shelf / dock / taskbar / desktop
- Empty or only-whitespace names can no longer be provided.

BUG=452830,450102,447385,447384

Review URL: https://codereview.chromium.org/907473002

Cr-Commit-Position: refs/heads/master@{#315184}

BUG=442930

Review URL: https://codereview.chromium.org/882343004

Cr-Commit-Position: refs/heads/master@{#315183}

* Button cycles between "Install", "Installing", and "Open",
  depending on the installation status of the app being promoted.

* Clicking on the icon or the title of the AppBannerInfoBar should
  send the user to see details about the app that is being promoted.

* Open up access to LinkClicked() from ConfirmInfoBar.
  Piggyback on LinkClicked() to determine that the user wants to
  see the link related to the app.

* Add an ID to the icon of the infobar so it can be retrieved and
  have an OnClickListener attached to it.

* Update the status of the button when the user hops in and out
  of the Chrome application.

BUG=453170

Review URL: https://codereview.chromium.org/871103004

Cr-Commit-Position: refs/heads/master@{#315182}

BUG=

Review URL: https://codereview.chromium.org/909623002

Cr-Commit-Position: refs/heads/master@{#315181}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2aafe6f..c319d07

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/904193002

Cr-Commit-Position: refs/heads/master@{#315180}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f3ed19e..d231f16

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/904943004

Cr-Commit-Position: refs/heads/master@{#315179}

There are situations where we really don't mind if firing a
[Pending]Intent doesn't return to Chrome.  In these cases,
alerting the user about Chrome dying is unnecessary.

BUG=453170

Review URL: https://codereview.chromium.org/907593002

Cr-Commit-Position: refs/heads/master@{#315178}

Currently, this is gated behind the enable-namespace-sandbox switch.
Furthermore, the namespace sandbox is only used if seccomp-bpf is
supported.

BUG=312380

Review URL: https://codereview.chromium.org/897723005

Cr-Commit-Position: refs/heads/master@{#315177}

See inline comment for gruesome details. Basically, just ignore the
Ultra Bold weight.

R=shrikant@chromium.org,eae@chromium.org,cpu@chromium.org
BUG=408093

Review URL: https://codereview.chromium.org/898403002

Cr-Commit-Position: refs/heads/master@{#315176}

Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().

BUG=

TEST=VideoCaptureDeviceTest.* in media_unittests pass.

Review URL: https://codereview.chromium.org/897483002

Cr-Commit-Position: refs/heads/master@{#315175}

Revert of Enable libc++ on Android (patchset #16 id:460001 of https://codereview.chromium.org/835633003/)

Reason for revert:
Slows down the slowest bot on CQ by 20 minutes.

BUG=456396

Original issue's description:
> Enable libc++ on Android
>
> Switch Chrome on Android to use libc++ instead of stlport. WebView AOSP
> builds will continue to use stlport for the time being.
>
> Note that this change is exploratory, and likely to be reverted before
> branch point (ensuring WebView and Chrome remain in lockstep with
> respect to standard library dependencies).
>
> BUG=427718
> TBR=cpu@chromium.org
>
> Committed: https://crrev.com/8681920fa22ded465054301ce96657a4ddaf2a04
> Cr-Commit-Position: refs/heads/master@{#315085}

TBR=fdegans@chromium.org,pasko@chromium.org,jamesr@chromium.org,thakis@chromium.org,boliu@chromium.org,davidben@chromium.org,cpu@chromium.org,piman@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=427718

Review URL: https://codereview.chromium.org/903323002

Cr-Commit-Position: refs/heads/master@{#315174}

Mechanical change that adds instrumentation required to locate the source of
jankiness (i.e. a long-running fragment of code executed as a part of the task
that causes jank) in the code. See the bug for details on what kind of jank we
are after.  A number of similar CLs were landed, and none of them caused issues.
The code of the instrumentation is highly optimized and is not expected to
affect performance. The code simply creates a diagnostic task which is identical
to ones created by PostTask or IPC message handlers.

BUG=456327,456331,456373
TEST=none
TBR=mmenke, erikwright

Review URL: https://codereview.chromium.org/894903004

Cr-Commit-Position: refs/heads/master@{#315173}

BUG=456042

Review URL: https://codereview.chromium.org/897083003

Cr-Commit-Position: refs/heads/master@{#315172}

And use it to flush rendering before page flip.

BUG=412508,442605
TEST=build and run Chrome on jerry/freon. It should render one frame.
R=alexst@chromium.org
R=dnicoara@chromium.org
R=kbr@chromium.org
R=piman@chromium.org
Signed-off-by: Dominik Behr <dbehr@chromium.org>

Review URL: https://codereview.chromium.org/903063003

Cr-Commit-Position: refs/heads/master@{#315171}

This addresses a TODO and reverts
https://codereview.chromium.org/777303004.

With https://codereview.chromium.org/889083002
the CrashDumpManager is now initialized earlier so
things should be fine.

BUG=439322

Review URL: https://codereview.chromium.org/893393004

Cr-Commit-Position: refs/heads/master@{#315170}

BUG=419551

Review URL: https://codereview.chromium.org/893963003

Cr-Commit-Position: refs/heads/master@{#315169}

Mojo's MessagePipe constructor uses assert() to check that
MojoCreateMessagePipe returns OK. This change makes the test explicitly
check the return value of MojoCreateMessagePipe, giving more correct
test behavior for Release builds.

Review URL: https://codereview.chromium.org/897093004

Cr-Commit-Position: refs/heads/master@{#315168}

This is a simple command, except we need to update client side caching of
uniform block info accordingly.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/906613005

Cr-Commit-Position: refs/heads/master@{#315167}

Note ui/views/BUILD.gn actually has it already.

views_unittests compile regressed in r314860

It's only a problem for toolkit-views on Mac because it doesn't depend
on aura_test_support there (which also has the dependency).
views_test_support should have it for the call to
ui::{Initialize,Shutdown}InputMethodForTesting() in ViewsTestBase.

BUG=378134

Review URL: https://codereview.chromium.org/895343004

Cr-Commit-Position: refs/heads/master@{#315166}

They may have problems when using hardware video decoding and D3D11 on the discrete gpu.

BUG=451420

Review URL: https://codereview.chromium.org/875403009

Cr-Commit-Position: refs/heads/master@{#315165}

By default, Android optimizes what it shows on top of
SurfaceViews (saves power). Effectively, layouts determine
what gets drawn and post-layout animations outside of this
area may be 'clipped'.

This adds an convenient way to avoid this clipping. When an
animation wishes to animate over a SurfaceView, it just
needs to register itself in its ContentViewCore and the
rest will be taken care of automatically.

BUG=441805

Review URL: https://codereview.chromium.org/895843002

Cr-Commit-Position: refs/heads/master@{#315164}

additional_res_dirs was removed and additional_res_packages does not use it
anymore.

Review URL: https://codereview.chromium.org/902193002

Cr-Commit-Position: refs/heads/master@{#315163}

This reverts commit 787196b9 and disables the handle closer on Windows 10.

BUG=452613

Review URL: https://codereview.chromium.org/891973005

Cr-Commit-Position: refs/heads/master@{#315162}