- 25 Mar, 2020 40 commits
-
-
Sigurdur Asgeirsson authored
The field trial data is exhausting the per-process user data stash. This makes field trial data incomplete and therefore useless, while also preventing the use of the per-process user data for other instrumentation. Bug: 1003391 Change-Id: I3837076763ba7672040d0223b78978565e472a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115760Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753282}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3685fb977e15..4504b6a42842 git log 3685fb977e15..4504b6a42842 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 hjd@google.com Merge "Add missing function prototype" Created with: gclient setdep -r src/third_party/perfetto@4504b6a42842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I104c2c76897d7c49d27a26e413783550038a0373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753281}
-
Yao Xiao authored
What: In FrameView::UpdateViewportIntersection, get the main_frame_scroll_offset from the frame owner’s local root’s intersection_state, instead of from the frame owner’s top Frame. Why: We already store this in the local root's viewport_intersection_state. Use that value, instead of additionally storing it to the top Frame. This is not only a redundancy, but can be a problem in sticky frame tracking when there are multiple subframes such as A(B1(C1(D1)),B2(C2(D2))), because an update in C1 or C2 will override the value that's previously set by the other, which could eventually cause false positively recordings of large-sticky-ads. Storing them in the local root will prevent this racing. Bug: 1013070, 1063760 Change-Id: If7bdc05a1b487bf4cfe70a3823b28d78ef0f938f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110473Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#753280}
-
Alison Maher authored
If the legend sets break-inside to avoid, and we can break before the fieldset, we should do so if it is a more appealing break point. This, however, was not the case because the fieldset content, if empty, would get laid out and override the break appeal of the builder, which is why the fieldset did not know to break before. This change fixes this issue by avoiding laying out the fieldset content if we've run out of space from laying out the legend. Bug: 875235 Change-Id: I2db2554fb1032d8297c6df954d9d8f6194b041d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116834 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#753279}
-
Aaron Leventhal authored
Prevent name calculation from getting out of control on really large regions, e.g. scrollable areas. Bug: None Change-Id: I996a15ba6d6b56df0af7975f1aca861eadf7adfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117454Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#753278}
-
Aran Gilman authored
This CL expands the existing JavaScript bindings to allow storing the theme and font family selected via the in-page appearance settings dialog to the corresponding synced preferences. The ability to persist the font size/scale will be added in a follow-up CL. Storing that setting requires some additional work to convert the font size in pixels used by the desktop UI to the scale relative to base size expected by the pref. Bug: 1016615 Change-Id: Ia7f8c86b8e9fa136b2b18429ba4b9d89272d1893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922788 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753277}
-
Marc Treib authored
This is a first step towards making this logic reusable and customizable for the MultiStorePasswordSaveManager. Bug: 1012203 Change-Id: I5875c083e8b7439677ac315c0be30de61ab08c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116080 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#753276}
-
Thomas Lukaszewicz authored
Bug: 1063511 Change-Id: Ib10bb02f0d34d7b9bd97be55f5692cbfc0c9c417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120912 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753275}
-
Renjie Tang authored
Change-Id: Ib5fca1d1763f46d4e63b5225674d9b98a97e3efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112832 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#753274}
-
Dave Tapuska authored
The test was temporarily disabled while a feature was fixed in devtools repo. Now that it landed a while ago make sure the test is re-enabled. BUG=1043151 Change-Id: Ia4bc03c375e0b168e0a703899a1dad64de5f0a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120746Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753273}
-
Liviu Tinta authored
Apply fixes for memory leaks and run memory leak trybots. Bug: 810882 TEST: Successfully ran the test locally on linux machine. Ran the test on trybots. Change-Id: Ie764d9dba3556e34aec93a0f4fae36f7341a0327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119371 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753272}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I0acc1ee7bce32f326340d21171f385936a8aa18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116448Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#753271}
-
Rohit Rao authored
BUG=1024115 Change-Id: I1702b5f91f9b3969e7aafdacbcfab1236c91ad64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119217Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753270}
-
Dave Tapuska authored
These tests were disabled for feature rework in the devtools repo but were never re-enabled. BUG=1011466 Change-Id: I3f459e211a0e273ef1dd626e6521f9fe37e37923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120739Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753269}
-
Maksim Moskvitin authored
This change replaces std::string with std::vector<uint8_t> for representation of raw trusted vault key. It makes tests more aligned with prod code and simplifies some further changes (e.g. exposing test API to Android counterpart). Bug: 1063877 Change-Id: I0cb8edb9df9131180c1d30ca4af0ee093c76a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116170 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#753268}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4de93855b203..d34983e8718f Created with: gclient setdep -r src-internal@d34983e8718f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie857da2a806fa4f2edb3d1bf706b4372235e664a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753267}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7cf24988387a2a786672bdec426811de672cead6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120893Reviewed-by:
-
Josh Nohle authored
If a v2 DeviceSync has never successfully completed and there are no pending failure retries, schedule a first-time initialization sync. Previously, we were waiting for an InvokeNext instruction after a v2 Enrollment or a GCM notification before scheduling the first v2 DeviceSync. This change ensures that Chrome OS starts using v2 DeviceSync as soon as the flag is enabled. Bug: 951969 Change-Id: I6ed5330029f943d3cf1ae07eefa9d88f965689f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116227 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753265}
-
David Maunder authored
Previously non-encryption and encryption were both handled in the same file with a flag passed in. With the new approach they are in separate files and selecting the right file is driven by a configuration offering better separation of concerns. Bug: 1059638 Change-Id: Icdb8ff751295a913123e9b16f36198efcb9785fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106491 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#753264}
-
Becca Hughes authored
Store a maximum of 5 images for a feed item. BUG=1057765 Change-Id: I49b97831d1d4adff0d5c75acb7f218e183948258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115885 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753263}
-
Amr Aboelkher authored
Bug: b/151692396 Change-Id: I3c2830bae15a07dd853ed4ae7ec9e87cad6e3f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119855Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/393c564ae0b4..8e26c5f50e85 git log 393c564ae0b4..8e26c5f50e85 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 johnkslang@users.noreply.github.com Merge pull request #2139 from neslimsah/master Created with: gclient setdep -r src/third_party/glslang/src@8e26c5f50e85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I00ba7b9b827e1fd5a2f8afd35d0fd25fc52ed32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120524Reviewed-by:
-
Becca Hughes authored
Adds more fields around fetch state that will be updated when we fetch the feed. BUG=1057765 Change-Id: Ia560644e8057b4339a275b0f2657ed4828fb57b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110391Reviewed-by:
-
Jun Mukai authored
This is a UI performance test to measure the input latency for dragging window/tab in tablet-mode. However it has been disabled for a while due to flakiness. As I revisited this, I've realized that the expected behaviors have changed significantly due to WebUITabStrip. The test scenario looks irrelevant at all. It would be just okay to simply remove the entire file. Bug: 1031526, 1028386, 1057868 Test: none Change-Id: I3ff5663acf8b65d799ca7490ce3287005cb6efd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118892Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#753259}
-
wutao authored
This patch adds a basic Chrome OS settings page for the ambient mode. Two settings added: 1. A top level toggle to enable/disable the ambient mode. 2. A radio button group to choose the topic source, e.g. Google photos. Bug: b/151372242 Test: new browser tests Change-Id: Ifeda979080b33a5d42643b010e39d5e15b31c2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102008Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753258}
-
Dave Tapuska authored
The changes were landed in the devtools repo but the tests were not re-enabled. BUG=1030746 Change-Id: If7d5184ae6bb1a21ce6241d1391e0b0c981b96e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120742Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753257}
-
Mark Cogan authored
This CL removes use of TabModelList from the metrics services manager client. Since this was the only use case for TabModelList's IsOffTheRecordSessionActive(), that logic is just reproduced in a static method for this class, using BrowserList. Bug: 1050142 Change-Id: I52090af91a3088cfe8e216c6c0d60f94ec292ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120412 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753256}
-
Robert Ma authored
Despite the claim, https://crrev.com/c/1603203 did not handle SIGTERM or SIGINT correctly; the script would still hang. Ultimately, `multiprocessing.Pool.map` is a blocking call during which the manager process cannot handle signals. This CL: 1. Reverts the failed workaround in executive.py added by https://crrev.com/c/1603203. 2. Switches from Pool.map to Pool.imap_unordered, which has two benefits: a) we can stream the results as we process files; b) the manager is unblocked every time a result is available so it can handle pending signals. imap_unordered is not added to the Executive class because of its limited use as of now. Change-Id: Ifd4c097875b62432a32e4e82c630f388e3e49ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117160 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753255}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ffbc3f6d5d3..218c5d61fbba git log 2ffbc3f6d5d3..218c5d61fbba --date=short --first-parent --format='%ad %ae %s' 2020-03-25 changhaohan@chromium.org add aria-label for styles section 2020-03-25 szuend@chromium.org [issues] Show affected network requests in issues 2020-03-25 leese@chromium.org Reland "Deduplicate tabs with same URL" 2020-03-25 szuend@chromium.org [network] Add filter for the path attribute of a cookie 2020-03-25 tvanderlippe@chromium.org Add documentation for GN-Typescript integration 2020-03-25 tvanderlippe@chromium.org Add test that verifies dependencies rebuild dependents 2020-03-25 tvanderlippe@chromium.org Check recompilation works when files change Created with: gclient setdep -r src/third_party/devtools-frontend/src@218c5d61fbba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1064287,chromium:1064472,chromium:670180 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I999c60238537c5f0178ef4624efa6c492a41b5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120525Reviewed-by:
-
Mike West authored
Following up on https://chromium-review.googlesource.com/c/chromium/src/+/2095548, which set the //content-side flag. This should be a no-op if things are wired up correctly. Bug: 739170 Change-Id: I91f977ab6bd472c3e8f1fdcae48a0dfbb4a070a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120416Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#753253}
-
Ioana Pandele authored
When the toggle is tapped, its state is communicated to the PasswordAccessoryController. The handling of the state change will be implemented in a separate CL. Android-only. Bug: 1044930 Change-Id: I8f3377593fa7b5f381d8d1f30ef437730a0b1787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117753Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#753252}
-
John Budorick authored
This isn't a great long-term solution, but in the short term, the links should work. Bug: 1034648 Change-Id: I3cca51467d681138fa2c3bb7375af350e9c9a127 Tbr: agable@chromium.org,gbeaty@chromium.org,efoo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120952Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753251}
-
Behdad Bakhshinategh authored
This reverts commit 20dddaa6. Reason for revert: crbug.com/1064605 Original change's description: > Added MissedDeadlineFrame category to Compositor Latency > > When a frame is started being tracked in controller the deadline is > recorded in compositor_frame_reporter and after presentation of the frame > it's compared to the presentation timestamp, and if it missed the > deadline is reported under CompositorLatency.MissedDeadlineFrame as well as > the super-set of CompositorLatency. > > Bug: chromium:1058909 > Change-Id: I39a624b3b0e11d764af26f92b5d849605a94ec0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096791 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752939} TBR=sadrul@chromium.org,schenney@chromium.org,behdadb@chromium.org Change-Id: If542b8f9b3a556e0ae6302387f5fb9f7696b2840 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1058909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120954Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753250}
-
Sorin Jianu authored
Some future work for the COM server requires accessing the ComServer instance, and there is no way to get to it starting from the objects instantiated by COM factories as a response to an RPC call. Bug: 1064498 Change-Id: I45923bf70cd922cb30a766fabea9bee87f524ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119213 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#753249}
-
Maksim Ivanov authored
Add a bunch of unit tests for the <security-token-pin> Polymer element. Bug: 1033936 Change-Id: I9b9545815c45c46074137604d71e0ddb72a2a081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116194Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#753248}
-
Dave Tapuska authored
Apply recommended changes for Mac platforms. BUG=591099,654477,638621,626703 Change-Id: I2c09ed17b0c82f239c14217af1bd16ffecc1b456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120737Reviewed-by:
-
Patrick Monette authored
This fixes the compilation when building with "-fno-ms-extensions" Since the underlying storage in VARIANT is a "long", it makes sense to make the main constructor of ScopedVariant take an integer of this type. But even after this change, since there still many callsites using a "int" variable, that version is still needed to avoid the ambiguity between the "double" and "long" constructors. Finally, I've added an explicit version for VT_BOOL, because the above changes were causing additional compilation errors. Bug: 1061948 Change-Id: Ib6b22b2c01976dc4e6cbcf641e8a4ed3986c84a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110452 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#753246}
-
Vasilii Sukhanov authored
Currently it doesn't process DELETE, DELETE, ADD sequence which can happen in password generation scenario. Bug: 1063360 Change-Id: I6221ca87f5ab473328266d9a93112eec2c1dc981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120575Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753245}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: Ic7d6191907067a216db444bdf8358749b40259f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120792Reviewed-by:
-
Vladimir Levin authored
This patch adds the ability for us to keep auto elements unlocked when the subtree has focus. The activation flag is replaced by an array of flags, and a function uses those flags to determine whether we should lock or unlock. This also adds a bunch of tests for focus(). Note that the place the focus/display lock updates happen needs to before the scroll, and NotifyFocusedElementChanged is too late in the pipeline for this. Change-Id: I251dcca44275322d4ba71b7de6f8fb83eb1fe81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112956 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753243}
-
