- 06 Nov, 2020 40 commits
-
-
Chong Gu authored
Bug: 1080853 Change-Id: Ia0e24f70cfc2a3a0d4e2ddf7a18c939cfeb5a13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523475 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825057}
-
Yulun Wu authored
Spec: https://www.figma.com/file/rQFGy3iAMfNdDnydTGkvHr/Style-%7C-Semantic-color-system-surface-theming?node-id=522%3A28 Bug: 1134432 Change-Id: I92ba9d50bdef74d1bff52db34019f7ca7f58ca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508363Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825056}
-
ssid authored
Reduces one of the hot spots in early startup. Change-Id: I0fbf412a14cf1e31bbfe601d523fb8169fb73a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523241 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#825055}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0512ce9c848a0e0924bf26649d42740a3c18a783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522897Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#825054}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I2b1ebe5bbc25ac716cb7b44c469d9f7dd880ffc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503320Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825053}
-
Kramer Ge authored
When exiting picture-in-picture view, the associated wl_surface is not destroyed, but attaches a nil wl_buffer. When restarting picture-in-picture mode, skia_output_device_buffer_queue does not know it has to reschedule the background image, resulting in picture-in-picture being unresponsive. Save the background buffer and re-attach it in wayland_window s.t. the buffer queue does not need to schedule/damage background every frame. Change-Id: I882e73cecd083d56e360ba61662db9eae566d199 Bug: 1142825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519607 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#825052}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ccc9dd2835f5..434681c2378b 2020-11-06 rohpavone@chromium.org Reland "[Telemetry] Adds telemetry support to Fuchsia for memory benchmarks." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I6ebf03df325982f3e89400bd78b4639d74716b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825051}
-
Aleks Totic authored
Move table-specific node to NGTableNode. This is good for code health: * ng_block_node header no longer includes table-specific headers, and compiles faster. * it is easier for developers to find out where table-specific methods are. Bug: 958381 Change-Id: I975e59aabbbbcd06892a746a918825da4336a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522113 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#825050}
-
Martin Kreichgauer authored
Also switch the default in WPTs back to CTAP 2.0 and have LargeBlob tests enable 2.1 explicitly, since they were relying on it. Bug: 1117630 Change-Id: Ib3e0fbfe1c1a5532f2246b98b3abfd6f2fcc7d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509030 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#825049}
-
John Delaney authored
What: New UseCounter to tracker % of page loads that have an ad. Why: This metric is useful for knowing how many pageloads are applicable for ad interventions, such as the heavy ad intervention. Bug: 1139434 Change-Id: I8e6e1b9b6aa60afcd4d58c331c00a3b9bcf6523e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480967 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#825048}
-
Kyle Horimoto authored
This function allows clients to set a NearbyConnector to be used when attempting a Nearby Connection. Within the SecureChannel implementation, connection requests are rejected with the newly-added MISSING_NEARBY_CONNECTOR failure reason if a connection is requested when a NearbyConnector has not been set. A future CL will use the provided NearbyConnector when initiating a connection. On the client side, NearbyConnectorFactory now sets the NearbyConnector instance when it is created. PhoneHubManagerFactory adds a dependency on NearbyConnectorFactory to ensure that the NearbyConnector is set before Phone Hub starts up. Bug: 1106937 Change-Id: I6f25aa9be817c0bb15c19045d2c4e9494b674368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513748 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#825047}
-
Xianzhu Wang authored
When a frame rebuilds its GraphicsLayer tree, we mark its root layer attachment dirty. Previously when we updated GraphicsLayer tree of the parent frame and saw a subframe had the flag, we forced rebuild of the parent frame's GraphicsLayerTree. However, if the parent frame didn't have any compositing update flag set, we wouldn't do GraphicsLayer tree update, and the subframe's root layer would be left detached. Now check child frame's root layer attachment dirty flag when we walk the frame tree, which is unconditional, and set the parent layer needing rebuild GraphicsLayer tree if any child frame has the flag set. Haven't created a simple test case for the bug. It happens as the following: 1. Some change in a subframe happens, requiring paint property update, but not compositing input update. 2. During paint property update, we mark the subframe's compositor needing compositing update. 3. During compositing update for the subframe, we rebuild the GraphicsLayer subtree and set the root layer attachment dirty. 4. Previously, as the parent frame didn't have any compositing flag set, the subframe's GraphicsLayer was left unattached. Now we force the parent frame to rebuild GraphicsLayer tree. Bug: 1142725 Change-Id: I11bd1839cf410aec4dd1e4ae87e9df32de9d210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522877Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825046}
-
Christian Dullweber authored
Add rounded corners to the outer ScrollView in PageInfo. Bug: 1077766 Change-Id: I23eb4f33c4c603ec835bc4dee3608549653e3fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517452Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#825045}
-
Josh Simmons authored
Previously, calling setSearchQuery when the UrlBar didn't yet have focus would result in autocomplete results being shown but no visible search query. This wasn't an issue previously, as all existing callsites explicitly focused the UrlBar. With https://chromium-review.googlesource.com/c/chromium/src/+/2496031 this will no longer be the case. Bug: 1144966 Change-Id: I6efd40b25d93704fb35665d69d07541190dd024f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518081 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#825044}
-
danakj authored
These used the wrong macros, so considered all values as in bounds. R=dcheng@chromium.org Bug: 1144462 Change-Id: I3b87aebd2e9a6a21e93a967361f6648ee4c91b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523494Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#825043}
-
Wez authored
Allow WebEngine to be configured to report an Android-like UserAgent via the system-provided config-data, to allow it to be fetch the right form of content for the device form-factor. This will likely be replaced with options to configure the Client Hints reported, on a per-instance basis, once those are standardized. Bug: b/171582703, 1010256 Change-Id: I9db408be09ec9b9a78facc7b078d635b96c3637b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522071 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#825042}
-
Rob Schonberger authored
Model desc: 1. Trained with Kohaku, Kohaku-Prev and Basking data. Combined AUC is 0.982 2. Feature Vector Unchanged 3. Model Radius changed in Kohaku for new fw. 4. Eval on held out Kohaku data is 0.988, held out basking 0.976. Bug: 1095874 Test: Deployed and tested on a kohaku device. Change-Id: Ia76a6c740dd7f85b8f64b87f0ff170a83196a8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521880 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#825041}
-
Pavel Yatsuk authored
Native interface includes MessageWrapper and MessageDispatcherBridge. MessageWrapper represents a message for native feature code and allows feature code to set message properties before enqueueing it. Java side of MessageWrapper constructs PropertyModel that maintains property values. MessageDispatcherBridge enables feature code to interact with Java MessageDispatcher to enqueue/dismiss message. BUG=1123947 R=lazzzis@chromium.org Change-Id: I28b58ed080dd63045f2e18f13e3875fabd9764e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472599Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#825040}
-
Charlie Hu authored
As |chrome::ShowWarningMessageBoxWithCheckbox| accepts |base::OnceCallback| as its last parameter, the call site should use |base::BindOnce|. Bug: 1007635 Change-Id: I5e437d37ba1573cf552a2a51916a2e34831ffe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522212Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#825039}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/639610df4433..df58b821059d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tinazwang@google.com,xiaochengh@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tinazwang@google.com,xiaochengh@google.com Change-Id: Ib7219a1d2bd371c21ce70a24ee04372be50e177d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522609Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825038}
-
Guido Urdaneta authored
This CL adds an UnderlyingSinkBase implementation that takes VideoFrames and sends them to a PushableMediaStreamVideoSource. This is intended to be used by Raw Access Insertable Streams (a.k.a. BreakoutBox) Bug: 1142955 Change-Id: I0da46c1867e1ce745f69da7ea10be4d9a00a8606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514400 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#825037}
-
Moe Ahmadi authored
Provides repeatable query suggestions to be shown in the NTP MV tiles when Google is the default search provider. The repeatable queries are requested from the server for signed-in users and extracted from the URL database for unauthenticated users. Fixed: 1106396, 1110077 Change-Id: I749739cb4382d83f21256430428a60c5f1d563bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518773 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#825036}
-
Andrew Xu authored
As demonstrated by the specs, there should be an 8-pixel gap between the text and the delete button. Bug: 1131731 Change-Id: Iedcc98ba4253d10ec3acdf828f6d5eab21d6ee47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523370 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Commit-Queue: David Black <dmblack@google.com> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#825035}
-
Nick Burris authored
These switches are no longer used by internal testing so they can be removed. This also removes ExternalAuthUtils' dependency on chrome. Bug: 1145663 Change-Id: I5ee1468bd78bd9bd7b3b0bf041aed214bb5e6016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518803Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#825034}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49d9785e4224..156c227d6cf2 2020-11-06 geofflang@google.com Remove the amend commit from roll_aosp.sh 2020-11-06 cnorthrop@google.com Capture/Replay: Restore buffer bindings during Reset 2020-11-06 geofflang@google.com Always use the -f flag with rm in roll_aosp.sh 2020-11-06 jmadill@chromium.org Update DevSetup. 2020-11-06 amaiorano@google.com Re-enable GLES31 test that is no longer flaky 2020-11-06 jmadill@chromium.org Perf Tests: Add --max-steps-performed argument. 2020-11-06 geofflang@google.com Fix wrong working directory for roll_aosp.sh 2020-11-06 jmadill@chromium.org Symbol Table: Error on duplicate group keys. 2020-11-06 geofflang@google.com Check out depot_tools in roll_aosp.sh 2020-11-06 syoussefi@chromium.org Vulkan: Remove vertex attribute aliasing suppressions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Capture Clash of Clans Change-Id: I23efe90faa66cf782987b2d3e6785943fb7154ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825033}
-
Gordon Seto authored
Add ability for users to switch between cameras when scanning for QR codes on the Activation Code Page. Screenshot: https://screenshot.googleplex.com/jacMJUL3HhZAAr2.png Bug: 1093185 Change-Id: I32282cd62e0b98c72d4a76c5257b3e6f02f111c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510740 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#825032}
-
David Tseng authored
R=dmazzoni@chromium.org Test: compiles, passes existing tests. Change-Id: I543899d7cc231df8b1748b1d614e36d482acf789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520802Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825031}
-
Jimmy Gong authored
- Phonehub will now be hidden in lockscreen, preventing notifications and controls from appearing in the lockscreen. - A followup CL will handle the suspend state of the Chrome OS device. Bug: 1139415, 1106937 Test: chromeos_components_unittest, ash_unittests Change-Id: Ie06dc84e22db98032e4f1479f4db5e4df0c1290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516248Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#825030}
-
Natalie Chouinard authored
Add feature flag for enabling ChromeStartupDelegate, to be used downstream. Bug: 1143402 Change-Id: I12a56e7927d204efd4f1f487e3256b30d487f5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523359Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825029}
-
Xiaocheng Hu authored
Bug: 1146560 Change-Id: Icbbb104dafc57e1abdc1aa540265896ac96357f2 NoTry: True Tbr: fserb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521949Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825028}
-
Mei Liang authored
Change-Id: I3becc899943b0e3aeb2eb06a3f9d3fc84f738e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522006Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825027}
-
Robert Sesek authored
Use base::TimeDelta instead. Change-Id: I8065fbb31e0360180ed2d201fd3a1c31c20b8144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522237Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#825026}
-
Tina Wang authored
This reverts commit 683608bf. Reason for revert: The newly added test UNSCHEDULED_tab_search keeps failing the build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome Please take a look and help fixing. Original change's description: > Tab Search: Implement performance benchmark > > Doc: > https://docs.google.com/document/d/1-1ijT7wt05hlBZmSKjX_DaTCzVqpxbfTM1y-j7kYHlc > Usage: > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top10:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top50:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top100:2020 > > Change-Id: I684024f9cf3264ac2ed4feca15c6059342a493c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461224 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824599} TBR=johnchen@chromium.org,tluk@chromium.org,yuhengh@chromium.org Change-Id: If919a1e96f43a661f72e3f33f59f590922790644 No-Presubmit: true No-Tree-Checks: true No-Try: true bug: 1146335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523416Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825025}
-
Matt Jones authored
Change-Id: I4f229ae0932f031a9083761a2fd0b09932f6c5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523487 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#825024}
-
Gang Wu authored
This is follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/2500274 Since ViewHighlighter provide 3 type of IPH now, we rename turnOnHighlight to turnOnCircularHighlight(View) turnOnRectangularHighlight(View) turnOnRectangularHighlight(View, int) Bug:1146243 Change-Id: Id36dab8992f848fa33569ebba23a377ffd0f0fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521782Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825023}
-
Eric Lawrence authored
To mitigate "tab-napping" attacks, in which a new tab/window opened by a victim context may navigate that opener context, the HTML standard changed to specify that anchors that target _blank should behave as if |rel="noopener"| is set. A page wishing to opt out of this behavior may set |rel="opener"|. Bug: 898942 Change-Id: Id34bbc480e96cb2cc8e922388a9a5bc4161b03b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630010Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#825022}
-
Kevin McNee authored
Bug: None Change-Id: I5308a19ad12f3b0ba59c33bef603f2ff5a0882a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523439 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825021}
-
Torne (Richard Coles) authored
The DEVELOPMENT_TOOLS permission group was removed from the framework many releases ago, and it's recently become an error to define a permission in a nonexistent group. Just remove the permission group from the declaration; it only ever affected how permissions were shown in the device permissions UI and since the group was deleted has been a no-op. Fixed: 1143827 Change-Id: I636aa0d5f9d6f27e51aa5b5fa15b2e5a6339dda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522983 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#825020}
-
Jeff Yoon authored
This reverts commit f19f9e01. Reason for revert: crbug/1144638 The changes have worked for webrtc, but is causing failures for iOS official bots. We'll wait for the autoroll and ensure that CL is in place before re-landing this if that's okay. Original change's description: > Reland "[DEPS] update luci-go" > > This reverts commit 94863f6a. > > Reason for revert: > https://crrev.com/c/2518615 fixed the previous issue. > > Original change's description: > > Revert "[DEPS] update luci-go" > > > > This reverts commit 1585878b. > > > > Reason for revert: > > https://crbug.com/1144638 > > https://crbug.com/webrtc/12126 > > > > Original change's description: > > > [DEPS] update luci-go > > > > > > Bug: 1142713 > > > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#822547} > > > > TBR=yyanagisawa@google.com,tikuta@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1142713, 1144638, webrtc:12126 > > Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823859} > > TBR=yyanagisawa@google.com,tikuta@chromium.org,mbonadei@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142713 > Bug: 1144638 > Bug: webrtc:12126 > Change-Id: I3cdb4d01a5d603b95d03b93b8dd43d81a84f7a2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519179 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824332} TBR=tikuta@chromium.org,mbonadei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713 Bug: 1144638 Bug: webrtc:12126 Change-Id: I33f3cf4b84818a8abbf5d468fb9165543af5f434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522982Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825019}
-
James Hawkins authored
'HEAD' will work when 'master' is renamed to 'main'. Change-Id: Ib59537426e942fcc7ff879c65d6c2eafbff98d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523391 Auto-Submit: James Hawkins <jhawkins@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#825018}
-