- 23 Sep, 2014 40 commits
-
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/a1f6e7b..082de98 TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org Review URL: https://codereview.chromium.org/597503002 Cr-Commit-Position: refs/heads/master@{#296156}
-
landell authored
This patch creates new URLLoaderResource objects for each request since those objects can't be reused. Calling Open() on an instance of URLLoaderResource requires that mode_ is set to MODE_WAITING_TO_OPEN. After Open() has been called mode_ will never reach that state again. BUG=None Review URL: https://codereview.chromium.org/582623002 Cr-Commit-Position: refs/heads/master@{#296155}
-
changwan authored
Smart clip rect output needs to be offsetted when there is a change in viewport, e.g., when location bar is shown. BUG=414597 TEST=verified by OEM that this fixes the bug Review URL: https://codereview.chromium.org/565383005 Cr-Commit-Position: refs/heads/master@{#296154}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/d76db5d..a1f6e7b TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/596663002 Cr-Commit-Position: refs/heads/master@{#296153}
-
tapted authored
r295646 moved ownership of the AppListViewDelegate out of the AppListViewController which meant that the Mac AppList began removing itself as an observer from the wrong model. This happens because, in Chrome, the AppListViewDelegate changes the return from GetModel() when the profile is switched, but doesn't currently have a way of notifying the AppList that this is happening. To fix, AppListServiceMac needs to explicitly clear the delegate on the Chrome side before asking the view delegate to switch out its model (which happens via AppListServiceImpl::GetViewDelegate(Profile*). Views platforms are not affected, because they retain a raw pointer to the AppListModel* separately from AppListViewDelegate::GetModel(). This only works because the AppListModel* sticks around until Chrome shutdown, when it's torn down with the other keyed services via the ~ProfileManager() destructor. This delayed destruction means that verifying observers in a test needs a lot of plumbing in non-test code (see patchset1). Instead, a DCHECK is added in AppListItemList to ensure RemoveObserver always removes something, then test coverage is given by AppListServiceImplBrowserTest.ShowLoadedProfiles. This CL fixes part of the flakiness in the app list interactive uitests on Mac (http://crbug.com/415264), but I've discovered other sources of flakiness to fix before re-enabling those tests. It should, however, fix the recent crashes (http://crbug.com/416345). BUG=415264, 416345 TEST=AppListServiceImplBrowserTest.ShowLoadedProfiles TEST=crbug/416345: have multiple profiles and switch between them in the app launcher on mac many times. Chrome shouldn't crash. Review URL: https://codereview.chromium.org/592983002 Cr-Commit-Position: refs/heads/master@{#296152}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#296151}
-
vitalybuka authored
By default both enabled. TBR=gene@chromium.org Review URL: https://codereview.chromium.org/598433002 Cr-Commit-Position: refs/heads/master@{#296150}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/356af1f..d76db5d TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/586393007 Cr-Commit-Position: refs/heads/master@{#296149}
-
dcheng authored
Remote frames can't script, so it never makes sense to dispatch orientation change events at remote frames. Also cleans up some method declarations to have named parameters, to match Chromium style. BUG=416658 Review URL: https://codereview.chromium.org/596623002 Cr-Commit-Position: refs/heads/master@{#296148}
-
wuchengli authored
Originally we use a static GetSupportedProfiles for each VEA implementation to get a list of supported codec profiles. But different devices of the same platform can support different profiles. To return a correct list, they are dynamically detected in runtime and added to GPUInfo. BUG=350197 TEST=Run apprtc loopback and Hangout on peach pit. Run gpu_info_unittest. Review URL: https://codereview.chromium.org/568413002 Cr-Commit-Position: refs/heads/master@{#296147}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/76ce81e..d39c191 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=borenet@google.com Review URL: https://codereview.chromium.org/594793002 Cr-Commit-Position: refs/heads/master@{#296146}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/179d620..356af1f TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/592943003 Cr-Commit-Position: refs/heads/master@{#296145}
-
isherman authored
BUG=none TEST=none R=jamesr@chromium.org Review URL: https://codereview.chromium.org/593913003 Cr-Commit-Position: refs/heads/master@{#296144}
-
vivek.vg authored
Although passing SkBitmap by value doesn't copy the underlying pixels, it indeed involves memcpy (~64 bytes to be precise) to replicate the settings from the other bitmap in the copy constructor. Along with this, it has to do some book keeping with respect to reference counts, updating pixel lock count etc. This overhead, albeit minor, can be avoided by passing SkBitmap as reference. R=abarth@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/583743002 Cr-Commit-Position: refs/heads/master@{#296143}
-
fgorski authored
BUG=285481 R=courage@chromium.org Review URL: https://codereview.chromium.org/591703002 Cr-Commit-Position: refs/heads/master@{#296142}
-
isherman authored
BUG=none TEST=none R=jamesr@chromium.org TBR=perkj@chromium.org NOPRESUBMIT=true NOTRY=true Review URL: https://codereview.chromium.org/594653004 Cr-Commit-Position: refs/heads/master@{#296141}
-
hanxi authored
This CL moves the core web_request code, except: -web_request_api_unittest.cc -web_request_apitest.cc -web_request_permissions_unittest.cc Also moves json files: -web_request.json -web_request_interal.json BUG=352293 Review URL: https://codereview.chromium.org/584163004 Cr-Commit-Position: refs/heads/master@{#296140}
-
sorin authored
Fix some style issues regarding order of includes and forward declararions. BUG=416623 Review URL: https://codereview.chromium.org/590333002 Cr-Commit-Position: refs/heads/master@{#296139}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/1b3738e..179d620 TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/592263003 Cr-Commit-Position: refs/heads/master@{#296138}
-
thestig authored
BUG=399852,416729 NOTRY=true TBR=groby@chromium.org Review URL: https://codereview.chromium.org/591323002 Cr-Commit-Position: refs/heads/master@{#296137}
-
yoz authored
Remove/ifdef (as appropriate) a few Linux-specific assumptions. BUG=399363 TEST=app_shell_browsertests Review URL: https://codereview.chromium.org/586583002 Cr-Commit-Position: refs/heads/master@{#296136}
-
danduong authored
Adding build support and JNI hooks for undoing bookmark actions. BUG=415411 Review URL: https://codereview.chromium.org/586913002 Cr-Commit-Position: refs/heads/master@{#296135}
-
elijahtaylor authored
This is to allow unpacked extensions to load without checking a shared module's whitelist. Webstore installs and side-loading via CRX are still restricted. BUG=414950 Review URL: https://codereview.chromium.org/573113002 Cr-Commit-Position: refs/heads/master@{#296134}
-
pkotwicz authored
BUG=408049 TEST=Manual, see bug Review URL: https://codereview.chromium.org/586323002 Cr-Commit-Position: refs/heads/master@{#296133}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/fdec548..1b3738e TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/586393006 Cr-Commit-Position: refs/heads/master@{#296132}
-
estade authored
BUG=122753 Review URL: https://codereview.chromium.org/586953002 Cr-Commit-Position: refs/heads/master@{#296131}
-
Mark Mentovai authored
The big change in this version is that an installation attempt initiated by the application can show up as ondemand on the server. This will allow us to provide throttled Mac downloads (such as a "5% push") with correct behavior. A previous registration framework, 1.2.0.6782, intended to fix this bug was backed out (via DEPS) because it was not compatible with older installed Keystones. This version contains a fix for that problem. Another previous registration framework, 1.2.0.7407, was backed out because it contained bugs in its installer. Previous commit: r245361, https://codereview.chromium.org/141193002 Backed out: r245603, https://codereview.chromium.org/141583005 Tried again: r261532, https://codereview.chromium.org/212703006 Backed out: r262037, https://codereview.chromium.org/227173002 BUG=35495 R=oemilyo@chromium.org Review URL: https://codereview.chromium.org/577353006 Cr-Commit-Position: refs/heads/master@{#296130}
-
mgiuca authored
BUG=None NOTRY=true Review URL: https://codereview.chromium.org/591303002 Cr-Commit-Position: refs/heads/master@{#296129}
-
sclittle authored
BUG=416673 Review URL: https://codereview.chromium.org/592903002 Cr-Commit-Position: refs/heads/master@{#296128}
-
reveman authored
BUG= TBR=vmpstr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/597443002 Cr-Commit-Position: refs/heads/master@{#296127}
-
jbauman authored
For now the vsync signal can be sent to the browser compositor, which will handle distributing it like before. BUG= Review URL: https://codereview.chromium.org/568763004 Cr-Commit-Position: refs/heads/master@{#296126}
-
calamity authored
This CL fixes a bug where drop targets were not being calculated correctly which led to duplication on reparents. BUG=415530 TEST=Drag an app from inside a folder onto the page switcher. The app should disappear from the folder and appear in the root grid. Review URL: https://codereview.chromium.org/583263004 Cr-Commit-Position: refs/heads/master@{#296125}
-
Victor Miura authored
There seems to be a problem with this test, as it seems to change often after being rebaselined recently. BUG=416719 Review URL: https://codereview.chromium.org/587753004 Cr-Commit-Position: refs/heads/master@{#296124}
-
alekseys authored
Do not change state of More/less settings button until printer capabilities are retrieved to avoid unnecessary fade in/out cycles. BUG=415898 Review URL: https://codereview.chromium.org/596633002 Cr-Commit-Position: refs/heads/master@{#296123}
-
kundaji authored
* Remove all #if defined guards from data reduction proxy functionality. * Hard code proxy urls in params rather than providing them in gyp files. * Add DataCompressionProxyRollout field trial to all platforms. * Pass in bypass duration into UpdateRetryInfoOnFallback rather than computing it based on SPDY_PROXY_AUTH_ORIGIN. Remove unused UMAs. BUG=384394,384397 Review URL: https://codereview.chromium.org/382313003 Cr-Commit-Position: refs/heads/master@{#296122}
-
amistry authored
The test shouldn't have worked since the reload() would have prevented the implicit domAutomationContoller.send() from executing. However, runtime.reload() is async, so sometimes it continue executing, and sometimes it doesn't. BUG=407409 Review URL: https://codereview.chromium.org/589223003 Cr-Commit-Position: refs/heads/master@{#296121}
-
tbarzic authored
The method will return the user email and whether the user's logged in, i.e. whether the app is running on signin screen. Adds an event that's triggered when the user focused on login screen changes. While here, add logic to unload the app and reset signin profile EasyUnlockService when user logs in. Create the signin service only if enable-easy-signin switch is set. BUG=401634 Review URL: https://codereview.chromium.org/576343002 Cr-Commit-Position: refs/heads/master@{#296120}
-
weiliangc authored
Revert of Class for allocating a chunk of memory for RenderPass (patchset #31 id:660001 of https://codereview.chromium.org/400463002/) Reason for revert: Broke cc_unittest for Linux ASan bot Original issue's description: > Class for allocating a chunk of memory for RenderPass > > For DrawQuads and SharedQuadState, RenderPass used allocate them one by > one whenever needed. This new class helps RenderPass manages allocation > and iteration of those two types. This container allocates a chunk of > memory at one time and hands out raw pointers. It also provides iterator > and reverse iterators for going through its contents. > > Unittest for ListContainer makes sure the raw pointers it hands out are > valid and iterator has same behavior as vector iterators. > > Follows 398533002, and 404563005. > > BUG=344962 > > Committed: https://crrev.com/6ae8c50c839a8c0d8fb399578256c754ed3ce39a > Cr-Commit-Position: refs/heads/master@{#296100} TBR=danakj@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true BUG=344962 Review URL: https://codereview.chromium.org/595733002 Cr-Commit-Position: refs/heads/master@{#296119}
-
skuhne authored
A visibile to invisible state change will also release memory and should therefore wait as an unload does A visibility change will also release memory and should therefore also stall an immediate unload. Updated comments and cleaned up the ResourceManager function. BUG=414918 TEST=unittest Review URL: https://codereview.chromium.org/588823002 Cr-Commit-Position: refs/heads/master@{#296118}
-
Paweł Hajdan, Jr authored
- add -o pipefail - do not hide stderr BUG=none R=thestig@chromium.org Review URL: https://codereview.chromium.org/582293002 Cr-Commit-Position: refs/heads/master@{#296117}
-