GitLab

This change applies the BindOnceRewriter in //remoting.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=lambroslambrou@chromium.org

Bug: 714018
Change-Id: I34f580a97431487d7b438a9cc4bf4640611b311a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132152
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755452}

Interstitial code that relies on dynamic_type_util is getting moved
to //ios/components so that it can be used by iGA, so the common util
methods should also be moved to a shared directory.

Bug: 1064382
Change-Id: I6719ddefd0ac76a9a5b2b3727221bd1f0207aa95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128086
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755451}

This is a reland of 4898ea48

Adds a missing export directive which was breaking component builds.

Original change's description:
> [Fuchsia] Add support for selectively enabling input types.
>
> * Implements the FIDL ConfigureInputTypes() API, for embedder control
> over whether input events should be routed to web content or ignored.
> * Transitions CastRunner to use ConfigureInputTypes().
> * Removes the deprecated SetInputEnabled() method.
>
> Bug: 1031776
> Change-Id: I54e0b5c3b5a92935e6860e037edc6bc5a92eaa42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956154
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755219}

TBR=ddorwin@chromium.org

Bug: 1031776
Change-Id: Ia0047b56ce7ac8b28b25d0853f4d772d94cec68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132854Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755450}

The model type was added in crrev.com/c/1455965, which failed to add
this suffix entry.
While we're here, also mark the EXPERIMENTS suffix as obsolete. The
corresponding data type has been deprecated and unused since March
2019 (crrev.com/c/1515537).

Bug: 919489
Change-Id: I1941e1fc34d21ea33e2fd0ac7a87807222894d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131328Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755449}

Add a field that stores whether the item has been
checked by Safe Search or not and the result. Adds
that to the Media Feeds WebUI.

BUG=1066643

Change-Id: I65587885d177b45f95237a22bd08a3e1488f407b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130784Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755448}

https://android.googlesource.com/platform/external/perfetto.git/+log/b6fd42ad9ae2..77cb6e24f164

git log b6fd42ad9ae2..77cb6e24f164 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 fmayer@google.com Merge "Try to connect to central heapprofd on user."

Created with:
  gclient setdep -r src/third_party/perfetto@77cb6e24f164

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I3bc81ea787fd83c5477c46f31e75b56fd4f23b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755447}

Add inline margin to the label, fix repeated ids.
Screenshot: http://screen/UO3c4g6HR17

Bug: 1043108
Change-Id: I169b11823efb6981d80574eda181bd4a7b7b4150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130350Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755446}

Also remove the timestamp since logd adds the timestamp. This
makes the logs similar to cast.

Bug: internal b/152558058
Change-Id: Ifda50ed1115e2192aaa7887440aba7a02341ef09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123507Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Mohit Hotwani <hmohit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755445}

This change applies the BindOnceRewriter in //ash.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug: 714018
Change-Id: I1bad1acf6e94610fe36679f925772aa0968b9cdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132131
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755444}

This change applies the BindOnceRewriter in //chromeos/services.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 714018
Change-Id: I13f5ea4b51764c8108cf630aa6913384f0657d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132392
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755443}

This change extends the histograms related to HTTP Password Migration
and performs some small clean-ups of the logging code.

Fixed: 1053097
Change-Id: If1950c16bc168ee6595c2cdf3755b9336a9fc06b
Bug: 1053097
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132264
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755442}

Add tests for the following:
- Images in <embed>
- Images in <object>
- Background repeat, position and size properties

Chromium fails the background repeat tests.

Also removed border properties from the existing tests as they
influence the compositing behavior of Chromium and are not necessary
for the test.

All the tests are marked as failing for Chromium due to a lack of fuzzy
matching support.

Bug: 1034283
Change-Id: Ib8dfc0c47ba7d9d1e33c38b541caf169e07c786d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130648
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#755441}

https://skia.googlesource.com/skia.git/+log/e8d2080a34ed..587b091d03bc

git log e8d2080a34ed..587b091d03bc --date=short --first-parent --format='%ad %ae %s'
2020-04-01 brianosman@google.com Stop including SkVertices.h from SkCanvas.h

Created with:
  gclient setdep -r src/third_party/skia@587b091d03bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I21579ad6f5af9b93109d7292f501a7659ab8f531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132509Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755440}

Original CL: https://crrev.com/c/2127707

Bug: 1062788
Change-Id: Ife67de34bd4b214a6832bd9889ac050fc056f2be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132129Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755439}

This change enables the OmniboxUIExperimentMaxAutocompleteMatches flag to
control ZeroPrefixSuggestions as well as other search suggestion types.

Bug: 1066904
Change-Id: I8eb0f41c0c86ecff32ad35f3a808225138e0ccb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132632
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755438}

Bug: 1057957
Change-Id: I782b98b4703d585eec99eb06fb1ea8a9f3dfb9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102540Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755437}

This change applies the BindOnceRewriter in //sandbox.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=jorgelo@chromium.org

Bug: 714018
Change-Id: I40e474d39448345830eaa34a8504d1815f940191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132136
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755436}

Localized changes should not require reviews from the service's
top-level OWNERS. This CL covers DOM Storage and IndexedDB, and sets up
an example for future features to follow.

Bug: 994911
Change-Id: I346bbfff65f5509eedd42f861604cbd43f25a92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129508
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#755435}

This histogram will collect the encryption types used when a Kerberos
TGT is successfully created or refreshed. This value can be 'all',
'legacy' or 'strong'.

This metric will be reported on ChromeOS, and is implemented on:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2117121

Bug: 1062630
Change-Id: Ie11daebbd3dade8d6753aa60c2815b28cd6e3ce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112711Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Felipe Andrade <fsandrade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755434}

This CL converts resource_dirs to sources for android_resources in
BUILD.gn files.

Details:
https://crbug.com/1026378
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ

Bug: 1062263
Change-Id: I3c0323854f0543d7e487d63b5c893a4567334891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121090Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755433}

The binding code is missing template definitions for
__stdcall object method invocations. Such template definitions
exists for functions but not for object methods.

This patch allows this code to compile:

class MethodHolder {
   public:
    int __stdcall Func(int n) { return n; }
    int __stdcall ConstFunc(int n) const { return -n; }
  };

  MethodHolder obj;
  auto stdcall_method_cb =
      BindRepeating(&MethodHolder::Func, base::Unretained(&obj), 1);


Bug: 1066580
Change-Id: I6ce3cbeb9b42ebcf75c64e33f464c4e4c5409a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129895
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755432}

This change applies the BindOnceRewriter in //pdf.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 714018
Change-Id: I6450f7b53ea140ac36b9db4a0c5bac5f3047f5dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132261
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755431}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I14e2abca33bacdfe8b3dfac3116d18159104d36a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755430}

This CL prevents mirroring profile menu feature buttons icons:
Passwords, Payment methods and localization in RTL mode. Payment methods
and localization are symmetric and there is no need for mirroring. This
change goes with consistency of the password icon in the settings page.

Bug: 1052244
Change-Id: I59593312241b592169125d54640e0b4f08db78e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127930Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755429}

https://swiftshader.googlesource.com/SwiftShader.git/+log/5cf1e9a31c90..c66dad9552ef

git log 5cf1e9a31c90..c66dad9552ef --date=short --first-parent --format='%ad %ae %s'
2020-04-01 bclayton@google.com Regres: Add invertCommon optimization.
2020-04-01 bclayton@google.com Regres: Move optimization logic to separate file
2020-04-01 bclayton@google.com Regres: Keep coverage span groups stable.
2020-04-01 bclayton@google.com Regres: Split coverage.go into multiple files
2020-04-01 bclayton@google.com Regres: Further optimizations for coverage
2020-04-01 bclayton@google.com Regres: Add cov.ReadJSON()

Created with:
  gclient setdep -r src/third_party/swiftshader@c66dad9552ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I4bf210429838cc2de263f531f17da2c56b38fcca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132508Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755428}

This CL makes sure the active_session_ object exists before shutting
it down. Without this, it was potentially causing a browser crash.

Bug: 1066768
Change-Id: I2793be0862b7c14b957712740c0bbde2b8d9f21a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131627
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755427}

This is to enable developers to turn it off for testing what future
deprecation will look like.

Bug: 582750,1055010
Change-Id: I7ea0570ec6cda99ec8027219ba5f272d875b679c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124237
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755426}

`allocate()` with a hint is deprecated in C++17 and removed in C++20.
Note that while `allocate(size_t)` isn't provided prior to C++17,
`allocate(size_t, void* = nullptr)` is and will behave equivalently.

Bug: 752720
Fixed: 1065435
Change-Id: I27a7a22a752e8304988f44d9a2e330a6b2b97db5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131045Reviewed-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755425}

This change applies the BindOnceRewriter in //android_webview.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=changwan@chromium.org

Bug: 714018
Change-Id: Idb3efb3cb232b948d227c4bd238327e3556afae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132148
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755424}

This change applies the BindOnceRewriter in //chrome.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=avi@chromium.org

Bug: 714018
Change-Id: I448d5a70b2027b4bbcaa91543cb6a1bd66c211cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132369
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755423}

Bug: 1066560
Change-Id: Icb6ae8ffc1cd5e4c7884e1984b584aa1f301433d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130180
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#755422}

Roll ChromeOS orderfile from 82-4085.6-1584957322-benchmark-82.0.4085.18-r1 to 83-4085.6-1584956258-benchmark-83.0.4091.0-r2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I5aacbe7cb136a728b817231ec9af1e64d5e383a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132580Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755421}

This reverts commit e6de1039.

Reason for revert: The crash was caused by a xml text failure. The original change also delete one of the test file unintentionally. A fix will be update as a patch set of this CL.

Original change's description:
> Revert "Move settings.homepage to homepage"
>
> This reverts commit e2054b9b.
>
> Reason for revert: this CL cause crashing. Tracked in crbug.com/1062959
>
> Original change's description:
> > Move settings.homepage to homepage
> >
> > Moving Homepage related settings code to homepage.settings package
> >
> > Change-Id: Iaf198f4a25cc03b32a1de997577d466916470437
> > Bug: 1052060
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095468
> > Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751162}
>
> TBR=twellington@chromium.org,wychen@chromium.org,wenyufu@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1052060
> Change-Id: I97b75da16bf58834ba555242476b9e3f7bfd71be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109816
> Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751748}

TBR=twellington@chromium.org,wychen@chromium.org,wenyufu@chromium.org

Bug: 1052060
Change-Id: I0f0a1200755471478feb6966b21211694dd9710e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125467Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755420}

A content::RenderView should always have a valid blink::WebView if it is
observable by non-content internal code.

Change-Id: I4afd471b5b46e16865c5b46d3bbdc23a06b7f95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131246Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755419}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7108574e87d0..0a34c98ea0b0

git log 7108574e87d0..0a34c98ea0b0 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 surma@chromium.org Important changes to Whitespace

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0a34c98ea0b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I940dbb8c24267a41a9ec7d2af20efb82cd4106b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755418}

This property is required for iOS builders running on chromium recipe.
It was removed in crrev/c/2122472 by mistake.

Change-Id: I0c4cf69ba6605ab73562d3eb125084afde828a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128567Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755417}

https://chromium.googlesource.com/angle/angle.git/+log/38df4ab61807..afd2cfa6c14d

git log 38df4ab61807..afd2cfa6c14d --date=short --first-parent --format='%ad %ae %s'
2020-04-01 ancheng.qiao@arm.com Add gles1 covgl tests

Created with:
  gclient setdep -r src/third_party/angle@afd2cfa6c14d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: I9f19cfa63b33d41257b9300a5037e494269d6a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132506Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755416}

Move feature_switch_unittest.cc to //extensions to neighbor its
source file (feature_switch.[h|cc]). It has no //chrome dependencies.

Bug: None
Change-Id: Ie98bdd50d973e168e5ab593047fd697deec53bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131626Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755415}

I'm not ready to remove the instrumentation code yet, so this CL punts
the expiry of the SupervisedUsers.ExtensionsAllowlist UMA histogram to
M84. The SupervisedUserAllowlistExtensionInstall feature flag will
probably remain disabled throughout M83, so there likely won't be any
data recorded on this histogram during M83.

Bug: 1066071
Change-Id: I90d3a2d08e12d6cef514e00190fbf92773ca87e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131155Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755414}

This change applies the BindOnceRewriter in //chrome/browser/notifications.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=mukai@chromium.org

Bug: 714018
Change-Id: I88ad0171b45602b8467c2261e08bdf89701d6016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132256
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755413}