- 06 Nov, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I32cd7e377903e753d6d1a8584977f94bf2cb2c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523233Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824877}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I029985ee36fd35eb814d648bc46d94411edf4dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523234Reviewed-by:
-
Eric Lawrence [MSFT] authored
The warning message shown when a test case is missing was garbled. Fix the message so it correctly states that an expected test is not present. Change-Id: I3202572b57dd47b6925aad7f4d28d586c5a4a677 BUG: 791125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522154Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#824875}
-
Dave Tapuska authored
There are a series of messages that are sent to the RenderThreadObserver of the webview. This maps ClearCache onto one of those messages. Other targeted messages will be converted in followup CLs. BUG=993189 Change-Id: I93d84f08bfcc74211ac175463754bf6b9d3d7ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515043 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824874}
-
Ian Kilpatrick authored
As above. Change-Id: Ibd1f4a342454960d211776568a73fa3bf8a8f8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522406 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#824873}
-
Mohamed Heikal authored
visibility is blocking the autoroller. Explicitly roll it so it is visibile. errorprone: error_prone_annotations target is used by doubldown and the Change-Id: I33386182ef80ae9975378188d021503ea4e9e0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522603 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#824872}
-
Clemens Arbesser authored
I have been able to reproduce the linked issue flakily. Disabling animations seems to fix it. The previous workaround might no longer be necessary, but will stay in for a bit until we're sure that the issue is indeed resolved. Bug: 1146084 Change-Id: I6d199f19f0dbcb9ef4b10f3492566f34f96104e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521818 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#824871}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604629242-25a4011689f36cdb7c5ac3ab0a40a3994e18267e.profdata to chrome-win32-master-1604642156-7d0afa322bb4bb6abbaa9b475fb0ac5b24eae09a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If44cb43893698aacbbb9bf71144ce48f00553bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523092Reviewed-by:
-
Justin Cohen authored
This reverts commit 702076d2. Reason for revert: Instacrash crbug.com/1146408 Original change's description: > [ios] Add Location Permissions Field Trial Experiment > > This change adds setup for a client-driven experiment that buckets > users on First Run into 3 groups, two experiment and one control. > > Bug: 1138603 > Change-Id: I7c100d173ea2d64e718950047d0c2f04ff4c3fbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506749 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824647} TBR=rohitrao@chromium.org,isherman@chromium.org,boliu@chromium.org,asvitkine@chromium.org,twellington@chromium.org,thegreenfrog@chromium.org Change-Id: I792cd345c47ceec5b8b817f9efe69da172050f2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522977Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824869}
-
Michael Ludwig authored
Bug: 1143929 Change-Id: I9c9ff50b0cca7197180e9c6e61f2196053df2cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508555 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#824868}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24c7b2d7..d38e0064 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03e1931586b16e8d0c50d617c72bc40b92f6ce63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523231Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824867}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d57e268ce139..1e9cf1a8e1bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2637c2c35740acd645b0bbca0eb9da6eff70cfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523235Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9cde39469149..6d6242c0dc2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: I2fa08b2e72e8e87184412a789f68671d1c4a6c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523216Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824865}
-
Ben Mason authored
This reverts commit 8933d94d. Reason for revert: Translation failure crbug/1146426 Original change's description: > Add support for items for bool policies > > Make this a required field for new main/bool policies. > > Since the item field isn't always copied over from main policies, > also add a warning check that the policy descriptions describe the > various cases. > > Add items to MediaRecommendationsEnabled and BlockThirdPartyCookies. > > No-Presubmit: true > BUG: 1139306 > Change-Id: I519202ed9eeb491b27f804f26fbe94ae8e501598 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507457 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Yann Dago <ydago@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824431} TBR=pastarmovj@chromium.org,csharp@chromium.org,zmin@chromium.org,pmarko@chromium.org,ydago@chromium.org Change-Id: I78f3830a59e52c104fd4cbdd48e452c7612e9960 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521617Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#824864}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I699e1e43313ca5ced45a5906e3890e4390f4d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523217Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604609790-bc5437f446ee5ad42df312047e176901e766dccd.profdata to chrome-win64-master-1604653017-42c23ccace2f0081edeac3e89e9dffaf10021d96.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icbe3df52c93fbf35649c3ecf1dbebe1c8f56f812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3d5d22136720..86a7c52a9341 2020-11-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-06 yangguo@chromium.org Extend infra owners in support of l10n reviews 2020-11-06 aerotwist@chromium.org TypeScriptify OverViewGrid.js 2020-11-06 jacktfranklin@chromium.org Fix resettting user focused cell in data-grid. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I267e751f06354f556871529d364f99ba03ab8b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523215Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in downloads deep scanning to use Connector policies directly instead of the indirect helpers that map to legacy policies. Bug: 1109242 Change-Id: I040ae5acbc96008cfc70eb98d2bce0a806a26d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521850Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824860}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604642156-6de658d746d924ba0793cdd79cc80ba08c1ee69e.profdata to chrome-mac-master-1604663931-0e7a1a6cfe18868c94b28acade631941d35c92c1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iadd3f58769fa100b9fde51928959f751492899dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523214Reviewed-by:
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Fixed: 1145358 Change-Id: Ia078ba495ea717ad0d1e1acda428b3d3704acd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521041 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#824858}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604642156-a25919d317c2bef6f3d61358a8f8892267c9f548.profdata to chrome-linux-master-1604663931-9bcb947a0377607416b3fb61f11cb5b7ddd933e4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie6cbaf943b59bc0bc583f17b547add3f3f2bb1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523213Reviewed-by:
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the OriginIdentifierValueMap. This CL does not include Observer, Providers and HostContentSettingsMap. They will be cleaned separately. This CL does not change methods API but makes sure resource identifier is not used. Bug: 1134547 Change-Id: I4e222d928b80c73e2a1780619f641333d7a0bc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517722Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#824856}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc515d41bba9..0781b693fa2d 2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad54c71632cc to 612ded0654a0 (4 revisions) 2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 51c1c5ab56d5 to bd0ebb680792 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I7d35d7e76bd916f98fc0de933907afdd333d0661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521207Reviewed-by:
-
Jordan Demeulenaere authored
This CL replaces the pick_one Selector filter by the nth_match filter, that matches the nth element of the elements currently matching. See [1] for more background. [1] https://docs.google.com/document/d/167LaI_WQNr31wBuO3DNlCPD2sx3If2GOHpPsT4atXIk Change-Id: I3024239d256201fe604c0c72b4985a9de3d45201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517535 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#824854}
-
arthursonzogni authored
Add tests about crossOriginIsolated, from a context where SharedArrayBuffer isn't enabled by default (e.g. like Android). I discussed with sigurds@ about crossOriginIsolated. I thought I could trigger a CHECK. I turns out, I wasn't able too. Instead, this just opened this question: https://crbug.com/1144838 Bug: 1144104, 1144838 Change-Id: I50f3ceb54ceef9f5029d7d28fcd346e3cfa758a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514211Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824853}
-
Julie Jeongeun Kim authored
This CL adds crash key logging to track WebRequestType and URL on WebRequestPermissions::HideRequest(). Bug: 1145496 Change-Id: Ib4658ef497c922b181e84d530bf05ab4e532dc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521885 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824852}
-
Ewann authored
This CL fixes tests impacted by the EnableCloseAllTabsConfirmation feature before submitting the config. Bug: 1119319 Change-Id: I32c86bcc8f6132fbd93d04578e7cbc9d4460d543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443852 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824851}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I08e7c26feeba95600d7c98a67829cd06d9788e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523093Reviewed-by:
-
Clemens Arbesser authored
This hopefully fixes/workarounds a test failure. The fix is to avoid using the bottom sheet in the UI test directly. I was not able to repro the originally reported test failure, so this is only a best guess effort for now. We will have to monitor if this has indeed fixed the problem. I have created b/172639096 to track the root cause of the test failure. Bug: 1146084 Change-Id: I6ef0cb4f05717805f4ba7dd36b6c0c682b89ef3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521817 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824849}
-
Antonio Gomes authored
... as well as kFrameRestoreLookKey. Dependency/include graph: - frame_util.cc uses kWindowManagerManagesOpacityKey and kFrameRestoreLookKey; - frame_utils.h is included by frame_header.cc; - frame_header.h is included by default_frame_header.h - browser_non_client_frame_view_ash.cc includes default_frame_header.h. So, in order to free browser_non_client_frame_view_ash.cc|h from including //ash/ headers, the items above will migrate step by step to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: If1ba34dca49f752ec3c9247e366879c10455a5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521691Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#824848}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1d7344bed6303d1ac2f9b7e9f916380525d19303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522590Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d57e268ce139..1e9cf1a8e1bd 2020-11-06 treehugger-gerrit@google.com Merge "protos: Use int32 instead of uint64 for ProcessSnapshot's pid field" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0b541402505a8806376808dbd72348a29269d843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522589 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41bb19c60930..9cde39469149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: clamy@google.com Change-Id: I2225589c12002981314cc9098f89292f69915129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522586Reviewed-by:
-
Mirko Bonadei authored
Instead of generating absl .def files at roll time, this CL switches the build config to generate the required .def file on the fly while building. The advantages are: 1. No need to re-generate .def files when something external to absl changes and affects .def files (e.g. when a new compiler optimization it enabled). 2. No need to hard-code supported build flavors in the .def generator script, resulting in multiple .def files checked-in. On the other hand, this makes the build slightly slower than it is today because reading all absl object files to generate the .def file can take a few seconds. Bug: 1046390 Change-Id: If3a8fb3dca0ed75dbd85655cff1263853dcc146a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270094 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#824844}
-
Sylvain Defresne authored
ChromeBrowserStateClient returned a hardcoded value of "1" when asked for the number of BrowserStates as using browser_state_info_cache.h would have introduced a circular dependency. Fix the circular dependency by moving browser_state_info_cache.h from the //ios/chrome/browser/browser_state:browser_state_impl target to the //ios/chrome/browser/browser_state target instead. Bug: 991575 Change-Id: I589fa36db8dc0e85d546982aaa096fd5a958b23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521001 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#824843}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb8e1e991bc9..3d5d22136720 2020-11-06 aerotwist@chromium.org [unit test] Isolate connection and environment helpers 2020-11-06 yangguo@chromium.org Add stack trace for assertion failures in e2e tests 2020-11-06 aerotwist@chromium.org Updates coverage config 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in developer_resources/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in security/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in layers/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in help/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in web_audio/ 2020-11-06 yangguo@chromium.org Introduce allow list for expected assertion failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132333,chromium:1145969 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48cbe89c881e13a3498feee0019f72733d139059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522588Reviewed-by:
-
Hajime Hoshi authored
Before this CL, not-stored reasons are not recorded when the browsing instance is not swapped. This means we are missing records in these cases. This CL fixes this by adding an additional record at RenderFrameHostManager::ShouldProactivelySwapBrowsingInstance Bug: 1134847 Change-Id: Id683b7f94de4e8cb81da0b5779f56a496d040b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466002 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#824841}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a61d347b99c9..ccc9dd2835f5 2020-11-06 landrey@webrtc.org Log full diagnostic data during insertion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1146040 Tbr: skyostil@google.com Change-Id: I5fdaf1b7c52bed201b031381edd7441c205d3352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522587Reviewed-by:
-
Stephane Zermatten authored
Before this change, ElementPositionGetter would round each coordinate it got before computing the center, then rounding it. With this change, only the center is rounded. This was puzzling. This change is expected to have no effect, as all coordinates should be integer values to begin with. It's just a cleanup. Change-Id: Ib0ac75f6e08d825f1521e32325c87672eb9f9d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521734Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824839}
-
Kyle Horimoto authored
Bug: 1146224 Change-Id: Ie240478c901e1ed791f05002d4f9d906072b1b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522507 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824838}
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
