GitLab

BUG=none

Review URL: https://codereview.chromium.org/501153006

Cr-Commit-Position: refs/heads/master@{#292374}

This removes an ash dependency from the system.display API in order to move it to extensions/. As a side effect, we got rid of #ifdefs on system_info_api.cc

BUG=392842

Review URL: https://codereview.chromium.org/507783003

Cr-Commit-Position: refs/heads/master@{#292373}

Instead add a run_mojo_python_bindings_tests.py that will be run from
the bots. This also refactor run_mojo_python_tests.py to factorize the
common code.

BUG=407818

Review URL: https://codereview.chromium.org/509863002

Cr-Commit-Position: refs/heads/master@{#292372}

BUG=405951
TBR=lally@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/515193002

Cr-Commit-Position: refs/heads/master@{#292371}

These functions where invaluable when trying to debug and fix the
cc::OrderedTestRunner as they let me easily inspect the tasks without having to
fire up GDB. They should also be useful in development / testing of other task
runners.

Added a very simple test for ShouldRunBefore which shows this stuff working. If
that test fails, the output looks like the following;
-------------------------------------------------------------------------------
../../base/test/test_pending_task_unittest.cc:49: Failure
Value of: task_after.ShouldRunBefore(task_first)
  Actual: false
Expected: true
TestPendingTask(
  {"delay":2000,"nestability":"NESTABLE","post_time":0,
   "posting_function":"Unknown@Unknown:-1","run_at":2000}
).ShouldRunBefore(TestPendingTask(
  {"delay":1000,"nestability":"NESTABLE","post_time":0,
   "posting_function":"Unknown@Unknown:-1","run_at":1000})
)
-------------------------------------------------------------------------------

BUG=380889

Review URL: https://codereview.chromium.org/491743002

Cr-Commit-Position: refs/heads/master@{#292370}

flight.

Merge internal change: 74165077

Renabled flaky LargePostZeroRTTFailure to see if this CL fixes issue
407756 on chromeos valgrind.

R=rch@chromium.org, rjshade@chromium.org
BUG=407756

Review URL: https://codereview.chromium.org/511003002

Cr-Commit-Position: refs/heads/master@{#292369}

BUG=408179
NOTRY=true

Review URL: https://codereview.chromium.org/509333002

Cr-Commit-Position: refs/heads/master@{#292368}

Revert of Modify test case to support streaming operation in sandbox file system. (patchset #6 of https://codereview.chromium.org/491813002/)

Reason for revert:
This is breaking fast/filesystem/op-copy.html in Blink:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/filesystem/op-copy.html

Original issue's description:
> Modify test case to support streaming operation in sandbox file system.
>
> BUG=360088
> TEST=content_unittests passed
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2332db94ec6c42aaa3d66f5226a4c17b85c1553e

TBR=tzik@chromium.org,iseki@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360088

Review URL: https://codereview.chromium.org/510323003

Cr-Commit-Position: refs/heads/master@{#292367}

This pulls in the following changes:

* dbus: Add method for cryptohomed GetKeyDataEx
* Remove deprecated shill::kPaymentURLProperty
* Add a constant for the 'org.freedesktop.DBus' interface.
* dbus/service_constants.h: Remove
      "Cellular.ActivateOverNonCellularNetwork"
* Add portal detection failed phase and status to service property

BUG=367847
TEST=Everything still compiles

Review URL: https://codereview.chromium.org/507973003

Cr-Commit-Position: refs/heads/master@{#292366}

https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/512183002

Cr-Commit-Position: refs/heads/master@{#292365}

This fixes a FindBugs warning.

NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/517453003

Cr-Commit-Position: refs/heads/master@{#292364}

BUG=110610
TBR=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/513673004

Cr-Commit-Position: refs/heads/master@{#292363}

TBR=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/510303003

Cr-Commit-Position: refs/heads/master@{#292362}

We have observed on some Mac that video frames are delivered back to back from the build in video capture device. This can potentially happen on all platforms. If that happen, the simple filter used for frame rate calculation get scewed. This cl fix that by dropping all frames received within 5ms of the previous frame.

BUG=394315

Review URL: https://codereview.chromium.org/516783002

Cr-Commit-Position: refs/heads/master@{#292361}

This patch introduces OpenPDFParamsParser class which is responsible
to parse open pdf parameters and set them in a dictionary. This
dictionary will be used to set initial viewport settings when opening
pdf document.

BUG=303491

Review URL: https://codereview.chromium.org/477933003

Cr-Commit-Position: refs/heads/master@{#292360}

BUG=405504

Review URL: https://codereview.chromium.org/501473002

Cr-Commit-Position: refs/heads/master@{#292359}

BUG=360088
TEST=content_unittests passed

Review URL: https://codereview.chromium.org/491813002

Cr-Commit-Position: refs/heads/master@{#292358}

Add __init__.py file to the password manager python tests to
make it a module so that it could be imported from python
files in the parent folder.
BUG= 408198

Review URL: https://codereview.chromium.org/511943002

Cr-Commit-Position: refs/heads/master@{#292357}

Reason for revert:
It broke some antialiasing tests on Win7, see:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/19724/steps/webkit_tests/logs/stdio

The output has some odd comma added after each character. It doesn't seem to be a rebase problem.

Original issue's description:
> Skia roll 6b0d6b4:b2f7fce
>
> https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=djsollen@google.com
>
> Committed: https://chromium.googlesource.com/chromium/src/+/98c591a509f0c760d514fe079cf507ef1f7e76a4

TBR=djsollen@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/515753004

Cr-Commit-Position: refs/heads/master@{#292356}

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/468873002

Cr-Commit-Position: refs/heads/master@{#292355}

The only use of Profile in that file is to get net::URLRequestContextGetter. This CL pulls that out, so that instead of getting a Profile, and asking for URLRequestContextGetter, the affected class gets URLRequestContextGetter directly.

This reduces a //chrome dependency to a //net one, and is part of preparations for content settings componentisation.

BUG=384873

Review URL: https://codereview.chromium.org/508223002

Cr-Commit-Position: refs/heads/master@{#292354}

BUG=none

Review URL: https://codereview.chromium.org/493293002

Cr-Commit-Position: refs/heads/master@{#292353}

BUG=403846
TEST=manually tested

Review URL: https://codereview.chromium.org/514103002

Cr-Commit-Position: refs/heads/master@{#292352}

* Make MalwareIframeReportDetails work with V3 and reenable it
* Make ReportingDisabled work with V3 and reenable it
* Remove TODO from PhishingProceed, since it's been enabled for a while
* Remove TODO from PhishingLearnMore, since it's been enabled for a while
* Remove logging statements scattered around

BUG=273302,247763
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/512073002

Cr-Commit-Position: refs/heads/master@{#292351}

With SearchProvider, we can suggest URLs as well as queries and show icons at the left of each suggested item.
Also, parts of the suggested query which is not typed by the user are shown bold.

Basically do the same thing as Chrome's AutocompleteController+OmniboxProvider.
Add required resources to athena_resources.

BUG=408050

Review URL: https://codereview.chromium.org/514583002

Cr-Commit-Position: refs/heads/master@{#292350}

Currently WebContentsViewDelegate has a mix of ObjectiveC and C++ code
guarded by #ifdef OS_MACOSX. This means, on Mac, it can only be included
in .mm files.

For views on Mac, we want to reuse the toolkit-views WCVD (and tests)
when hosting a WebContents in a views::Widget. So we can't convert
everything to .mm.

This CL changes the guards to use __OBJC__ and ensures the vtable is a
consistent size with the compile flags used on MacViews.

To reduce churn, the WCVD methods are given default implementations.
MacViews needs the other methods, currently guarded by USE_AURA, so
things get really complex without this.

BUG=399191

Review URL: https://codereview.chromium.org/507363002

Cr-Commit-Position: refs/heads/master@{#292349}

BUG=259656
TEST=manually

Review URL: https://codereview.chromium.org/510713002

Cr-Commit-Position: refs/heads/master@{#292348}

The role of MountedDiskMonitor is replaced with DeviceEventRouter.

BUG=360946,396258
TEST=manually

Review URL: https://codereview.chromium.org/479563007

Cr-Commit-Position: refs/heads/master@{#292347}

https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/516563003

Cr-Commit-Position: refs/heads/master@{#292346}

Review URL: https://codereview.chromium.org/508953003

Cr-Commit-Position: refs/heads/master@{#292345}

Cleaning up weak_ptr_factory destruction order in "src/net" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/506523002

Cr-Commit-Position: refs/heads/master@{#292344}

https://codereview.chromium.org/501093003/

BUG=None
TBR=skuhne@chromium.org

Review URL: https://codereview.chromium.org/517483002

Cr-Commit-Position: refs/heads/master@{#292343}

Heap allocated MultiThreadedCertVerifier was passed to URLRequestContext::set_cert_verifier, which doesn't take ownership.

Leak was introduced in r249928.

BUG=NONE

Review URL: https://codereview.chromium.org/516453002

Cr-Commit-Position: refs/heads/master@{#292342}

Currently, it crashes entire chrome. This CL is to stop devtools gracefully
when socket for http server cannot be instantiated because of any reasons
including address-already-in-use error.

BUG=407999

Review URL: https://codereview.chromium.org/516483002

Cr-Commit-Position: refs/heads/master@{#292341}

BUG=none
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/511903003

Cr-Commit-Position: refs/heads/master@{#292340}

It's flaky on Windows 7, but appears to be okay on Windows 8.

BUG=336558
TEST=None.
TBR=tonyg

Review URL: https://codereview.chromium.org/510263002

Cr-Commit-Position: refs/heads/master@{#292339}

BUG=390086

Review URL: https://codereview.chromium.org/467113004

Cr-Commit-Position: refs/heads/master@{#292338}

Cr-Commit-Position: refs/heads/master@{#292337}

Revert of Re-enable SitePerProcessBrowserTest.CrossSiteIframe (patchset #10 of https://codereview.chromium.org/479403004/)

Reason for revert:
This is causing unaddressable memory errors on the DrMemory full bot. Build where the error was introduced:

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/945

(error hash: 25DFC5E3C30FC6B7)

Sample log output:

UNADDRESSABLE ACCESS of freed memory: reading 0x034348e0-0x034348e4 4 byte(s)
# 0 blink_web.dll!blink::toCoreFrame                                      [third_party\webkit\source\web\webframe.cpp:24]
# 1 blink_web.dll!blink::RemoteFrameClient::firstChild                    [third_party\webkit\source\web\remoteframeclient.cpp:49]
# 2 blink_web.dll!blink::WebRemoteFrameImpl::~WebRemoteFrameImpl          [third_party\webkit\source\web\webremoteframeimpl.cpp:106]
# 3 blink_web.dll!blink::WebRemoteFrameImpl::close                        [third_party\webkit\source\web\webremoteframeimpl.cpp:131]
# 4 content.dll!content::RenderFrameProxy::~RenderFrameProxy              [content\renderer\render_frame_proxy.cc:120]
# 5 content.dll!content::RenderFrameProxy::`vector deleting destructor'
# 6 content.dll!content::RenderFrameProxy::OnDeleteProxy                  [content\renderer\render_frame_proxy.cc:180]
# 7 content.dll!content::MessageRouter::RouteMessage                      [content\common\message_router.cc:54]
# 8 content.dll!content::MessageRouter::OnMessageReceived                 [content\common\message_router.cc:46]
# 9 content.dll!content::ChildThread::OnMessageReceived                   [content\child\child_thread.cc:494]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage                 [ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run                                [base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask                          [base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask                                   [base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask                     [base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork                                    [base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run                                [base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler                                [base\message_loop\message_loop.cc:408]
#18 content.dll!content::RendererMain                                     [content\renderer\renderer_main.cc:227]
#19 content.dll!content::RunNamedProcessTypeMain                          [content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run                       [content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain                                      [content\app\content_main.cc:19]
#22 content::LaunchTests                                                  [content\public\test\test_launcher.cc:475]
#23 main                                                                  [content\test\content_test_launcher.cc:123]

BTW IMHO the CL summary for this change could be better, this change did way more than re-enalbe a test. Ideally the summary would capture the entirety of the change.

Original issue's description:
> Re-enable SitePerProcessBrowserTest.CrossSiteIframe
>
> This CL fixes a few issues in the cross-process subframe navigation and re-enables the CrossSiteIframe test on most platforms. There are still some issues on ChromeOS and Android, which will be investigated and fixed in follow-up CL.
>
> BUG=399775, 357747
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291437

TBR=creis@chromium.org,avi@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399775, 357747

Review URL: https://codereview.chromium.org/515073002

Cr-Commit-Position: refs/heads/master@{#292336}

This CL depends on https://codereview.chromium.org/512943003/

BUG=408373
R=oshima@chromium.org
TBR=tony@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/515723003

Cr-Commit-Position: refs/heads/master@{#292335}