- 25 Nov, 2020 40 commits
-
-
Igor Tukh authored
PermissionAuditingService is a service which allows to store and audit the basic information about the permissions usage. Bug: 1152769 Change-Id: If22ed0ad189eca8dbdd8502d3a1151d7561aeffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517443 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#831018}
-
Palak Agarwal authored
Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. This is an API for capturing the current tab. Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Bug: 1136942 Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#831017}
-
Clemens Arbesser authored
Bug: b/171776026 Change-Id: I061a82a990b60a07952e4c6203b1b6260de97d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554569 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#831016}
-
Janusz Majnert authored
If input file contains non-utf-8 characters, running GetResourceAllowlistFileList in python3 fails with a variation of: "UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 24: invalid start byte" This change makes python3 treat data as bytes, while leaving python2 behavior unchanged. Change-Id: Idb6f4cf8fe3a98551df91b1249a1b74ba2916acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560505Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831015}
-
Alex Turner authored
Use of base::CancelableCallback is deprecated in favor of the more explicit base::Cancelable{Once,Repeating}Callback. The uses were often missed when converting directories from base::Bind/Callback to the Once/ Repeating versions. This cl completes this conversion for directories already marked as fixed. A follow-up cl (crrev.com/c/2506350) will enforce a presubmit for this deprecation on converted directories. Bug: 1142629 Change-Id: I0453280104339d359b4a9dfa90507104d154b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505963Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#831014}
-
Gauthier Ambard authored
This CL changes the key used in the error to pass the URL of the failed navigation as it is not the one used in the rest of the navigation code. Fixed: 1140976 Change-Id: I752feef45742477ca38f9e3e89f3921378889f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550674Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831013}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1e79537bc8ee341113d56edc4da819c6daeb1326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831012}
-
Thomas Tellier authored
Bug: 1152041 Change-Id: I040b4d71be130b0a0102e66a13976c3a940123eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560102Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#831011}
-
chrome://flagsViktor Semeniuk authored
This features allows obtaining Change Password URLs from the Affiliation Service. Also UseOfHashAffiliationFetcher enables usage of Affiliation Service for non-synced uses. Bug: 1108279 Change-Id: Iaf9551af033b0636596ba6d3abab156c111c9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556843Reviewed-by:
-
Egor Pasko authored
Just a tiny fix to follow the API contract. Bug: None Change-Id: I2ed632b45d802ddc100340121b7e29b37abc5198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560123Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831009}
-
Wei Lee authored
Bug: b/172344305 Test: Build successfully Change-Id: Ibef322d2c968a844c778baa6d8ca9cd0a2909b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554262Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831008}
-
Adrian McCarthy authored
The `got_clang_revision` property is no longer available, so point out that the LLVM revision range is available in the `gclient runhooks` log. Change-Id: I5adde8dfc5e0a9ee6da0b852803744497d4c240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537700 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831007}
-
Andres Calderon Jaramillo authored
Bug: 1152030 Test: None Change-Id: I24840d83ec6fe3ee14c387943740d606491151a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559445 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, a Mojo message PaymentRequest.Init() with null details, id, or total would not be rejected and could cause null pointer dereferences in the browser. This patch adds checks for null details, id, and total in the browser, so the invalid Mojo IPC messages are rejected. After this patch, a Mojo message PaymentRequest.Init() with null details, id, or total is rejected, so the transaction is aborted. Bug: 1148074 Change-Id: I39c821eef034cafc4ed830769785fb812304f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556470Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831005}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606283471-f8912cacc34d1ac24aa30fb74f9ef98ec89268aa.profdata to chrome-linux-master-1606305050-8edbd758527486c76db2fc42225801a21c253468.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie8c9f0df5dc5d26c8becf2f2cf1a6defd4c52812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560865Reviewed-by:
-
Roman Sorokin authored
Check if it's inited before setting a callback to wait Fixed: 1151851 Change-Id: I94ae394067474c277d0f7c5786c611d637aa98fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560508 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831003}
-
Robert Ma authored
And add more logging (consistent with other parts of wpt-export). Change-Id: If2d1e2b6e80fe3600e2dc1b9ff63f11ec41f2018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559230Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#831002}
-
Liquan (Max) Gu authored
Since the raw PaymentMethodData array may have null elements, this CL null-check element and reject these cases. Bug: 1152662 Change-Id: I51382071f1f90966f9ed16e88b6b3ed2691ae482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559642 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831001}
-
Gauthier Ambard authored
This CL unfocusing the omnibox when the NTP is created. This is needed as the NTP is re-created when the browsing data are cleared. This can happen while the omnibox is focused on multiwindow. Unfocusing the omnibox ensure that the NTP state (i.e. scrolled down) is matching the omnibox state. Bug: 1139191 Change-Id: I07d050bc1c2d90178bf80786150fd2cbc1d4e4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550044 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831000}
-
Ulan Degenbaev authored
The performance.measureMemory API relies on PerformanceManager, so we need to enable PerformanceManager to run web platform tests. Bug: 1085129 Change-Id: I5e49a35025928526d8e5a36a07e8dcecf2793977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551122Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830999}
-
Boris Sazonov authored
Improves testability of AccountManagerFacadeLacros - mojo::Remote is now passed explicitly to the ctor. Bug: 1117472 Change-Id: I81475ea7bf369a51ff0b0bdf8e43117737d09706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550809 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#830998}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I492fc44a2805ada0577fff025343470e685b653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560047Reviewed-by:
-
Philipp Hancke authored
this will intentionally break when adding new codecs and we can not add new codecs anymore because we do not have enough payload types. BUG=webrtc:12194 Change-Id: Ic1dff5f479377280111729f6443fc60a7d2e2658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550806 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830996}
-
Jack Franklin authored
It was disabled to allow a DevTools Frontend CL to land, but it should now be able to run again. I thought the test would need updating given the changes in the source file, but it doesn't. There was a legitimate bug in the source CL (which has since been fixed) which I mistakenly took to mean I needed to disable the test before my frontend change could land. Fixed: 1150854 Change-Id: I672b336941e5f9a797a09d3139af1ea61f516ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558338 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830995}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606283471-7d9c21277781bbef8f12040d64fba3a4328552df.profdata to chrome-mac-master-1606305050-ea6ce0091e94442cf03fb928da3568602c7b69e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee98d112dc96901b7c15d69d5c5543d643a65680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560861Reviewed-by:
-
Maciek Slusarczyk authored
When the online sign-in flow is executed after password change CrOS shows old password confirmation dialog. If the old password provided by the user is incorrect the dialog is displayed with an error message. The message stays there even if we cancel the flow and start from scratch. This CL introduced a new flag that checks if the flow was restarted anew and if so hides the error message. Bug: 1138083 Change-Id: I8a6c6cafcbedf154f8d0cc008ed0510ed6373e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537639 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eaf49c6587ad..16534e267df0 2020-11-25 tvanderlippe@chromium.org Remove Python infrastructure for the Closure Compiler 2020-11-25 jacktfranklin@chromium.org [DarkMode]: rename patchThemeSupport to enableLegacyPatching 2020-11-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-25 jacktfranklin@chromium.org [DarkMode] turn off legacy patching in CSSOverviewStartView 2020-11-25 alexrudenko@chromium.org Allow expanding/collapsing details in the Layout panel using arrow keys 2020-11-25 yiorsi@gmail.com Add copy object context menu in Console and Sources panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511,chromium:1148353,chromium:1149859,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f65ff96ffcc72b7f849ca24d9a58c644d948acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560052Reviewed-by:
-
Pavol Marko authored
The test was failing/flaky on some MSAN bots, presumably because the listener was registered after the event was fired. Introduce a helper class that allows us to easily register the listener, perform the event, then wait for the listener to have fired. TBR=josiahk@chromium.org, dtseng@chromium.org Bug: 1145612 Test: Runs locally but real test will be whether this fixes failures on the 'Linux ChromiumOS MSan Tests bot' Change-Id: I16303d96b101113e80ab4f484b4e604faeab4c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560622Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830991}
-
Ewann authored
PageInfoRefactoring has been launched. This CL removes The Legacy PageInfo implementation as well as the implementation of the PageInfoRefactoring flag. Bug: 1038923 Change-Id: I24d60982ca1de28ef12faa6f2e89d3883c3046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529162 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#830990}
-
arthursonzogni authored
Merge the DidSetFramePolicyHeaders IPC into DidCommitProvisionalLoad. They were sent together one after the other, but in two separate calls, which caused race conditions. Benefits: 1. Fix a race condition about sandbox flags. This is https://bugs.chromium.org/p/chromium/issues/detail?id=1145139#c5. The first IPC was resetting the sandbox flags, and the second was updating them with the right values. If a navigation is started from the browser process just in between receiving both IPCs, the navigation will use no sandbox, when it should have. 2. Fix https://crbug.com/1093268. It was possible to receive DidSetFramePolicyHeaders for speculative RenderFrameHost. It is logically no more possible, since DidCommitProvisionalLoad is the IPC that will "activate" the speculative RenderFrameHost. 3. Recover from https://crbug.com/1146025. Page with sandbox flags are properly restored after entering the BackForwardCache. 4. Since the IPC doesn't exist anymore. There are no more need to be guarded behind a `IsInactiveAndDisallowReactivation`. A page in the backforward cache can't receive this anymore, since it doesn't exist. Fixed: 1145139, 1146025 Bug: 1145139, 1146025 Change-Id: Ic720dd125a103fa09894a7f5348accc34823e33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536467Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830989}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Id36838b51a8ea1009951b1ccb5e6266df4b16d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560860Reviewed-by:
-
Hitoshi Yoshida authored
Credentials type converter can access a dictionary member[1] when it is not available. This CL fixes the issue. [1] PublicKeyCredentialCreationOptions.extensions.largeBlob.support Bug: 839389 Change-Id: Ica1b43775e221a37a4be0befc920035f32fa214f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558133Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#830987}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1e918ec96e32fb8c05c9770d5b9e4878edf124bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560858Reviewed-by:
-
Viktor Semeniuk authored
Change-Id: I35e47822676fa88221a4061c3bbf231670a8d02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560299Reviewed-by:
-
Ewann authored
This CL updates the UITableViewStyle used in the Settings when the kSettingsRefresh flag is enabled, according to: http://slides/1oQp4K1J_Ue0U6Obsy-73PWD9wzuU4OhDEJczu82kXk8#slide=id.g5402559cba_0_413 it also cleans the white theme when the flag is enabled. Bug: 922511 Change-Id: I9d14fba7a46b41563bd1a1c14fbed9aef3cf6152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556965 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd56c5490710..1bb4e5eef6d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: I6388bf7334ac9608a04604d40d094881041ec6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560051Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830983}
-
Chris Lu authored
When tab closures are undone, the max/min inset ranges are not set in the new WKWebView before loading the page, because the session restoration logic doesn't follow the new tab creation logic. This change sets the max/min inset ranges whenever the Fullscreen model is reset, which covers any change of the active WebState. There will be no-op calls as a result of this since max/min inset ranges change during rotations, but it shouldn't hurt performance. Bug: 1149908 Change-Id: Ic94345d4e01854ab7addb70bf27f215b0f3cb590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552172 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606262372-c93aa4463db3b18479db12ddf45a2403c2ea87d0.profdata to chrome-win64-master-1606283471-0c692a03b66417a93fe8e91b8a0c4f515aaad0a9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I821ddffb7ee1967d9e1916a695850ca977dc8997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560044Reviewed-by:
-
Morten Stenshorne authored
We may re-layout between hit-testing and calculating PositionForPoint(), which may mean that the fragment stored in HitTestResult is from an older fragment tree generation. Fixes the following browser test when LayoutNGFullPositionForPoint is enabled: PasswordAutofillAgentTest.NoRefillOfUserInput And the following web tests: fast/css-generated-content/pseudo-triple-click.html fast/dom/MutationObserver/end-of-task-delivery.html fast/forms/search/search-hide-cancel-on-cancel.html fast/forms/text/input-text-self-emptying-click.html Bug: 1150362 Change-Id: I2717702da635613edb5dea4191a1dffa3cea8422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552865 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#830980}
-
Aya ElAttar authored
- Added unittests for DataTransferDlpController. - Changed some functions in DlpRulesManager & DataTransferDlpController to be virtual, so it'd be possible to override them in tests. Bug: 1140528 Change-Id: I36091bb4bc8d2c55cd0ef8749ce46073e9cac689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550544 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#830979}
-
