GitLab

These got lost while rebasing the last few CLs.

Bug: 1009124
Change-Id: I85daee52a6506d1b21d1e9c276ca5dd2de4a0443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080468Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745601}

This is the first step in incorporating Sophie and Rose's code from last
summer into the new navigation paradigm.

Bug: 982004
Change-Id: I247fa82ec58560505c64f92993108ec7b5687d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076000Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#745600}

This reverts commit 5854b63f.

Reason for revert: failed to build on bot linux-chromeos-rel
details: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/35381?

Original change's description:
> Add unit tests for drag handle nudge.
> 
> Other changes:
> 
> Add test methods to drag_handle class
> Modified shelf_widget GetDragHandle() to return DragHandle* instead of View*
> Modified DragHandle::ShowDragHandleNudge() to fetch timeout for current pref instead of taking it as an argument.
> Fixed bug where ShowDraghandleNudge did not call handleNudgeShown.
> 
> Bug: 1034168
> Change-Id: Ifde73e31b1e35b630ab61b7ab43d49c9796dce20
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076015
> Auto-Submit: Yulun Wu <yulunwu@chromium.org>
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Toni Baržić <tbarzic@chromium.org>
> Commit-Queue: Yulun Wu <yulunwu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745583}

TBR=tbarzic@chromium.org,manucornet@chromium.org,yulunwu@chromium.org

Change-Id: Iee2da855a7f8ca0c0cba9689a4319607edbdd108
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1034168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079204Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745599}

Bug: 1056063
Change-Id: I513d5d1d4b0629aef7bbe85cf48dbb10e43bccc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076533
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745598}

Adds a target for the library and test targets.

- Integrate into compontents_unittests as all other components do as
  well. This ensures that unittests are automatically run on CI.
- Provide a separate gc_unittests binary as the components binary
  requires ~35k files to build.

Bug: 1056170
Change-Id: I8fa235c239f2dc5217145c12abb8c1f27af84fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080422
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745597}

Change-Id: Ibd9edc2f826f3a6a0cd4014fccf9308fd3791285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080076
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745596}

Set kCFBundleNameKey to be the app title. Leave the behavior of legacy
apps (not PWAs) unchanged.

Bug: 1021804
Change-Id: I0c4dbfc01cead79c3fad8b1bc7a9ddd1147c9bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080471Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745595}

Bug: 710376
Change-Id: I40fe4b1aa37d9c1f334ade3b474135d7a7f9ccf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078653Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745594}

Change-Id: Ib4559631453e2eec14345b9c9273d770b2eefb9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077118Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745593}

Bug: 1056878
Change-Id: I82ee6e3b9990495c5a82abd0472bbbd0f7e2e032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080435
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745592}

The gfx GetFontFallback(...) using Skia is using the same
API under the hood than font_fallback_mac.mm.
see: https://cs.chromium.org/chromium/src/third_party/skia/src/ports/SkFontHost_mac.cpp?l=3043

This CL is doing the migration to use GetSkiaFallbackTypeface(..) like
other platforms to have an more uniform results.

Skia Implementation also supported other corner cases like decomposition.
see: ui/gfx/font_fallback_skia_impl.cc

Bug: 1026735
Change-Id: If26ce32a0a826fea688dbbf25977ffb7590e31df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075222Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745591}

This reverts commit b2543971.

Reason for revert: The underlying cause of crbug/1055216 has been fixed.

Original change's description:
> Revert "[WebNFC] Enable feature flag by default for Origin Trial"
> 
> This reverts commit 22b25dd3.
> 
> Reason for revert: NFC settings crash on Android L and M. (crbug/1055216)
> 
> Original change's description:
> > [WebNFC] Enable feature flag by default for Origin Trial
> >
> > For the WebNFC Origin Trial the feature flag needs to be enabled by
> > default and configured as "disable only" in runtime_features.cc so that
> > it can still be used as a kill switch but will not enable the feature
> > on sites which don't have a valid Origin Trial token.
> >
> > Bug: 1035048
> > Change-Id: I139a79dd0f93013bc59d5023017b49c820532fb1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052198
> > Commit-Queue: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Charlie Reis <creis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#743309}
> 
> TBR=creis@chromium.org,reillyg@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1035048, 1055216
> Change-Id: I6617ee1b2bc6b3d1fb719d0454d4f8f4735bd44c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070106
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743984}

TBR=creis@chromium.org,reillyg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1035048, 1055216
Change-Id: Ifc09be93e634ce418e21d2b8482eb38a07b2e8cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079159Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745590}

This is a reland of 21245a70

Original change's description:
> [xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec
>
> Change-Id: Ib77234174ece4facb35596808fd964a18db04311
> Bug: 1054944
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409
> Commit-Queue: Cathy Li <chili@chromium.org>
> Reviewed-by: Justin DeWitt <dewittj@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744352}

Bug: 1054944
Change-Id: Ifc70eedc0dd645d6f1ae834a05c3989c1c67dfa3
TBR: twellington@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079850
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745589}

AttachToElement() name was unclear: while it technically attaches the
MediaSource to the Element, the underlying MediaSource cannot be used
for appending media, etc. by the app until it is opened with a call to
SetWebMediaSourceAndOpen().

This change renames these two methods, respectively, to
{Start,Complete}AttachingToMediaElement(), along with some comment
updates. Actual function remains unchanged.

This clarification CL is expected to improve readability and review,
especially of the in-progress MSE-in-Workers CLs.

BUG=878133

Change-Id: Ic726cbee71d92e82a5a8c7d3be7d8d9185d1fb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079384Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745588}

This CL adds JankyScrollPeriods metric from Chrometto dashboard to
be computed on the waterfall. We want to compare results of this metric
and ScrollJankMetric on lab devices and delete one of them afterwards.

Bug: b/150125501
Change-Id: Ifec9f2f41b9f579a94ada95d35459f00b3f17cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080414Reviewed-by: Deep Roy <dproy@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#745587}

In the process, convert the buffer_types.mojom to handle<platform>. This
also adds a legacy IPC::ParamTraits<ScopedHandle> to support sending
GpuMemoryBufferHandle over legacy IPC.

Tbr: flackr@chromium.org
Bug: 863011, 710376
Change-Id: I087d9d83edc729b512dbb79806a0b4b2db2b31bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064609
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745586}

Every time a quic merge with API changes will introduce changes to quic
transport files. This is to decrease the review latency of a regular
quiche merge.

No-Try: True
Change-Id: I02fbc4eb79798236e18d4795132195d4b521c3c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079896Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745585}

This reverts commit 99965b74.

Reason for revert: Fix for the test landed.

Original change's description:
> Disable the load:games:spychase:2018 story on webview due to flakes
> 
> TBR=crouleau@chromium.org
> NOTRY=true
> 
> Bug: 1046101
> Change-Id: Ifb27532f7096ab1461a552b87a20e1f9379ddb10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023987
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735574}

TBR=oysteine@chromium.org,crouleau@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1046101
Change-Id: I2816333bcae2a57fd7e07ac6af2d7b9d277c2949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080440Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745584}

Other changes:

Add test methods to drag_handle class
Modified shelf_widget GetDragHandle() to return DragHandle* instead of View*
Modified DragHandle::ShowDragHandleNudge() to fetch timeout for current pref instead of taking it as an argument.
Fixed bug where ShowDraghandleNudge did not call handleNudgeShown.

Bug: 1034168
Change-Id: Ifde73e31b1e35b630ab61b7ab43d49c9796dce20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076015
Auto-Submit: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745583}

This CL is a logical no-op.

It manually covers the use cases the script
(https://crbug.com/1026641#c22) didn't cover in
https://chromium-review.googlesource.com/c/chromium/src/+/2026350.

A few of the affected files were also migrated to
content::GetUIThreadTaskRunner() whenever surrounding code consistency
was at stake (but the bulk of that migration is staged to happen after
this one so this wasn't a priority in this batch).

Most files intentionally kept base/task/post_task.h as an include. It is
still required because of a cyclical dependency during the migration
preventing base/task/thread_pool.h from implicitly providing
base/task/task_traits.h to its users (callers that explicitly store
TaskTraits and include task_traits.h don't have this problem). The
post_task.h include will be cleaned up in a later phase.

This CL was uploaded by git cl split.

R=mark@chromium.org

Bug: 1026641
Change-Id: I32abc8694280a33819067901636915b2be5f12dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078421
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745582}

It was noted that in the case of WebView the labels are not shown even
though the permission to access the devices were granted. After further
inspection, crrev.com/c/1964495 exposed an issue in permission checking
in the case of WebViews.

To give us time to look into the issue further and fix the actual
permission checking for WebViews, this CL disables by default the behavior
change of enumerateDevices on Android.

Bug: 1055770
Change-Id: I9dc557fed9961cf90794c87c4da4fa12213793f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078547
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745581}

When a request was redirected to a page with a service worker installed,
webRequest was not seeing the events. This is because the network loader
factory was no longer proxied on the redirect.

Bug: 1012977
Change-Id: I1161a8d6ac58711b83427accc8026a0981fa527e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079932Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745580}

Change-Id: I5215174f057e1e377216db73b7f0bf7a77086f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079465
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745579}

TBR=caseq@chromium.org

Bug: 1055006
Change-Id: Ie2859a35d586ff2ae9ea54f461c9fd8552e32c3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078975
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#745578}

canvas-lostgpu-context.html is consistently crash in last 3 builds:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29

TBR=thakis@chromium.org

Bug: 818426

Change-Id: I77f658d014ca5eab2bfef811e182e27f1c53ad3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079681Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745577}

Fixed: 1057032
Change-Id: I594e390ec47d17fed42cb8a374f4d58917addc62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079688
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745576}

This CL modifies PageTestBase::NavigateTo accept all http headers through a HashMap. Previously the method only accepts feature policy header and CSP header.

The modification is prework to add test for document policy which has its own header.

Change-Id: I7cabaaba3c099ff5e77040891ba9950a25271f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080438
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745575}

Doesn't include internal builders.

Bug: 1028719
Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745574}

The test very occasionally times out on Mac 13 and Mac 14.

TBR: vmpstr@chromium.org
Bug: 1054894
Change-Id: Iff9857cd24b84bc2d5c076ac5bef44d86815b608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080198Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745573}

R=mlamouri, tguilbert

Bug: 1012063
Change-Id: I863429b989244ebd09db76d0d52b9d8b58053347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079512
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745572}

Change-Id: I9ad0f3e030a95055a93b2a567317f513af641505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076328Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745571}

Smaller screen treatment for padding and scaling:
https://spec.googleplex.com/crosux-spec/feature-specs/oobe-system-window.html

Bug: 1033273
Test: Manual Test
Change-Id: I9938b1c728d66f1a914138102fe3ea466b08875c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079544Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745570}

The view is quite large, so removing the mask will improve draw times
and use less GPU memory. Also changed the end gradient colour to match
the spec; personally I think using transparent as the end gradient
looked better.

Test: manual
Bug: 1056967
Change-Id: I254e11bca1a85c6bf19a74e8e5e852d00f568f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079687Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745569}

Bug: 1050345
Test: loaded Secure Shell & checked chrome.xxx APIs were defined
Change-Id: Iff76898eed3ebf86c212560aa9182314c016b87f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047769
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745568}

Mirror the behaviour of GetAssertion and obtain a UV token for devices
that support it and have UV configured. Handle retries and fallback to
PIN.

Bug: 1055497
Change-Id: I8c3c524db0da848374f2a68a0166a4420bdd248d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073139
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#745567}

Before this change, element coordinates were relative to their window,
i.e. frame. For elements in iFrame this meant that the "cutout" was
misplaced.
This change now keeps a frame-stack while retrieving elements and
then sums up the position to get a "global" position of the element
for using in a showcast.

Bug: b/143942385
Change-Id: I8f3827002df58874d7921e969954f911630cc4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074499
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745566}

Bug: None
Change-Id: Iaf4ad87d59a6f957c5aef6623e7c64f72d92c364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080195Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745565}

This CL continues the process of moving OS specific strings from
setttings_strings.grdp to os_settings_strings.grdp, specifically
languages sub page strings.

Bug: 967883
Change-Id: I6309deb37268c2210ffb28b2e02b299a274521c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055968Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#745564}

with the goal of making it impossible to have values from invoker
accidentally clobber values from the template (or vice versa).

Bug: 1050094
Change-Id: I7248c76cc7f0b628f756d23d9618271befffb820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079838
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745563}

This reverts commit d3273ac4.

Reason for revert: Causing crashes on (internal) iphone-device and ipad-device. Might be a Debug vs Release issue, rather than a device vs simulator issue.

https://ci.chromium.org/p/chrome/builders/ci/iphone-device/7243
https://ci.chromium.org/p/chrome/builders/ci/ipad-device/7808

Original change's description:
> [iOS] Plumb Browser into RecentTabsViewController
> 
> Changes RecentTabsViewController to accept a Browser instead of separate
> WebStateList and BrowserState inputs. This will make future refactoring
> more straightforward.
> 
> (There remains a great deal of work to do to fully refactor Recent Tabs
> to properly factor responsibilities into a mediator and coordinator).
> 
> Bug: 845192
> Change-Id: I068b0a343752dba602d2a2226cd0bcf327873446
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078452
> Commit-Queue: Mark Cogan <marq@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745456}

TBR=marq@chromium.org,gambard@chromium.org

Change-Id: I7119af082ce06b110638bda6ba6782f4382c1f16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079468Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745562}