- 11 Jul, 2018 40 commits
-
-
Xi Han authored
With "allow-start-service-manager-only" flag, we can start the service manager without starting the remaining parts of the browser, particularly the browser main loop. Later, we could start the full browser with the service manager running. Currently, both code path go through service_manager::main(). Therefore, we need to avoid calling the initialization in service_manager::main() multiple times. In this CL: 1. service_manager::main() checks its static bool flag to decide whether initialization should be called. 2. Plumbs the start-service-manager-only flag to the ContentMainRunner who starts the browser main loop. This CL impacts Android only for now. It follows up CL: https://crrev.com/c/1093303. BUG=854209, 846846 Change-Id: I7fcfb804ce7f3065da7df12947674344fe2f56d6 Reviewed-on: https://chromium-review.googlesource.com/1114077 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574169}
-
Jeremy Roman authored
They are unused. Change-Id: I5857cac266ddbe296188490817edc1aeb70a45d6 Reviewed-on: https://chromium-review.googlesource.com/1132294 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574168}
-
David Bertoni authored
The Video Player app has a test, VideoPlayerBrowserTest.OpenSingleVideoOnDrive, that loads a script from ui/file_manager/integration_tests. This script would normally be blocked by the platform app's CSP. Update the app to use an explicit CSP allowing the extension's resource. Bug: 861815 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idf10b0eea4e284ea4c3f0c624dc05c5a340fc4ed Reviewed-on: https://chromium-review.googlesource.com/1132314 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#574167}
-
Fabio Tirelo authored
The new value is consistent across platforms and is according to MD2 spec. Bug: 860273 Change-Id: I4b1f28a8f063f08fe99865580f5ac7085d8c27d6 Reviewed-on: https://chromium-review.googlesource.com/1131680 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574166}
-
Francois Doray authored
This CL removes the initialization of TabManager by ChromeUnitTestSuite before every Chrome unit test run. This will make it easier to initialize metrics::DesktopSessionDurationTracker before TabManager in tests that need to verify that Chrome usage (instead of wall time) is used for tab lifecycle state transitions. Bug: 775644 Change-Id: I01d05579964822c87ebc515cafdd25e08fdab661 Reviewed-on: https://chromium-review.googlesource.com/1132121Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#574165}
-
Joshua Pawlicki authored
Bug: 862588 Change-Id: Ie8733b4735fc481205c51858da88c82708f3482c TBR: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1133123Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#574164}
-
Francois Doray authored
These methods don't access member variables, so they can easily be made static. Making these methods static will avoid having to initialize TabManager and its dependencies in a bunch of tests. Bug: 775644 Change-Id: I2ef567c855e34e234faad569126e752460cd2418 Reviewed-on: https://chromium-review.googlesource.com/1132094Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#574163}
-
Justin Donnelly authored
When we added kExperimentalUi, I added it to views_mode_controller::IsViewsBrowserCocoa() but I didn't notice that there was this other implementation. The omnibox has a feature that uses features::IsViewsBrowserCocoa() and I'd like it to trigger on kExperimentalUi. Let me know if there's some reason why we'd expect these to give different answers. There are only a handful of places that depend on the features:: version: https://cs.chromium.org/search/?q=features::IsViewsBrowserCocoa Bug: 862336 Change-Id: Ieffe5d13bb08c5c36994cef9ccc850ca4552c2b2 Reviewed-on: https://chromium-review.googlesource.com/1132430Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#574162}
-
Nicolas Pena authored
Bug: 832680, 830882 Change-Id: I7fc5145f1b1ce9fee9bff6470cc55cda578e2c64 Reviewed-on: https://chromium-review.googlesource.com/1127259Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#574161}
-
Calder Kitagawa authored
This bug was found by the fuzzer. If a large int32 value is present for a RelCode32 the result of mapping the location to its target results in integer overflow or underflow as found by UBSAN. In the particular example found by the fuzzer a value of 1292632068 is read from the image. The result of |(1292632067 - 1) * kInstrUnitSize|, where |kInstrUnitSize = 2| results in an overflow. This is only possible for RelCode32 so we only need the fix there. The solution is to check for overflow and if it occurs just to skip the reference. In a regular DEX file these should be very rare if ever present. I've tested the updated version on a subset of the corpus with no ill effects. Bug: 862095 Change-Id: Ifedeeaf1ae7e72a147421ecb917ec1751f4bb8d4 Reviewed-on: https://chromium-review.googlesource.com/1131225 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#574160}
-
erikchen authored
The original CL caused a test failure in DetachToBrowserTabDragControllerTest.DetachToOwnWindow. This was due to a bug in the test itself, which was generating an incorrect mouse-up event. This CL fixes the test to delay generation of the mouse-up event until the new tab dragging window has been detached. > WebContentsView::Focus() is supposed to update the first responder of the > Window, not make the window focused. The latter should go through > WebContentsDelegate::ActivateContents(). > > This logic is usually a no-op because the window receiving the call is the > active window. But in the case where the user quickly switches windows, this can > cause the old window to re-take focus. > > This logic was added in 2009 not because it had the right semantics, but to > match the behavior of Windows: http://codereview.chromium.org/165492. > > Bug: 859614 > Change-Id: I2bc44a825d93159d774c632da17cc2f2d151fc3a > Reviewed-on: https://chromium-review.googlesource.com/1124772 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573344} Bug: 859614 Change-Id: I441a00ad015eb3559718b448fc42f98827beee35 Reviewed-on: https://chromium-review.googlesource.com/1132106Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574159}
-
Francois Doray authored
Previously, TabManager::PerformStateTransitions() could be called repeatedly and needlessly while a tab is being discarded: - TabManager::PerformStateTransitions() Transitions a LifecycleUnit to PENDING_DISCARD. - TabManager::PerformStateTransitions() Calls CanFreeze() to check if the LifecycleUnit can be frozen. CanFreeze() returns true even though the LifecycleUnit is already being discarded. Calls Freeze(), which transitions the LifecycleUnit to PENDING_FREEZE. Calls CanDiscard() to check if the LifecycleUnit can be discarded. CanDiscard() returns true. Calls Discard(kProactive) to discard the LifecycleUnit. ** Since a LifecycleUnit was discarded, another call to PerformStateTransitions() is scheduled immediately. ** - TabManager::PerformStateTransitions() Called repeatedly until the LifecycleUnit transitions to DISCARDED. This CL fixes the issue by returning false from CanFreeze() and Freeze() for a LifecycleUnit that is being discarded. Bug: 775644 Change-Id: I4de25dfe7d569f61d0eef988b217203eeae6f006 Reviewed-on: https://chromium-review.googlesource.com/1132343Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#574158}
-
Saman Sami authored
This will allow us to see these events for all clients and not just RenderWidgets. Also will make it work with OOP-D Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id7a65a0129d27821797f8a46408ece32c580fc3b Reviewed-on: https://chromium-review.googlesource.com/1132323Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#574157}
-
Nico Weber authored
Also add a data dep that's necessary (but apparently not sufficient) for cast_shell_browsertests to run on swarming. Bug: 861753, 861843 Change-Id: Ib10a8589c1349ac70dc4d4358395af6b2867d16b Reviewed-on: https://chromium-review.googlesource.com/1133201Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574156}
-
huangxueqing authored
This is a reland of 6d48958d Don't check acceptable scheme links since UrlUtilities.isAcceptedScheme() was native function, libchrome.so had not loaded when handle intent. Original change's description: > Ignore Intent filters with wildcard hosts when handling links. > > If the Android device has a package installed that declares > an Intent filter with `android:host="*"`, Chrome will launch > the Intent picker UX whenever a person taps a link. > This is a poor user experience. (Using `android:host="*"` > arguably doesn't make much sense; normally, Intent filters > would use `*` to match subdomains such as *.google.com.) Thus, > skip Intent filters with such wildcard hosts when handling > acceptable scheme links. > > R=dtrainor@chromium.org > > Bug: 841133 > Change-Id: I3cb14309ed53e0bd623ed0da59af6635391a8718 > Reviewed-on: https://chromium-review.googlesource.com/1053847 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564487} Bug: 841133 Change-Id: Id2fd7f7364eb6c70280b29a1f71783a2ee89747b Reviewed-on: https://chromium-review.googlesource.com/1096554Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#574155}
-
Chris Sharp authored
The main changes were: -converting LOG(INFO) to VLOG(1) -Removing usages of Time::FromInternalValue Bug: 830892 Change-Id: I117d6d605b5ca0b82ea7d509a127fbf316f483b0 Reviewed-on: https://chromium-review.googlesource.com/1130103 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#574154}
-
Gauthier Ambard authored
This CL removes the autolayout constraints on the TabGrid button in the toolbar and instead positions it using frames. Bug: 862576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5eda2cc58ee38228e40870f723315bc91ac6953f Reviewed-on: https://chromium-review.googlesource.com/1133167Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#574153}
-
Anthony Vallee-Dubois authored
The pref was gated on being in the Heuristic Model experiment, which isn't necessarily the case anymore. The pref should always be registered when the Heuristic Model is chosen. Bug: 862229 Change-Id: I41fd77334edac643f43c638a6d56abc408242a53 Reviewed-on: https://chromium-review.googlesource.com/1131814Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#574152}
-
Ian Clelland authored
This allows debug messages to print sandbox flags in a convenient binary format, rather than outputting them as decimal numbers or 4-byte arrays. This means that you can easily add debug statements for sandboxing code like: DLOG(INFO) << "The sandbox flags here look like " << sandbox_flags_; rather than having to cast: DLOG(INFO) << "The sandbox flags here look like " << std::bitset<32>(static_cast<int>(sandbox_flags_)); It also changes the test output from EXPECT_EQ failures from looking like: ../../content/browser/some_browsertest.cc:12345: Failure Expected: blink::WebSandboxFlags::kAll & ~blink::WebSandboxFlags::kScripts & ~blink::WebSandboxFlags::kAutomaticFeatures Which is: 4-byte object <6F-FF FF-FF> To be equal to: root->child_at(1)->effective_frame_policy().sandbox_flags Which is: 4-byte object <FF-FA FF-FF> to the more reasonable: ../../content/browser/some_browsertest.cc:12345: Failure Expected: blink::WebSandboxFlags::kAll & ~blink::WebSandboxFlags::kScripts & ~blink::WebSandboxFlags::kAutomaticFeatures Which is: 11111111111111111111111101101111 To be equal to: root->child_at(1)->effective_frame_policy().sandbox_flags Which is: 11111111111111111111101011111111 in which single bit errors can easily be spotted. Change-Id: Ibc9020d67654c555e1c70dcb99829e2eb29d0b3c Reviewed-on: https://chromium-review.googlesource.com/772320Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#574151}
-
Maxim Kolosovskiy authored
This CL increases |kMaxFieldsOnTheForm| to 100 in |FormStructure::IsMalformed|. It allows to crowdsource more forms. See the bug for details. Later the parameter will be increased even more and will be finchable. UMA histogram is introduced to monitor the size of forms Autofill has to process. TODO: Finch-controlled threshold and UKM metric. Bug: 857454 Change-Id: I50c1382dd36e2c707cd34f1a4f139413d9ea6026 Reviewed-on: https://chromium-review.googlesource.com/1131457Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#574150}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cbed949bee84..b1a4db5551ca git log cbed949bee84..b1a4db5551ca --date=short --no-merges --format='%ad %ae %s' 2018-07-11 thestig@chromium.org Fix some nits in fxjs code. Created with: gclient setdep -r src/third_party/pdfium@b1a4db5551ca The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I520096872b1ab632c4dc59d4c653620e08f0fc52 Reviewed-on: https://chromium-review.googlesource.com/1133238Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574149}
-
Morten Stenshorne authored
When discarding intrinsic block size for contain:size, we need to reset intrinsic size to the border+padding sum (not zero), since intrinsic_block_size_ is the size of the border box, not the content box. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I29195a09a6d47b9e3c2a82da3be6f528aac25c68 Reviewed-on: https://chromium-review.googlesource.com/1133163 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#574148}
-
Javier Ernesto Flores Robles authored
Currently an instance of the input accessory view controller is created per tab view the tab helper. This CL changes that to instead only have one instance per BVC. This the first step to start adopting the new coordinators architecture, which will be used in to present the manual fill view controllers from the input accessory view. The next step woould be fixing dependncies in order to move the coordinator to ui folder. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id0cc93c57e18f51f0208c38ddcdf4e3b8e9e90ac Bug: 845472 Reviewed-on: https://chromium-review.googlesource.com/1103126 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574147}
-
Emily Hanley authored
TBR=nednguyen@google.com NOTRY=True Bug: 757933 Change-Id: Ie817891643082472fc46805ef4a2ffe43356f2bf Reviewed-on: https://chromium-review.googlesource.com/1133278Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#574146}
-
Peter Mayo authored
This is passing at ToT. The bug reference here looks like an old or original import. I wonder when this started working, but it does not seem worth chasing down. Bug: 706118 Change-Id: Ie8163cb204ed03f9ab04524400b84bb8d3e47232 Reviewed-on: https://chromium-review.googlesource.com/1132558Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574145}
-
chcunningham authored
This changes the interface such that saves can only performed via the SaveCB. Internally the CB is weakly bound to the perf history so post destruction saves are quietly dropped. This unblocks re-landing https://chromium-review.googlesource.com/c/chromium/src/+/1123687/1 The above CL will give incognito profiles a distinct VideoDecodePerfHistory instance. Incognito profile's are rapidly deleted when the last tab closes, creating a race condition for any per stats that are inbound from video's on that tab. Now, using the SaveCB, those late stats will be safely dropped. Bug: 855631, 855215, 796280 Change-Id: Ia978dbca14d5584ca92301aee84020437a90311e Reviewed-on: https://chromium-review.googlesource.com/1123396Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#574144}
-
John Barboza authored
Introduces `is_aix` variable and suppress non-virtual-dtor warning. Change-Id: Iab0ceee2309d96b1efcb09fadc710362159da752 Reviewed-on: https://chromium-review.googlesource.com/1103535Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#574143}
-
Mihai Sardarescu authored
This CL add the activity and interactions sync settings. This allows the user to control whether event logger is enabled. This is controlled internally by the sync data type USER_EVENTS. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If32166e4b6d8eb3c25d28a8ada67491721cf59d8 Reviewed-on: https://chromium-review.googlesource.com/1126239 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#574142}
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I5f237f6be4311ebd36262354aef1256cd06d44eb Reviewed-on: https://chromium-review.googlesource.com/1131995Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#574141}
-
Nico Weber authored
gn now lives at https://gn.googlesource.com/gn/ , so delete src/tools/gn, and bot configuration to run gn_unittests. Bug: 859536 Change-Id: I64f4d4fb00349cb8d7143d0a1b96088cc173e27c Reviewed-on: https://chromium-review.googlesource.com/1129822 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#574140}
-
Michael Lippautz authored
Page::main_frame_ is used during constructing Page::visual_viewport_ (VisualViewport) which imples that the field should be constructed before using. allocatd memory. Note: In practice this works because Oilpan currently 0-fills all newly Change-Id: I103d90c17d649dffbce2c9ac70a0a6a9cac9448b Reviewed-on: https://chromium-review.googlesource.com/1133159Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#574139}
-
Greg Kraynov authored
Change-Id: I8625303764e75b947515f2bcdaf67fa092f925d5 Reviewed-on: https://chromium-review.googlesource.com/1133173Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574138}
-
Ramin Halavati authored
Change-Id: I4d6e738dba8a06cd62d8d03b41492a3ebecce88f TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1133162Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#574137}
-
Henrique Grandinetti authored
On cl https://chromium-review.googlesource.com/c/chromium/src/+/1112051, I changed the override part of UsageTimeLimit policy from a single object to an array. On this cl I change the usage_time_limit_processor to handle this as well. Currently, the only override considered is the latest one. Bug: 823536 Change-Id: Ia5842edec3fc6127115d7f7b988ec43c437b1713 Reviewed-on: https://chromium-review.googlesource.com/1127399Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#574136}
-
Sebastien Marchand authored
Bug: 775644 Change-Id: I63764d060763c2040086c84ae02517f7bea3af52 Reviewed-on: https://chromium-review.googlesource.com/1132399Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#574135}
-
Gauthier Ambard authored
This CL changes the location bar background to be less visible in non-incognito. Also it updates the search button to be the same background color as the location bar. Bug: 862518 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7e25c2b093161524cb38619dcc834776e0891cc8 Reviewed-on: https://chromium-review.googlesource.com/1133008Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#574134}
-
Miguel Casas authored
This CL is a spin off of crrev.com/c/1130662/4 with the old data type uses (e.g. int8, int16, int32) corrected (e.g. int8_t, int16_t, int32_t) etc. https://chromium.googlesource.com/libyuv/libyuv.git/+log/4d67b3e851b1..55f5d91f11f9 $ git log 4d67b3e85..55f5d91f1 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 fbarchard Disable old int types by default. 2018-07-03 fbarchard msa use void * for loads 2018-06-29 johannkoenig xcode: disable avx512 support Created with: roll-dep src/third_party/libyuv Bug: libyuv:807 Test: local builds and try bots for libyuv pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I60d62b047b04c6c0f821df15a5f5b4be85cf331c Reviewed-on: https://chromium-review.googlesource.com/1131560 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#574133}
-
Gauthier Ambard authored
This CL prepares FindInPage to have its UI updated for UI refresh. A new protocol for both UI elements and a new shared constants file are added. The old UIView is renamed to LegacyFindBarView. Bug: 805504 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic732a11c38b8b068d59138d9073f988a2b206843 Reviewed-on: https://chromium-review.googlesource.com/1131951Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#574132}
-
Greg Kraynov authored
Bug: 841735 Change-Id: I95f2c967423fd5419002527c2b18041b8e5d499a Reviewed-on: https://chromium-review.googlesource.com/1131746 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574131}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/08859344..8885d8b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2f2ca58a2d7665e92d0f7164307a33bf75ab5d40 Reviewed-on: https://chromium-review.googlesource.com/1132851Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574130}
-