- 10 Mar, 2020 40 commits
-
-
Owen Min authored
CloudExtensionRequestEnabled policy is only used when CloudReportingEnabled policy is set to True Bug: 1006899 Change-Id: Iac7b65d043de6bff91d46b7adfc06b2bbbd6d61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095451 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748925}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4072.0-1583751487-benchmark-82.0.4079.0-r1 to 82-4072.0-1583751487-benchmark-82.0.4081.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4c779a931ce80341e6602af3d043f8c936c81043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748924}
-
Jonathan Ross authored
This test has begun flaking regularly on Windows. Marking as RetryOnFailure so that we can hopefully handle the flakes. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2096089 Where we marked deqp/functional/gles3/shaderloop_do_while.html as flaky. Seems both related tests are affected. TBR=ynovikov@chromium.org TEST= webgl2_conformance_gl_passthrough_tests deqp/functional/gles3/shaderloop_while.html Bug: 1060024 Change-Id: Ie9b6e1f5b56a5d1e6515baff0f5133e09cc2e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094740Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748923}
-
Theresa Wellington authored
If we fail to create a TabModel because there are already too many, don't set TabModel on various clients. Rather, #finish() and return immediately. BUG=1059989 Change-Id: I01dca310d50de4f6665ccd23102316bc234ce611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097235Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#748922}
-
Mohsen Izadi authored
To be able to include and use it without including the whole cc::InputHandler. This is specially needed for use in cc::EventMetrics to avoid include cycle. While doing this, also changed ScrollInputType to be an enum class. Bug: 1058162 Change-Id: Ifb17c9852e0f2e6e7481e527a40523a1c153b6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092198Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748921}
-
Lily Chen authored
"Endpoint groups" in the ReportingCache were previously identified by an origin and a group name. Since the NetworkIsolationKey must now be added as an additional key, this CL adds the NIK to the ReportingEndpointGroupKey struct. Everywhere where an origin, group tuple was used to identify a particular endpoint group, we now use a ReportingEndpointGroupKey, which contains a NIK, origin, and group name. The "clients", which used to each describe the Reporting configuration for a particular origin, are also now identified by both a NetworkIsolationKey and origin. This CL does not touch the reports stored in the ReportingCache. It also does not yet double-key the header parser, which is the entry point into the cache, so for now the NIK fields are not yet filled in with real NIKs; they are all empty (except in tests). Bug: 993805 Change-Id: I23aa38bd6ab439376d7f6134c3e13b4e1a2c9318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988987 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#748920}
-
Frank Tang authored
Types of files: conversion data, dictionaries, and break rules, etc with the following extension only: *.cnv, *.dict, *.brk, *.icu, *.cfu, *.nrm None of '*.res' files is tracked. Enable UMA to find out which ICU data files were seldom used for future trimming consideration. Still need to set U_ENABLE_TRACING to 1 in third_party/icu/BUILD.gn to turn it on. Bug: 1056846 Change-Id: Ia99a6b318bae6c1ac6aeeb917440b3a691312733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079299 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e6a773d..1003942d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfaefeec67a02c902dcbfdecea12fbe0b9bf12a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096391Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748918}
-
Ovidio Henriquez authored
This change implements getDevices() which returns a list of WebBluetoothDevice objects that the current site has permission to access. If the kWebBluetoothNewPermissionsBackend flag is enabled, the list of devices will contain all of the permitted devices. If the flag is not enabled, then the list of devices will contain the permitted devices that are currently connected to the system. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit#heading=h.5ugemo7p04z9 Bug: 577953 Change-Id: I9785f24ee46ac634b6a96d6146f54da37d132a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044660 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#748917}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e5db26faa43..4bdcfb7b6e69 git log 9e5db26faa43..4bdcfb7b6e69 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 bpastene@chromium.org Revert "Fix CrOS minidump pulling on certain devices" Created with: gclient setdep -r src/third_party/catapult@4bdcfb7b6e69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055225,chromium:1059426 Tbr: eseckler@google.com Change-Id: Ie0157d9731b76304a450924f89274e9484bd1c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097042Reviewed-by:
-
Adrienne Walker authored
This patch restricts IndexedDBContextImpl usages to StoragePartitionImpl and indexeddb itself. This is one of the final pieces before the StoragePartitionImpl bit can be removed and IndexedDBControl is used by StoragePartitionImpl instead of IndexedDBContext. Bug: 1015214 Change-Id: Ia96becbba462716e001633cc526afa55dd6af7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092182 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748915}
-
Joshua Bell authored
Noticed as flakes in wpt-firefox-stability-nightly, interfering with landing some other tests. These tests don't use helpers to ensure unique database names and are sensisive to residue left by previous tests, e.g. if the cleanup functions don't run. Make the tests somewhat more robust by ensuring unique names and deleting state left by previous runs. Change-Id: Ie2cb5672f12c0fed0e6ff53900f16e5ba8998262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086452Reviewed-by:
-
nancy authored
AppService doesn't have the extensions information, so the tilte for extensions on shelf is empty when launch extensions. Modify LauncherControllerHelper::GetAppTitle. If the app can't be found from AppService, call extensions to get the title. BUG=1059732 Change-Id: Ib2766671e85c049c17c98f0a524e79f457706979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096416Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748913}
-
Stephen Chenney authored
Adds UMA and UKM for various aspects of asynchronous HTML document parsing (i.e. parsing files): - Chunk counts, indicating how often the parser yields and is unpaused - Parsing time total and min/max across chunks - Tokens parsed, total and min/max across chunks - Yielded time, min and max, indicating how long the parser wait after yielding Metrics are only collected for main frames, with high resolution clocks, for asynchronous parsing policy. Privacy review doc: https://docs.google.com/document/d/1wp_Od8Q2mwJtf-kqEnGdZ2P3SHu1MzdQLwKqhNQQhdU/edit?usp=sharing Bug: 1031723 Change-Id: Id9cc0faf95e15d1dd0a33b963e876674084f3f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088036 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#748912}
-
Eugene But authored
Most crashes with known steps to repro require 4 product data keys to fit all steps. Users will likely do unnecessary steps between required steps, so using 2 extra keys should allow to accommodate for all steps. Bug: 1046223 Change-Id: Ia6b97453822a2ab7e6b80cc11488f9f0f91fc949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089720 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748911}
-
llin@chromium.org authored
This CL also moved click tracking into QuickAnswersClient to reduce code duplication and make all logging handled by QuickAnswersClient. Bug: 1060265 Test: manual test Change-Id: Ia3ae5d0101a8096aa745c7a797be504bc4093025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096927 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748910}
-
Natalie Chouinard authored
Move Site Settings to org.chromium.chrome.browser.site_settings package and update OWNERS. Bug: 1047357 Change-Id: Id0a9cc5189ec2e9a6eb17dac2aed9bc581cb6568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087978Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748909}
-
George Burgess IV authored
We get warnings if floating-point values are multiplied by enums. The warnings go away if we use a `constexpr int` here instead, which should be equivalent given `kTickMultiplier`'s current uses. Bug: 1058218 Change-Id: I5fef7bfc74a9572020e71b62c667d21123135b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096096Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#748908}
-
Alexis Hetu authored
SwiftShader's Vulkan library will soon switch from using LLVM as its backend to Subzero. When using Subzero small off by one errors may happen, so a few off by one comparators were added in both cases where this was happening. Bug: 1060139 Change-Id: Ib3b793f860cb7d76ef8fd1846757e7ae1e483f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097178Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Alexis Hetu <sugoi@google.com> Cr-Commit-Position: refs/heads/master@{#748907}
-
Navid Zolghadr authored
As pointerlock wpt tests are now all fully automated with testdriver APIs there is no need for internal automation whitelisting of pointerlock folder. Change-Id: Id06b0e49a99c95a7c3d1ffe4f8cee44362159d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097118Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748906}
-
Felicia Lim authored
Applies patch from https://gitlab.xiph.org/xiph/opus/-/commit/923bebde Bug: 1052051 Change-Id: I3130b04d86cbdf33a8a3a3244daa5304b1ad77b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095456Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748905}
-
John Lee authored
This CL adds a tracker that observes a tab's WebContents after it has been swiped to close on the front-end. The tracker's observer listens for close events (which will naturally remove the TabElement from the DOM) or for when a user cancels out of a beforeunload dialog (which will reset the swipe animation). Bug: 1059080 Change-Id: Id21355fc8d1b8f1001a10106c801fd514cf35ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088410 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748904}
-
Dan Harrington authored
Instead of using FeedSchedulerHost directly, this CL starts importing its capabilities into FeedStream. - Added RefreshTaskScheduler interface for scheduling the background task. - Added AllRefreshThrottler to wrap use of RefreshThrottler - FeedStream handles various events, and reacts by attempting to do a refresh. Actual refresh code is TBD. Injection of these events will happen externally. - scheduling.cc implements some scheduling logic/constants. - Added a FeedStream::EventObserver interface to simplify testing and push metric logging code out of FeedStream. Unit tests in this CL are admittedly minimal, and should be improved. I'm thinking it makes sense to wait until we have code that actually does a refresh. Things FeedSchedulerHost does not included here: - Reconciling host state vs feed library state (we don't need this) - Lots of UMA (we'll replicate some of this) - Resetting the scheduled fetch on fetch success (todo) Bug: 1044139 Change-Id: I8fbecfad67ff1639b419fe65962f4887ec2ea305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031721 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#748903}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f8ceb227ac3a..8aa9d62e8ecc git log f8ceb227ac3a..8aa9d62e8ecc --date=short --first-parent --format='%ad %ae %s' 2020-03-10 tandrii@google.com git cl: better detection of messages from CQ. Created with: gclient setdep -r src/third_party/depot_tools@8aa9d62e8ecc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:911811 Tbr: agable@chromium.org Change-Id: I8779a0fa84e99d4703943362b5861bcc007ab28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094738Reviewed-by:
-
Meredith Lane authored
Uses aria-valuetext to set the label for the slider to reflect the data list pixel value, rather than slider position. Works when the slider initially receives focus, and when the slider position is moved. Bug: 1041918 Change-Id: Id2276c1a8bff0dea54d767d9c067d8119fb5a5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087197Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#748901}
-
Lijin Shen authored
This CL excludes actions that are provided by other browsers and system launchers, because it is reported as a really odd experience. Bug: 850195 Change-Id: I70bc4482a03eb57e28ac46da6130b575ff532cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082995Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch rebaselines paint/invalidation failures that are caused when empty |LayoutBlowFlow| becomes non-empty, or vice-versa. This is |NGPaintFragment|-specific behavior. When |LayoutBlockFlow| got or lost |NGPaintFragment|, its |DisplayItemClient| changes between |LayoutBlockFlow| and corresponding |NGPaintFragment|. |FragmentItem| does not have this behavior; i.e., uses |LayoutBlockFlow| as |DisplayItemClient|, and that the invalidation results are more similar to legacy. TBR=wangxianzhu@chromium.org, yosin@chromium.org Bug: 982194 Change-Id: Id433962da7a32e51ca6046135ccc3e300b3cb7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096796Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748899}
-
David Van Cleve authored
As part of expanding the Trust Tokens code in the network service from NetworkContext to URLLoader and URLLoaderFactory, this change adds a build flag that indicates when Trust Tokens is supported. This makes it easier to conditionally build some lightweight Trust Tokens code even when the Trust Token API itself is unavailable (because the build is for iOS, say). Bug: 1042962 Change-Id: Ic7eb9a710ebf25c26326aa9b0e24ce4c7fd73511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090508 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
-
Ramin Halavati authored
ukm.xml is updated to add GoogleDocsOfflineExtension metrics to UKMs dashboard. Bug: 588766 Change-Id: I46f09d9ab3e68304610a0f4567b0c3329258f4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094984Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#748897}
-
Manu Cornet authored
Bug: 1009638 Change-Id: I6c712d615a113686e137c240bf5435bd20828869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096565Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#748896}
-
Peter Kasting authored
This involves * Moving non-MD-related code out of Initialize into LinearAnimation * Moving other Initialize() code into the constructor * Removing all Initialize() calls * Replacing other static methods with instance methods * Adding GetInstance() calls to callers to get the instance * Converting the TestAPI class to a scoping object * Other assorted #include removal etc. in the process Bug: 940773 Change-Id: Ieb8d44eabae63b014a90ff452010eb4c067e5e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090877 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748895}
-
Luke Zielinski authored
This splits up generation of metadata filenames and generation of "inline test names" that go inside the metadata files. This improves readability and code isolation so that fixing a bug on the filename side doesn't break the inline testname side. Bug: 937369 Change-Id: I80665a551db216de391abe2fdf736202e2b466c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095726 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#748894}
-
George Burgess IV authored
This constant is sometimes implicitly converted to a floating-point number, which clang complains about, since such conversions are often bugs. Using a `constexpr int` should be equivalent. Bug: 1058218 Change-Id: Ic6cafe54b97053b841caaa094a400727eb4cebb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096097Reviewed-by:
-
Takumi Fujimoto authored
Record the results of CreateRoute(), JoinRoute(), and TerminateRoute() calls to the native Cast and DIAL MRPs in new histograms separate from the one for the extension MRPs. Bug: 1044259 Change-Id: Id4dd5faa26601523f43053b8ebb140f26b93d2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078976 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This removes BookmarkPermanentNode::set_visible(), which was misnamed in the sense that it didn't directly determine what BookmarkNode::IsVisible() returns, but instead the returned value for the case where the node has no children. As it turns out, none of the callers need to change this attribute (i.e. the visibility when empty) dynamically. For the managed node, it needs to always be false, and the remaining permanent nodes take this value from BookmarkClient upon construction. BookmarkClient gets a minor refactoring to adopt more accurate names and to allow evaluating the visibility of permanent nodes prior to their construction. Change-Id: I4435140e80216800ce1dcee5604e8370bcc2cedc Bug: 1060311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095125 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Gary Kacmarcik authored
The Mac doesn't always support full desktop capture (e.g., it is not support unless the DPIs of all displays match). This check is not necessary on other platforms. Change-Id: I444732f153b706bb1615b8c3cd1798b15cc66540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096095 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#748890}
-
Thomas Lukaszewicz authored
Pushed color calculation logic in GetTabBackgroundColor() down into ThemeHelper. Bug: 1056916 Change-Id: I6c6b5a204554b825887b1c306b766e4403609279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092199 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748889}
-
Tom Anderson authored
This removes the dependency of //c/b/u/gtk on //c/b/u. This will allow us to move //c/b/u/gtk out of //c/b to a better home like //ui/gtk once the //content dependency is removed in a separate CL. This also removes some select file dialog tests which had all of their tests disabled and never added any value. R=sky BUG=None Change-Id: I38403a967593c76ea55c14315a63a8190e5cae33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093015Reviewed-by:
-
Allen Bauer authored
TBR=jamescook@chromium.og Bug: 1044687 Change-Id: Ib31fbf481e215eb6eb7a7af43369a343e322faf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095566 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This is a reland of 2eb368c0 Changed to not allow long paths for the root of the tree being rmtree'd, so it works on Windows 7. Original change's description: > Implement FileSystem.rmtree for long paths on Windows > > Changes blinkpy filesystem tests to use remove_contents instead of > rmtree. remove_contents calls into rmtree, but > (1) retries several times to delete the files, and > (2) throws by default instead of silently swallowing errors. > This improves all of the tests. Additionally, the retrying was > actually necessary to pass many tests (files were otherwise still > locked during teardown). > > Extends the test_long_paths test to check spaces and apostrophes. > > FileSystem.rmtree is now implemented on Windows by just calling > a shell with "rmdir /s /q". This is necessary, because > shutil.rmtree doesn't work for \\?\C:\ style "extended-length" paths > on Windows, and several other implementations I tried didn't work: > - Loop using os.walk. os.walk doesn't support long paths, and > though it seemed to work on the bots, it failed tests locally. > - Recursive using os.listdir. os.listdir also doesn't support long > paths. > > Tested on dawn-win10-* try job on crrev.com/c/2050036/17. > Found in dawn-win10-* try jobs on crrev.com/c/2050036/4. > > Change-Id: I7c67bb12305a41244829e35293edfc88901b76f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058065 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742961} Bug: 1054331 Change-Id: Ib1f7a7ac0109fb77e1d26f1bdb292ad2c95cea24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092946 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
-
