GitLab

It is unused, and was never updated to Harmony/MD style.

Bug: 822074
Change-Id: Ic12e4dc5ffa9f271e940090f6954a4a16f7dde84
Reviewed-on: https://chromium-review.googlesource.com/c/1298095
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603009}

Add a new experiment group which is used for finch on stable release.

Bug: 838725
Change-Id: Ib4e140270e4a1aa70cc676aaae3c8eea8ab8abfc
Reviewed-on: https://chromium-review.googlesource.com/c/1300533
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603008}

This reverts commit 0275d360.

Reason for revert: 
Suspect compile failure on Android(x64) Builder Dbg.

Example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/30291

Log:
../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:114: error: cannot find symbol
        Toast.makeText(ContextUtils.getApplicationContext(), R.string.vr_module_install_start_text,
                                                                     ^
  symbol:   variable vr_module_install_start_text
  location: class string
../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:127: error: cannot find symbol
            int mToastTextRes = success ? R.string.vr_module_install_success_text
                                                  ^
  symbol:   variable vr_module_install_success_text
  location: class string
../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:128: error: cannot find symbol
                                        : R.string.vr_module_install_failure_text;
                                                  ^
  symbol:   variable vr_module_install_failure_text
  location: class string
3 errors


Original change's description:
> [vr] On-demand install VR dynamic feature module
> 
> With this CL we initate the module install once the user enters VR on a
> WebXR/VR page. In more detail this CL
> 
> - Introduces native VrModuleDelegate used to request VR module from
>   native,
> 
> - Refactors GvrDevice to request the VR module as part of its
>   initialization flow,
> 
> - Adds native side of the VrModuleProvider for Java-native
>   communication.
> 
> Bug: 862689
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b
> Reviewed-on: https://chromium-review.googlesource.com/c/1241458
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602922}

TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org

Change-Id: I19d05dd6f13e5d6eee5ea0ac2f168a3a4d1a3680
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862689
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1301194Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#603007}

Bug: 841886
Bug: b/115291749
Test: ash_unittests
Change-Id: Ibfd54d17fa035d432fbb0570ab5eee922b1a8856
Reviewed-on: https://chromium-review.googlesource.com/c/1300819Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603006}

Absolute paths in zip files are invalid, as per the APPNOTE:

4.4.17 file name: (Variable)
       4.4.17.1 The name of the file, with optional relative path.
       The path stored MUST not contain a drive or
       device letter, or a leading slash.  All slashes
       MUST be forward slashes '/' as opposed to
       backwards slashes '\' for compatibility with Amiga
       and UNIX file systems etc.  If input came from standard
       input, there is no file name field.

However, zip files in the wild and ones generated by some services do
have them, so they should be handled in a reasonable manner, as other
platform (including Google Drive) do. Stripping the leading slash and
treating the path as relative seems reasonable. This won't work if there
are two files with the same path, but one being relative and the other
absolute. But in this case, the archive was already invalid, so any
attempt to handle it is best effort.

BUG=646850

Change-Id: I7681e888bb78d7f4f53c7bd3a5ab318bffb8c527
Reviewed-on: https://chromium-review.googlesource.com/c/1301094Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603005}

We currently have COMPUTERS_GRAND_ROOT as a sharable volume, but
once you drill into a specific Drive Computer, the volume is COMPUTER.

Bug: 878324
Change-Id: I25a4bf377200b37c9e5914ad558a3596484f4915
Reviewed-on: https://chromium-review.googlesource.com/c/1300354Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603004}

This CL passes the status of sliding on OnSlideChanged handler so that
the handler in ArcNotificationContentView can hide the copied surface
at the timing of the sliding finished.

Bug: 897653
Test: manual
Change-Id: I8e76d54f59105b6101b1d2dfc10eb171272be611
Reviewed-on: https://chromium-review.googlesource.com/c/1295632
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603003}

This puts the Canvas, Youtube TV and Showtime apps in the desired order
in the app launcher.

Bug: 882945, 882948, 893481
Change-Id: Ie023e86cd557407f26f26cad905ed683586651a4
Reviewed-on: https://chromium-review.googlesource.com/c/1298096Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603002}

This is reland of crrev.com/c/1295633 with some fix.

When ARC++ app builds bundled notifications, multiple individual
notifications are sent and then replaced with a single bundled
notification. The indicator icon showed such update as-is, resulting
in flashing. This change limits the frequency to reflect notification
count updates for avoiding such effect.

Bug: 892021
Change-Id: If7dbfdfdc530d3498f271f9b7b15b2d02b6b216d
Reviewed-on: https://chromium-review.googlesource.com/c/1298829Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603001}

Bug: 878324
Change-Id: I2eaec453ff0555b6a77c8dd650a705f8be2d89bd
Reviewed-on: https://chromium-review.googlesource.com/c/1300818Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603000}

To improve security of web downloaded text presented on the dino page
this change makes so that it is base64 encoded before being converted
into a JSON structure. It is later decoded by Javascript before being
inserted into the page.

Bug: 852872
Change-Id: Idb31c53b204762bcf99ad56bbc7bf79e8d500bcc
Reviewed-on: https://chromium-review.googlesource.com/c/1299780
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#602999}

"Extensible" annotation has no effect for structs [1] and this CL
removes them in notifications.mojom.

[1] https://chromium.googlesource.com/chromium/src/+/master/mojo/public/tools/bindings/README.md#attributes

Bug: none
Test: none

Change-Id: Ie296e48b91c28d750bf5a1f6d18f1a696c8bc0a2
Reviewed-on: https://chromium-review.googlesource.com/c/1296569Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602998}

Simplified gesture-nav has been the default mode for overscroll history
navigation since M66. We can now safely remove parallax mode. This CL
removes the option from the flag and since the flag is now a simple
enable/disable flag, changes it to a feature. Follow-up CLs will remove
the code supporting the deprecated UI.

BUG=890390

Change-Id: I92ab3c1da1033853fb12be2a40e4fb4b372e0952
Reviewed-on: https://chromium-review.googlesource.com/c/1272255Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602997}

BUG=889097
TEST=single_process_mash_interactive_ui_tests
R=sky@chromium.org

Change-Id: If6bc4ffa7c3e97cadf7eb1ce1bdfc371a034e322
Reviewed-on: https://chromium-review.googlesource.com/c/1300757Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602996}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: Iea2cb88110172516b86e627f2324cf90944ed745
Reviewed-on: https://chromium-review.googlesource.com/c/1299373Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#602995}

This function isn't being called by any other code, its user was removed
in crrev.com/c/1203596

Change-Id: I78e75f7720bfcabea3cf4047c4fb5fab612ccaaa
Reviewed-on: https://chromium-review.googlesource.com/c/1301033Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602994}

https://skia.googlesource.com/skia.git/+log/f5eaee917bb7..3f5b4ee4adfd


git log f5eaee917bb7..3f5b4ee4adfd --date=short --no-merges --format='%ad %ae %s'
2018-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5978150ed763..4c84379fd3cb (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@3f5b4ee4adfd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I687249c70275f1a08defedb037af01f47157f8df
Reviewed-on: https://chromium-review.googlesource.com/c/1300634Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602993}

This reverts commit a0b9be91.

Reason for revert: Broke linux-chromeos-dbg

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8515

Original change's description:
> arc: Add wake lock based logic to re-suspend after dark resume
> 
> This change adds functionality to support lock screen notifications for
> Android. The wake lock module now listens to dark resume notifications
> from the power manager. It -
> 
> 1. Starts a timer to check for partial wake locks acquired by Android.
> 
> 2. After the timer in 1 expires, if no partial wake lock is acquired the
> power manager is requested to re-suspend the system. If a partial wake
> lock is acquired, then another hard timeout timer is set and also an
> observer to wake lock release is set.
> 
> 3. If wake lock is released, the system is re-suspended immediately.
> 
> 4. If a wake lock is still acquired but the hard timeout expires then
> the system is re-suspended immediately.
> 
> 5. If the system transitions to a full resume all dark resume related
> state and timers are cleared.
> 
> BUG=chromium:898297
> TEST=Unit tests and end to end test with Android applications.
> 
> Change-Id: I6dbae0c5f63af67637032b62d0c56cae27d08bad
> Reviewed-on: https://chromium-review.googlesource.com/c/1297474
> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602980}

TBR=derat@chromium.org,yusukes@chromium.org,abhishekbh@chromium.org,ravisadineni@chromium.org

Change-Id: If613721a75cf2341b12310622649dfb17da1308f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:898297
Reviewed-on: https://chromium-review.googlesource.com/c/1301074Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602992}

This reverts commit 0b107635.

Reason for revert: 
Suspect Linux ChromiumOS MSan Tests failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9258

One of error logs:
[ RUN      ] LockStateControllerTest.LockButtonBasicGuest
==6821==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000005c58 at pc 0x000007937b9c bp 0x7ffdd8818530 sp 0x7ffdd8818528
READ of size 8 at 0x616000005c58 thread T0
    #0 0x7937b9b in begin buildtools/third_party/libc++/trunk/include/vector:1506:30
    #1 0x7937b9b in base::ObserverList<ash::TabletModeObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(ash::TabletModeObserver const*) base/observer_list.h:282
    #2 0x73376c6 in RemoveAll base/scoped_observer.h:45:20
    #3 0x73376c6 in ScopedObserver<ash::TabletModeController, ash::TabletModeObserver>::~ScopedObserver() base/scoped_observer.h:26
    #4 0x7889542 in ~WallpaperView ash/wallpaper/wallpaper_view.cc:150:1
    #5 0x7889542 in ash::WallpaperView::~WallpaperView() ash/wallpaper/wallpaper_view.cc:148
    #6 0x9a96a66 in views::View::~View() ui/views/view.cc:162:9
    #7 0x788c19d in ash::(anonymous namespace)::LayerControlView::~LayerControlView() ash/wallpaper/wallpaper_view.cc:43:7
    #8 0x9a9b800 in operator() buildtools/third_party/libc++/trunk/include/memory:2325:5
    #9 0x9a9b800 in reset buildtools/third_party/libc++/trunk/include/memory:2638
    #10 0x9a9b800 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2592
    #11 0x9a9b800 in views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) ui/views/view.cc:2053
    #12 0x9a9d418 in views::View::RemoveAllChildViews(bool) ui/views/view.cc:300:5
    #13 0x9ac9585 in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:183:5
    #14 0x9ac973d in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:179:23
    #15 0x9ad351b in operator() buildtools/third_party/libc++/trunk/include/memory:2325:5
    #16 0x9ad351b in reset buildtools/third_party/libc++/trunk/include/memory:2638
    #17 0x9ad351b in DestroyRootView ui/views/widget/widget.cc:1456
    #18 0x9ad351b in views::Widget::~Widget() ui/views/widget/widget.cc:187
    #19 0x9ad455d in views::Widget::~Widget() ui/views/widget/widget.cc:186:19
    #20 0x9b2bb12 in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc
    #21 0x9b2bdad in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc:1034:39
    #22 0x95945c5 in aura::Window::~Window() ui/aura/window.cc:139:16
    #23 0x95960ad in aura::Window::~Window() ui/aura/window.cc:94:19

Original change's description:
> Makes wallpaper dim in tablet mode, without relying on app_list_shield
> 
> Bug: 898712
> Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/1298507
> Reviewed-by: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Kevin Strohbehn <ginko@google.com>
> Cr-Commit-Position: refs/heads/master@{#602938}

TBR=xiyuan@chromium.org,weidongg@chromium.org,ginko@google.com

Change-Id: I86dbf4da685e23e5106ac7a778e665729581e0ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898712
Reviewed-on: https://chromium-review.googlesource.com/c/1301035Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#602991}

The container was given focus so that after the menu (dialog) closed,
the settings would regain focus and to allow arrow keys to update the
scroll position. This introduced the regression that pressing tab
moves focus to the first control (as well as https://crbug.com/708960
and https://crbug.com/709359 which are fixed in subsequent CLs).
This CL adds a condition that if a section was selected, it will gain
focus, otherwise the container gains focus, as was the preexisting fix
for https://crbug.com/707106 and related changes that closely followed.

Bug: 870732
Change-Id: Ic0ae5b44f2778a56999297018427a9fda9f19eb1
Reviewed-on: https://chromium-review.googlesource.com/c/1284064
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602990}

Command used:
$ lebab --replace \
    ui/file_manager/file_manager/foreground/js/ui/directory_tree.js \
    --transform let

Lebab: https://github.com/lebab/lebab

No change in behaviour.

Bug: 778674
Change-Id: I4693f3da54d904bbb9e115bc5f413f67d867707a
Reviewed-on: https://chromium-review.googlesource.com/c/1298817
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602989}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

Bug: 889726
Change-Id: Ia10dabc21bedb31e05f4132f654305a6f9dac704
Reviewed-on: https://chromium-review.googlesource.com/c/1299164Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602988}

While working on crrev.com/c/1294870 I cleaned up a bit the style
around the files below:
- no {} for one liners
- if (a) then return foo; return bar ==> return a ? foo : bar;

All in all: less lines, more consistent style.  No new functionality
intended.

Bug: 865957
Change-Id: Iac7f26be9a9a2323b09f80d29a5f7ec9f4370278
Reviewed-on: https://chromium-review.googlesource.com/c/1300037Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602987}

https://pdfium.googlesource.com/pdfium.git/+log/84a534d9473a..6fe32f898af3


git log 84a534d9473a..6fe32f898af3 --date=short --no-merges --format='%ad %ae %s'
2018-10-25 tsepez@chromium.org Make CPWL_Wnd own its pAttachedData.
2018-10-25 thestig@chromium.org Simplify some code in CGdiDisplayDriver.
2018-10-25 thestig@chromium.org Pass source rect parameter to SetDIBits() by const-ref.


Created with:
  gclient setdep -r src/third_party/pdfium@6fe32f898af3

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibda5ce70d63b74732580a92b231fd177c8f4ac47
Reviewed-on: https://chromium-review.googlesource.com/c/1300573Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602986}

Apparently our times saturate the default bucketing and we want wider.

BUG=None

Change-Id: I03d5c0ef99107c4025e5d8a67e4d2e85133dcb3b
Reviewed-on: https://chromium-review.googlesource.com/c/1300355
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602985}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I9c08b600abeae79d3593b09dd08a2db9f1069c95
Reviewed-on: https://chromium-review.googlesource.com/c/1300779Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602984}

https://webrtc.googlesource.com/src.git/+log/8c27ccac7597..5abd54166ae7


git log 8c27ccac7597..5abd54166ae7 --date=short --no-merges --format='%ad %ae %s'
2018-10-25 yujo@chromium.org Stop exporting simulcast_encoder_adapter.h in :rtc_internal_video_codecs
2018-10-25 benwright@webrtc.org Refactor: Removing IgnoreBadCert from SSLStreamAdapter. Make test methods more explicit.
2018-10-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d68fb50e..f54583b6 (602627:602763)


Created with:
  gclient setdep -r src/third_party/webrtc@5abd54166ae7

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic3c2ba3694fc76401ea28e90111e481659f23853
Reviewed-on: https://chromium-review.googlesource.com/c/1300417Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602983}

Added a TabObserver handling fullscreen-related tasks. This moves factors
out the methods out of Tab and defines its own observer class.

Change-Id: Iad47a6f1818b0e8b7564aa431aadff753400015f
Reviewed-on: https://chromium-review.googlesource.com/c/1276005
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602982}

https://skia.googlesource.com/skia.git/+log/5281f369f4f0..f5eaee917bb7


git log 5281f369f4f0..f5eaee917bb7 --date=short --no-merges --format='%ad %ae %s'
2018-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 683bb0130ca2..e9503ae90a9d (5 commits)


Created with:
  gclient setdep -r src/third_party/skia@f5eaee917bb7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I70c11b056b2a6aaf7ffc1fb92a7b5743e8598426
Reviewed-on: https://chromium-review.googlesource.com/c/1300576Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602981}

This change adds functionality to support lock screen notifications for
Android. The wake lock module now listens to dark resume notifications
from the power manager. It -

1. Starts a timer to check for partial wake locks acquired by Android.

2. After the timer in 1 expires, if no partial wake lock is acquired the
power manager is requested to re-suspend the system. If a partial wake
lock is acquired, then another hard timeout timer is set and also an
observer to wake lock release is set.

3. If wake lock is released, the system is re-suspended immediately.

4. If a wake lock is still acquired but the hard timeout expires then
the system is re-suspended immediately.

5. If the system transitions to a full resume all dark resume related
state and timers are cleared.

BUG=chromium:898297
TEST=Unit tests and end to end test with Android applications.

Change-Id: I6dbae0c5f63af67637032b62d0c56cae27d08bad
Reviewed-on: https://chromium-review.googlesource.com/c/1297474
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602980}

Add feature flag MyFilesVolume that when it's enabled the MyFiles folder
will be an actual volume and Downloads will be just a plain folder
inside it.

Change GetDownloadsFolderForProfile to return
<cryptohome>/MyFiles/Downloads when the flag is active.

Add a new function GetMyFilesFolderForProfile which returns the correct
folder to be used as volume root, when the flag is disable it returns
the current value, by calling GetDownloadsFolderForProfile, which
returns <cryptohome>/Downloads. When the flag is active it returns
<cryptohome>/MyFiles.

Change GetPathDisplayTextForSettings to recognize the
<cryptohome>/MyFiles/Downloads pattern, for now it will return just
Downloads.

This is an initial work, follow up CLs wil change the rest of code base
to use either GetDownloadsFolderForProfile (when the code wants the
actual downloads folder) or GetMyFilesFolderForProfile when the code
wants the volume root, previously these 2 situations were the same path;
when the new flag is enabled they're different and depending on the use
case we might have to change to GetMyFilesFolderForProfile.

Bug: 873539

Change-Id: I7d01bc5370072ba574a6761d4a54d43d4b62ff6e
Reviewed-on: https://chromium-review.googlesource.com/c/1298824
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602979}

Implement SharedImageRepresentationGLTexture interface
for SharedImageBackingAHardwareBuffer.

Bug: 891060
Change-Id: I36429244c3643655124052392f983ee4713f60bb
Reviewed-on: https://chromium-review.googlesource.com/c/1294513
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602978}

In all builds I've looked at recently, these suppressions were mentioned
as unused. Let's remove them to see if they're still needed.

Bug: 429358
Change-Id: I3dcdebb0fca0a34374d00962a906d879564d963e
Reviewed-on: https://chromium-review.googlesource.com/c/1300493Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602977}

To use, specify only the specific version in the expectation (like
'm', 'n', etc.) instead of 'android'.

Tested manually.

Bug: 865957
Change-Id: I62f036ade714ec79f773c603fac73314c9da0f30
Reviewed-on: https://chromium-review.googlesource.com/c/1299738
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602976}

This reverts commit 8380640d.

> > fuchsia: Avoid unnecessary references to WindowEventFilter
> >
> > The link error I'm trying to avoid is this:
> >
> > [122->5/127 ~1] SOLINK ./libviews.so
> > FAILED: libviews.so libviews.so.TOC lib.unstripped/libviews.so
> > python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libviews.so" --tocfile="./libviews.so.TOC" --output="./libviews.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,-z,max-page-size=4096 -Wl,--icf=all -Wl,--color-diagnostics --target=aarch64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/arm64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/arm64/lib -o "./lib.unstripped/libviews.so" -Wl,-soname="libviews.so" @"./libviews.so.rsp"
> > ld.lld: error: undefined symbol: views::WindowEventFilter::WindowEventFilter(views::DesktopWindowTreeHost*)
> > >>> referenced by memory:3118 (../../buildtools/third_party/libc++/trunk/include/memory:3118)
> > >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> >
> > ld.lld: error: undefined symbol: views::WindowEventFilter::SetWmMoveResizeHandler(ui::WmMoveResizeHandler*)
> > >>> referenced by desktop_window_tree_host_platform.cc:106 (../../ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc:106)
> > >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> > clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
> >
> > I'm not sure what the correct approach is; DesktopWindowTreeHostPlatform
> > depends on WindowEventFilter which uses LinuxUI.
> >
> > Since there's no available non-client area on Fuchsia currently, not
> > doing this seems correct for the time being. Or does Fuchsia really need
> > its own DesktopWindowTreeHostFuchsia implementation?
> >
> > Bug: 808287
> > Change-Id: I2af683415ea00147607eb4236540d8d3e8643603
> > Reviewed-on: https://chromium-review.googlesource.com/c/1298554
> > Commit-Queue: Scott Graham <scottmg@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602860}
>
> TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org
>
> Change-Id: I00a7631118f58db9413c391416079c4f94a974ae
> Bug: 808287
> Reviewed-on: https://chromium-review.googlesource.com/c/1300101
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602887}

TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org

Change-Id: I3302a0dec267ebec369d53ec8906c1c31cd12ba0
Bug: 808287
Reviewed-on: https://chromium-review.googlesource.com/c/1300110
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602975}

This CL does the following:
- optimize png
- some styling + string updates to match mocks
- fix an edge bug with which if the user reaches NTP and presses the back
  button, the page briefly flashes an invalid step and go back to NTP again.

Bug: 874151
Change-Id: If4ff1b0d9d3bf9ae50e23172a1cee270efdab880
Reviewed-on: https://chromium-review.googlesource.com/c/1295183
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602974}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: Idbe50cad950947ba8633758dbf7070d2288fa6d0
Reviewed-on: https://chromium-review.googlesource.com/c/1298946Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#602973}

This reverts commit 77cbc4f0.

Reason for revert:
Suspect compile failure on linux-chromeos-dbg.

Example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8511

Log:
FAILED: ash_unittests 
../../buildtools/third_party/libc++/trunk/include/memory:5091: error: undefined reference to 'ash::StartAnimationObserver::StartAnimationObserver()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Original change's description:
> overview: Introduce OnOverviewStartAnimationComplete observer.
> 
> Introdue a new overview observer which notifies observers when the start
> animation for overview is different.
> 
> Uses will be both in and out of overview - for example adding mask, shadow
> and animating tray, shelf.
> 
> Also modify CleanupObserverTest to use some new stuff.
> 
> Test: ash_unittests StartAnimationObserverTest.Basic
> Bug: 898222
> Change-Id: I86bdd253f0a4a4dd81ad6ba03780baf07923d256
> Reviewed-on: https://chromium-review.googlesource.com/c/1297405
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602941}

TBR=oshima@chromium.org,sammiequon@chromium.org

Change-Id: I5038dbe64ae02fb0f71a7c4ffcc36bcfaaca13ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898222
Reviewed-on: https://chromium-review.googlesource.com/c/1300815Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#602972}

Bug: 889222
Change-Id: I5af4c643bd14e3e52b37a931eb04b7d3c533c6f1
Reviewed-on: https://chromium-review.googlesource.com/c/1287437
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602971}

On Android, Chrome is responsible for handling external protocols and
determining if an external activity should be launched. When an
installed WebAPK opens a Chrome Custom Tab for an out of scope link, the
external protocol handling code was not being triggered for links like
mailto: and tel:, resulting in a broken CCT launch to the mailto: link
containing a blank page. This issue was caused by two reasons:

1. The navigation type for the Custom Tab intent was set to
   PageTransition.FROM_API, indicating it came from an external intent.
   This would trigger a code path that explicitly avoided launching an
   external program.
2. Once (1) was addressed, the lack of a user gesture on the resulting
   navigation created by the intent also blocked external program
   launch.

This CL fixes both issues by introducing a new Custom Tab extra indicating
whether a Custom Tab intent came from a WebAPK. When this extra is
present, we do not set the FROM_API transition type, and we add a user
gesture on the resulting new tab navigation. This essentially passes on
the user gesture that must have been present to create the new tab in
the first place, mimicking the behaviour that should be present when
not in a standalone window.

BUG=792990

Change-Id: Ifad590228b10fa7a09c1c34611124957ba857ac1
Reviewed-on: https://chromium-review.googlesource.com/c/1270204Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602970}