GitLab

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2892323002
Cr-Commit-Position: refs/heads/master@{#473416}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/917b0589..8fa0a956

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2894103003
Cr-Commit-Position: refs/heads/master@{#473415}

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636

Review-Url: https://codereview.chromium.org/2893833005
Cr-Commit-Position: refs/heads/master@{#473414}

Removed Omnibox.ProgressBarUpdateCount and
Omnibox.ProgressBarBreakPointUpdateCount
since collected data is not used anymore

BUG=719801
R=mdjones@chromium.org

Review-Url: https://codereview.chromium.org/2885013004
Cr-Commit-Position: refs/heads/master@{#473413}

https://skia.googlesource.com/skia.git/+log/a40d9c89b766..2f687877835b

$ git log a40d9c89b..2f6878778 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 msarett SkWebpEncoder: use bgra for lossless and yuv for lossy
2017-05-19 egdaniel Update Porter Duff analysis to match LCD logic.
2017-05-19 stephana Remove debug flag for ios bots

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Icbcae09596f9e84c5452336548f9c381982fd436
Reviewed-on: https://chromium-review.googlesource.com/509941Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473412}

Rename DocumentMarkerController::RenderedRectsForMarkers() to
RenderedRectsForTextMatchMarkers() and remove the marker_type param.
After https://codereview.chromium.org/2883503004, we only create
RenderedDocumentMarkers for TextMatch markers, and the type param is
no longer needed.

BUG=707867

Review-Url: https://codereview.chromium.org/2886893008
Cr-Commit-Position: refs/heads/master@{#473411}

https://pdfium.googlesource.com/pdfium.git/+log/92c13a7d495c..d15ce4c1e088

$ git log 92c13a7d4..d15ce4c1e --date=short --no-merges --format='%ad %ae %s'
2017-05-19 tsepez Use observed ptrs from CFGAS_GEFont back to its font mgrs.
2017-05-19 thestig Use std::vector and std::sort() in CPDF_PageRenderCache.
2017-05-19 tsepez Use unowned ptr from CXFA_FFDocView to CXFA_FFDoc
2017-05-19 tsepez Fix off-by-one introduced at ab20404
2017-05-19 thomasanderson Update more references to sanitizers:deps
2017-05-19 tsepez Back-fill some functionality for CFX_UnownedPtr

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I2a79a022380f5a6525660dd84edf9321f7fb8b54
Reviewed-on: https://chromium-review.googlesource.com/509903
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473410}

Replaced Blink.UseCounter.Features by Blink.UseCounter.Extensions.Features when
URL protocol is chrome-extension://

BUG=687169

Review-Url: https://codereview.chromium.org/2796283005
Cr-Commit-Position: refs/heads/master@{#473409}

Revert of Use Stub CDM for building libwidevinecdmadapter.so (patchset #4 id:100001 of https://codereview.chromium.org/2792743002/ )

Reason for revert:
Using stub cdm is a workaround and it breaks the load_library_perf_test.
This change reverts the stub cdm because the unaligned ELF header issue
has been fixed for libwidevinecdm.so, so that we can re-enable the
load_library_perf_test.

Original issue's description:
> Use Stub CDM for building libwidevinecdmadapter.so
>
> - This is a temporary fix for unblocking LLD.
> - We use the stub CDM to build the CDM adapter.
> - We ship the copied (real) CDM and the CDM adapter.
> - Even though the CDM adapter is built against the stub cdm at
>   "stub_cdm/libwidevinecdm.so", only the filename is baked
>   into the adapter because of the gn dependency,
>   e.g., readelf -d libwidevinecdmadapter.so :
>   0x0000000000000001 (NEEDED)    Shared library: [libwidevinecdm.so]
> - At run time, when loading the CDM adapter, the system will search
>   for the CDM in the same dir where the adapter is located. Hence
>   the real CDM will be loaded.
>
> BUG=707488
>
> Review-Url: https://codereview.chromium.org/2792743002
> Cr-Commit-Position: refs/heads/master@{#462104}
> Committed: https://chromium.googlesource.com/chromium/src/+/4bd7678fefa459f3f29a4ea511ff26971cfb5648

TBR=xhwang@chromium.org,hmchen@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707488

Review-Url: https://codereview.chromium.org/2893853003
Cr-Commit-Position: refs/heads/master@{#473408}

The unified interface will enable css_agent to set/access many
properties of widget, view and window without the need of knowing the
actual object type. A UIElement tree where each node can be either
view, widget and window will be kept in sync with tree structures of
window, widget and view objects.

BUG=700024

Review-Url: https://codereview.chromium.org/2776543002
Cr-Original-Commit-Position: refs/heads/master@{#473315}
Committed: https://chromium.googlesource.com/chromium/src/+/bdcdb17a4fa7ffea34afed460b776cc2e5032855
Review-Url: https://codereview.chromium.org/2776543002
Cr-Commit-Position: refs/heads/master@{#473407}

Now the horizontal/vertical writing mode code won't go out of sync.

Review-Url: https://codereview.chromium.org/2893653006
Cr-Commit-Position: refs/heads/master@{#473406}

Last time there was a spurious import that broke the build.  So I
quickly restored the build to open the tree (broke Android compile).
This time, Im fairly sure nothing is using inputs.py.  Lets try again.

Unfortunately, the CQ doesnt seem to catch these types of errors or has
some stale .pyc files lying around or something. Unlucky.

R=dpapad@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898563002
Cr-Commit-Position: refs/heads/master@{#473405}

Cr-Commit-Position: refs/heads/master@{#473404}

Currently, the border-image property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that their getters/setters can be generated as well.

Diff: https://gist.github.com/dc683ef590e3d4e88e1ed7f3a54ff16f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2888323002
Cr-Commit-Position: refs/heads/master@{#473403}

This fixes the issue with the value set by ScopedCurrentChannel
potentially being overwritten by the browser process initialization
code.

This could happen when the ScopedCurrentChannel instance was constructed
with the default channel (that is, the STABLE channel) before the browser
initialization code happens, as the latter would then assume that the channel
wasn't set before and overwrite it.

This issue means that it was impossible to set up the STABLE channel in
the browser test in the setup code that runs before the browser initialization,
unless the building environment was configured to be stable.

BUG=none, 626343
TEST=existing tests

Review-Url: https://codereview.chromium.org/2854293003
Cr-Commit-Position: refs/heads/master@{#473402}

After a user clicks "Report Abuse" in the extension uninstall dialog, two
webpages may open -- the CWS Report Abuse page and an extension uninstall page,
if the extension specifies a custom uninstall page via
chrome.runtime.setUninstallURL.

Between these two webpages, the extension uninstall page becomes the in-focus,
active tab. Thus users will likely only fill out this form over the CWS Report
Abuse page.

This CL changes the active tab to become the CWS report abuse page instead of
the extension's uninstall page.

BUG=690050

Review-Url: https://codereview.chromium.org/2860663003
Cr-Commit-Position: refs/heads/master@{#473401}

These DCHECKs check that we're resetting the possibly_has_marker_types_ flag
when markers_ becomes empty. Resetting this flag properly enables a performance
optimization. These DCHECKs are causing sporadic crashes in debug builds; we
believe this is because the markers_ map is holding weak references to its keys
(Node objects), so it's possible for the map to become empty through garbage
collection, which doesn't reset possibly_has_marker_types_.

This CL modifies DocumentMarkerController::PossiblyHasMarkers() to catch this
case. Alternatively, we could handle this case at garbage collection time, but
we believe this approach has better performance characteristics.

BUG=685755

Review-Url: https://codereview.chromium.org/2891843003
Cr-Commit-Position: refs/heads/master@{#473400}

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //storage

BUG=665062

Review-Url: https://codereview.chromium.org/2890143004
Cr-Commit-Position: refs/heads/master@{#473399}

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2899523002
Cr-Commit-Position: refs/heads/master@{#473398}

We need more detailed check which is implemented in
MixedContentChecker::ShouldBlockFetch().
It take time to implement it for workers.
And returning false is a bit scary from the security point of view.

So I want to use MixedContentChecker::IsMixedContent() for a while.

BUG=443374

Review-Url: https://codereview.chromium.org/2895563002
Cr-Commit-Position: refs/heads/master@{#473397}

SitePerProcessBrowserTest.PopupMenuTest is occasionally flaky on
ChromeOS bots, possibly because a Linux-only section was added in
r459476 that relies on browser process hit testing, but the test does
not call WaitForChildFrameSurfaceReady() to prevent races between hit
tests and compositor frames.

This adds a call to attempt to resolve the flakiness, and does some
unrelated cleanup.

BUG=723657

Review-Url: https://codereview.chromium.org/2895653003
Cr-Commit-Position: refs/heads/master@{#473396}

Wake Lock is a Mojo interface that wraps PowerSaveBlocker. As part of the
creation of standalone Device Service, all browser-side clients of
PowerSaveBlocker should be converted to be clients of the Wake Lock Mojo
interface instead.

This CL converts clients of PowerSaveBlocker in //content/browser/webrtc

BUG=689413

Review-Url: https://codereview.chromium.org/2886603003
Cr-Commit-Position: refs/heads/master@{#473395}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/695547

https://chromium.googlesource.com/chromium/src/+/bf85ac4f08f64

BUG=722724
TBR=enne@chromium.org

Review-Url: https://codereview.chromium.org/2896683002 .
Cr-Commit-Position: refs/heads/master@{#473394}

BUG=n/a
TBR=jam@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2893103002
Cr-Commit-Position: refs/heads/master@{#473393}

BUG=internal b/38263595
TEST=cast_base_unittests

Review-Url: https://codereview.chromium.org/2896673002
Cr-Commit-Position: refs/heads/master@{#473392}

There's a non-trivial overhead for the machinery to run posted tasks in
a given run loop mode. Only observe modes known to be run for a particular
thread.

BUG=640466, 724076

Review-Url: https://codereview.chromium.org/2889293002
Cr-Commit-Position: refs/heads/master@{#473391}

This Cl moves the imports of polymer.html to the top of the file so that
polymer.html is imported before other files. This is an exception to the
normal alphabetical order of imports. A blank line is added under this
first import to visually separate it from the rest of the imports, since
it's special.

This ensures that custom elements can be configured according to
polymer_config.js, which has to be loaded before any Polymer code.

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893063002
Cr-Commit-Position: refs/heads/master@{#473390}

With various changes coming to the Google local NTP, it'll be useful to
be able to differentiate it from the non-Google local NTP.

(Also, take over ownership of the histogram from people who don't work
in this area anymore.)

BUG=583292

Review-Url: https://codereview.chromium.org/2897523004
Cr-Commit-Position: refs/heads/master@{#473389}

Specifically, the automatic nature of Hands-Off Enrollment leads to
the DUT performing an update check after reboot which interferes
with autoupdate_EndToEndTest. This CL fixes that issue.
It does so by instructing the UpdateScreen to skip checking for updates
if both of the following conditions hold:
1. The previous update check initiated by the UpdateScreen did not result
in an update.
2. This previous update check occurred during the last hour.

BUG=chromium:710716
TEST=unit test

Review-Url: https://codereview.chromium.org/2894783003
Cr-Commit-Position: refs/heads/master@{#473388}

The usage of BrowserThread::FILE is deprecated in favor of the
post_task.h API.

BUG=689520

Review-Url: https://codereview.chromium.org/2898523002
Cr-Commit-Position: refs/heads/master@{#473387}

https://swiftshader.googlesource.com/SwiftShader.git/+log/9ed48ba..bf7a814

BUG=716803

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2894253003
Cr-Commit-Position: refs/heads/master@{#473386}

The ExtensionsLoadTestWithLoginScreenApps.CommandLineExtensionsDontLoad
test was failing in mash_browsertests. According to some investigation,
it may be due to the problem not with the test itself, but with the test
suite (see https://crbug.com/716727#c6).

Therefore enabling the test, but with blacklisting it from running in
mash_browsertests.

Bug: 716727
Change-Id: I0860b9efbcfd5a333464a2567273a962d0957a5e
Reviewed-on: https://chromium-review.googlesource.com/503351Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473385}

Revert of Add NTPCondensedLayout to test config. (patchset #3 id:40001 of https://codereview.chromium.org/2885023002/ )

Reason for revert:
crbug/724698

May be causing tests failures of NewTabPageTest. Small cl, so just going to revert.

Original issue's description:
> Add NTPCondensedLayout to test config.
>
> BUG=688291
>
> Review-Url: https://codereview.chromium.org/2885023002
> Cr-Commit-Position: refs/heads/master@{#473225}
> Committed: https://chromium.googlesource.com/chromium/src/+/de26ab98dcd8747564fd3e078db2862a53cb7246

TBR=asvitkine@chromium.org,bauerb@chromium.org,mvanouwerkerk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=688291

Review-Url: https://codereview.chromium.org/2898533003
Cr-Commit-Position: refs/heads/master@{#473384}

Some stale .pyc files allowed its removal to go unnoticed on
bots and locally for me, it looks like.

This is a partial revert of r473381.

TBR=thestig@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2900473002 .
Cr-Commit-Position: refs/heads/master@{#473383}

The mir project has been cancelled [1], so Chromium will never need
to support it.

libmirclient has previously interfered with developer builds [2],
leading to a complex hack [3] that placed all global variables in
libprotobuf-lite into their own shared library.

This CL adds a libmirclient.so.9 stub on Linux component builds.
The library will get loaded, but its symbols will never be used by
Chromium directly, or through GDK since only the X11 backend (and
wayland in the future) is whitelisted [4].

[1] https://arstechnica.com/information-technology/2017/04/ubuntu-unity-is-dead-desktop-will-switch-back-to-gnome-next-year/
[2] https://crbug.com/700120
[3] https://codereview.chromium.org/2756543002/
[4] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/gtk_ui.cc?rcl=50612fa00dfc8e79fe5bc92e2f235eee645739e9&l=434

R=pkasting@chromium.org
BUG=700120

Review-Url: https://codereview.chromium.org/2885223002
Cr-Commit-Position: refs/heads/master@{#473382}

R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2887253006
Cr-Commit-Position: refs/heads/master@{#473381}

The scale factor can change even if the image itself doesn't change,
so the variables need to be updated before that early-out.

BUG=654631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2888783002
Cr-Commit-Position: refs/heads/master@{#473380}

There is no point trying to take special actions on browser shutdown
aside from what is necessary to create isolation between test runs. This
change removes the UsbService's Shutdown method and removes the separate
shutdown logic from DeviceClient implementations. Service shutdown now
happens in the destructor. When running in the production browser we may
choose to even leak the USB and HID services on shutdown since the
process is exiting.

Bug: None
Change-Id: Ice9df8c5d78e486dfe4510227c39d2a74e0313c6
Reviewed-on: https://chromium-review.googlesource.com/508151Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473379}

It was already safe to call it off-sequence as of r472835.

But making it thread-safe is key to enabling use cases like:

  RunLoop run_loop_;
  <post a task binding run_loop_.QuitClosure() to task scheduler>
  run_loop_.Run();

e.g. happens in https://codereview.chromium.org/2881143002/ without this CL

Run() and Quit() are racing in this situation as the posted task may run
at any point after being posted. FYI, RunLoop() already supports being Quit()
prior to being Run() so the race resolving either way is fine, it just needs
to be thread-safe.

BUG=722537

Review-Url: https://codereview.chromium.org/2892993002
Cr-Commit-Position: refs/heads/master@{#473378}

Reland of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2893093002/ )

Reason for revert:
downstream breakage fixed by adding another mock target downstream

Original issue's description:
> Revert of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2888283002/ )
>
> Reason for revert:
> broke downstream
>
> Original issue's description:
> > Add a mock vision-common GMS client target
> >
> > Upcoming GMS versions will split the vision client into vision and
> > vision-common. In order to roll downstream, we must add an upstream
> > dependency on vision-common. But upstream is not yet ready to roll, so
> > we add a mock vision-common target to temporarily satisfy the new
> > dependency in upstream builds.
> >
> > BUG=706943
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2888283002
> > Cr-Commit-Position: refs/heads/master@{#473268}
> > Committed: https://chromium.googlesource.com/chromium/src/+/420cf37ad0ddf1c54203a4fdffb68af920503b0e
>
> TBR=agrieve@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=706943
>
> Review-Url: https://codereview.chromium.org/2893093002
> Cr-Commit-Position: refs/heads/master@{#473302}
> Committed: https://chromium.googlesource.com/chromium/src/+/9010e14d8fc816219fe22ca57b63a9d1eefef45b

TBR=agrieve@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706943

Review-Url: https://codereview.chromium.org/2892953003
Cr-Commit-Position: refs/heads/master@{#473377}