- 16 Oct, 2018 40 commits
-
-
Andrew Grieve authored
* Fix exception when not using a wrapper script * Fix stripping "Hidden system packages" (does not always come last) * Fix error message when package does not exist (on newer OS's) * Add a warning when measuring a system apks Change-Id: I0b43993e3b28f723899d236f43365e2d954607bb Reviewed-on: https://chromium-review.googlesource.com/c/1281104Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#599884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4ed4fd40624..a97ee638d858 Created with: gclient setdep -r src-internal@a97ee638d858 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: I807793eef453e86ab3e5076b0bb77360efd1ca98 Reviewed-on: https://chromium-review.googlesource.com/c/1282343Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599883}
-
Dan Sanders authored
Bug: 893739 Change-Id: Icb19a36549d9f877f5b32a5a10b05f1420f812a8 Reviewed-on: https://chromium-review.googlesource.com/c/1279292 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#599882}
-
Nicolas Ouellet-Payeur authored
Adds a function to |MenuDelegate| that can be overloaded to create a footnote View for a top-level menu. The footnote view is rendered at the bottom of the menu, with a different background color, similar to |BubbleFrameView::SetFootnoteView()|. Bug: 889229, 894193 Change-Id: Icb67740fddfe03a7a2d9bae7c70b383cfe6a9845 Reviewed-on: https://chromium-review.googlesource.com/c/1277573Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#599881}
-
Ned Nguyen authored
Reland "[testing/scripts] Add base adapter class that enables more code reuse for all isolated script test" This is a reland of 18e40bdc It also includes the fix to only generate filter file for isolated_script_test if --isolated-script-test-filter flag is passed This will make the behavior of testing/scripts/run_isolated_script_test.py matches with what happened before the refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/1278156 The bug happened because when --isolated-script-test-filter is not passed, TypUnittestAdapter.generate_test_filter_args() isn't called, which means the _temp_filter_file file handle is not closed. Hence attempting to remove the file will cause a crash on Windows platform (removing a file whose file handle opened). In this fix, we create _temp_filter_file within TypUnittestAdapter.generate_test_filter_args() and only clean up the file if it was created. This also fix generate_test_filter_args to generate flags with self._temp_filter_file.name (used to beself._temp_filter_file) TBR=kbr@chromium.org, dpranke@chromium.org, dtrainor@chromium.org Bug: 894261, 895586, 895601 Change-Id: I74255ba2bc7598db9df18cff4bff4407c2a927f8 Reviewed-on: https://chromium-review.googlesource.com/c/1281902 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#599880}
-
David Benjamin authored
Due to non-compliant middleboxes, it is possible we'll need to do some surgery to this mechanism. Fix the double-negative on the base::Feature so it is less confusing and gather more extensive metrics when enforcement is disabled. Also flip the default in trunk to disabled and connect it to about:flags. Finally, add a bunch of machinery to test this stuff. Bug: boringssl:226 Change-Id: Ib910328c9733b47db16b4cb811e8f2cb09b69d0c Reviewed-on: https://chromium-review.googlesource.com/c/1274605Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#599879}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2be20fdd2d70..88afab4ff0f0 git log 2be20fdd2d70..88afab4ff0f0 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 benjhayden@chromium.org Add ReportCacheRequest for v2spa service worker 2018-10-15 pasko@chromium.org event_finder_util: skip renderer events when no mainThread 2018-10-15 chiniforooshan@chromium.org Telemetry: fix a bug in percentage_smooth 2018-10-15 dproy@chromium.org Fix top level scheduler task title Created with: gclient setdep -r src/third_party/catapult@88afab4ff0f0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891797,chromium:895096,chromium:871204,chromium:832651 TBR=sullivan@chromium.org Change-Id: I2a5a1b05066c3c5f10bbec768c0bd430c80e5fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1282342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599878}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be7450b6c635..198b87e5be20 git log be7450b6c635..198b87e5be20 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bbd532d164f0..a1ac3fe80647 (1 commits) 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 egdaniel@google.com Revert "Have GrAtlasManager use legacy behavior" 2018-10-15 herb@google.com Have GrAtlasManager use legacy behavior 2018-10-15 reed@google.com remove noisy gm Created with: gclient setdep -r src/third_party/skia@198b87e5be20 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I7ca32feb9b943f90ba7ee1ad6f9614ddde1417ad Reviewed-on: https://chromium-review.googlesource.com/c/1282324Reviewed-by:
-
Koji Ishii authored
This patch fixes |MarkLineBoxesDirtyFor()| when the object is an atomic inline that is not LayoutNGBlockFlow; e.g., form controls. It fails because |EnclosingNGBlockFlow()| returns itself if the given object is LayoutBox, and if the atomic inline is in legacy, it returns nullptr. This problem keeps occuring, and there are two fixes done independently. To avoid this happening again, this patch also removes |EnclosingNGBlockFlow()| and add |ContainingNGBlockFlow()| instead. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia01a197697b1d4b3da3efde18154e33ece289529 Reviewed-on: https://chromium-review.googlesource.com/c/1278667 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599876}
-
Vladimir Levin authored
This patch updates the trace names to be Run*LifecyclePhase for each lifecycle phase, making it easier to track via telemetry. It also inlines a function called only from one spot. R=schenney@chromium.org, chrishtr@chromium.org Bug: 892861 Change-Id: I4224844532235d89671d79ed0408618b6203ed63 Reviewed-on: https://chromium-review.googlesource.com/c/1272258Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=881371 R=robliao Change-Id: Ic4a06e4e98cf93339ee9038d25ee6cc7b945037b Reviewed-on: https://chromium-review.googlesource.com/c/1277684 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#599874}
-
Mike Wasserman authored
EventObserver has support for Window Service clients. EventObserver prevents changes to events and dispatch. Encapsulate FullscreenControlHost's EventMonitor; destroy with widget. Move Mac's dispatch changes to the one user, MenuPreTargetHandlerMac. Bug: 887725, 799428 Change-Id: I1dcb9f7786885210ea56b0c3c3f7134e21228de1 Reviewed-on: https://chromium-review.googlesource.com/c/1258217 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599873}
-
Wenzhao Zang authored
This is the refactor portion of https://crrev.com/c/1272085. The logic in wizard_controller.cc is very complex. We should try to move the screen specific logic out of it. Bug: NONE Change-Id: Id89479b4b145b2a80333bbbadd1e51472fb8ab49 Reviewed-on: https://chromium-review.googlesource.com/c/1281171 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#599872}
-
Ria Jiang authored
There are non-targeting windows that can still submit CompositorFrame, set a flag when creating HitTestDataProviderDrawQuad to indicate whether that window has TARGET event-targeting policy or not to decide whether we should set Mine (accept events) or Ignore (reject events) flag. This is a speculative fix to bug 877762, with tests to show the expected behavior. Bug: 877762 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6f9971daccffb3065abb984e1166eb266c5a9db2 Reviewed-on: https://chromium-review.googlesource.com/c/1260511 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599871}
-
Khushal authored
Add an UMA metric which reports the accumulated time for a raster task including the time from raster worker thread and the GPU main thread. The GPU side timer takes care of only measuring time slices when the decoder is processing commands. R=vmiura@chromium.org, piman@chromium.org BUG: 894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If02a76420dbdf5ffb5041b8290412d144d787fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1267235 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599870}
-
Robert Sesek authored
This reverts commit b20ba21c. Reason for revert: Added capacity isn't finding bot deaths as fast as manual, targeted swarming invocations. Will reland this after having some confidence that the 10.13 bot-killer tests are identified. Original change's description: > Run browser_tests as a 25% experiment on Mac10.13 Tests & mac_chromium_rel_ng. > > Bug: 828031 > Change-Id: I1d4bdb235ad9d93df0653215c7c5928c471b6c16 > Reviewed-on: https://chromium-review.googlesource.com/c/1277693 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599364} TBR=rsesek@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828031 Change-Id: I38c447f53d533eeff40abfd462c3bb1f09eac75f Reviewed-on: https://chromium-review.googlesource.com/c/1282283Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599869}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3871bde5c505..079a94f7aec0 git log 3871bde5c505..079a94f7aec0 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 dgarrett@google.com chromeos_config: Enable all firmwarebranch builders. 2018-10-15 dgarrett@google.com chromeos_config: Move nyan_blaze-paladin to swarming. 2018-10-15 shapiroc@chromium.org Remove model details from chromeos version string 2018-10-15 vapier@chromium.org cros_test_lib: drop mox support 2018-10-15 dgarrett@google.com WorkspaceBuildPackages: Adjust --withdebugsymbols cutoff. 2018-10-15 derat@chromium.org chromeos_config: Set warn_only for chrome-informational. Created with: gclient setdep -r src/third_party/chromite@079a94f7aec0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ieb4124355375ef34707d143448dc512b1e5a9b75 Reviewed-on: https://chromium-review.googlesource.com/c/1282346Reviewed-by:
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Id609b13a2bc3dbe67652a18f3d8344e52d24ae12 TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1282502 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#599867}
-
Patrick Monette authored
Bug: 884075 Change-Id: I7fba4358da8876c591490dd15263f3b669abdaf7 Reviewed-on: https://chromium-review.googlesource.com/c/1277950 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/a5078bf8d0e7..ffffc5655474 $ git log a5078bf8d..ffffc5655 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 debargha Remove obsolete comments 2018-10-01 debargha Use fast_interpolation filter search in speed 0 2018-09-25 david.turner SSE4.1 & AVX2 wiener compute_stats_highbd 2018-10-01 yunqingwang Change encoder initialization in unit tests 2018-09-26 zoeliu Add encoder speedup feature prune_ref_mode_for_partitions 2018-10-01 wtc Also reset has_detail when resetting error_code. 2018-10-01 tomfinegan obudec: Modify buffer capacity only when appropriate. 2018-10-01 debargha For keyframe-only coding do not boost in q mode 2018-09-28 wtc Handle failure of read_one_tile_group_obu(). 2018-09-29 wtc Handle sequence header change for still pictures. 2018-09-19 wtc Call get_dec_job_info() only if !td->xd.corrupted. 2018-09-27 satish.suman Remove approx rd based gating in tx_type search 2018-09-29 wtc Fix Visual Studio warning C4244. 2018-09-27 jonathan.matthews Turn off LOOP_FILTER_BITMASK by default 2018-09-28 wtc Release frame buffer references on all error paths 2018-09-20 tomfinegan aomenc/webmenc: Check for errors. 2018-09-27 tomfinegan obudec: Improve buffer size management. 2018-09-27 wtc Release references in ref_frame_map before resync. 2018-09-28 satish.suman Optimize highbd fwd_txfm modules 2018-09-28 david.turner Move highbd scaling outside of tight loop (...) Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org Change-Id: Ibe7dddc94fa17f2db079724a6203472a9d2eb6cf Reviewed-on: https://chromium-review.googlesource.com/c/1276887 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#599865}
-
Luciano Pacheco authored
Move library to base to be able to share it with other apps. Fix the comment about metrics.js to be on top of metrics.js include. Move error_util.js in background page to be first script loaded to be able to catch errors from all scripts. Bug: 893430 Change-Id: I9744089d258fc36979e88b1418595f733e00b81f Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1282642Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d7bbc3b530f..feec80e97144 git log 7d7bbc3b530f..feec80e97144 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 tandrii@chromium.org git cl: no longer support --rietveld flag when forcing codereview. Created with: gclient setdep -r src/third_party/depot_tools@feec80e97144 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: I5dc25649db0f7eebc765c911d2ff94268c2a73eb Reviewed-on: https://chromium-review.googlesource.com/c/1282345Reviewed-by:
-
Tarun Bansal authored
Fix crash when logging resource load timing metrics for the main frame request in UKM page load metrics observer. This is a tentative fix. Change-Id: I70358e646fd64cad6e9e8258bec7c43c51633d78 Bug: 894789 TBR: bmcquade@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1279942 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599862}
-
Xiaohan Wang authored
Currently there's a special logic in mime_util_internal.cc that encrypted VP9 profiles 1/2/3 are generally not supported. In this CL, this logic is removed, so that each key system has the opportunity to declare whether VP9 profiles 1/2/3 are supported. To do so, EME_CODEC_LEGACY_VP9 is replaced by EME_CODEC_VP9_PROFILE0, which is used for both legacy VP9 ("vp9" and "vp9.0") and new multi-part VP9 profile 0 ("vp09.00.*"). EME_CODEC_VP9_PROFILES123 is added for VP9 profiles 1/2/3. Since External Clear Key (ECK) key system supports all codecs, now VP9 profiles 1/2/3 are supported by ECK. Browser tests are updated to reflect this. Bug: 707127 Test: Updated test cases Change-Id: Ia6cdabde0edc4680d0bfa0f8a74a7b8e4151d4e1 Reviewed-on: https://chromium-review.googlesource.com/c/1274893Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599861}
-
Josh Nohle authored
On the start setup page of OOBE, change the text of the cancel button to read "No thanks" instead of "Cancel". Screenshots: OOBE: https://drive.google.com/open?id=1QjHg1_v1QFg1tph986Xi2igPUYG8nJlneA post-OOBE: https://drive.google.com/open?id=1-hxQjU-WVMi8sAWNAZB-7LyrcX3F5ju5bQ Bug: 893353 Change-Id: I748f282b392bccfe17bd14f8bc036cca786bb8f9 Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice* Reviewed-on: https://chromium-review.googlesource.com/c/1272067 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599860}
-
Nick Peterson authored
Bug: 774731 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I811af3256766f6cd7b4466b6b894067e74f652fd Reviewed-on: https://chromium-review.googlesource.com/c/1050806 Commit-Queue: Nick Peterson <nrpeter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599859}
-
Min Qin authored
These download will not show up on Download Home, and user will not be able to interact with them. Just remove them from history on startup BUG=851650 Change-Id: I1966510ec2ffb16df2d797433a629d8e1260f26c Reviewed-on: https://chromium-review.googlesource.com/c/1281422 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599858}
-
siyua authored
Code regarding the dialog pending view is useless now since we've changed the design. Previously dialog would change to a pending state with all checkboxes and buttons disabled after the user clicks the save button. And after 5 secs a close button would show. New design is to dismiss the dialog directly. Bug: 852904 Change-Id: Idb0ab56f80431a8c26a6bd178ef864bcc16887f0 Reviewed-on: https://chromium-review.googlesource.com/c/1282037Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#599857}
-
Xianzhu Wang authored
Remove out-dated docs about PaintInvalidationState and DisplayItemClient cache generation. Add new paint invalidation and raster invalidation. Update docs about paint properties. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I46df3f3e98353fc9a66fc950430df0d8e416d394 Reviewed-on: https://chromium-review.googlesource.com/c/1281921Reviewed-by:
-
Greg Kerr authored
This reverts commit 642d0ad7. Reason for revert: The browser tests are failing again. I cannot reproduce locally but it seems most likely related to this CL. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5775 Original change's description: > Reland "macOS V2 Sandbox: Report correct sandbox profile for nacl-loader." > > This is a reland of 6d83f4b9 > > Original change's description: > > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader. > > > > The nacl loader process, used only on macOS, currently tries to load an > > invalid profile type under the V2 sandbox. This loads the correct type. > > > > Bug: 892554 > > Change-Id: I7b2733db426e3c91181b1f375d791d2918ac6763 > > Reviewed-on: https://chromium-review.googlesource.com/c/1268671 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Derek Schuff <dschuff@chromium.org> > > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#598380} > > TBR: rsesek@chromium.org,dschuff@chromium.org,tsepez@chromium.org > > Bug: 892554 > Change-Id: Ic9cd4da3a17f2a6d36b3ed7145762baf22d8c7f4 > Reviewed-on: https://chromium-review.googlesource.com/c/1279201 > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599391} TBR=dschuff@chromium.org,tsepez@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892554 Change-Id: I3770ed00eafff34550530f7820e76b4e43da252c Reviewed-on: https://chromium-review.googlesource.com/c/1281869Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599855}
-
Giovanni Ortuño Urquidi authored
Implements GetBluetoothState() by using the new BluetoothSystem mojo interface. Bug: 882346 Change-Id: I75f11b9de33c98e2913aeb08a1e5e085532e803d Reviewed-on: https://chromium-review.googlesource.com/c/1272957 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
Bug: 895031 Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 Reviewed-on: https://chromium-review.googlesource.com/c/1281165Reviewed-by:
-
Tetsui Ohkubo authored
This CL adds animation to NewMessageListView when notifications are removed. Video: http://shortn/_hXnIGaYesF UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest.RemovingNotificationAnimation BUG=769219 Change-Id: I06c909acb227f9bfa484083dca36a95d79ece7f5 Reviewed-on: https://chromium-review.googlesource.com/c/1280087 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#599852}
-
Ben Pastene authored
Bug: 876494 Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a Reviewed-on: https://chromium-review.googlesource.com/c/1281230Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#599851}
-
Aleks Totic authored
Labeling all the failures caused by #889721, "no fragment, no outline" as such. I've also triaged rest of outline failures. I'd like to rebaseline, these are minor inline layout pixel differences: paint/invalidation/outline/focus-layers.html paint/invalidation/outline/focus-ring-on-inline-continuation-move.html paint/invalidation/outline/inline-outline-repaint-2.html paint/invalidation/outline/outline-containing-image-in-non-standard-mode.html I've also investigated paint/invalidation/outline/inline-focus.html This seems to be a real case of too much invalidation. Bug: 889721 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iba888ea769e54433ca1272d475baefd078bf6a12 Reviewed-on: https://chromium-review.googlesource.com/c/1281915Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#599850}
-
Sunny Sachanandani authored
After migrating InProcessCommandBuffer to use GPU scheduler, most tasks are scheduled after their sync token dependencies are satisifed (see crrev.com/c/1157874). The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer for pepper, which specifies a sync token, and waits while handling the message. Change ReturnFrontBuffer to contain the sync token, and use it to specify the dependency to the scheduler. Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are specified as task metadata in all cases. Make other cleanups such as removing unnecessary sync token tests, and make sure the sync token code paths are not used where unsupported by using NOTREACHED. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 Bug: 778753 Reviewed-on: https://chromium-review.googlesource.com/c/1168155Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Adam Rice authored
http/tests/fetch/chromium/release-handle-crash.html no longer crashes since https://chromium-review.googlesource.com/c/1278613 landed. Remove the flaky expectations. BUG=893015 Change-Id: I79738c8d44e001a3fad05fdbe11d687d895a3dae Reviewed-on: https://chromium-review.googlesource.com/c/1280074Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#599848}
-
Joel Einbinder authored
This will allow for new methods that operate on AXNodeIds, like Accessibility.click and Accessibility.focus. It also allows multiple calls to getFullAXTree to be compared. Bug: 887173 Change-Id: Iaaf103bced9c5dbc9dd04306c2562044f50dfd2c Reviewed-on: https://chromium-review.googlesource.com/c/1237526 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599847}
-
Andrew Xu authored
(1) Modified code so that tablet mode updating will enable/disable display orientation in setting page. (2) Code refactoring: move all of methods related with display information in SystemInfoApi::SystemInfoEventRouter to DisplayInfoProvider and its subclasses. In the previous code, tablet mode's change will not affect display orientation when setting page has already shown. As result, when opening setting page then changing laptop to tablet mode, user is still able to modify display orientation. After investigation, the bug reason is that in ChromeOS change in tablet mode will not trigger OnDisplayChanged event. Bug: 889625 Change-Id: Ic526ec54e6c01cd14a0d4a7e883774b9fafed268 Reviewed-on: https://chromium-review.googlesource.com/c/1264544 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#599846}
-
Trent Apted authored
Related apps under ui/file_manager all use background_base.js, which instantiates a VolumeManagerFactory. VolumeManagerFactory, BackgroundBase, their tests, and things they depend on should all move to //ui/file_manager/base/*. Capturing deps by Closure-compiling makes things easier to move. Start with volume_manager_unittest.js. Break its dependency on the files app `unittest_util.js` (which shouldn't move) by splitting out some test utility functions to ui/file_manager/base/js/mock_chrome.js. Bug: 879035, 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieab83e90607da78cf06352ecce73c0f8d62a2838 Reviewed-on: https://chromium-review.googlesource.com/c/1278622 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
