- 19 Mar, 2020 40 commits
-
-
Robert Ma authored
Looks like it also sometimes times out on Win10. TBR=lanwei Bug: 947951 Change-Id: I83202a04e10741391e972363ab5ac59b0b92111c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110217Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#751765}
-
Martin Kreichgauer authored
Change helper methods ToJavaFooArray() and to ToJavaArrayOfFoo() to take their input as base::span<> instead of const std::vector<>&. base::span is implicitly converted from most array-like container types; so existing callers work unmodified, and new callers can choose to convert from other types like std::array<>. Also add an overload of ToJavaArrayOfByteArray() that takes an input bytes as std::vector<uint8_t> instead of std::string. Change-Id: Ic9b9327220c4836c01b716299b3ce4ec973b32a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109036Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#751764}
-
gogerald authored
StartSurfaceToolbar* is used when start surface is enabled right now. Bug: 990600 Change-Id: Ib63ae8423c1027cacd27d88179a451f014055f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094713Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#751763}
-
Robbie Gibson authored
This tests that the PopupMenu item is enabled/disabled based on the state of page being displayed. Bug: 1062101 Change-Id: Ide6f00c7e8315054bd74c68c584aaa81ae819e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109765 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#751762}
-
Theresa authored
This reverts commit 89ee6b6a. Reason for revert: Caused test flakiness/failures, crbug.com/1063037 Original change's description: > [TabSelectionEditor] Add List mode supports > > This CL enables TabSelectionEditor to show a List for low-end devices. > > Change-Id: Ie60c1e7ddcda09c2f32e23c4de52be7e642e09e0 > Bug: 1042889 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103313 > Commit-Queue: Mei Liang <meiliang@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751588} TBR=wychen@chromium.org,meiliang@chromium.org Change-Id: I10615c8368f003844193ad535db1c5ca810e912b No-Presubmit: true No-Tree-Checks: true Bug: 1042889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109827 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751761}
-
Etienne Pierre-doray authored
NonEmptyPaint3 now compares to application start time instead of process creation time. This CL refactors startup.LoadTime steps to be cross-platform, with: - process creation - application start time - ChromeMain() time This CL also updates a histograms that measure delta between these for validation. The metric is behaving weird on mac. It's less error prone to use TimeTicks sampled early than aligning clocks. Context: https://groups.google.com/a/google.com/g/chrome-catan/c/BhJOc7JIYeY Change-Id: I77c9791f4fe9129d2882fccd752640ec04bd9efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098403 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#751760}
-
Takashi Toyoshima authored
When URLLoaderFactoryOverride is used, the factory may want to handle custom schemes and allow to accept CORS-enabled requests for them. This patch adds an argument in URLLoaderFactoryOverride to specify if the factory wants to allow CORS-enabled requests for such custom schemes. Bug: 898589, 1062250 Change-Id: Ia5ecc825df6a9cfc3b7c1e87f1bf16b55fd5436a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106047Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#751759}
-
Nico Weber authored
Apparently no longer needed. Change-Id: I19cca28fea7b647a7613b06b7c0c4754e09172ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106812 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#751758}
-
Morten Stenshorne authored
Actually check the flag that tells whether we're in an NG inline formatting context, rather than DCHECKing RootInlineFormattingContext(). I had forgotten about this cheap flag when I introduced this method. This means that CanTraversePhysicalFragments() can now be called on any object. Previously we assumed that, if the object was non-atomic inline, the container had to be NG, or the DCHECK would fail. Bug: 1043787 Change-Id: Ia6d2f301c842c25365558a10952214d9fada77c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107844 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751757}
-
Shawn Gallea authored
This changes default behaviour of clients to correctly match display transform instead of needing to use command line switches as a convenience to those running the clients. Bug: 1011977 Test: Run sample client with and without cmd line flag Change-Id: Idf0bb9e4df8c48f2b8244354f25d9a77a97790a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108285 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#751756}
-
Tarun Bansal authored
The tests are being removed completely instead of just annotating them to enable them for only past milestones. This is simpler since it removes the dependency on the server being enabled and working. Bug: 1048736 Change-Id: Ib20a3c48a2ee2e6a90888517977cc45444ebf7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109631Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751755}
-
Becca Hughes authored
Add a last discovery time which is when we last saw the Media Feed. BUG=1057765 Change-Id: Iab3e255c511135c75c27355484dc6c52aaaf393d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107689Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751754}
-
Jonathan Backer authored
Bug: 1044841 Change-Id: I2ab179dfc0a321d076c64ae99590e3052926889a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107596 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#751753}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8a1e6c065240..747295674924 git log 8a1e6c065240..747295674924 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 mathias@chromium.org Add e2e test for vision deficiency simulation 2020-03-19 pfaffe@chromium.org Implement Mock Plugin Test 2020-03-19 tvanderlippe@chromium.org Enable common/Settings test Created with: gclient setdep -r src/third_party/devtools-frontend/src@747295674924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700,chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib70f1c011439045f0fe898625a860a5234ab1ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751752}
-
Jeffrey Cohen authored
Add a requirement for devices to have a min width, and use finch param. Bug: 1036023 Change-Id: I75e15afc4ddd646f6d3f8577dae792160d13f215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088635 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#751751}
-
Fredrik Söderqvist authored
Even if we don't need to record (new) content for the filter, we still create a SVGFilterRecordingContext. Make this conditional on actually needing to record content instead. This makes it possible to simplify the setup and interface of said helper class. Also move the filter-content PaintInfo to SVGFilterRecordingContext since they are pretty tightly coupled anyway and now have the same lifetime. Bug: 109224 Change-Id: I6507d6666e270499e19b7ed279f95546c99594f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106192Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#751750}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3adef6f2983c..d0550b313874 Created with: gclient setdep -r src-internal@d0550b313874 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2488e75b664e21471244932849080f38b8706d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110035Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751749}
-
Wenyu Fu authored
This reverts commit e2054b9b. Reason for revert: this CL cause crashing. Tracked in crbug.com/1062959 Original change's description: > Move settings.homepage to homepage > > Moving Homepage related settings code to homepage.settings package > > Change-Id: Iaf198f4a25cc03b32a1de997577d466916470437 > Bug: 1052060 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095468 > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751162} TBR=twellington@chromium.org,wychen@chromium.org,wenyufu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1052060 Change-Id: I97b75da16bf58834ba555242476b9e3f7bfd71be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109816 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Marc Treib authored
When the profile and account store contain credentials with the same username but different password, and one of the two versions is used successfully, then the other one should get updated automatically. This was already partially working as part of the existing silent update logic. It didn't fully work because FindMatchForUpdating() didn't consider the case of multiple matches for the same username. This CL fixes the issue in FindMatchForUpdating() and adds integration tests for this scenario. Bug: 1060524, 1058339 Change-Id: Iacdc94ac8045b7c4ccf5a2be47754b92b8d16043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105380 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#751747}
-
Peter Kasting authored
Lots of locally-scoped changes that are (hopefully) reasonably simple. Everything from adding const to removing temps to reordering code blocks, but nothing that should require looking outside the immediate change to evaluate. Bug: none Change-Id: If59592ac3208e6a3cd227afab04b8eb172630598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106960 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751746}
-
Bruce Dawson authored
While rearranging code to do a manual bisect I hit variable shadowing warnings. The warning doesn't normally trigger but the duplicate declarations are still confusing, so this removes the duplicates. Bug: 794619 Change-Id: Ie4388d96e9ae3409a4c2974891dd8dd0fefdf3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110073Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#751745}
-
Eugene But authored
VerifyErrorFinishedContext expects net error code, so pass net::ERR_FAILED. Bug: 1063015 Change-Id: I75562e0162d4e1cef859c7f2220777a3186b8b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109820 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
gogerald authored
Please just disable that test if the flaky comes back. Bug: 1051643 Change-Id: I135dc66d52fd79d77216c671f4acfd2f6ce52b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085296Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#751743}
-
Michael van Ouwerkerk authored
Bug: 1060229 Change-Id: Ie0edce63717231d1b4a6cebd86e9918441958025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108506 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751742}
-
Artur Kochowski authored
Bug: 1058041 Change-Id: I018c8e7ac9b51f8d25222d7547cd6af5b1057dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093608 Commit-Queue: Artur Kochowski <akochowski@opera.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#751741}
-
Dominik Röttsches authored
The DCHECK is too harsh in this case and affecting developers that test in --single-process mode. Removing the DCHECK, as the LOG(ERROR) seems sufficient to detect that src: local() font matching does not work as expected in --single-process mode on Linux. R: cbiesinger, dgrogan Change-Id: I3bb50896ba9f879c8002ae8a125d1df8104fb819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109912 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#751740}
-
Scott Violet authored
A timeout multiplier of .25 means tests are expected to complete in 1/4 the time. This causes timeouts in some tests. We shouldn't need to explicitly set a multiplier, and if there is a need to it should be done in the wpt runner. This also removes HOST_RESOLVER_ARGS as it is unused. BUG=1049426 TEST=test only change Change-Id: Ifbefc33cd9c595d689f4fb7500e61459d20c7c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109022Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751739}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2507f8cdc979..dc5522b4bf4d git log 2507f8cdc979..dc5522b4bf4d --date=short --first-parent --format='%ad %ae %s' 2020-03-19 peah@webrtc.org APM: Removing the redundant VAD output from the integer API Created with: gclient setdep -r src/third_party/webrtc@dc5522b4bf4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a32c8a515d5aedb8536650aad163d277abe1023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110037Reviewed-by:
-
Peter Kasting authored
Make GetSystemMetricsForScaleFactor() non-static. This sometimes references |g_instance|, so it might as well be a const member method. Bug: none Change-Id: I285f21dcc94ca12106f5f661e3526ffa0415aee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106825 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/25ede1ced679..18d3896a15fc git log 25ede1ced679..18d3896a15fc --date=short --first-parent --format='%ad %ae %s' 2020-03-18 ehsannas@gmail.com Whitelist SPV_EXT_demote_to_helper_invocation for opt passes (#3236) 2020-03-17 dgkoch@users.noreply.github.com Add support for KHR_ray_{query,tracing} extensions (#3235) Also rolling transitive DEPS: src/third_party/spirv-headers/src a17e17e36da4..f8bf11a0253a Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@18d3896a15fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I6759cef15417f6c7621730465e1a051bacb04294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108755Reviewed-by:
-
Hazem Ashmawy authored
Always merge dev ui launcher manifest for standalone and trichrome webview into the final manifest unconditionally similar to monochrome launcher manifest. Use jinja_template to: - Generate the manifests for all variants from one Manifest file. - Pass a variable to determine the default enabled state for the launcher activity-alias. Standalone, Trichrome and Monochrome WebView, all use one activity-alias to show the launcher icon. Change the name and the behaviour of the GN flag to always show the launcher icon. If the flag is set to true then Monochrome will always show the icon unconditionally. Fixed: 1047824 Test: Enable/Disable the flag for stable/prestable WebView variants Test: check no changes permissions in standalone and trichrome manifest Change-Id: Ida10e39e294715e69ad19f1253cf302113322cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098804Reviewed-by:
-
Xianzhu Wang authored
We still have cases that fail in pre-CompositeAfterPaint. Split the test into 2 to ensure test coverage of the passing cases. Bug: 957674 Change-Id: I951c28eb3f4d44f122c3d0314d24b454a2e56bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109144Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751734}
-
Anna Mace authored
The rows and cells of TableView are given a state of kInvisible when they should actually be visible. This is because their relative bounds are calculated before the TableView's size is set up, so the width of the row or cell is determined to be 0 and thus does not intersect the bounds of the containing TableView. The fix is to recalculate the relative bounds of the AXVirtualView rows and cells whenever the bounds of the TableView are updated. Then the populate data callback for each AXVirtualView will correctly determine if the row/cell intersects the TableView and should be invisible or not. The reason we don't do this recalculation in the populate data callback is that it is called from the const function AXVirtualView::GetData, but we want to save the result in the member variable custom_data_ (to return from AXVirtualView::GetBoundsRect) which we can't do in a const function. Change-Id: I5ed6b3dd03ceec8e02bfd7c2491a764598e616b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083397 Commit-Queue: Anna Mace <anmace@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#751733}
-
Kevin Babbitt authored
This is a reland of a471ff9b The failures that led to the second revert had the same root cause as the first revert, in two additional tests, with the added feature of being flaky. The affected tests already had a history of flakiness, but it seems this change exacerbated the problem. As near as I can tell it's a timing issue. I verified with VLOG() calls that we're firing exactly two focus events: one on the document root at or near startup, and one on the select control when focus() is called from script. The OS is generating additional focus events for clients. Some of these appear to be sourced from Win32 focus movements; others may be coming from the MSAA-to-UIA bridge, or from UIA itself, as a feature, when selection changes. AccessibilityEventsMenuListCollapse was introduced in crrev.com/396653 and AccessibilityEventsMenuListCollapseNext was introduced in crrev.com/583367. From looking at those CLs, it appears they intend to verify that focus events are *not* fired in the test scenarios for some platforms, so I don't want to suppress the events from the logs. Instead, this CL seeks to stabilize the output by moving the initial focus() from global scope to a go() pass before the existing test body. By doing so, the focus() call - and the accessibility event it triggers - is guaranteed to come after kLoadComplete is fired. Original change's description: > Reland "Ensure UI Automation GetFocus reaches focused node in web content" > > This is a reland of 756820dd > > The original CL was reverted due to test failures on Win7. > > On both Win10 and Win7, UI Automation was generating an initial focus > event when the test listener first connects. On Win10, this initial > focus event comes from a window managed by the operating system > (ClassName=ApplicationManager_ImmersiveShellWindow). Since that element > is outside the scope of the test app, the test listener throws it out. > On Win7, the initial focus event comes from an element in our web > content, so the test listener logs it. > > My suspicion is that the difference in behavior is due to mitigations > for focus stealing introduced between Win7 and Win10. Regardless, the > fix is to generate separate expectation files for Win7. > > Original change's description: > > Ensure UI Automation GetFocus reaches focused node in web content > > > > AXPlatformNodeDelegate::GetFocus() returns the node within the called > > node's subtree that currently has focus. When an element in web content > > has focus, and a delegate in Views is asked for focus, that delegate can > > only reach as far as the web content root. Calling GetFocus() again on > > the web content root ensures that the platform API returns the currently > > focused node. > > > > Bug: 928811 > > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162 > > Reviewed-by: Ian Prest <iapres@microsoft.com> > > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#749386} > > Bug: 928811 > Change-Id: I32e59febfb6dbb7b5386c155c252c880a0f2ebc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101930 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#750781} Bug: 928811 Change-Id: I6a1095335547078db2427599ef5d8c4d30438f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106490 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751732}
-
Fredrik Söderqvist authored
The DynamicTo<LayoutSVGForeignObject>(...) is sufficient. Change-Id: If73029df141d61efab8271e6d980e12dc954a858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109772 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#751731}
-
Katie D authored
Creates a timer for each DistillabilityDriver which records how much time is spent on a distillable page and logs that time when switching to the distilled page. (Moves UMAHelper to content/browser so that it can be accessed by the DistillabilityDriver.) The timer also records how much time is spent on a distilled page and records that when leaving a distilled page. Uses ReaderModeIconView to get updates, as it is already watching the distillability/distilled status of each page as well as the WebContents. These metrics will be helpful in determining how useful Reader Mode is for users. Bug: 992074 Change-Id: I73e12f626380c270473320d5ddc0e1bbc1663319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070738 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751730}
-
Xing Liu authored
This CL adds image cache protobuf and store interfaces. No implementation is added yet. The raw bytes are saved in a separate store, which only supports loading one image at a time in its API. Bug: 1058534 Change-Id: I0646b9906b81432e39f29dd5f235481d12a756c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108180Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751729}
-
Jeff Yoon authored
additional compile targets cause tests that use the test template in test.gni to generate more than once, making ninja unhappy as there are multiple rules that generate the script. The underlying test wrapper was using root_build_dir. Swapping to root_out_dir Bug: 1063028 Change-Id: I4dffec31bd366ae6811307bae1acd5046d10ea97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109463 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751728}
-
Fergal Daly authored
As discussed in http://docs/document/u/1/d/1ZHWWEYT1L5Zgh2lpC7DHXXZjKcptI877KKOqjqxE2Ns/edit we will not have 3 boolean flags for enabled new-RFH behaviour, instead we will have a level param from all-disabled to all-enabled. Add a RenderDocumentLevel enum, controlling what is enabled. Move uses of IsRenderDocumentEnabled to IsRenderDocumentEnabledForSubFrame and implements that and IsRenderDocumentEnabledForCrashedFrame in terms of level. Since there are now a lot of parameterized tests all parameterized by the same list of strings, this also adds some test helper code to ensure consistency. I will submit a change to the finch config before submitting this. Bug: 981339 Change-Id: I9340a89c22703018c515edd97ba8580abc2e7e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098156 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751727}
-
Garrett Beaty authored
Change-Id: I7f8bf64cbe8db266f0cc1654204712c9db8ae090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107768 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#751726}
-
