- 12 Sep, 2018 40 commits
-
-
yoshiki iguchi authored
This CL updates the background of arc notification when surface is set from null or to null. Some notifications have transparent area, so we have to draw a blank background correctly when necessary. Bug: 876430 Change-Id: I273be6a01b4dfde1944f0f720c3ac29e4cfeadfa Reviewed-on: https://chromium-review.googlesource.com/1216582 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#590580}
-
Fumitoshi Ukai authored
This reverts commit a56c7856. Reason for revert: added more capacity: https://chrome-internal-review.googlesource.com/c/infradata/config/+/666063 https://bugs.chromium.org/p/chromium/issues/detail?id=855319#c35 Original change's description: > cq: drop linux-goma-rbe-staging-rel experiment. > > TBR=martiniss@chromium.org > NOTRY=true > > Bug: 855319 > Change-Id: Ia760d2ff0e5c7bfe6cf1508464d0c1e5bc1e2026 > Reviewed-on: https://chromium-review.googlesource.com/1194325 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586731} TBR=martiniss@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855319 Change-Id: Ibd6d62bf793809162ba27a113d5c9429808702e7 Reviewed-on: https://chromium-review.googlesource.com/1220058Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#590579}
-
Tien-Ren Chen authored
This CL extracts sticky offset from paint offset and apply it as a transform node instead. BUG=762098,838018,877196 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6706f09e26ca4549f58500e45153970edfcedc28 Reviewed-on: https://chromium-review.googlesource.com/1208449 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6146bd7be6f..1b5ece0f06f4 git log e6146bd7be6f..1b5ece0f06f4 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 kjlubick@google.com Add mesa_intel_driver asset and dockerfile for creating 2018-09-11 fmalita@chromium.org [sksg] Stop caching full SkPaints in Paint nodes 2018-09-11 brianosman@google.com Initialize bitmaps to different colors, to avoid flaky success 2018-09-11 fmalita@chromium.org [skottie] Shrink SkPaths 2018-09-11 fmalita@chromium.org SkPath::shrinkToFit docs 2018-09-11 herb@google.com Determine too-big-for-atlas in common code 2018-09-11 djsollen@google.com Supress warnings about implicit fallthrough in Android. 2018-09-11 caryclark@skia.org fixup bookmaker 2018-09-11 mtklein@google.com use getColor4f() in raster pipeline blitter 2018-09-11 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 17b75890e71a..fe79649598fb (1 commits) 2018-09-11 mtklein@google.com first start on a P3 GM Created with: gclient setdep -r src/third_party/skia@1b5ece0f06f4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I2a9cfb38ecbc8874cf652ee8b9eb964abe71a1eb Reviewed-on: https://chromium-review.googlesource.com/1220240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590577}
-
Yutaka Hirano authored
This reverts commit 3ce3af5c. Reason for revert: Revert didn't fix the flakiness. Original change's description: > Revert "Scheduler: WebURLLoader should notify Blink with the initial priority." > > This reverts commit d2bade56. > > Reason for revert: Speculative revert for test failure. > https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw > > Original change's description: > > Scheduler: WebURLLoader should notify Blink with the initial priority. > > > > The loading stack only notifies Blink with any increase in the > > request priority. Add support to notify the scheduler with the > > initial priority as well. > > > > Bug: 870349 > > Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b > > Reviewed-on: https://chromium-review.googlesource.com/1185593 > > Commit-Queue: Farah Charab <farahcharab@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#586752} > > TBR=kinuko@chromium.org,altimin@chromium.org,farahcharab@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 870349, 882200 > Change-Id: Id010e1ce5f2c4374f3f89208567fe4e344399051 > Reviewed-on: https://chromium-review.googlesource.com/1218263 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590218} TBR=kinuko@chromium.org,yhirano@chromium.org,altimin@chromium.org,farahcharab@chromium.org Change-Id: I1b363f0f4c7396ccf1cdc7b67b436602e8738df3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870349, 882200 Reviewed-on: https://chromium-review.googlesource.com/1220409Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590576}
-
Hitoshi Yoshida authored
This reverts commit e200b3b1. Reason for revert: This CL seems to break tests. See issue 883160 for details Original change's description: > Add another BeforeUnloadType in support of discarding. > > In order to not discard sites with potential unsaved user state it is necessary > to run beforeunload handlers to see if they return the empty string or not. When running > handlers in this context it is undesirable to launch a modal dialog, but rather to > silently block the discard and continue running the page. > > This CL adds a new BeforeUnloadType to RenderFrameHostImpl in support of this. A > follow-up change will expose functionality for invoking DispatchBeforeUnload with > this BeforeUnloadType, and returning the results of the unload via a callback. > > BUG=877550 > > Change-Id: Iad029fb0f70f9f44695f15c5ca0c0f6e4ed7ff78 > Reviewed-on: https://chromium-review.googlesource.com/1208962 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590362} TBR=chrisha@chromium.org,alexmos@chromium.org Change-Id: If974ab384c3fdda13ca8e3eb89940d5a4026fa68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877550, 883160 Reviewed-on: https://chromium-review.googlesource.com/1220408Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#590575}
-
Kent Tamura authored
This CL reduces the pre-processed size of handle.h by 10%. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic8a9d1c83e2cbc6eba1573eb47667a7eca8973b6 Reviewed-on: https://chromium-review.googlesource.com/1219526 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#590574}
-
Kyle Milka authored
Previously arrow key navigation was fixed for the collection selection dialog in RTL mode, but not for the image selection dialog. Bug: 880764 Change-Id: I96f4f007d6f8f8ecda7a5f72e8353e75a6391211 Reviewed-on: https://chromium-review.googlesource.com/1220767Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#590573}
-
Sunil Kumar authored
Temporarily Excluding test "AudioVideoPipelineDeviceTest.Mp4Playback" from cast_media_unittests. Issue to be tracked as a separate bug ( internal : b/115400220). Test : System testing using script run_unit_test_2 Change-Id: I124f17ca9173a4154b59718a267a5349cf532621 Reviewed-on: https://chromium-review.googlesource.com/1219936Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Sunil Kumar <skx@chromium.org> Cr-Commit-Position: refs/heads/master@{#590572}
-
Dean Liao authored
In Chrome media codebase, it sometimes outputs fourcc value to log. However, we need to table lookup to know which format it refers to. If we convert the 32bit value into four character code (what fourcc stands for), it is easier to get what the format is. BUG=chromium:882339 TEST=Build and run media_unittests --gtest_filter=VideoTypesTest* Change-Id: I806699ff93646640b69d328e2dffae0ba4e84067 Reviewed-on: https://chromium-review.googlesource.com/1216763 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590571}
-
wutao authored
This patch replaces int32 to uint32_t in the assistant_audio_decoder mojom. Bug: b/114096556 Test: manual. Change-Id: I27fbd386b4fb61d8218b411867ae29ef8cb94740 Reviewed-on: https://chromium-review.googlesource.com/1208466Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#590570}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fc2514597ca6..134ee369521c git log fc2514597ca6..134ee369521c --date=short --no-merges --format='%ad %ae %s' 2018-09-11 brucedawson@chromium.org Allow cswitch version 4 as well as 2 2018-09-11 simonhatch@chromium.org Dashboard - Generate 50'th and 90'th percentiles for metrics 2018-09-11 benjhayden@chromium.org Fix dashboard/spa/simple-redux-test.html Created with: gclient setdep -r src/third_party/catapult@134ee369521c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:883106 TBR=sullivan@chromium.org Change-Id: Ibbd4a49fd5221b6e9761fd1388f3252adce58f33 Reviewed-on: https://chromium-review.googlesource.com/1220713Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590569}
-
Yue Li authored
Used to check for Assistant opt-in dialog, now update to check for OOBE login host. Bug: b/115426992 Test: Manual Test Change-Id: I62962abed4df1e65e1985cd00f114e7c549d1997 Reviewed-on: https://chromium-review.googlesource.com/1220674Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#590568}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eccfdf3b. With Chromium commits locally applied on WPT: d3406a52 "Add more WPT tests for mixed-content check in workers/worklets (2/2)" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24560 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I7ce58a06a6fd95135893d02bbb627c7be8d6be3c Reviewed-on: https://chromium-review.googlesource.com/1220301 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590567}
-
Zhiqiang Zhang authored
This CL migrates RemotingCastSession into RemotingSessionController (CAF version). Changes include: * Abstract common logic from CastSessionController into BaseSessionController. * Add onSessionStarted() and onSessionEnded() callback to BaseSessionController to handle session-specific logic regardless of session suspend. * Return the correct namespaces in CastSessionController Please diff BaseSessionController from Patchset 2 for easy review (other files should be diff'ed against base) Bug: 711860 Change-Id: I2bcb71b38758bb7f7b3a46f25cc4d55fe5c2956f Reviewed-on: https://chromium-review.googlesource.com/1220300 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#590566}
-
Anand K. Mistry authored
No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 Change-Id: If66a7ebf25d401397492133c2977a1b9e6109dde Reviewed-on: https://chromium-review.googlesource.com/1220347Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#590565}
-
Artur Khachatryan authored
Test testClickingAnUnfocusableChildShouldNotBlurTheParent fails on Android platforms. Disabling test execution. Bug: chromedriver:2480 Change-Id: Ieec3569437608e0f7145ca1b87a154f669d76191 Reviewed-on: https://chromium-review.googlesource.com/1220770Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590564}
-
Pavel Yatsuk authored
BreakingNewsPush feature is disabled by default and is not enabled by any server side Finch config. Enabling it causes traffic to server endpoint that doesn't have implementation and throws exception. This is one of the two places where this feature can be enabled, the other being about:flags. Change-Id: I4f0e9513098623b938ef4ee20907d1d482e12884 Reviewed-on: https://chromium-review.googlesource.com/1200485 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#590563}
-
Khushal authored
R=cpu@chromium.org Bug: 879259 Change-Id: I4ad88bcf863be355a286b6e0271a08dc470d1cda Reviewed-on: https://chromium-review.googlesource.com/1220769Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#590562}
-
Will Harris authored
Because of MSVC error: warning C4067: unexpected tokens following preprocessor directive - expected a newline BUG=None Change-Id: I31b0d19f797c5a5bc67ce6fe2cfb614725861fa3 Reviewed-on: https://chromium-review.googlesource.com/1162802Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590561}
-
Weiyong Yao authored
The test case 'tabIsUnmutedWhenTabCaptured()' has several issues itself and is not valid any more in nowadays. This cl is to remove this test case. Bug: 882397 Change-Id: I9cc7826ae26cf0d57f66426cce26bcfeb16941a0 Reviewed-on: https://chromium-review.googlesource.com/1219902 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590560}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ddda0b5b8a96..0425ebd2b395 git log ddda0b5b8a96..0425ebd2b395 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0425ebd2b395 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4104c7c032cf9d6b6a0a143f5d259fdd2902a0c9 Reviewed-on: https://chromium-review.googlesource.com/1220238Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590559}
-
Dominic Mazzoni authored
Original: crrev.com/c/1213311 Revert: crrev.com/c/1217645 (Issue was just with a mac10.13 expectation) The previous behavior was deliberate but dates back to this 2006 WebKit bug without any clear rationale: https://bugs.webkit.org/show_bug.cgi?id=8705 In the absence of a strong argument in favor of this behavior, we should do what's better for users and show the focus ring. TBR=alancutter@chromium.org Bug: 870062 Change-Id: I2d413cec6cd94528f5f99852896a99ea68b4bdb7 Reviewed-on: https://chromium-review.googlesource.com/1220169Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#590558}
-
Timothy Gu authored
R=foolip@chromium.org Bug: 626703, 716320 Change-Id: I41c76ac598f77d8f1c3633a22cde413f9aed6418 Reviewed-on: https://chromium-review.googlesource.com/1220108Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590557}
-
Yuki Yamada authored
This CL removes "void GetFunctionLocation(...)". Only InspectorDOMDebuggerAgent::BuildObjectForEventListener() used this method to set some values and it was not useful. "std::unique_ptr<SourceLocation> GetFunctionLocation(...)" will be moved into another class in following CL as commented, so this CL addresses void one first. Bug: 872138 Change-Id: I6cbb771a11c50d70654eac2918d5246b6838adc4 Reviewed-on: https://chromium-review.googlesource.com/1219427Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#590556}
-
Xianzhu Wang authored
The node is needed for PaintArtifactCompositor to correctly set backface visibility properties of cc layers. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 879364 Change-Id: Idc8241988f1582a160f816371e137c4ce03f4aa2 Reviewed-on: https://chromium-review.googlesource.com/1217909 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590555}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/375d35e01b11..bfd412ef716c git log 375d35e01b11..bfd412ef716c --date=short --no-merges --format='%ad %ae %s' 2018-09-11 benwright@webrtc.org Adds integration of the FrameEncryptor/FrameDecryptor into the MediaChannel. 2018-09-11 buildbot@webrtc.org Roll chromium_revision de648460..8952ae00 (589477:590303) 2018-09-11 artit@webrtc.org Excluded tests and test utils from code coverage by generate_coverage_command.py 2018-09-11 nisse@webrtc.org Use SdpVideoFormat in VideoReceiveStream::Decoder 2018-09-11 danilchap@webrtc.org Allow nullptr retransmition rate limiter 2018-09-11 kthelgason@webrtc.org Remove unused file. 2018-09-11 kthelgason@webrtc.org Remove RTCUIApplicationStatusObserver. 2018-09-11 perkj@webrtc.org Reland "Decrease complexity of RtpPacketHistory::GetBestFittingPacket."" 2018-09-11 ssilkin@webrtc.org Fix target frame rate of spatial layer. Created with: gclient setdep -r src/third_party/webrtc@bfd412ef716c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:844647,chromium:None,chromium:None,chromium:882358 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2319c5745080bd3de25d4aabd7e9bc5f0f9cf214 Reviewed-on: https://chromium-review.googlesource.com/1220237Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590554}
-
Lan Wei authored
This is a follow up CL of https://chromium-review.googlesource.com/c/chromium/src/+/1194406 We should setup the keyboard observer before displaying the virtual keyboard otherwise the observer won't see the change of the virtual keyboard. Bug: 871756 Change-Id: I6b13072ed06d9e10d188c553082b411f2bb09326 Reviewed-on: https://chromium-review.googlesource.com/1220560Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#590553}
-
Darren Shen authored
There is a call to ShowVirtualKeyboard in DefaultKeyboardExtensionBrowserTest::GetKeyboardWebContents, which is quite confusing, because the virtual keyboard should be showing up from focus/clicking and not an explicit call. I don't really know why that code is there (maybe it's to load the extension). However, when --enable-virtual-keyboard flag is on, we begin loading the extension anyway. Bug: 849995 Change-Id: Icae6c405ccde304ece80456190802012e487ebc5 Reviewed-on: https://chromium-review.googlesource.com/1215432 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#590552}
-
Katie Dillon authored
The ResourceResponse class has a default constructor and a constructor taking a KURL with some optional parameters. Upon investigation, these parameters are used exclusively in test code with the exception of mime_type which is used twice in document_loader.cc. In most cases, the constructors' optional parameters were used followed by setters to set other parameters not provided by the constructor. We thought it would be more descriptive and simpler to remove the optional parameters in favor of using the already-defined setters. Change-Id: Ifb26f75019a1901f83908be92639d44b4000edd1 Reviewed-on: https://chromium-review.googlesource.com/1220478 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#590551}
-
Tarun Bansal authored
The threshold is controlled using field trial. Also, add few more histograms to track any regressions. Change-Id: I7901f70196dd23de5eec6fc9574602c71fbe0235 Bug: 882913 Reviewed-on: https://chromium-review.googlesource.com/1214748 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#590550}
-
Siddhartha authored
Store TracingSamplerProfiler in ChromeMainDelegate and make sure profiling starts early at startup if needed. Also make the observer async and thread safe. BUG=859260 Change-Id: Ic84a2bfbe832a81071b05e0cff8f77c0015a1576 Reviewed-on: https://chromium-review.googlesource.com/1197324 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#590549}
-
Becky Zhou authored
This patch extracts the SuggestionsSource dependency out from SignInPromo.java so that we can reuse the logic from SignInPromo.java. Bug: 860043 Change-Id: I62e38c37727a3a14727fedc505bb1c7031365024 Reviewed-on: https://chromium-review.googlesource.com/1168116 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590548}
-
Changwan Ryu authored
There is no logic change - this just move the code around for optimization. Android's VM does run-time verification for all the methods in a class if any of the methods fails in AOT compilation time. Therefore, splitting out failing methods into a separate class containing it there help reduce the overall time taken in the run-time verification. See https://chromium-review.googlesource.com/c/chromium/src/+/1175444/8 for the whole picture. See crbug.com/838702 for more information about run-time verification issue. Bug: 868250 Change-Id: I2f878edb7eb2b45119b146231beeb868174d3f2e Reviewed-on: https://chromium-review.googlesource.com/1187661 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#590547}
-
Stefan Zager authored
Prior to this patch, any call to SetNeedsIntersectionObservation would cause all IntersectionObservers in all documents in the frame tree to be marked as needing an update, even when they were not actually dirty. This patch avoids propagating the dirty bit all the way up the frame tree, so that each IntersectionObservation runs only when necessary. BUG=879798 R=chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a5e7b3b966441aca9193a97026ca89c66e039b1 Reviewed-on: https://chromium-review.googlesource.com/1212449 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590546}
-
Chris Palmer authored
This reverts commit 99391f02. Reason for revert: <INSERT REASONING HERE> Original change's description: > [PartitionAlloc] Don't poison memory on free. > > It might? be the cause of a perf regression. > > Bug: 882471,680657 > Change-Id: Iec34a348426ccfdf5864a3b2cbe0c377da20ac0e > Reviewed-on: https://chromium-review.googlesource.com/1220468 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590508} TBR=palmer@chromium.org,eae@chromium.org,haraken@chromium.org Change-Id: I6c687b8cb2b8aa0bc3de682c1c39f430b1f6b05c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882471, 680657 Reviewed-on: https://chromium-review.googlesource.com/1220815Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#590545}
-
Xiaohui Chen authored
Bug: None Test: locally compile Change-Id: I80d12ad3edd287aa9ad7932dea60a1a5f8608b1b Reviewed-on: https://chromium-review.googlesource.com/1217721 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#590544}
-
Jordy Greenblatt authored
The primary purporse of this CL is just to add the board name to the URL for the MultiDevice suite learn more link in the Unified Setup WebUI. However, it also factors all the logic around providing the link into a new function chromeos::multidevice_setup::GetBoardSpecificLearnMoreUrl so that future board specific changes can be implemented in one place and apply to all uses of the link, in particular Settings UI and Setup Flow. Screenshots: Setup flow: screen/42uKYYxBp6d Settings UI: screen/q7WBgweWCcr Bug: 870108 Change-Id: I06e0914194c64fb52fb46ed85822d0372c102d4a Reviewed-on: https://chromium-review.googlesource.com/1217720Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#590543}
-
Sean Topping authored
Since the LEFT swipe is the only gesture with multiple consumers, it's unnecessary to have the rapid-event redirect logic in place for other swipe gestures. Bug: internal b/115367714 Test: Swipe up multiple times quickly, verify the event is handled by the default target each time. Change-Id: I5053fdfbb4d193aba64a99dbb1de02935ab66fa6 Reviewed-on: https://chromium-review.googlesource.com/1220303Reviewed-by:Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#590542}
-
Xiaohui Chen authored
Bug: 113734839 Test: "tell me a joke" reads the joke out through screen reader Change-Id: I92832ff6e7eea298b59aec660763b0d1a4854eef Reviewed-on: https://chromium-review.googlesource.com/1217751 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#590541}
-