- 09 Dec, 2011 40 commits
-
-
varunjain@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8888037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113851 0039d316-1c4b-4281-b951-d872f2087c98
-
aofdwsl@gmail.com authored
When defined USE_XI2_MT, slot id of TouchEvent is maintained by a map of tracking id to slot id. Because tracking id will always keep increasing. The item should be released by TouchRelease to free the slot id for future use. BUG=106673 TEST=Manually Tested Review URL: http://codereview.chromium.org/8839004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113850 0039d316-1c4b-4281-b951-d872f2087c98
-
saintlou@chromium.org authored
BUG=107024 TEST=sync data Review URL: http://codereview.chromium.org/8897015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113849 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Previously we would reject requests with pinning errors at the URLRequest layer but, by that time, we would already have sent cookies. The commenting of the #ifdef is deliberate - it allows the builders to chew the code over. Once the builders are happy I'll land another change to uncomment the #ifdefs. This also happens to start unpicking the DNS certificate provenance stuff. BUG=none TEST=Verify that https://pinningtest.appspot.com fails to load in offical builds. Review URL: http://codereview.chromium.org/8865006 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/8896012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113846 0039d316-1c4b-4281-b951-d872f2087c98
-
rnk@chromium.org authored
This suppression is too broad, and I can't reproduce the original stack trace I saw anyway, so let's remove this for now and see if it comes up on the bots. TBR=timurrrr@chromium.org BUG=96010 TEST=drm release bot Review URL: http://codereview.chromium.org/8895005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113844 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Not the final UI yet. Additional improvements: - file name is selected in save-as dialog at start; - new folder moved to context menu, button deleted. BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549 TEST=Manual Review URL: http://codereview.chromium.org/8554003 TBR=dgozman@chromium.org seems to have broken Linux Chromeos bot: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2359/steps/browser_tests/logs/stdio Review URL: http://codereview.chromium.org/8898009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113841 0039d316-1c4b-4281-b951-d872f2087c98
-
dspringer@chromium.org authored
BUG=none TEST=run_all_tests Review URL: http://codereview.chromium.org/8893007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113839 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
Review URL: http://codereview.chromium.org/8872046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113837 0039d316-1c4b-4281-b951-d872f2087c98
-
stevet@chromium.org authored
BUG=106951 TEST=With a fresh Chrome, create a second profile. Ensure that the original shortcut is modified to point to the first profile. If you check the shortcut, the argument to chrome.exe should include something like --profile-directory="Default". Review URL: http://codereview.chromium.org/8897002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113836 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
With multiple profiles we would sometimes crash with the following backtrace: ProfileImpl::~ProfileImpl ProfileDependencyManager::DestroyProfileServices ... ProfileImp::InitSyncService() UpdateProfileUserNameCache profile_manager->GetProfileInfoCache( The problem was that at this point the profile manager and the profile sync service were both already deleted. Our lazy load of the profile sync service was causing us to create the service twice. In our other lazy load code we have a flag to prevent us from creating something twice. I added the same code to the profile sync service. BUG=106869 TEST=Reproduced the crash. Applied my fix and verified that the crash no longer reproduced. Review URL: http://codereview.chromium.org/8879047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113835 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113834 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@google.com authored
This fixes shared builds. BUG=NONE TEST=trybots pass TBR=crogers Review URL: http://codereview.chromium.org/8899005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113828 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users. BUG=none TEST=existing. Review URL: http://codereview.chromium.org/8824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
-
epoger@chromium.org authored
BUG=106987 TBR=avi Review URL: http://codereview.chromium.org/8894009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113824 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Previously we would reject requests with pinning errors at the URLRequest layer but, by that time, we would already have sent cookies. The commenting of the #ifdef is deliberate - it allows the builders to chew the code over. Once the builders are happy I'll land another change to uncomment the #ifdefs. This also happens to start unpicking the DNS certificate provenance stuff. BUG=none TEST=Verify that https://pinningtest.appspot.com fails to load in offical builds. Review URL: http://codereview.chromium.org/8865006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113823 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=106988 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/8896003 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/8897004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113822 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@google.com authored
This helps us move closer to being able to do renderer-side mixing, for improved performance. See original CL for discussion: http://codereview.chromium.org/8477037/ BUG=none TEST=audio_renderer_impl_unittest (also verified that the media layout tests all pass, and did manual testing with several audio files and YouTube videos) Review URL: http://codereview.chromium.org/8785008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113821 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=106988 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/8896003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113820 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
[ Reland of 113565 http://codereview.chromium.org/8764003 ] This splits apart the old in-process implementation into a new object in shared_impl that does most of the general tracking. This alllows that code to be shared by the proxy. BUG=http://crbug.com/101154 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8898005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113819 0039d316-1c4b-4281-b951-d872f2087c98
-
tsepez@chromium.org authored
have permission to open them directly. For example, right-click on a "chrome://" link in an ordinary window should show two items: Copy link location and inspect element, but a full menu from a WebUI window itself. NOTE: Fixing this issue requires a fix to ChildProcessSecurityPolicy, which as been silently too permissive. BUG=104466 Review URL: http://codereview.chromium.org/8588039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113818 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
[ Reland of 113565 http://codereview.chromium.org/8764003 ] This splits apart the old in-process implementation into a new object in shared_impl that does most of the general tracking. This alllows that code to be shared by the proxy. BUG=http://crbug.com/101154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113817 0039d316-1c4b-4281-b951-d872f2087c98
-
epoger@chromium.org authored
BUG=106984 Review URL: http://codereview.chromium.org/8899003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113816 0039d316-1c4b-4281-b951-d872f2087c98
-
dspringer@chromium.org authored
The --archive-id option allows you to specify the archive id that is used to build the BigStore URL for the SDK tarballs. This id overrides the default id that looks like "pepper_15_1347". BUG=none TEST=native_client_sdk/src/scons run_update_manifest_test Review URL: http://codereview.chromium.org/8879042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113815 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
As the Web Audio API won't be enabled, make sure that Android uses an empty implementation of the DecodeAudioFileData. BUG= TEST= Review URL: http://codereview.chromium.org/8844005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113814 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113812 0039d316-1c4b-4281-b951-d872f2087c98
-
tomhudson@google.com authored
Review URL: http://codereview.chromium.org/8885035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113811 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=106957 TEST=none R=dmazzoni@chromium.org TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/8893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113810 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. Attempt 2 failed because of last minute changes to chrome_tests.gypi that I didn't merge properly with. TBRing again. BUG=104360 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8890050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113809 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=105872 TEST=no change Review URL: http://codereview.chromium.org/8865004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113808 0039d316-1c4b-4281-b951-d872f2087c98
-
epoger@chromium.org authored
BUG=101731 Review URL: http://codereview.chromium.org/8890034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113807 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
Revert the revert. It did not fix the tree. BUG=79520 TEST=no TBR=battre@chromium.org Review URL: http://codereview.chromium.org/8897001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113806 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
Not the final UI yet. Additional improvements: - file name is selected in save-as dialog at start; - new folder moved to context menu, button deleted. BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549 TEST=Manual Review URL: http://codereview.chromium.org/8554003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113804 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
BUG=chromium:106442 TEST= Review URL: http://codereview.chromium.org/8872027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113803 0039d316-1c4b-4281-b951-d872f2087c98
-
steveblock@chromium.org authored
JavaBridgeDispatcherHost::AddNamedObject() currently has a race condition, as it posts to the WEBKIT thread before sending the injected object to the renderer. See bug for details. To fix this, JavaBridgeDispatcherHost::AddNamedObject() now creates the NPVariant_Param synchronously, and immediately sends this to the renderer. This requires use of a route ID generator which is shared with the JavaBridgeChannelHost. Creation of the JavaBridgeChannelHost and the corresponding NPObjectStub is done asynchronously on the WEBKIT thread. This means that the channel handle is not available when the Java Bridge is first initialized in the renderer. To overcome this, the renderer obtains it from the browser with a new sync IPC call. - RenderViewImpl - OnJavaBridgeInit() no longer supplies a channel handle. - JavaBridgeDispatcher - Lazily gets channel handle from browser. - JavaBridgeDispatcherHost - Now a RVH obsever to provide channel handle. Uses shared route ID generator to synchronously create the NPVariant_Param when a new object is injected. Creates the JavaBridgeChannelHost and the corresponding NPObjectStub asynchronously on the WEBKIT thread. - JavaBridgeChannelHost - Shares a route ID generator with the JavaBridgeDispatcherHost. BUG=106691 Review URL: http://codereview.chromium.org/8834013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113802 0039d316-1c4b-4281-b951-d872f2087c98
-
backer@chromium.org authored
Relies on WK patch: https://bugs.webkit.org/show_bug.cgi?id=73485 for damage to external texture and WK patch: https://bugs.webkit.org/show_bug.cgi?id=67341 for scissoring optimization. BUG=none TEST=run GYP_DEFINES="use_aura=1 use_webkit_compositor=1" on a machine that supports GLX_MESA_copy_sub_buffer; go to http://www.webkit.org/blog-files/3d-transforms/poster-circle.html; move a different X11 window over top of the chrome window; see that only part of the chrome window (with the animation) gets redrawn Review URL: http://codereview.chromium.org/8764001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113801 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
BUG=chromium-os:23996 TEST=manual Review URL: http://codereview.chromium.org/8885034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113800 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
Reverting previous revert as it did not cause the problem. BUG=chromium-os:22840 TEST=Manual: see bug description TBR=ivankr@chromium.org TBR=dgozman@chromium.org Review URL: http://codereview.chromium.org/8895001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113799 0039d316-1c4b-4281-b951-d872f2087c98
-
markusheintz@chromium.org authored
Fix UserActionsMetrics calls for content settings UMA, so that they get picked up by the the chrome/tools/extract_actions.py tool. Remove wrong and unused user action metrics hash and add the correct hashes. BUG=105865 TEST=none Review URL: http://codereview.chromium.org/8873056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113798 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
This may potentially cause failure of ExtensionApiTest.ProcessesVsTaskManager. BUG=chromium-os:22840 TEST=Manual: see bug description Review URL: http://codereview.chromium.org/8872015 TBR=ivankr@chromium.org Review URL: http://codereview.chromium.org/8890069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113797 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
Revert for potential cause of ExtensionApiTest.ProcessesVsTaskManager failure. This enables a fix for bug 79520 that was previously committed but not enabled http://src.chromium.org/viewvc/chrome?view=rev&revision=112847. BUG=79520 TEST=no TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8889007 TBR=battre@chromium.org Review URL: http://codereview.chromium.org/8879051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113794 0039d316-1c4b-4281-b951-d872f2087c98
-