- 15 Jul, 2020 40 commits
-
-
Koji Ishii authored
This patch adds |DCHECK|s that check all |NGFragmentItem| in |LayoutBox::layout_results_| are valid (i.e., not destroyed nor removed from the tree.) 5 tests in |virtual/layout_ng_block_frag| fail, marked as failures. Bug: 829028, 982194 Change-Id: I4e3bdadaa129945fa2e5444d1c4fcb7002ee3347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291566 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788583}
-
Wolfgang Beyer authored
Relevant DevTools CL: https://crrev.com/c/2297420 Bug: https://crbug.com/1101262 Change-Id: I52ef4614fe5add94dcbdf9eeaff2b031eccc85e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299227Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788582}
-
Richard Knoll authored
After some recent changes to notification_view_md the colors are off. Screenshot with before and after this CL: https://imgur.com/CzkIxZy - NotificationHeaderView now handes the default accent color itself - SmallIcon actually checks the native theme now - NotificationMdTextButton updates on theme changes - Textfield placeholder color needs to be different for blue background Bug: None Change-Id: Ib4a556ab110f20ea26a6cc1813b7d6783584c8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292512 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788581}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/264237a97225..bb7978bb9ed4 2020-07-15 tvanderlippe@chromium.org Update several @types packages 2020-07-15 changhaohan@chromium.org Disable style-related adorners for comment nodes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e3a0f08e6fcb3646458acac7e27a30c09efaf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788580}
-
Denis Kuznetsov authored
This change will limit set of screens where accelerator can be toggled to just Welcome screen (as this is dev-only feature, and it is possible to navigate to Welcome screen from other screens where it was possible to toggle). This CL also marks some places via TODOs as a scope for issue 1105387. TBR=bcwhite@chroimium.org Bug: 1102393, 1105387, 1100909, 1100910 Change-Id: I4285a1e5e3d5db7b6762e06b12a6b60bcf2c2e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297339 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#788579}
-
Hans Wennborg authored
This was a copy-pasto from ceb49dda. TBR=thakis Bug: 1105518 Change-Id: I263cd1fbbe99b4c7435789099f41ad4d59b67805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300105 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#788578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f5d0ae98c34c..4265fce66e9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: melandory@google.com Change-Id: I247cc9dad7d4d71c1a8c22de0f1f0170ebf838c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299487Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788577}
-
Dominic Battre authored
The creation of the map was completely redundant, so I have removed it. Bug: 896173 Change-Id: Ibe28940c458de4f18b28d958e0d4d34581bbdf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279825 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788576}
-
Mugdha Lakhani authored
Move more tests to NoStatePrefetch tests Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I4a050e5bfe839d91ad615f46219f9d91447569a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292255 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#788575}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0f7f4611c4c..264237a97225 2020-07-15 jacktfranklin@chromium.org Upgrade TypeScript ESLint dependencies. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0f542ddd628866f75a3e21978df2ce53fd4a1265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299496Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/55ef680dab93..a0a8e1d6457f 2020-07-15 treehugger-gerrit@google.com Merge "gen_amalgamated: Move cpp proto bindings from perfetto.cc to perfetto.h" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib75ddad5901b6b91d062507bd23bf2d29039b4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299495Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4ad0f250a010..c08b0ace9907 2020-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 0bc4c2ae7012 to d8f34456c819 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ie9aa7d8c0794efbe9ed4fbb97548368c5caee1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299494Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/40c3c1cace0a..4c33fb0d3dba 2020-07-14 jaebaek@google.com Rewrite KillDebugDeclares() (#3513) 2020-07-14 andreperezmaselco.developer@gmail.com spirv-fuzz: Fix instruction insertion issue (#3521) 2020-07-14 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement the OpMatrixTimesMatrix linear algebra case (#3527) 2020-07-14 greg@lunarg.com Add support to GPU-AV instrumentation for Task and Mesh shaders (#3512) 2020-07-14 andreperezmaselco.developer@gmail.com spirv-fuzz: Support adding dead break from back-edge block (#3519) 2020-07-14 andreperezmaselco.developer@gmail.com Support OpPhi when replacing boolean constant operand (#3518) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ia998836a33461e8a572a2faf0ca6c222f62d38eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299485Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98ad3617..ee5d7c41 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0e4a35467643a92ae6fb8ca95df98e0e8ccfdcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299859Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788570}
-
Callistus authored
device instead of always Chromebook. - Added a new string that supports placeholder for the device type. Screenshot uploaded to https://storage.cloud.google.com/chromium-translation-screenshots/76cb4679fbbc7d77ab048559d8cf7147920b9fab as per https://g.co/chrome/translation. - Update the release notes notification code to use this new string. Bug: b/157107063 Change-Id: If723e3716d390ba00461abc5bbb9d5dca410ed20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296761Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#788569}
-
Jack Franklin authored
https://crrev.com/c/2297395 ships a new breadcrumbs component that includes its own unit tests and DevTools frontend also has an e2e test for the breadcrumbs. Therefore we don't need to also maintain these layout tests in Chromium. Change-Id: Ifefb09a545442d3681a9b4921d4d708c636943d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300081 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#788568}
-
Hans Wennborg authored
Bug: 1105518 Change-Id: I267708d4990adbbdb7d9fe3642fb40d077cad7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297525Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#788567}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594640123-fdf8a72e5b13627e142e52b62a8ba89cbc874f73.profdata to chrome-win64-master-1594771186-8c7f3834398f8caaba6f32c369440926161c5207.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2d30330f7effe85b6f644920ad5629c9af89a189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298806Reviewed-by:
-
Alice Wang authored
This CL updates the icon to expand the account list in the collapsed bottom sheet used in web sign-in flow. Screenshot: https://crbug.com/1103328#c1 Bug: 1103328 Change-Id: I4ce657ce917cb3b3f87dde62009cf026f4c62c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288378 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#788565}
-
Sara Kato authored
invalid. On a focus event, AXTreeSource searches the first a11y focusable node under the event source. When no focusable node is found, it sets the focus on the event source node, but it invoked undesired behavior. For instance, in ArcSettings application focus was requested, by sending a requestFocus() event. This results in android_focused_id_ being computed again in ax_tree_source_arc. However as this is forced focused event, sometimes the new node is not valid. In this case, rather than default back to the event_source (and move the focus there), the focus should remain unchanged. Removing requestFocus() would cause undesired behaviors in other areas of the app. This CL adds a change, so that when no focusable node is found under the focus event source node, we don't change focus so that it won't invoke unexpected behavior. Note that the a11y event of type FOCUSED can be dispatched in various ways (e.g. via ViewParent#requestSendAccessibilityEvent is another way to request the a11y event). Also, even if it's not the "forced" focus event, technically FindFirstFocusableNode can return null as we're doing different computation than the Android framework. This change also fixes HasText() computation in CanBeAccessibilityFocused. AX-Relnotes: n/a. Bug: b:156562991 Test: Manual. Open arc settings and observe no scrolling Test: AXTreeSourceArcTest.* Change-Id: If07e0c342dab929bf6f516a1753beda31bd9522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291552 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#788564}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e7083de3589..b92d53afbead 2020-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d98afb787a24 to 4ad0f250a010 (9 revisions) 2020-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2a68959f to c28de0e5 (434 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105609 Tbr: nifong@google.com Change-Id: I0fc1cb4ae797f2de93ddf514339eb78c2ab1c553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299067Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b31f5e717e2d..3b17f0bde80c 2020-07-15 jiawei.shao@intel.com Optimize B2T and T2B copies with multiple texture layers on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I27fe01df5e836dd03a2a1969bf5e9b360780794c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299493Reviewed-by:
-
Mugdha Lakhani authored
Bug: 898955 Change-Id: Id85bc95c44ad553911dacf731630b5750d4779e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290930 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Gabriel Kerneis authored
Bug: 750948 Test: CQ Change-Id: Ic11aec698c70d8d562ab51c16859b248b430b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299620 Commit-Queue: Gabriel Kerneis <kerneis@google.com> Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Gabriel Kerneis <kerneis@google.com> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#788560}
-
Aya ElAttar authored
Added EnterpriseClipboardDlpController to apply data-leak prevention on clipboard confidential data according to the policy rules set by the admin. Bug: 1096458 Change-Id: Idcdba108918e59ecebd50546f78ebf2a9d50c15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275907 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#788559}
-
Miyoung Shin authored
It has been flaky on the chrome os bots since https://crrev.com/c/2215650 landed. As this change has a WebUI Mojo pipe, the order in which WebUI's Send API is called has changed, and the test is failed when 'hideOobeDialog' is called through WebUI's Send and IME's state is updated to show the sign-in screen before the test's result is checked. Bug: 1104861 Change-Id: Iccaf905dd63f4e1e22b8ca399079e1e6a3cee08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297207 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788558}
-
Mugdha Lakhani authored
Bug: 1104943, 1104926 Change-Id: Id4b32c31de3cd5fb8765e79f5824e679ac4b285e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297385Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#788557}
-
Manuel Rego Casasnovas authored
Similar to what we have in NGOutOfFlowLayoutPart constructor we should have an early return in NGOutOfFlowLayoutPart::Run() when we have no positioned descendants. We already have it a few lines later, but we can move it to the beginning of the method to avoid any extra operation. We also add a check for fragmentainer descendants to avoid doing extra work if we don't have any. BUG=1098231 Change-Id: I2d233c1c79a903d1696099c26029c2d09d59a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279759Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#788556}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a61a55a444b3..8516651130b5 2020-07-14 thestig@chromium.org Add FPDFEditEmbedderTest.ExtractImageBitmapIgnoresSetMatrix. 2020-07-14 nigi@chromium.org Remove unused integer fill flags and converter functions. 2020-07-14 nigi@chromium.org Change FX_FillMode type parameters in CXFA_Graphics. 2020-07-14 tsepez@chromium.org Make CFXJSE_Context delete its own CXFA_ThisProxies. 2020-07-14 thestig@chromium.org Use ScopedFPDFBitmap in FPDFEditEmbedderTest(). 2020-07-14 nigi@chromium.org Replace more integer fill types with CFX_FillRenderOptions::FillType. 2020-07-14 nigi@chromium.org Remove usage of FXFILL_WINDING and FXFILL_ALTERNATE in CPDF_ClipPath. 2020-07-14 tsepez@chromium.org Put CJX_Objects into V8 object embedder slots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1269c3a627baa9ab4557c3005b8fcf38679f8d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299484Reviewed-by:
-
Koji Ishii authored
Similar to what r784356 crrev.com/c/2275281 did to |ScrollableOverflow|, this patch adds dirty-tree guard to |AddOutlineRects|. This is another operation that walks though post-layout fragment tree. We already use |PostLayoutChildren| since r662988 <crrev.com/c/1624010>, but skipping |NGFragmentItem| was not done yet. This patch adds this. Bug: 1101086 Change-Id: Iac9ef846a03ea6e2a9fbd6aad196b13e14991e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299320 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/49d9f039e26b..f4db4dad69d7 2020-07-15 cduvall@chromium.org Allow running perf tests with trichrome and standalone WebView 2020-07-15 wvw@google.com [ftrace importer] Add thermal parser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103896,chromium:1105096 Tbr: skyostil@google.com Change-Id: I23403549fef60f12ef21bad9bc8231e9bf9739b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299479Reviewed-by:
-
Thiemo Nagel authored
The logic has changed here: https://chromium-review.googlesource.com/c/chromium/src/+/2038774 Bug: 888981 Change-Id: I02f4ca33477c3e6f3e77fd3021764b9ae96a99cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298003Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788552}
-
Kent Tamura authored
It has no reasons to use the legacy layout. Bug: 1040826 Change-Id: I2adf8160551d5ec5fa77d506b1e8d930bff43416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299659 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Aya ElAttar authored
Added Clipboard data leak prevention controller to be used on Chrome OS on every clipboard read to validate whether it's allowed. Bug: 1096458 Change-Id: Ibf5441dc80ecc82e46fc20b68053b697a1920d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275445 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788550}
-
Noel Gordon authored
Selection menu button is an action-icon and it should also have a 48px tap target per the files-ng spec. Again borrow the tap target CSS used for {#gear,#sort}-button, since they are action-icon. Bug: 1066727 Change-Id: Ibcb1ae00f70e0dd33a870be4c90563d6976cb6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299661 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788549}
-
Richard Knoll authored
This makes sure any observed Widgets are removed when this class is destroyed. Found by adding a CHECK in its destructor in crrev.com/c/2254598. Bug: 1104876 Change-Id: I58def066b80c314a15d21bf75fd790b16bf54247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296981Reviewed-by:
-
Eleonora Rocchi authored
Add an illustration in the Password Check button which will be shown until the user has clicked 3 times the button. This CL also adds a test to verify the illustation is shown the correct number of times. Bug: 1101720,1092444 Change-Id: I88c666ba9015e112e55bbac3802fa33662cb54de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283323Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#788547}
-
Dominic Schulz authored
They've moved from .clangd/index to .cache/clangd/index in https://github.com/llvm/llvm-project/commit/9b55bc4d1197aedd76b0f4e04270265cb74cd0b8 Change-Id: I4b3e351940ef3abfc3bfbc393c66a78c7ded3f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297710Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Dominic Schulz <dominicschulz@google.com> Cr-Commit-Position: refs/heads/master@{#788546}
-
Wolfgang Beyer authored
Relevant DevTools CL: https://crrev.com/c/2297420 Bug: https://crbug.com/1101262 Change-Id: I29b37d6c30ea2600129f80935a7e1fca85c8e3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299220Reviewed-by:
-
Alex Rudenko authored
The order in which stylesheets are added can be arbitrary. This CL sorts stylesheets by the content to avoid flakiness. Fixed: 1104260 Change-Id: I4b57e588374bc14ae3d6dd1ee8f5644e12eac093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299719Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#788544}
-
