GitLab

We need to support sequence as IntersectionObserverCallback uses
a sequence.

BUG=648486

Review-Url: https://codereview.chromium.org/2350813005
Cr-Commit-Position: refs/heads/master@{#421154}

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none

Review-Url: https://codereview.chromium.org/2348053002
Cr-Commit-Position: refs/heads/master@{#421153}

BUG=589380

Review-Url: https://codereview.chromium.org/2360293002
Cr-Commit-Position: refs/heads/master@{#421152}

Previously, with the pre-Lollipop picker, onCancel was never called. Now
it is called immediately upon dismissing the dialog. In post-Lollipop,
there is still an ongoing issue where onCancel is not called immediately
upon closing the picker (it waits until the next share action); see
crbug.com/636274.

BUG=646247,636274

Review-Url: https://codereview.chromium.org/2338683002
Cr-Commit-Position: refs/heads/master@{#421151}

After https://codereview.chromium.org/2257363002
I think it was added accidentally.

BUG=

Review-Url: https://codereview.chromium.org/2352683002
Cr-Commit-Position: refs/heads/master@{#421150}

his patch converts "editing/pasteboard/paste-table-002.html"
to use w3c test harness to simplify test case for improving code helath.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2370683002
Cr-Commit-Position: refs/heads/master@{#421149}

MD History, which was the only user of this element, moved away from it
in https://codereview.chromium.org/2352293002/. It can now be safely
removed from the binary and repository.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2357093002
Cr-Commit-Position: refs/heads/master@{#421148}

BUG=none

Review-Url: https://codereview.chromium.org/2364213002
Cr-Commit-Position: refs/heads/master@{#421147}

BUG=527304

Review-Url: https://codereview.chromium.org/2276113002
Cr-Commit-Position: refs/heads/master@{#421146}

In r648880 we introduced a regression because of the new implementation
of LayoutBox::computePercentageLogicalHeight() was wrongly initializing
as 0 the availableHeight variable.
We should just use -1 like the code was doing before that patch.

BUG=648880
TEST=fast/table/quirks-mode-percent-height.html

Review-Url: https://codereview.chromium.org/2376483002
Cr-Commit-Position: refs/heads/master@{#421145}

Whether a BlimpContents is visible or not is an important concept for
Blimp feedback. This CL adds support for emitting data about whether
any BlimpContents is visible.

To be able to do this, we now expose the list of all active
BlimpContents from the BlimpContentsManager, and the
BlimpCompositorManager now exposes whether it is visible or not.
The state can still be controlled directly from BlimpContentsImpl
by invoking Show()/Hide(), which is what the test code is invoking.

Since this CL adds another test for BlimpContentsManager, it also
cleans up that test file by making the test-class
BlimpContentsManagerTest set up all the common parts of all the tests.

BUG=637988

Review-Url: https://codereview.chromium.org/2371503002
Cr-Commit-Position: refs/heads/master@{#421144}

BUG=650150

Review-Url: https://codereview.chromium.org/2372123002
Cr-Commit-Position: refs/heads/master@{#421143}

There was a GDI leak when hovering input elements. Reaching 10000 GDI objects
would cause process to crash.

Fixed by deleting HBITMAP that was selected onto the HDC. Deleting HDC does not
take care of that.

The skia utility function was removed and replaced with a custom scoped object
at call site as it was used only in one place and making it safe to use for
others would be a bit tricky as bitmap needs to be deleted before HDC and there
is no easy access to the bitmap after utility function returns HDC.

R=pkasting@chromium.org,fmalita@chromium.org,tomhudson@google.com

BUG=649712

Review-Url: https://codereview.chromium.org/2365903002
Cr-Commit-Position: refs/heads/master@{#421142}

We shouldn't block the UI thread waiting for crash_reporter which
performs disk IO.

BUG=None

Review-Url: https://codereview.chromium.org/2367333002
Cr-Commit-Position: refs/heads/master@{#421141}

The expectations incorrectly expect 'subString' instead of 'substring'
in the case when substring is called on null or undefined.

BUG=chromium:650247

Review-Url: https://codereview.chromium.org/2369003003
Cr-Commit-Position: refs/heads/master@{#421140}

Chrome has maybe gotten a bit slower at muting, but it's at most 1 sec.
This test should not be a performance test of muting speed though,
merely that muting happens, so update the test to just look at the last
10K samples in case we're unlucky and get a beep into the samples
window before the mute kicks in.

BUG=648879
R=ehmaldonado@chromium.org

Review-Url: https://codereview.chromium.org/2366303002
Cr-Commit-Position: refs/heads/master@{#421139}

This patch postpones the creation of |visiblePos| in
|InsertParagraphSeparatorCommand::doApply|  so that |visiblePos|
does not get invalidated by the creation of |blockToInsert|.

Note: ideally, the creation and modification of an out-of-document
element (in this case, |blockToInsert|) shouldn't invalidate
VisiblePositions, but this is still hard to fix in the current
implementation. See crbug.com/650164.

BUG=648949

Review-Url: https://codereview.chromium.org/2372903003
Cr-Commit-Position: refs/heads/master@{#421138}

This change optimises LengthInterpolationFunctions::createLength() to skip
processing units whose corresponding values are zero. This avoids the
nanification of Length for the majority of CSS length animations that don't
use viewport units in SVG images.

See crbug.com/650147 for further details on nan viewport units in SVG images.

BUG=650147,650216

Review-Url: https://codereview.chromium.org/2370783003
Cr-Commit-Position: refs/heads/master@{#421137}

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988

Review-Url: https://codereview.chromium.org/2362693003
Cr-Commit-Position: refs/heads/master@{#421136}

Making timer callback public for testing as per Marijn's comment in https://codereview.chromium.org/2192413002/.

BUG=629462

Review-Url: https://codereview.chromium.org/2222883002
Cr-Commit-Position: refs/heads/master@{#421135}

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16: note: candidate function not viable: no known conversion from 'int' to 'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2375593002
Cr-Commit-Position: refs/heads/master@{#421134}

When we need to restore the trailing space of a line and the
leading space of the next line together for copy operation,
we don't have to restore the trailing space in the first line.
Example: <div style="width: 2em;"><b><i>foo </i></b> bar</div>

BUG=318925
TEST=TextIteratorTest.PreserveOnlyLeadingSpace

Review-Url: https://codereview.chromium.org/2336043006
Cr-Commit-Position: refs/heads/master@{#421133}

Cr-Commit-Position: refs/heads/master@{#421132}

BUG=648336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2355723002
Cr-Commit-Position: refs/heads/master@{#421131}

BUG=527304

Review-Url: https://codereview.chromium.org/2274243002
Cr-Commit-Position: refs/heads/master@{#421130}

'*' should match 'file://whatever.jpg' when loaded from 'file://document.html'.
The patch in [1] tightened '*'s behavior, but missed this bit.

[1]: https://codereview.chromium.org/2209113002

BUG=648508

Review-Url: https://codereview.chromium.org/2368073003
Cr-Commit-Position: refs/heads/master@{#421129}

Use ActivityManager.getMemoryInfo() to implement MemoryMonitor
for android.

Design doc:
https://docs.google.com/document/d/1xHBD29Pi26cwXd7byJd7DhvdhJ8EzODP_uqUUI7J9e4/edit#heading=h.z8w4k8xdqow

NO_DEPENDENCY_CHECKS=true
BUG=617492

Review-Url: https://codereview.chromium.org/2340293003
Cr-Commit-Position: refs/heads/master@{#421128}

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode CrossThreadCopier<PassRefPtr>::copy taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp?l=215

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2355153002
Cr-Commit-Position: refs/heads/master@{#421127}

The application state when the request was created should be used to
record foreground vs background data use. Currently, application state at
the time of data use is used.

BUG=648808

Review-Url: https://codereview.chromium.org/2358663004
Cr-Commit-Position: refs/heads/master@{#421126}

Currently, we early exit if the visibility amount matches our
desired ending amount.  But when you set HIDDEN as the current,
it will start an animation, and a immediate call to SHOWN will
see that the ending condition is met and return, but does not
clear the animation.

Now, clear the animation if the current value matches our
desired ending value to ensure it doesn't move.

BUG=639702
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2372713004
Cr-Commit-Position: refs/heads/master@{#421125}

When removing B from siblings A B C, we scheduled invalidations for
features of A requiring two adjacent combinators to schedule an
invalidation at all. That is fine for rules already affecting C, but
for rules kicking in after B is removed, a single combinator is enough.
For instance ".a + .c".

R=ericwilligers@chromium.org
BUG=647780

Review-Url: https://codereview.chromium.org/2362463004
Cr-Commit-Position: refs/heads/master@{#421124}

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try

Review-Url: https://codereview.chromium.org/2363303003
Cr-Commit-Position: refs/heads/master@{#421123}

This CL partly uses auto-generated code for PerformanceObserverCallback.
Especially, part of hand-written V8PerformanceObserverCallback.{h/cpp}
are replaced with auto-generated V8PerformanceObserverInnerCallback.{h/cpp}.

BUG=569301

Review-Url: https://codereview.chromium.org/2371633002
Cr-Commit-Position: refs/heads/master@{#421122}

BUG=650228

Review-Url: https://codereview.chromium.org/2377543002
Cr-Commit-Position: refs/heads/master@{#421121}

Review-Url: https://codereview.chromium.org/2370053003
Cr-Commit-Position: refs/heads/master@{#421120}

<style no-process> was added in crrev.com/391871 as a temporary measure
to allow native custom properties to be used without being overridden by
Polymer's shim.

All Polymer pages now use native custom properties, so this bypass is no
longer necessary. This CL removes it from our Polymer checkout and the
MD History/Downloads pages, with no visible changes as a result.

BUG=608098
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370653002
Cr-Commit-Position: refs/heads/master@{#421119}

Adds flag to turn on per thread heap on DedicatedWorkers. Add tests so both per thread haep enable and disabled are tested.

BUG=591606

Review-Url: https://codereview.chromium.org/2335063003
Cr-Commit-Position: refs/heads/master@{#421118}

More precisely, reads the last N lines preceding the microdump, if any,
since any lines that follow the microdump are most likely not relevant to
the crash.

BUG=641655
R=gayane@chromium.org

Review-Url: https://codereview.chromium.org/2282173003
Cr-Commit-Position: refs/heads/master@{#421117}

BUG=527304

Review-Url: https://codereview.chromium.org/2276933003
Cr-Commit-Position: refs/heads/master@{#421116}

The spec has been updated to properly define a constructor for
USBConnectionEvent. This patch updates Blink's version of the IDL to
match.

Review-Url: https://codereview.chromium.org/2348703003
Cr-Commit-Position: refs/heads/master@{#421115}