- 05 Apr, 2011 40 commits
-
-
commit-queue@webkit.org authored
Reviewed by David Levin. Added MediaTypeFile enum value to WebContextMenuData::MediaType. https://bugs.webkit.org/show_bug.cgi?id=57566 * public/WebContextMenuData.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82976 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tony@chromium.org authored
Unreviewed, removing the chromium-win results causes this test to start passing on chromium win and linux. * platform/chromium-win/fast/images/svg-as-tiled-background-expected.checksum: Removed. * platform/chromium-win/fast/images/svg-as-tiled-background-expected.png: Removed. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82975 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dino@apple.com authored
Reviewed by Simon Fraser. Add parentheses around && within || to avoid clang warning. * WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): git-svn-id: svn://svn.chromium.org/blink/trunk@82974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
Reviewed by Adam Roben. Add two more entries to the sandbox profile https://bugs.webkit.org/show_bug.cgi?id=57875 Allow read-access to /Library/Dictionaries since WebCore::nextBreakablePosition ends up calling into ICU which accesses the dictionary. Allow Mach access to com.apple.networkd since it's used by CFNetwork. * WebProcess/com.apple.WebProcess.sb: git-svn-id: svn://svn.chromium.org/blink/trunk@82973 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mihaip@chromium.org authored
Reviewed by Tony Chang. Add --baseline-search-path to NRWT https://bugs.webkit.org/show_bug.cgi?id=56233 Add NRWT option to specify additional directories to look for baselines (will be used by hardware GPU bots which will have local per-bot expectations for some tests) * Scripts/webkitpy/common/system/filesystem_mock.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: git-svn-id: svn://svn.chromium.org/blink/trunk@82972 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Make caches window show more info about non-jsobject GC values https://bugs.webkit.org/show_bug.cgi?id=57874 Add ClassInfo to the various internal JS types that currently don't have any, and make the text for caches window show the classname for non-JSObject instances. * runtime/Executable.cpp: * runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::createStructure): (JSC::NativeExecutable::NativeExecutable): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure): * runtime/Heap.cpp: (JSC::TypeCounter::typeName): * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): * runtime/JSGlobalData.h: * runtime/ScopeChain.cpp: * runtime/ScopeChain.h: (JSC::ScopeChainNode::createStructure): * runtime/StructureChain.cpp: * runtime/StructureChain.h: (JSC::StructureChain::createStructure): git-svn-id: svn://svn.chromium.org/blink/trunk@82971 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
Reviewed by Oliver Hunt. Invalidate callbacks if the WebPageProxy is no longer valid https://bugs.webkit.org/show_bug.cgi?id=57873 <rdar://problem/9059717> Audit all function calls that take callbacks and make sure to invalidate the callbacks if the web page is no longer valid. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptInMainFrame): (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): (WebKit::WebPageProxy::getSourceForFrame): (WebKit::WebPageProxy::getContentsAsString): (WebKit::WebPageProxy::getSelectionOrContentsAsString): (WebKit::WebPageProxy::getMainResourceDataOfFrame): (WebKit::WebPageProxy::getResourceDataFromFrame): (WebKit::WebPageProxy::getWebArchiveOfFrame): (WebKit::WebPageProxy::forceRepaint): (WebKit::WebPageProxy::computePagesForPrinting): (WebKit::WebPageProxy::drawRectToPDF): (WebKit::WebPageProxy::drawPagesToPDF): git-svn-id: svn://svn.chromium.org/blink/trunk@82970 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Adele Peterson. Add a fast path for simple color backgrounds https://bugs.webkit.org/show_bug.cgi?id=57773 Add a fast path for drawing simple color backgrounds. It's faster to fill a path or rect than it is to set up a clip, and then paint the rect. No visible behavior change so no new tests. * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): git-svn-id: svn://svn.chromium.org/blink/trunk@82969 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
paroga@webkit.org authored
Unreviewed EFL build fix for r82962. * CMakeListsEfl.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82968 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html files, rather than pointing to the directory that contains them. This is more convenient for people browsing build.webkit.org, but confused Leaks Viewer. Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds list don't work Reviewed by Joseph Pecoraro. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL. git-svn-id: svn://svn.chromium.org/blink/trunk@82967 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
This includes machines without the necessary graphics hardware, and machines without WebKitQuartzCoreAdditions (like the Windows 7 Release (WebKit2 Tests) bots). Fixes <http://webkit.org/b/57870> REGRESSION (r82960): Lots of tests crashing in DrawingAreaImpl::enterAcceleratedCompositingMode on Windows 7 Release (WebKit2 Tests) Reviewed by Anders Carlsson. * WebProcess/WebPage/LayerTreeHost.h: (WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. On platforms other than Windows, this always returns true. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Only enable accelerated compositing-related preferences if the machine supports accelerated compositing. * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp: (WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Added. Creates a view, asks it if it can draw, and returns the result. * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added supportsAcceleratedCompositing. * WebProcess/WebPage/win/LayerTreeHostWin.cpp: Added. (WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. Calls through to LayerTreeHostCAWin in configurations that support that class. Otherwise just returns false. * win/WebKit2.vcproj: Added LayerTreeHostWin.cpp. Let VS reorder some other files. git-svn-id: svn://svn.chromium.org/blink/trunk@82966 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
Reviewed by Jian Li. [chromium] send-sliced-dragged-file.html started to crash on chromium bots https://bugs.webkit.org/show_bug.cgi?id=57539 * platform/chromium/test_expectations.txt: Removed passing test as it has been fixed in the chromium network stack as of chromium r80114 and it was introduced in r79905 so no need to change the chromium deps since it is before the regression. git-svn-id: svn://svn.chromium.org/blink/trunk@82965 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, mark unexpectedly passing Linux Chromium tests as such. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82964 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
crogers@google.com authored
Reviewed by Kenneth Russell. Add support for offline audio rendering to AudioContext API https://bugs.webkit.org/show_bug.cgi?id=57676 No new tests since audio API is not yet implemented. * DerivedSources.make: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): * bindings/js/JSEventCustom.cpp: (WebCore::toJS): * bindings/js/JSEventTarget.cpp: (WebCore::toJS): * bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object): * bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::constructorCallback): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): * dom/Event.cpp: (WebCore::Event::isOfflineAudioCompletionEvent): * dom/Event.h: * dom/EventTarget.cpp: (WebCore::EventTarget::toAudioContext): * dom/EventTarget.h: * platform/audio/HRTFDatabaseLoader.cpp: (WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion): * platform/audio/HRTFDatabaseLoader.h: (WebCore::HRTFDatabaseLoader::loader): * webaudio/AudioContext.cpp: (WebCore::AudioContext::createOfflineContext): (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::constructCommon): (WebCore::AudioContext::document): (WebCore::AudioContext::scriptExecutionContext): (WebCore::AudioContext::toAudioContext): (WebCore::AudioContext::startRendering): (WebCore::AudioContext::fireCompletionEvent): * webaudio/AudioContext.h: (WebCore::AudioContext::isOfflineContext): (WebCore::AudioContext::eventTargetData): (WebCore::AudioContext::ensureEventTargetData): (WebCore::AudioContext::refEventTarget): (WebCore::AudioContext::derefEventTarget): * webaudio/AudioContext.idl: * webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::AudioDestinationNode): * webaudio/AudioDestinationNode.h: (WebCore::AudioDestinationNode::reset): (WebCore::AudioDestinationNode::numberOfChannels): * webaudio/ConvolverNode.cpp: (WebCore::ConvolverNode::setBuffer): * webaudio/DefaultAudioDestinationNode.cpp: Added. (WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode): (WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode): (WebCore::DefaultAudioDestinationNode::initialize): (WebCore::DefaultAudioDestinationNode::uninitialize): (WebCore::DefaultAudioDestinationNode::startRendering): * webaudio/DefaultAudioDestinationNode.h: Added. (WebCore::DefaultAudioDestinationNode::create): (WebCore::DefaultAudioDestinationNode::sampleRate): * webaudio/OfflineAudioCompletionEvent.cpp: Added. (WebCore::OfflineAudioCompletionEvent::create): (WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent): (WebCore::OfflineAudioCompletionEvent::~OfflineAudioCompletionEvent): (WebCore::OfflineAudioCompletionEvent::isOfflineAudioCompletionEvent): * webaudio/OfflineAudioCompletionEvent.h: Added. (WebCore::OfflineAudioCompletionEvent::renderedBuffer): * webaudio/OfflineAudioCompletionEvent.idl: Added. * webaudio/OfflineAudioDestinationNode.cpp: Added. (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode): (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode): (WebCore::OfflineAudioDestinationNode::initialize): (WebCore::OfflineAudioDestinationNode::uninitialize): (WebCore::OfflineAudioDestinationNode::startRendering): (WebCore::OfflineAudioDestinationNode::renderEntry): (WebCore::OfflineAudioDestinationNode::render): (WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch): (WebCore::OfflineAudioDestinationNode::notifyComplete): * webaudio/OfflineAudioDestinationNode.h: Added. (WebCore::OfflineAudioDestinationNode::create): (WebCore::OfflineAudioDestinationNode::sampleRate): git-svn-id: svn://svn.chromium.org/blink/trunk@82963 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Reviewed by Eric Seidel. [Cairo] Better separate the concerns of GraphicsContextCairo https://bugs.webkit.org/show_bug.cgi?id=55150 Add a PlatformContextCairo which right now stores the cairo_t* for a GraphicsContextCairo. Later patches will move logic for tracking ContextShadow and image masking layers into this PlatformContextCairo class. No new tests. This patch is only a code cleanup. * GNUmakefile.am: * platform/graphics/GraphicsContext.h: The platform context is no longer a cairo_t, but our new class the PlatformContextCairo. * platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j * platform/graphics/cairo/FontCairo.cpp: Ditto. * platform/graphics/cairo/GradientCairo.cpp: Ditto. * platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical changes which now reference platformContext()->cr() to get the cairo_t. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the PlatformContextCairo instead of the cairo_t. * platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class. * platform/graphics/cairo/ImageCairo.cpp: Ditto. * platform/graphics/cairo/PathCairo.cpp: Ditto. * platform/graphics/cairo/PlatformContextCairo.cpp: Added. * platform/graphics/cairo/PlatformContextCairo.h: Added. * platform/graphics/gtk/FontGtk.cpp: Update to reflect new class. * platform/graphics/gtk/IconGtk.cpp: Ditto. * platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out m_data with a private section containing the platform context instead of just a cairo_t. * platform/gtk/RenderThemeGtk.cpp: Update to reflect new class. * platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto. * plugins/gtk/PluginViewGtk.cpp: Ditto. 2011-04-05 Martin Robinson <mrobinson@igalia.com> Reviewed by Eric Seidel. [Cairo] Better separate the concerns of GraphicsContextCairo https://bugs.webkit.org/show_bug.cgi?id=55150 Add a PlatformContextCairo which right now stores the cairo_t* for a GraphicsContextCairo. Later patches will move logic for tracking ContextShadow and image masking layers into this PlatformContextCairo class. * webkit/webkitwebframe.cpp: (draw_page_callback): * webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw): 2011-04-05 Martin Robinson <mrobinson@igalia.com> Reviewed by Eric Seidel. [Cairo] Better separate the concerns of GraphicsContextCairo https://bugs.webkit.org/show_bug.cgi?id=55150 * WebFrame.cpp: (hdcFromContext): Modify this method to take PlatformContextCairo instead of a cairo_t. (WebFrame::spoolPage): Update to reflect new platform context. (WebFrame::spoolPages): Ditto. * WebFrame.h: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@82962 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, mark some unexpectedly passing Chromium tests as such. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82961 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
LayerTreeHostCAWin uses WKCACFView to render each frame to an image, then has DrawingAreaImpl send that image over to the UI process (just like it does for non-accelerated rendering). It's unfortunate that this requires reading every frame back from the GPU into system memory. More efficient solutions can be explored in the future. Fixes <http://webkit.org/b/45567>. Reviewed by Anders Carlsson. * DerivedSources.make: Added $(WebKit2) to the VPATH so that DerivedSources.make can be found when used as a target dependency. Added rules to generate a HeaderDetection.h file on Windows. If we can find WebKitQuartzCoreAdditions headers, we define HAVE_WKQCA in HeaderDetection.h. * WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setLayerHostNeedsDisplay): * WebProcess/WebPage/DrawingAreaImpl.h: Added setLayerHostNeedsDisplay. Lets the layer host tell the DrawingAreaImpl that it has a new frame to render. This should only be called by layer hosts that participate in DrawingAreaImpl's display mechanism. * WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): Only try to instantiate LayerTreeHostCAWin if we have WebKitQuartzCoreAdditions, since it depends on that library. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Removed code that forced accelerated compositing to be disabled on Windows. * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp: (WebKit::registerDummyWindowClass): Registers the window class we use for the dummy window. (WebKit::createDummyWindow): Creates the dummy window we pass to WKCACFView so that D3D can determine the display mode, etc. (The window is never shown on screen.) (WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Initialize new members. (WebKit::LayerTreeHostCAWin::platformInitialize): Create our dummy window and view and associate the two. We set ourselves as the view's context's user data so that PlatformCALayer can get our AbstractCACFLayerTreeHost pointer as needed. (WebKit::LayerTreeHostCAWin::invalidate): Cancel any pending flushes, tear down our view, and destroy the dummy window if no other layer host is using it. (WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Ask LayerChangesFlusher to call us back soon to perform the flush. (WebKit::LayerTreeHostCAWin::participatesInDisplay): Added. Returns true, since we render each frame to an image. (WebKit::LayerTreeHostCAWin::needsDisplay): Added. Returns true if it's now time to displayReturns true if it's now time to display. (WebKit::LayerTreeHostCAWin::timeUntilNextDisplay): Added. Returns how many seconds remain before we need to display again. (WebKit::size): Added. Helper function to get the size of a WKCACFImage. (WebKit::toShareableBitmap): Added. Helper function to convert a WKCACFImage to a ShareableBitmap. (WebKit::LayerTreeHostCAWin::display): Added. Renders the next frame to an image and stuffs the image into the UpdateInfo struct. (WebKit::LayerTreeHostCAWin::sizeDidChange): Added. Tells the view about the new size. (WebKit::LayerTreeHostCAWin::forceRepaint): Added. Flushes any pending changes to the view. (WebKit::LayerTreeHostCAWin::contextDidChangeCallback): Added. WKCACFView calls this whenever any changes made to the view or its layer tree have been flushed. Just calls through to contextDidChange. (WebKit::LayerTreeHostCAWin::contextDidChange): Added. Tells layers that they've started animating, and tells the DrawingAreaImpl that we need to display again. (WebKit::LayerTreeHostCAWin::rootLayer): Added. Gets the root layer's PlatformCALayer. (WebKit::LayerTreeHostCAWin::addPendingAnimatedLayer): Added. Stores the layer so that we can tell it animations have started the next time we get a contextDidChange callback. (WebKit::LayerTreeHostCAWin::layerTreeDidChange): Added. Schedules a flush, unless we're already in the process of flushing. This code came from WebCore::WKCACFViewLayerTreeHost. (WebKit::LayerTreeHostCAWin::flushPendingLayerChangesNow): Added. Performs the flush. This code was adapted from WebCore::WKCACFViewLayerTreeHost. * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Wrapped this whole header in HAVE(WKQCA), since this class only works when WebKitQuartzCoreAdditions is available. Added a bunch of new members. git-svn-id: svn://svn.chromium.org/blink/trunk@82960 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
When LayerTreeHost participates in display, it renders each frame into a bitmap. DrawingAreaImpl sends the bitmap to the UI process in an Update message, just like in non-accelerated compositing mode. The UI process never knows that accelerated compositing is going on. (When LayerTreeHost does not participate in display, as on Mac, it is responsible for getting bits from the web process to the UI process.) No LayerTreeHost uses this mechanism (yet). This patch should cause no change in behavior. Fixes <http://webkit.org/b/57792> LayerTreeHost needs a way to render frames to a bitmap Reviewed by Anders Carlsson. * WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint): If the layer tree host participates in display, perform a display (like in the non-accelerated case). (WebKit::DrawingAreaImpl::layerHostDidFlushLayers): Don't send an EnterAcceleratedCompositing message to the UI process if the layer tree host participates in display. In that case, the UI process doesn't even need to know we're using accelerated compositing in the web process. (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Go through the normal display mechanism if we have a layer tree host that participates in display. (WebKit::DrawingAreaImpl::didUpdate): Don't ignore DidUpdate messages when we have a layer tree host that participates in display. (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): If the new layer tree host participates in display, let the display timer continue to run and continue to expect DidUpdate messages so that we don't interrupt the normal display mechanism. We still clear out m_dirtyRegion, m_scrollRect, and m_scrollOffset, though, because the layer tree host is still responsible for keeping track of those things even when it participates in display. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): If the outgoing layer tree host was participating in display, just send another Update message instead of an ExitAcceleratedCompositing message, since the UI process never even knew we were using accelerated compositing. (WebKit::DrawingAreaImpl::displayTimerFired): If we have a layer tree host that's participating in display, ask it when it next needs to display when scheduling our timer. (WebKit::DrawingAreaImpl::scheduleDisplay): (WebKit::DrawingAreaImpl::display): If we have a layer tree host that's participating in display, it will keep track of its own dirty region, so ask it if it needs display rather than checking our own dirty region. (WebKit::DrawingAreaImpl::display): If we have a layer tree host that's participating in display, don't bail out. Instead, tell it to display rather than asking the page to paint. Moved the setting of updateInfo.viewSize earlier so that it will be set even when the layer tree host is displaying. Other changes are just due to indentation. * WebProcess/WebPage/LayerTreeHost.h: (WebKit::LayerTreeHost::participatesInDisplay): (WebKit::LayerTreeHost::needsDisplay): (WebKit::LayerTreeHost::timeUntilNextDisplay): (WebKit::LayerTreeHost::display): Stubbed out these functions. Derived classes can override them to participate in display. git-svn-id: svn://svn.chromium.org/blink/trunk@82959 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
carol@webkit.org authored
Updated my info in committers.py Scripts\webkitpy\common\config\committers.py git-svn-id: svn://svn.chromium.org/blink/trunk@82958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
carol@webkit.org authored
Updated my info in committers.py Scripts\webkitpy\common\config\committers.py git-svn-id: svn://svn.chromium.org/blink/trunk@82957 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by David Levin. Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING) https://bugs.webkit.org/show_bug.cgi?id=57400 Check whether the full screen renderer layer is being composited by the GPU before assuming that the backing is valid. Accelerated compositing may be compiled in but disabled at runtime or for some elements. Tests: Fullscreen layout tests on Chromium. * dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): (WebCore::Document::webkitDidEnterFullScreenForElement): (WebCore::Document::webkitWillExitFullScreenForElement): git-svn-id: svn://svn.chromium.org/blink/trunk@82956 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, temporarily suppress Chromium failures for tests in r82947. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82955 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Unreviewed. Add Web Inspector stack trace, pause on exception and window.onerror screenshots. * blog-files/inspector/stack-traces-img/1.png: Added. * blog-files/inspector/stack-traces-img/2.png: Added. * blog-files/inspector/stack-traces-img/3.png: Added. * blog-files/inspector/stack-traces-img/4.png: Added. * blog-files/inspector/stack-traces-img/5.png: Added. * blog-files/inspector/stack-traces-img/6.png: Added. * blog-files/inspector/stack-traces-img/button.png: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@82954 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zimmermann@webkit.org authored
Reviewed by Dirk Schulze. Regression: Invalid write in SVGTextLayoutEngine https://bugs.webkit.org/show_bug.cgi?id=57721 * svg/text/font-size-null-assertion-expected.txt: Added. * svg/text/font-size-null-assertion.svg: Added. 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Dirk Schulze. Regression: Invalid write in SVGTextLayoutEngine https://bugs.webkit.org/show_bug.cgi?id=57721 Properly stop layout if all metrics object refer to zero-width/height characters, which can happen for instance when using <text font-size="0">. Test: svg/text/font-size-null-assertion.svg * rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes): (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics): git-svn-id: svn://svn.chromium.org/blink/trunk@82953 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@google.com authored
Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult. This change also added TextCheckerClient::requestCheckingOfString() should have TextCheckingTypeMask as a parameter to control text checking type. * WebCore.exp.in: * editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges() * editing/SpellChecker.cpp: (WebCore::SpellChecker::requestCheckingFor): Added a parameter. (WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object. (WebCore::SpellChecker::didCheck): * editing/SpellChecker.h: * loader/EmptyClients.h: (WebCore::EmptyTextCheckerClient::checkTextOfParagraph): (WebCore::EmptyTextCheckerClient::requestCheckingOfString): * platform/text/TextCheckerClient.h: 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 Followed the signature change. * src/EditorClientImpl.h: * src/EditorClientImpl.cpp: * src/WebTextCheckingCompletionImpl.cpp 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebCoreSupport/TextCheckerClientEnchant.h: (WebKit::TextCheckerClientEnchant::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method. for requestCheckingOfString method. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (toCoreTextCheckingResults): (WebEditorClient::checkTextOfParagraph): (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]): (-[WebEditorSpellCheckResponder perform]): (WebEditorClient::requestCheckingOfString): * WebView/WebFrame.mm: (-[WebFrame markersForSelectionStartAsText]): * WebView/WebFramePrivate.h: 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClientWinCE::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::requestCheckingOfString): 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult https://bugs.webkit.org/show_bug.cgi?id=56085 * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::requestCheckingOfString): * WebProcess/WebCoreSupport/WebEditorClient.h: * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::checkTextOfParagraph): git-svn-id: svn://svn.chromium.org/blink/trunk@82952 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=57814 Reviewed by Sam Weinig. Don't load resources with Very Low priority until there are no other resources to load for the host (or until document is complete enough that we stop limiting requests). No tests, this is difficult to observe reliably with our current testing infrastructure. Verified working with Wireshark. * loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::servePendingRequests): (WebCore::ResourceLoadScheduler::HostInformation::limitRequests): * loader/ResourceLoadScheduler.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82951 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
steveblock@google.com authored
Reviewed by Dimitri Glazkov. JavaInstance should be a pure interface https://bugs.webkit.org/show_bug.cgi?id=55383 This patch fixes JavaInstance for V8 only. It factors out a JavaInstance interface which does not use JNI types. This will allow the Java bridge to be used with objects that don't use JNI directly. The existing jobject-backed implementation is moved to a new JavaInstanceJobject class which implements the interface. No new tests, refactoring only. * Android.v8bindings.mk: * WebCore.gypi: * bridge/jni/JobjectWrapper.h: * bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::jvalueToJavaValue): (JSC::Bindings::javaValueToJvalue): * bridge/jni/v8/JavaInstanceJobjectV8.cpp: (JavaInstanceJobject::JavaInstanceJobject): (JavaInstanceJobject::~JavaInstanceJobject): (JavaInstanceJobject::begin): (JavaInstanceJobject::end): (JavaInstanceJobject::getClass): (JavaInstanceJobject::invokeMethod): (JavaInstanceJobject::getField): * bridge/jni/v8/JavaInstanceJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaInstanceV8.h. (JSC::Bindings::JavaInstanceJobject::javaInstance): * bridge/jni/v8/JavaInstanceV8.h: (JSC::Bindings::JavaInstance::~JavaInstance): git-svn-id: svn://svn.chromium.org/blink/trunk@82950 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
Reviewed by Darin Adler. Move MouseEvent-dispatching logic into MouseEventDispatchMediator. https://bugs.webkit.org/show_bug.cgi?id=57639 Refactoring, covered by existing tests. * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Moved useful assertion here from dispatchMouseEvent. (WebCore::EventDispatcher::adjustRelatedTarget): Converted into a method. * dom/EventDispatcher.h: Adjusted decls. (WebCore::EventDispatcher::node): Added. * dom/MouseEvent.cpp: (WebCore::MouseEvent::create): Moved useful assertion here from dispatchMouseEvent. (WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator): Added. (WebCore::MouseEventDispatchMediator::event): Added. (WebCore::MouseEventDispatchMediator::dispatchEvent): Added. * dom/MouseEvent.h: (WebCore::MouseEvent::setRelatedTarget): Added. * dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): Changed to use MouseEventDispatchMediator. git-svn-id: svn://svn.chromium.org/blink/trunk@82948 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zimmermann@webkit.org authored
Reviewed by Adam Roben & Dirk Schulze. text-tspan-02-b.svg from SVG 1.1 2nd edition fails https://bugs.webkit.org/show_bug.cgi?id=57831 Add text-tspan-02-b.svg from SVG 1.1 2nd edition, which was buggy. Add reduced testcase, which exposes a bug with midpoint splitting, which is now fixed. * platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added. * platform/mac/svg/text/text-midpoint-split-bug-expected.checksum: Added. * platform/mac/svg/text/text-midpoint-split-bug-expected.png: Added. * platform/mac/svg/text/text-midpoint-split-bug-expected.txt: Added. * svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg: Added. * svg/text/text-midpoint-split-bug.svg: Added. 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Adam Roben & Dirk Schulze. text-tspan-02-b.svg from SVG 1.1 2nd edition fails https://bugs.webkit.org/show_bug.cgi?id=57831 We were not spanning rotation values correcty accross text children, which resulted in text-span-02-b.svg misrendering. While rewriting the rotation specific code, it came apparent that the LayoutScope concept is flawed in general and should be replaced by a global list of x/y/dx/dy/rotate values for the whole text subtree. This makes it much simpler to implement the demand that the last rotation value spans the whole scope. A follow-up patch will optimize the required memory. Example: <text rotate="10,20,999,50">AB<tspan rotate="30">CDE</>FGH</text> text: A B C D E F G H rotate="10 20 30 30 30 50 50 50" Tests: svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg svg/text/text-midpoint-split-bug.svg * rendering/RenderBlockLineLayout.cpp: Move SVG specific midpoint creation after the non-SVG specific code that may mutate the midpoints. otherwhise we end up in an (WebCore::RenderBlock::findNextLineBreak): inconsistent state. We were intereferring with the ignoreSpaces code resulting in wrong truncations - covered by new testcase. * rendering/svg/SVGTextLayoutAttributes.cpp: (WebCore::SVGTextLayoutAttributes::reserveCapacity): Also reserveCapacity for the text metrics list (minor optimization). (WebCore::SVGTextLayoutAttributes::fillWithEmptyValue): Added helper function for use from SVGTextLayoutAttributesBuilder. (WebCore::SVGTextLayoutAttributes::appendEmptyValue): Ditto. (WebCore::safeValueAtPosition): Ditto. (Inline helper) (WebCore::SVGTextLayoutAttributes::appendSingleValueFromAttribute): Ditto. * rendering/svg/SVGTextLayoutAttributes.h: Ditto. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewrite code, see explaination above. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): (WebCore::processRenderSVGInlineText): (WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements): (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForAllCharacters): (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): (WebCore::fillListAtPosition): (WebCore::SVGTextLayoutAttributesBuilder::fillAttributesAtPosition): * rendering/svg/SVGTextLayoutAttributesBuilder.h: (WebCore::SVGTextLayoutAttributesBuilder::TextPosition::TextPosition): git-svn-id: svn://svn.chromium.org/blink/trunk@82947 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
leviw@chromium.org authored
Reviewed by Ryosuke Niwa. DeleteButtonController is given invalid style https://bugs.webkit.org/show_bug.cgi?id=57853 DeleteButtonController was assigned an invalid style that can lead to assertions in debug builds. This matches up the code with its intent. No new tests as this changes nothing on release builds. * editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): git-svn-id: svn://svn.chromium.org/blink/trunk@82946 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
* Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:value:]): git-svn-id: svn://svn.chromium.org/blink/trunk@82945 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Laszlo Gombos. [Qt] EditorQt.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40260 This patch does not require new test cases. * editing/qt/EditorQt.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@82944 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: go to line dialog highlights wrong line. https://bugs.webkit.org/show_bug.cgi?id=57845 * inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine): git-svn-id: svn://svn.chromium.org/blink/trunk@82943 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Implement CSSPropertyDirection in CSSStyleApplyProperty https://bugs.webkit.org/show_bug.cgi?id=57608 No new tests required as no new functionality introduced. * css/CSSStyleApplyProperty.cpp: Add implementation class for CSSPropertyDirection * css/CSSStyleSelector.cpp: Remove existing implementation for CSSPropertyDirection * css/CSSStyleSelector.h: Add getter for element git-svn-id: svn://svn.chromium.org/blink/trunk@82942 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=55755 <rdar://problem/9087969> Unreviewed. Update Qt specific expected results after r82925. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82941 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Steve Block. Factoring the creation of 'FunctionOnly' callbacks in V8. https://bugs.webkit.org/show_bug.cgi?id=57760 This method creates a template from an existing functionality in V8GeolocationCustom.cpp to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API. No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html * bindings/v8/V8Utilities.cpp: (WebCore::throwTypeMismatchException): * bindings/v8/V8Utilities.h: (WebCore::createFunctionOnlyCallback): * bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback): git-svn-id: svn://svn.chromium.org/blink/trunk@82940 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
Reviewed by Laszlo Gombos. [Qt] Make WebKitLibraries optional for building QtWebKit https://bugs.webkit.org/show_bug.cgi?id=57542 * Scripts/build-webkit: git-svn-id: svn://svn.chromium.org/blink/trunk@82939 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Laszlo Gombos. [Qt] MiniBrowser defaultUrl does not work https://bugs.webkit.org/show_bug.cgi?id=57021 Match the behavior and coding of MiniBrowser to QtTestBrowser. * MiniBrowser/qt/main.cpp: (main): git-svn-id: svn://svn.chromium.org/blink/trunk@82938 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chang.shu@nokia.com authored
Unreviewed. Unskip passed tests after bugs 57572, 57568, 42540, 42692 have been resolved. * platform/qt-wk2/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@82937 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alex@webkit.org authored
Another compilation fix after r82929 horrible patch merge. * UIProcess/WebPageProxy.messages.in: git-svn-id: svn://svn.chromium.org/blink/trunk@82936 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-