- 27 Sep, 2018 40 commits
-
-
Sylvain Defresne authored
Change TestingFactories to use base::Callback instead of function pointers to allow removal of the deprecated methods of BCKSF. Bug: 809610 Change-Id: I10cde9d5c7afefe8f9eeb0e018b47bebdd269604 Reviewed-on: https://chromium-review.googlesource.com/1243130 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594675}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e41fbed8adf..95c25ea38fcf Created with: gclient setdep -r src-internal@95c25ea38fcf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3291631a9cf7826e5283250d33983873b60e9fcd Reviewed-on: https://chromium-review.googlesource.com/1248962Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594674}
-
Marina Ciocea authored
This reverts commit d3b31cd0. Reason for revert: Tests are still flaky: https://crbug.com/884589#c40 Sample failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29201 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29202 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29203 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29203 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29208 Original change's description: > Re-enable some previously flaky single_process_mash_browser_tests > > Tests were blacklisted because of flakiness due to crbug.com/884589. Now that it's fixed, renable these tests. > > Bug: 884589 > Change-Id: Idc1b073c7a50636778231177488112f778d649b5 > Reviewed-on: https://chromium-review.googlesource.com/1246954 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ryan Cui <rcui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594499} TBR=sky@chromium.org,rcui@chromium.org Change-Id: I9d2591b7f847270af395765fd0f27b4fd67c8045 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884589 Reviewed-on: https://chromium-review.googlesource.com/1249263Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594673}
-
Daniel Fenner authored
Expand webcam_private api such that we can control auto focus setting ('on' or 'off') and the focus value. The focus value can be read back with the get command. Implemented for Visca and UVC cameras. Bug: 888475 Change-Id: I41ac7c75e4e0893d085b7b1599ead7ffba7b5d26 Reviewed-on: https://chromium-review.googlesource.com/1240281Reviewed-by:Zachary Kuznia <zork@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Daniel Fenner <dfenner@google.com> Cr-Commit-Position: refs/heads/master@{#594672}
-
Hans Wennborg authored
This reverts commit 386fa9a7. Reason for revert: Broke the fuchsia_sdk update step, see bug. Original change's description: > [fuchsia] Reland "Generate BUILD.gn from SDK metadata..." > > Reland of CL https://chromium-review.googlesource.com/c/chromium/src/+/1241842. > (Confirmed that the code builds on Cast builders, and manually examined > all references to targets under //third_party/fuchsia-sdk to verify > that all FIDL targets have been modified to reference the new sdk/ > subdir.) > > This script uses the metadata JSON files in the SDK to generate a > BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is > regenerated whenever a new SDK is downloaded using "gclient sync". > > Only FIDL libraries are migrated for now. Additional metadata types can > be migrated in followup CLs. > > TBR=scottmg@chromium.org > TBR=sky@chromium.org > > Bug: 888753 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I7ec714982cdfbb6f6ccd8fad3cd7cbb48af4eb1c > Reviewed-on: https://chromium-review.googlesource.com/1246681 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594419} TBR=kmarshall@chromium.org Change-Id: I1a89a1c3d8223e6dd58e2a4b23f251eb96a7bba8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888753, 889839 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1249203Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#594671}
-
Hans Wennborg authored
This reverts commit a6be9ec6. Reason for revert: Reverting in order to revert reverse-dependent https://chromium-review.googlesource.com/c/chromium/src/+/1246681 Original change's description: > [Fuchsia] Remove namespace_path parameter from FIDL targets > > GN now supports string_replace(), which allows to remove namespace_path > > TBR=dcheng@chromium.org (trivial change in //base) > > Change-Id: Iac8a71b6962cf48bc7a79e2f7fc62a88969f80a1 > Reviewed-on: https://chromium-review.googlesource.com/1246834 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594473} TBR=kmarshall@chromium.org,sergeyu@chromium.org Change-Id: Ibc138775c8b32a5d2d421a39ff4fe7ef7709826a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1249262Reviewed-by:
-
Oskar Sundbom authored
When using APM in Audio Service, the output device for a microphone with native echo cancellation support may be set before the stream has started. Currently, this causes the audio unit to be restarted, even when it shouldn't. This CL avoids that. Bug: 882420, b/115305826 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6c25e8225f918dd4da2e4e0637e4808e03acf125 Reviewed-on: https://chromium-review.googlesource.com/1243067Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594669}
-
Denis Kuznetsov authored
Bug: 854101 Change-Id: I8c08f755f36f6b8ddddac6018aae8c9c022ee66a Reviewed-on: https://chromium-review.googlesource.com/1228202 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#594668}
-
Takashi Toyoshima authored
CompleteInitialization can be posted at a place after DeleteSoon's task, and it can potentially cause a UAF crash. This happens only on browser's shutdown sequence, and it won't practically. But just in case and to make ASAN bots happy:) Bug: 880665, 672793 Change-Id: I8435290b4df7068d456368624935d3007a2c52d7 Reviewed-on: https://chromium-review.googlesource.com/1238297 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#594667}
-
A Olsen authored
chrome_user_manager_util is a static helper class that mostly helps implement ChromeUserManagerImpl and FakeChromeUserManager. A few other classes also call it directly. The different functions in it make use of four different global singletons - 1. chromeos::LoginState::Get() 2. user_manager::UserManager::Get() 3. g_browser_process->platform_part() ->browser_policy_connector_chromeos() ->GetMinimumVersionPolicyHandler() 4. g_browser_process->platform_part() ->browser_policy_connector_chromeos() ->GetDeviceLocalAccountPolicyService() This changes moves most of the code out of chrome_user_manager_util, and makes sure that the remaining code doesn't depend on these singletons. This is done as follows: 1. Code common to ChromeUserManagerImpl and FakeChromeUserManager now goes in ChromeUserManager. 2. Code only used by ChromeUserManagerImpl is now there. 3. Direct calls to chrome_user_manager_util by GaiaScreenHandler or SigninScreenHandler are now replaced by the equivalent calls to the ChromeUserManager singleton 4. The only code which remains is the completely static function IsUserAllowed - only contains logic, not state, since all policy data is passed in - and a variant which takes the policy data as a ChromeDeviceSettingsProto. (This variant is still called directly from DeviceOffHoursController.) The previous design - static functions with dependencies on global singletons - had some disadvantages, which this CL tries to address: 1. Unwanted dependencies on g_browser_process in chromeos code - removing these is part of http://crbug.com/446937 2. Static cling - go/staticcling - it is harder to setup tests for static utilities if they depend on global singletons. 3. Strange dependency cycles. When calling IsUserAllowed on a ChromeUserManager, it delegated to chrome_user_manager_util, which calls user_manager::UserManager::Get(), which could be a different ChromeUserManager, or not be initialized. This also makes tests harder to set up. Now, all the code is part of the one ChromeUserManager instance. Bug: 446937 Change-Id: Ifb6c7aa5bf7081b4c6dd9f5f4043a07d51c79a96 Reviewed-on: https://chromium-review.googlesource.com/1243074 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594666}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 607ea4c4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25386 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I6c14ad485fc4b071f1946082a63122ce8cff39fe Reviewed-on: https://chromium-review.googlesource.com/1248137 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594665}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2cefe906..c9fae1c2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28468148f8617da7fe242a8c4dd690470563817e Reviewed-on: https://chromium-review.googlesource.com/1248841Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594664}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3cf15a9b47a0..ba7382c58459 git log 3cf15a9b47a0..ba7382c58459 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 anthonyalridge@google.com Add title attribute to provide stack name on mouseover. Created with: gclient setdep -r src/third_party/catapult@ba7382c58459 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ibaa88606b833444bc6d6a1320b53eb6c1f3527bc Reviewed-on: https://chromium-review.googlesource.com/1248961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594663}
-
Alan Cutter authored
In hosted app windows extension browser action icons may exceed the vertical size of the menu button causing the title bar to increase in size when shown. This CL fixes the title bar height to ignore hosted app buttons other than the menu button to ensure title bar height consistency. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359771&signed_aid=KtAw0K1pvNkili8_InVRHg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359772&signed_aid=BomSSrucsiT4t0Ixn8hGdw==&inline=1 Bug: 885011 Change-Id: Iedcc6eeaaff649d106e5cd1e1c7be1cfe13047ef Reviewed-on: https://chromium-review.googlesource.com/1242584 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#594662}
-
Marina Ciocea authored
Tests disabled: WebstoreInlineInstallerTest.ReinstallDisabledExtension WebstoreInlineInstallerListenerTest.BothListenersTest TBR=rdevlin.cronin@chromium.org Bug: 889804 Change-Id: Iecccc27a4540685099e895aa71f3504e91978ef3 Reviewed-on: https://chromium-review.googlesource.com/1249121 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d8f3c17e8da2..02fed02c00e5 git log d8f3c17e8da2..02fed02c00e5 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 ssilkin@webrtc.org Assign spatial_idx in FrameStatistics ctor. Created with: gclient setdep -r src/third_party/webrtc@02fed02c00e5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1c71943cf165b1bc495707522564adb01a60dfb Reviewed-on: https://chromium-review.googlesource.com/1248862Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL: OnSyncStopping assumed that the process is already tracking the metadata which isn't necessarily true. The only guarantees is that the model has been loaded. After this CL: we relax the guarantees in OnSyncStopping and it requires only the model to be loaded Bug: 516866 Change-Id: I4dc94c8e0f24dbb73239f1903693eceb5765fab2 Reviewed-on: https://chromium-review.googlesource.com/1243118 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594659}
-
Matthew Cary authored
This adds dexlayout to the build system. The dexlayout binary is from a host build of ART (the Android RunTime) and will be populated by .DEPS. Bug: 875276 Change-Id: I1931bb2effe893b9e7962777b5e776e6e2490e8b Reviewed-on: https://chromium-review.googlesource.com/1199583Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#594658}
-
Noel Gordon authored
Add a test.util.async.deepExecuteScriptInWebView API, which can inject script into the first child <webview> of a Files App (or other) window using a CSS selector. Note the <webview> can be in shadow DOM. Use the new API to test scrolling the QuickView <webview>. The Closure compiler notices the executeScript() call: add new build dependency to teach Closure about the WebView type (externs:webview_tag). Remove the externs_list rule, externs:webview_tag provides the same files. Test: browser_tests --gtest_filter="QuickView*openQuickViewScrollText" Bug: 883117 Change-Id: I494147d1f3911dd0de62a52f1e7ae5e8a726fee6 Reviewed-on: https://chromium-review.googlesource.com/1245001Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594657}
-
Mirko Bonadei authored
The build target //webrtc/system_wrappers:field_trial_default is deprecated. WebRTC will always link the default field_trial implementation unless rtc_exclude_field_trial_default is true. The default value of rtc_exclude_field_trial_default keeps Chromium needs into account (see [1]). [1] - https://cs.chromium.org/chromium/src/third_party/webrtc/webrtc.gni?l=44-51&rcl=95c56eebe0a2b31ad5752138d15b431124e17d36 Bug: webrtc:9631 Change-Id: Ie603530c8bb3b10b3fcbee47398dc69085e5f1e8 Reviewed-on: https://chromium-review.googlesource.com/1226143 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59d6ace5cb99..0d9930ffe556 git log 59d6ace5cb99..0d9930ffe556 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 hjd@google.com Merge "perfetto-ui: Move Dingus to own repo" Created with: gclient setdep -r src/third_party/perfetto@0d9930ffe556 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibb8db10f7af64b618731eed0066b5063e6762f81 Reviewed-on: https://chromium-review.googlesource.com/1248861Reviewed-by:
-
Mark Cogan authored
This CL removes the IsRefreshInfobarEnabled() flag function and refactors code around its use. Bug: 884722 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I90dea9cf5e196f455eda1fe516140daa8ad68a8c Reviewed-on: https://chromium-review.googlesource.com/1245366 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#594654}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03de943cb030..5e41fbed8adf Created with: gclient setdep -r src-internal@5e41fbed8adf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3065e70a9f1fd53209ee89e3a4b434122400fe67 Reviewed-on: https://chromium-review.googlesource.com/1248176Reviewed-by:
-
Camillo Bruni authored
Bug: 878390 Change-Id: Ida4352f5409bfed8dcdbe9a8cabd22014284c981 Reviewed-on: https://chromium-review.googlesource.com/1219689 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#594652}
-
Juan Antonio Navarro Pérez authored
This reverts commit 8bf0d21e. Reason for revert: Test should be fixed now. Original change's description: > [tools/perf] Disable flaky power.typical_10_mobile story > > TBR=perezju@chromium.org > > Bug: 887546 > Change-Id: Ia96997eb631402aab7f5fe1ad4ede733d383969d > Reviewed-on: https://chromium-review.googlesource.com/1236278 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592869} TBR=pasko@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 887546 Change-Id: I07854cdd3517066f30b8e4de8018ce65c8494af9 Reviewed-on: https://chromium-review.googlesource.com/1248701Reviewed-by:
-
Keishi Hattori authored
DEFINE_STATIC_LOCAL automatically created Persistents for garbage collected objects. This CL removes that behavior. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If1d9ea40b0584b4266312c1b5ba5d9133a143f2b Reviewed-on: https://chromium-review.googlesource.com/1245862 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594650}
-
Ernest Galbrun authored
Refactored the available_script filtering: we now express it as a precondition on the ScriptStatus for the current script. I made this precondition a default precondition only when there is no existing ScriptStatusMatch explicitly set, so it is now possible to run a script twice. Change-Id: I2ceb87f62b18dfdb455c9fff2f883000da918848 Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1224553 Commit-Queue: Ernest Galbrun <galbrun@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594649}
-
Oskar Sundbom authored
The render delay is calculated backwards, making it negative. The time we're comparing with is in the future, not the past. Bug: 889494 Change-Id: I3aa8b64096caa9ad5feadcafc1df5bca8e035750 Reviewed-on: https://chromium-review.googlesource.com/1246163Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594648}
-
Marina Ciocea authored
TBR=jdufault@chromium.org Bug: 889782 Change-Id: I6be17af18c5dc92c3c8ed53b02357a8a9bf8ea3a Reviewed-on: https://chromium-review.googlesource.com/1248781 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
Mikel Astiz authored
SyncableServices don't actually consume this field, the only caller to GetId() being GenericChangeProcessor. Changing the API towards SyncableServices would require a huge refactoring, so let's instead allow that SyncData may not be populated, and DCHECK-fail lazily on read (in case a SyncableService implementation is changed in the future to consume this field). The rationale behind is that future patches will integrate SyncableService instantes within the USS framework, where the ID doesn't have any semantics. As implementation detail: because local vs remote was previously implemented verifying id_ != kInvalidId, we need to instead introduce a dedicated bool member. Bug: 870624 Change-Id: I75aa92e69a861ea6af58327a14406bc086233043 Reviewed-on: https://chromium-review.googlesource.com/1205393 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594646}
-
Stefan Teodorescu authored
Add a first metric to the chrome://management page which counts how many times the page is accessed Bug: 879146 Change-Id: I42be7a314ebffb295069e44735913f49376edda3 Reviewed-on: https://chromium-review.googlesource.com/1243484 Commit-Queue: Stefan Teodorescu <fane@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#594645}
-
Koji Ishii authored
Following bot results are included. 10004 10005 10015 10018 10020 10029 10035 10039 10041 10046 10052 10054 10059 10062 10072 10074 10076 10084 10088 18 lines were removed and 5 lines were deflaked by consecutive results since 10039. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3ded830a7de56e3c4063999e46e0b97b4a974b50 Reviewed-on: https://chromium-review.googlesource.com/1242586 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594644}
-
Ramin Halavati authored
Checks if an extension with access to history API and incognito mode can modify regular mode history if it is used from incognito. Bug: 862075 Change-Id: I4964ff94db19cdacdbfd3e57e8414b95f837519f Reviewed-on: https://chromium-review.googlesource.com/1188564 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594643}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4c562dc..2cefe906 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If359b9c300d5865ff86df5c630bb1d314ee72793 Reviewed-on: https://chromium-review.googlesource.com/1248135Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca716904bcfb..03de943cb030 Created with: gclient setdep -r src-internal@03de943cb030 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I34cfb3850f3eaf4f16e14387db7915603219445c Reviewed-on: https://chromium-review.googlesource.com/1248173Reviewed-by:
-
François Beaufort authored
This CL makes sure DetectedFace interface is serializable so that DetectedFace can easily be transfered from workers. Change-Id: I7477a6882775d576677ce955c987667c7a663341 Reviewed-on: https://chromium-review.googlesource.com/1246522Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#594640}
-
Daniel Bratell authored
Noticed because RemoteTestServer refers to BaseServer which is not included in ios builds. Change-Id: I006a32ca751dd8d9e3c3d6be6ece93f30e0bc992 Reviewed-on: https://chromium-review.googlesource.com/1244841 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#594639}
-
Miguel Casas-Sanchez authored
This CL removes the class DecompressDestroyer in favour of a unique_ptr<> with specific Deleter. Less lines of code. Functionality covered by gfx_unittest, also under asan bot. Bug: 868400 Change-Id: I7ac2d254d6f5771a81620b14db7e610ff3b7e4b9 Reviewed-on: https://chromium-review.googlesource.com/1245467 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594638}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/10eb5745824a..d8f3c17e8da2 git log 10eb5745824a..d8f3c17e8da2 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 phoglund@webrtc.org Added test dependency factory. Created with: gclient setdep -r src/third_party/webrtc@d8f3c17e8da2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/113654555 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8a522176c32238863744c166a7f29309b9ab79a2 Reviewed-on: https://chromium-review.googlesource.com/1248174Reviewed-by:
-
Yoshifumi Inoue authored
This patch adds |DCHECK()| to narrow down the case of returning null from |Position::ComputeContainerNode()| for helping to search the root cause of the bug[1] caused by |ComputeContainerNode()| returning null for non-null position. This patch also changes tests using before/after position of shadow root. Node: document and document fragment, including shadow root, can not be an anchor node of before/after position, since these position can not be represent by RangeBoundaryPoint == container node with offset of child. [1] https://crbug.com/882592 SelectionEditor should not call Node::ContainsIncludingHostElements() with null Bug: 882592, 889737 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9c7b0c8ad1c97d20a9080aa9baddea69faf805c5 Reviewed-on: https://chromium-review.googlesource.com/1248361Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594636}
-
