- 22 Jun, 2020 40 commits
-
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. TBR=kenrb Bug: 1031540 Change-Id: Ifbee7d4d7a4f1e226ada4d3cff0f5220c51cd4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254604 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#780737}
-
Ewann authored
This CL rephrases strings related to Chrome Guard. Bug: 1063824 Change-Id: I7ac2525015e754fb169c4923dd81c50996aa8d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252341Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#780736}
-
Jan Wilken Dörrie authored
As a follow-up to r775075 this change introduces a Windows version of string_number_conversions.h, which contains wide string overloads that are only exposed on Windows. In order to facilitate code sharing with the regular string number conversions, this change also adds string_number_conversions_internal.h. Furthermore, it performs some small clean-ups to simplify the template logic and rely on more automatic type deductions. Bug: 911896 Change-Id: I0ed8f8b73b8b78ccbe3a762b04a021c7b2a60ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231142 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780735}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. TBR=jorgelo,meacer Bug: 1031540 Change-Id: Iaa243f8ff7ccfd865f26b765606314c453b90329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254665 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#780734}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b97d7669bc7b..adacba3ee921 2020-06-22 johnkslang@users.noreply.github.com Update README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ia859b74eb1a8e9259b635d34191aa34f43e973b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780733}
-
Takashi Sakamoto authored
Instead, use defined(ARCH_CPU_64_BITS) && !defined(OS_NACL). Bug: 1086388,1073933 Change-Id: I66d2214f46e4cf77e391548e780b451869163d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251573 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#780732}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b85a296d6a61..1ff270d3e636 2020-06-22 mathias@chromium.org Fix typo in link to triage guidelines 2020-06-22 patrick.brosset@microsoft.com Enable the no-return-assign ESLint rule 2020-06-22 petermarshall@chromium.org Update CDP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084558,chromium:1093379 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie326de87cbea0e1664d7327a5fce6996ebf00ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257045Reviewed-by:
-
Maksim Sisov authored
This patch adds usage of ozone platform in //chrome. It's not possible to use linux wrapper [1] for everything as it may introduce circular deps and other problems. Plus, there are many places that are guarded either by single USE_X11 or USE_OZONE. Thus, use the IsUsingOzonePlatform feature flag to choose the correct path. [1] https://crrev.com/c/2250106 ----- Please note that this ugliness is added temporarily and will be removed as soon as use_x11 is removed (hopefully by Q1 2021 depending on how the finch trial goes). Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I01653d42a448e708bc772ac2ec4aa64dd3f178b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250066 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#780730}
-
Matthias Körber authored
This CL relaxes the requirements to import a profile. If no address \ profile could be imported from a form section, the import is performed on the union of all sections. Change-Id: Id366c8acc5ab98deb130c592dad507ef7f4cf5c5 Bug: 1097692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254603 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#780729}
-
chrome://signin-reauthAlex Ilin authored
chrome://signin-reauth needs to display different strings depending on ReauthAccessPoint parameter. Callers pass this parameter to SigninReauthUI as a URL query parameter. chrome/browser/signin/reauth_util takes care of generating a corresponding URL and reading an encoded parameter from in. Bug: 1045515 Change-Id: Ib83ca63cf179fe04a58ba889d8ad0629d54df688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254144 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#780728}
-
Austin Tankiang authored
Bug: 1091104 Change-Id: I966d7e4eab4522f506f08349fa442fd6b0d32ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230380Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#780727}
-
Anatoliy Potapchuk authored
The test suite has been increasingly flaky recenly. Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/89791 Bug: 1090931 Change-Id: I27dc58e06232cf513f53714a299ffea1b8d5bf08 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256181Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#780726}
-
Stephen Nusko authored
nexus 5x webview This test flakes 10% of the time due to a timeout. See bug for details. Bug: 1097719 Change-Id: Idfccd2c1839e302781b35d7bcf0c23dcb1ceb532 No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255474Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780725}
-
Marc Treib authored
Typically, PasswordAutofillAgent (unsurprisingly) shows its popup only if it has password suggestions. However, if the feature EnablePasswordsAccountStorage is enabled, then sometimes the popup needs to be shown even without password suggestions, because it might contain other entries. However, PasswordAutofillAgent didn't know if such other entries actually exist, and so would show the popup "speculatively". If it later turned out that there actually aren't any entries to show, the popup would get suppressed later (in PasswordAutofillManager). That's all well and good, but it produces a bad interaction with (non-Password) AutofillAgent: If PAA says it wants to show a popup, then AA suppresses its own popup. Together, this led to some cases where neither of the two popups showed up. This CL fixes the issue by explicitly informing PAA whether it should show its popup even without suggestions. This bit is passed as a new parameter in the existing InformNoSavedCredentials() IPC. (If there *are* saved credentials, then PAA will always show its popup, so no need to change anything about the FillPasswordForm() IPC.) Bug: 1096521 Change-Id: Id4cafc3e0190dd1d20ad266bc1d7e39f32f83b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252241Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780724}
-
Tim van der Lippe authored
In DevTools, we want to write Node scripts as part of our Ninja action scripts. That's because we are more familiar with Node than with Python. However, since Ninja only allows Python scripts to be a script of an `action`, we were previously forced to write Python. This change allows the `third_party/node/node.py` script to be used as if it was a regular `node <script args>` invocation. As a result, we can use this script as part of a Ninja action as follows: ``` action(target_name) { script = "//third_party/node/node.py" args = [ "path/to/my/node/script.js", "--any-arg", anyValueForArg, ] } ``` We were previously already using this in DevTools itself, but that requires a Node checkout in `third_party/devtools-frontend/src/third_party/node`. To make sure that a build in Chromium is possible as well, we need to reference the absolute path to `//third_party/node/node.py` and thus requires the same file to exist in Chromium itself. Additionally, the script would now fail with the exitcode as defined by the invoked Node script. Lastly, this CL reformats the script according to the Python formatting standard. Bug: 1096473 R=jacktfranklin@chromium.org,dpapad@chromium.org CC=devtools-reviews+blink@chromium.org Change-Id: Ie11150475d4d32c9dc9e8ec18228d490239ff7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248568Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#780723}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I053fb6f7fc1cb03ba43abceba93274f12f2c395f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254124 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Olivier Robin authored
We report URLs for the latest 3 WebStateLists that had activity. Preload WebState count as a separate WebStateList. Bug: 1060658 Change-Id: I035a192de232ce9e9ce6ae864dbf57c8bdc051f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238933 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780721}
-
Anastasiia Nikolaienko authored
HandleNavigationButtonClicked was used only on Chrome OS and was triggered when user clicked "back" button. Remove this method from handler and navigate back when "back" button is clicked, instead of calling the handler. Bug: 1096007 Change-Id: If4992670fd03b23439be95650fd3a2a1551e5853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247889Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#780720}
-
Anatoliy Potapchuk authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12878 Change-Id: I024fe697bce0a6e4cfad7953b76958fdfd6dc3ce No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256180Reviewed-by:
-
Victor Hugo Vianna Silva authored
This is a reland of a89d80c4 Reason for reland: One of the upstream CLs had missing .js extensions in some imports, this caused failures later and then all CLs in the chain were reverted. TBR=aee@chromium.org Original changes's description: > This CL addresses a few design issues with PasswordListItem that predate > the introduction of PasswordsListHandler. > > - PasswordListItem would refer to a "menu" even though it knows nothing > about such menu, which is actually provided by the embedder. This CL > replaces mentions to passwordMenu in the component with what it actually > represents: the "more actions" button. > - The event fired by clicking the button was not documented in the file > overview. Moreover, the typedef for the event lived in the embedder. Now > the file exports the typedef. > - Tests that simulated clicks on the button would use the $$('#id') > syntax instead of the $.id one. This is now fixed. > > Bug: None > Change-Id: Ie815237134236468c639e73831bdb3eb7db36f98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248561 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779777} Bug: None Change-Id: I1a1db35efab745c7b5cb2893d153f6c643e3bbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254321Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b772a955e70c..0cc3a37881a2 2020-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 545d158a2ff9 to d4b9f576ebb4 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib29c51559917802a5db1bfc481fbc082b49d7750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257042Reviewed-by:
-
Mahmoud Gawad authored
Made untrusted.html create a Dedicated Web Worker. BUG=b:158119679 TEST=added browsertest to test WebWorker is working (PASS) Change-Id: I52a84135215b1cae028d3865af762d3ddb2cf44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232401Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#780716}
-
arthursonzogni authored
Patch [1] switched from RFH::is_active() toward RFH::IsCurrent(). We re-learnt this is possible for a RenderFrameHost to be pending deletion while being the "current" RenderFrameHost. This can happen when its frame is detached. [Bug] is caused by receiving DidFocusFrame() on a RenderFrameHost pending deletion (is_active() == false), but current (IsCurrent() == true). This caused a crash later. Patch [2] showed 100% of the crashes in [Bug] were explained by [1]. This patch revert all the is_active() -> IsCurrent() changes from [1]. It also revert the instrumentation [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2186641 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2252803 [Bug]: https://crbug.com/1093943 Bug: chromimum:1093943 Change-Id: If5cd5774a0f6fd7d0c77de96286f88649627a0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255603Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780715}
-
Joel Hockey authored
Bug: 1097596 Change-Id: I5bc30e9964f811041cc98bdbcba1d39bc2a2af85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256939 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780714}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592798309-f2bcf0f33aab857d8bcffdd4e0dd372aeeedf408.profdata to chrome-win32-master-1592808845-5ecd6c23d23a299e7b02af052540dc3d30072113.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9801ad9b38fcaa16c8e1cbec5430700f4d701258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257043Reviewed-by:
-
lijunsong authored
This changeset restores tests for UsernameDetector. The tests were removed in 1814832 along with the old parser. Bug: 1090694 Test: run the added tests Change-Id: I1de631de9943e975dfabaf4e9bc995de3cd7a252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239105Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53beceea..be2b0d66 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e63e61bf9b38efb8d32f9fc298d4242a1977b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256063Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780711}
-
Ulan Degenbaev authored
The test needs to wait until the redirected iframes load their documents. Additionally, the 'same-origin-8' iframe is allowed to appear in the result. Bug: 1097332 Change-Id: I44e0b2bc7adff7cdba68c9b8ba6b240aa380a08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255599 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19576 TBR=apotapchuk@chromium.org Bug: 1097708 Change-Id: I7c926cdffc37ff418b23ed0a5654fb92129260b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257199Reviewed-by:
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I06bc0c29ef1369ac3d104c404a032e2937d500c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254325 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780708}
-
Fredrik Söderqvist authored
Like in SVG LayoutObjects deriving from LayoutSVGModelObject, we need to handle implicit transform changes caused by changes to the viewport. Add the equivalent CheckForImplicitTransformChange() method that LayoutSVGModelObject has and hook it up in UpdateTransformAfterLayout(). Bug: 1094020 Change-Id: Iedd05bb7e2de2bde25a6ce9f01cf1903dc1d6a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250000 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780707}
-
Maksim Moskvitin authored
Bug: 1016702 Change-Id: I75da209fc1cbe8a93eb3f9cd229097161064bf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253766 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780706}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2cb6faf0664d0411d489583eb1576f9f4c1285b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257044Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id64ee411246fe966b9964c3f72e5a80c1dabcb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257040Reviewed-by:
-
Friedrich Horschig authored
This CL adds two metrics that should help us figure out whether the unlock of the account store is used and yielded useful suggestions. The PasswordManager.* Metrics are: - CredentialsFromAccountStoreAfterUnlock which records the number of account suggestions a user has available right after the unlock. - Three new entries in PasswordDropdownItemSelected to check the usage of generation, unlock, and re-signin promo Metrics to see whether they dropped out during the reauth were split out into https://crrev.com/c/2252809. Bug: 1063852 Change-Id: I737e6dc73e4dd294d2b2b91a77a3dbdd2ae1fd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252338 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Christoph Schwering authored
The AutofillCapturedSitesInteractiveTest test crashes on Linux because the process is not allowed to be blocking. This CL remedies this by adding a ScopedAllowBlocking RAII variable with minimal necessary scope. Bug: 1097526, 1090042 Change-Id: I6475d67be1cf308d4d2086076a7a0b2e7eb82ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255360Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#780702}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e20ac35adbfd..b97d7669bc7b 2020-06-22 johnkslang@users.noreply.github.com Merge pull request #2278 from ShabbyX/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ib294326b017e5e57935aa1ab81f604aae8c1c9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256697Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/545d158a2ff9..d4b9f576ebb4 2020-06-19 jaebaek@google.com [spirv-opt] debug info preservation in ssa-rewrite (#3356) 2020-06-19 ehsannas@gmail.com Updated desc_sroa to support flattening structures (#3448) 2020-06-19 vasniktel@gmail.com spirv-fuzz: Refactor variable creation (#3414) 2020-06-19 vasniktel@gmail.com spirv-fuzz: Swap operands in OpBranchConditional (#3423) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I5b25081679cd69cd5a52054088d35e1296bddcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257041Reviewed-by:
-
Jan Krcal authored
This is a reland of ec355e1b Original change's description: > [Profile menu] Streamline ProfileMenuClickTests > > This CL removes behavior of profile menu in tests that is not checked by > the click tests (i.e. the various actions that happen after clicking the > menu items). > > This CL is a speculative fix for high flakiness of > ProfileMenuClickTests. The flakiness has multiple root causes, none of > which seems specific to profile menu / the test code. The hope is based > on the fact that many of the actions in the user menu are expensive > (loading guest mode and opening another browser) and thus increase the > risk of flakiness. > > Bug: 1021930 > Change-Id: I0f24a1f18ce8d3029daef44e2bc96b95eef81ac9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247642 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780296} Bug: 1021930 Change-Id: I861463cf7e54be7456ff8e59fa46392a1f2893d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255463 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/47e76886f0ca..b85a296d6a61 2020-06-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6673f0192ef6c34131079fd494617c2d4d8489a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257038Reviewed-by:
-
