GitLab

This test is no longer correct and doesn't have any real value anyway.
Bye, Felicia.

BUG=None
TBR=jcivelli@chromium.org

Change-Id: Ia13c63a5a8741db739c2c197f2164fea8180e719
Reviewed-on: https://chromium-review.googlesource.com/518485Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475802}

Due to conflicts with the GVR library, we had to stop using this for the VR
browser mode. I think this attribute is still useful for the future, but we
should use it to reduce priority of possibly-slow user GL code instead of using
"high" priority ourselves.

BUG=725684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2914593003
Cr-Commit-Position: refs/heads/master@{#475801}

This patch generates getters/setters/mapping for TextEmphasisFill,
TextEmphasisPosition, TextEmphasisCustomMark.

BUG=628043

Review-Url: https://codereview.chromium.org/2904403002
Cr-Commit-Position: refs/heads/master@{#475800}

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2865903002
Cr-Commit-Position: refs/heads/master@{#475799}

This works behind flag. Currently only normal notification is supported.

BUG=723144

Review-Url: https://codereview.chromium.org/2892893002
Cr-Commit-Position: refs/heads/master@{#475798}

BUG=chromium:726811

Review-Url: https://codereview.chromium.org/2908383002
Cr-Commit-Position: refs/heads/master@{#475797}

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
It rewrites base::Bind to base::BindOnce where the resulting Callback is converted to
OnceCallback immediately.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

Bug: 554299
Change-Id: Id0d8d60e6c0104d89093522a030fa05d7c50ae67
Reviewed-on: https://chromium-review.googlesource.com/517845Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475796}

Revert of Making answer card to behave like other results. (patchset #6 id:100001 of https://codereview.chromium.org/2905523004/ )

Reason for revert:
This broke a build
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/36279

Original issue's description:
> Making answer card to behave like other results.
>
> Now it lives in a search result container, which can be selected,
> highlighted, navigated with keyboard etc.
>
> Opening the result (i.e. what happens upon clicking on it) is not yet
> implemented.
>
> Unit test for the new result container isn't yet implemented since both
> result opening and accessibility behavior are not yet implemented.
>
> Bug=712331
>
> Review-Url: https://codereview.chromium.org/2905523004
> Cr-Commit-Position: refs/heads/master@{#475782}
> Committed: https://chromium.googlesource.com/chromium/src/+/2420a92712ee82be175bea6750774bec8006c5ce

TBR=xiyuan@chromium.org,jam@chromium.org,sky@chromium.org,vadimt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug=712331

Review-Url: https://codereview.chromium.org/2910173003
Cr-Commit-Position: refs/heads/master@{#475795}

BUG=n/a
TEST=n/a

Review-Url: https://codereview.chromium.org/2907333002
Cr-Commit-Position: refs/heads/master@{#475794}

This patch prunes two call sites of the deprecated function, which is
safe because layout is already updated at their caller,
Editor::HandleTextEvent().

BUG=698633

Review-Url: https://codereview.chromium.org/2912233002
Cr-Commit-Position: refs/heads/master@{#475793}

This is to fix a problem where the error message lists all the
directories owned by the teams that share a component instead of only
those that actually have the component specified.

BUG=707774
R=ymzhang,sshruthi,katesonia

Change-Id: Ibee24a40604d0e0e4e0475f937782887cf360ab7
Reviewed-on: https://chromium-review.googlesource.com/498055Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475792}

Per the analysis in https://crbug.com/725689, the equivalent functionality
of ShouldServiceRequest is present with PlzNavigate, which means this
comment is now obsolete.

BUG=725689

Review-Url: https://codereview.chromium.org/2910793002
Cr-Commit-Position: refs/heads/master@{#475791}

This patch fixes the PermissionRequestManager codepath to show Android
system permission prompts where appropriate, by implementing
PermissionRequestImpl::GetContentSettingsType() so we know what
permission to request.

BUG=606138

Review-Url: https://codereview.chromium.org/2909223003
Cr-Commit-Position: refs/heads/master@{#475790}

This CL implements the logic of display notification when selecting
"Open in new Chrome tab" from the Browser Actions context menu. Clicking
the notification will open Chrome. If the notification is for single
link, Chrome shows the current active tab, otherwise Chrome shows the
tab switcher. Opening Chrome will dismiss the notification.

BUG=719080

Review-Url: https://codereview.chromium.org/2876863002
Cr-Commit-Position: refs/heads/master@{#475789}

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

This is in preparation for supporting custom copying behaviour for
fields.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2911373002
Cr-Commit-Position: refs/heads/master@{#475788}

https://skia.googlesource.com/skia.git/+log/114a3c0b2b26..b365cf590f87

$ git log 114a3c0b2..b365cf590 --date=short --no-merges --format='%ad %ae %s'
2017-05-30 fmalita Speculative fix for SkPerlinNoiseShaderImpl::asFragmentProcessor leak
2017-05-30 herb Add aarch64 tail code.
2017-05-30 fmalita [Reland] Relocate shaders to own dir
2017-05-30 fmalita Delete SkGaussianEdgeShader
2017-05-30 reed move perlinenoise2 into effects
2017-05-30 mtklein simplify sse41::srcover_srgb_srgb
2017-05-30 herb Add arm tail code.
2017-05-30 mtklein remove sse2::srcover_srgb_srgb
2017-05-30 fmalita Don't pull private headers in SkOverdrawColorFilter.h

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I27e6535e4fc5894b10a8ebdd63bd2e6f962a0db9
Reviewed-on: https://chromium-review.googlesource.com/518425Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475787}

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//services/device starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

Bug: 714018
Change-Id: Ida11b9eaa331cce7f72ed0f1554731fd26659f2f
Reviewed-on: https://chromium-review.googlesource.com/517586Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475786}

Add a "color spin" set of primaries to be used by layout tests. These
primaries are rotated RGB->GBR and have a ginormous gamut, so any
places where we fail to do color conversion should be very noticeable.

BUG=713891

Review-Url: https://codereview.chromium.org/2912903003
Cr-Commit-Position: refs/heads/master@{#475785}

Begin/FinishProcessingOrderNumber can release fence syncs and run their
callbacks. Those callbacks can call into the scheduler, in particular,
Enable/DisableSequence. So move the order processing to outside the lock
and make it safe to reenter the scheduler.

The included test deadlocks without this change. I haven't figured out
what happens after gpu process crash that causes problematic sync token
waits. I suspect it's sync tokens submitted by renderers that are left
over from the previous gpu process instance.

R=piman
BUG=514813
TEST=gpu_unittests SchedulerTest.ReentrantEnableSequenceShouldNotDeadlock

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0a1d4154bb5f7b83b32a197fa8cb47a0f0d8e188
Reviewed-on: https://chromium-review.googlesource.com/518583Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475784}

Single-line messages in the network detailed view are updated to follow
Material Design specs. Also, fixes the padding for single-line messages
in Bluetooth detailed view from 22dip to 18dip.

BUG=687778
TEST=none

Change-Id: I82c377ad401026c9bdac595f614006584bd74336
Reviewed-on: https://chromium-review.googlesource.com/517967Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475783}

Now it lives in a search result container, which can be selected,
highlighted, navigated with keyboard etc.

Opening the result (i.e. what happens upon clicking on it) is not yet
implemented.

Unit test for the new result container isn't yet implemented since both
result opening and accessibility behavior are not yet implemented.

Bug=712331

Review-Url: https://codereview.chromium.org/2905523004
Cr-Commit-Position: refs/heads/master@{#475782}

Currently, we only construct instances of TextMatchMarker (previously
RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling
TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this
so callers directly construct instances of TextMatchMarker. This sets us up to
eventually move the storage and accessor methods for whether or not the marker
is active out of DocumentMarker and into TextMatchMarker.

BUG=707867

Review-Url: https://codereview.chromium.org/2905753002
Cr-Original-Commit-Position: refs/heads/master@{#475724}
Committed: https://chromium.googlesource.com/chromium/src/+/6b0a494122ebe2fc48099a9549b0acbf0b28571d
Review-Url: https://codereview.chromium.org/2905753002
Cr-Commit-Position: refs/heads/master@{#475781}

Bug: 
Change-Id: Id45f9ef44b25aac984b1f444911a233457a630f5
Reviewed-on: https://chromium-review.googlesource.com/517550Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475780}

Active LayerImpl properties are never pushed. This patch enforces this
by making LayerImpl::SetNeedsPushProperties only work on the pending tree.

The existing VerifyLayerChangesAreTrackedProperly test has been modified
to work on the pending tree instead of the active tree. The existing
mask_to_bounds tests have been updated as they were intended for
another era when SetBounds did depend on mask_to_bounds.

An additional test has been added for active layer change tracking.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I711109df86e6c644333a8e14a5540a4b22675894
Reviewed-on: https://chromium-review.googlesource.com/516826
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475779}

This CL makes it so editing commands will keep touch selections if they were
present before the command.

BUG=719890

Review-Url: https://codereview.chromium.org/2890313003
Cr-Commit-Position: refs/heads/master@{#475778}

SortableDataGrid.create may return null in some cases, subsequent call
to setStriped in such cases results in an exception logged.

Change-Id: I3f125c5747aeeaf54fce6596bd8451e2eb61b124
Reviewed-on: https://chromium-review.googlesource.com/518505Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475777}

Bug: 726439
Change-Id: Ia688e6b35c33e48353d371476991c35559eb1b7d
Reviewed-on: https://chromium-review.googlesource.com/516865Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475776}

On the x86 architecture on Android, there is an ordering issue for when
an std::move(...) happens. The call is on the form:
std::unique_ptr<Foo> foo;
...
foo->Init(std::move(foo));

On arm and other platform, this causes no issue, but for Android x86,
this pattern leads to |this| being nullptr inside Foo::Init(...).

This CL fixes that by first creating a copy of the raw pointer, and
invoking the method on that raw pointer instead of the std::unique_ptr.

BUG=727291, 727677

Change-Id: I617a1a3e41e486aeb1ede4d61bf3b35677f617b5
Reviewed-on: https://chromium-review.googlesource.com/518423Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475775}

This patch removes unnecessary LayerById lookups in DidUpdateScrollOffset
in an attempt to improve both understanding and performance.

In addition:
1) An call to InnerViewportContainerLayer has been removed from
DidUpdateScrollState. This contains a LayerById lookup and is false in the
common case. This null-check removal is safe because it will be null-checked
later in DidUpdateScrollState.
2) The scrollbar vertical adjustment code has been moved so it only applies
to viewport scrolls. Non-viewport scrolls do not have ViewportBoundsDelta.

Bug: 724193
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia1bc76769781243b2e486d0f1bbbae59bbe07ad3
Reviewed-on: https://chromium-review.googlesource.com/517902Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475774}

In our vain attempt to re-enable performance_browser_tests on the Mac
bots, a number of breakages seem to have happened over the months where
we were not even aware the tests weren't running.

This change fixes all of the following:

1. Adds a BUILD dependency on //chrome:chrome_app. Without this, the
test binary would be missing many runtime dependencies (e.g., the whole
"Chrome Framework" bundle).

2. Migrate MachPortsTest to use BrowserTestBase::embedded_test_server()
instead of its own server of "fake content" for its browser tests.

3. Add base::ScopedAllowIO for a test utility class that creates and
tears down its own set of threads. It's not clear why the thread
restriction is only checked on Mac (perhaps it's in the way the
browser test's main thread is set up?). Nevertheless, it's perfectly
reasonable for the main thread to block on stopping these other threads:
After the test has run, the threads are shut down before the data
analysis begins, since we want to be sure the data sets are no longer
mutating. Also, added PRESUBMIT.py exception for this use case.

BUG=697444,722367
TBR=nduca

Review-Url: https://codereview.chromium.org/2901113003
Cr-Commit-Position: refs/heads/master@{#475773}

TextIterator::Advance() used to contain some code before its main loop
to handle the remembered progress, if any. This patch wraps the code
into a new function TextIterator::HandleRememberedProgress() for better
code health.

Follow-up patches will utilize this function to make the control flow
in TextIterator cleaner.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2911373003
Cr-Commit-Position: refs/heads/master@{#475772}

 - Fixing almost all existing violations
   (remaining ones are fixed at crrev.com/2903063007).
 - Enabling http://eslint.org/docs/rules/semi check during PRESUBMIT

This enforces the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-required

BUG=720034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2909503003
Cr-Commit-Position: refs/heads/master@{#475771}

This CL stops adding preloaded RawResources to MemoryCache. This is needed
to match preloaded resources with requests with UseStreamOnResponse specified.

From the following reasons, I believe the performance impact is negligible.

 - Preloading matching is now decoupled from MemoryCache in general.
 - Loading resources can be shareable only in the same frame.
 - There is no speculative RawResource preload.

Bug: 652228
Change-Id: Icc5f7fc893702233cc45bc130eb13e6fcae919df
Reviewed-on: https://chromium-review.googlesource.com/516926Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475770}

R=dalecurtis@chromium.org

BUG=667532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2902313003
Cr-Commit-Position: refs/heads/master@{#475769}

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666

TBR=jdonnelly@

Review-Url: https://codereview.chromium.org/2908033002
Cr-Commit-Position: refs/heads/master@{#475768}

- introduce TimelineHistoryManager;
- keep a list of at most 5 recorded/loaded timelines, discard LRU ones;
- present recording history as a drop-down list of overview & screenshot thumbnails,
    accessible via a toolbar button or shortcut;
- (drive-by) make ListControl focusable, properly disable Reload action button.
- (drive-by) fix initial state of action button if action is disabled;

Bug: 726381
Change-Id: I8e154530da6c60744c7f5192cae1914ab3623e4f
Reviewed-on: https://chromium-review.googlesource.com/517295
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475767}

Give an indication in the documentation where this structure is
defined/specified. So others readers studing this code can read
more information about it.

BUG=None

Change-Id: Iedf747d27231be4982010519365a6caa6dfc1c6d
Reviewed-on: https://chromium-review.googlesource.com/518046
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475766}

Record the source of PPDs and the success or failure of a printer setup
request from the setup flow in settings.

BUG=725741

Review-Url: https://codereview.chromium.org/2911523002
Cr-Commit-Position: refs/heads/master@{#475765}

This CL uses /media/test/data/ as the seed_corpus for
media_pipeline_integration_fuzzer.

BUG=584119

Change-Id: Ic0f237f4326b8dc4ab41fd9c5fced6c2a9c5ac05
Reviewed-on: https://chromium-review.googlesource.com/518256
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475764}

Bug: 718063
Change-Id: Ibe1fd15363646bc7132975548c6ef7944508c5e1
Reviewed-on: https://chromium-review.googlesource.com/518482Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475763}