GitLab

crrev.com/2533163002 changed the way we allocate modeset buffers.
Unfortunately the new use flags introduced a regression that makes it
not possible to pageflip from a modeset buffer to a buffer queue buffer.
This CL restores the old modeset buffer use flags in order to fix the
regression, while we work on a long term solution.

BUG=673026
TEST=manually tried the step described in the bug and verified it now works.

Review-Url: https://codereview.chromium.org/2568243004
Cr-Commit-Position: refs/heads/master@{#438193}

GlobalErrorService ownership was crazy; sometimes the error objects contained were owned, and sometimes they weren't. This separates the two cases into clear statements of ownership, and deprecates the case where the error objects are unowned.

BUG=555865,673578

Review-Url: https://codereview.chromium.org/2409443002
Cr-Commit-Position: refs/heads/master@{#438192}

Revert of Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky (patchset #1 id:1 of https://codereview.chromium.org/2568413003/ )

Reason for revert:
Infra problem, not test problem. And the problematic bot has been taken off of cq.

Original issue's description:
> Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky
>
> BUG=672885
> TBR=boliu@chromium.org
>
> Committed: https://crrev.com/7d0a2e6fd2a182eb8fa8888cd9539c6072bbf136
> Cr-Commit-Position: refs/heads/master@{#438190}

TBR=nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672885

Review-Url: https://codereview.chromium.org/2573833002
Cr-Commit-Position: refs/heads/master@{#438191}

BUG=672885
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2568413003
Cr-Commit-Position: refs/heads/master@{#438190}

These are third party libraries used by Chrome for iOS.

BUG=none

Review-Url: https://codereview.chromium.org/2551963004
Cr-Commit-Position: refs/heads/master@{#438189}

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2569713003/ )

Reason for revert:
Breaks compilation of autofill_controller_unittest.mm

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a
> Cr-Commit-Position: refs/heads/master@{#438167}

TBR=noyau@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2577443002
Cr-Commit-Position: refs/heads/master@{#438188}

Using a dialog is a much cleaner solution because it handles all focus
trapping without attempting to capture TAB or require updating all
tabindex properties.

We removed the ability to swipe the drawer open in order to keep the
code simple.

BUG=633858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2465433002
Cr-Commit-Position: refs/heads/master@{#438187}

BUG=651041

Review-Url: https://codereview.chromium.org/2569223002
Cr-Commit-Position: refs/heads/master@{#438186}

BUG=673362

Review-Url: https://codereview.chromium.org/2555033003
Cr-Commit-Position: refs/heads/master@{#438185}

This CL triages the currently failing layout tests. Marking this as
NOTRY since this is only affecting the FYI bot
LinuxBrowserSideNavigation.

BUG=576261
NOTRY=TRUE
TBR=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2572783003
Cr-Commit-Position: refs/heads/master@{#438184}

Semi-automatically generated ARCMigrate commit

Notable issues:Had to fix includes and subclasses.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2574463002
Cr-Commit-Position: refs/heads/master@{#438183}

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order.

BUG=673371
TEST=PaymentRequest* (java)

Review-Url: https://codereview.chromium.org/2571493002
Cr-Commit-Position: refs/heads/master@{#438182}

https://skia.googlesource.com/skia.git/+log/3b3bdafa8e3a..941e7e2c9567

$ git log 3b3bdafa8..941e7e2c9 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 ethannicholas re-land of added sk_FragCoord support to skslc
2016-12-13 borenet Add PDFium_SkiaPaths bot
2016-12-13 reed don't use deprecated api
2016-12-12 scroggo SkGifCodec: intersect frameRect with image size
2016-12-12 msarett Fix Android overdraw detection
2016-12-12 borenet Roll recipe DEPS
2016-12-13 reed remove old clipping flags

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2569843003
Cr-Commit-Position: refs/heads/master@{#438181}

BUG=673681
TBR=donnd@chromium.org,twellington@chromium.org

Review-Url: https://codereview.chromium.org/2571783002
Cr-Commit-Position: refs/heads/master@{#438180}

If Chromium is using a HTTP2 proxy server, then the preconnect jobs
are skipped if a preconnect request is already pending.

This prevents Chromium from unnecessarily establishing multiple
preconnections to an HTTP2 proxy. The new behavior is guarded
behind a field trial so that the performance benefits can be
evaluated.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=667471

Review-Url: https://codereview.chromium.org/2522703002
Cr-Commit-Position: refs/heads/master@{#438179}

BUG=669668
TEST=WebFrameTest.TestNonCompositedOverlayScrollbarsFade

Review-Url: https://codereview.chromium.org/2569053002
Cr-Commit-Position: refs/heads/master@{#438178}

Revert of Implement a runtime headless mode for Linux (patchset #20 id:380001 of https://codereview.chromium.org/1991953002/ )

Reason for revert:
Unexpectedly added a couple of new static initializers: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/29946

Original issue's description:
> Implement a runtime headless mode for Linux
>
> This patch implements a runtime headless mode (i.e., a
> --headless command line switch) that makes it possible to
> use a regular Chrome binary as a headless. When the binary
> is launched with this switch, the main entrypoint calls
> into the Headless Shell entrypoint, effectively starting
> that shell instead of Chrome.
>
> To make this possible we must remove the dependency from
> Headless to Ozone, because Ozone is a build-time feature
> which is generally not enabled for regular Chrome builds.
> In practice this means implementing a new headless-specific
> WindowTreeHost and modifying various graphics and input
> entrypoints to do something appropriate in headless mode.
>
> Since many of the modifications are in platform-specific
> code, this initial patch only adds headless support in Linux.
> Other platforms will be added later.
>
> Design doc: https://docs.google.com/document/d/1aIJUzQr3eougZQp90bp4mqGr5gY6hdUice8UPa-Ys90/edit#
>
> BUG=612904
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/eb0f3b0218478f30858dfa2078cb350ea259701f
> Cr-Commit-Position: refs/heads/master@{#438152}

TBR=jochen@chromium.org,eseckler@chromium.org,sky@chromium.org,zmo@chromium.org,vmiura@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612904

Review-Url: https://codereview.chromium.org/2570873002
Cr-Commit-Position: refs/heads/master@{#438177}

BUG=643804

Review-Url: https://codereview.chromium.org/2544793003
Cr-Commit-Position: refs/heads/master@{#438176}

Define BrowsingDataRemoverDelegate, a class to which BrowsingDataRemover
will delegate all embedder-specific deletions. This class is in 1:1
relationship to BrowsingDataRemover and is owned by it.

Create a Chrome-specific subclass ChromeBrowsingDataRemoverDelegate by
extracting all Chrome datatypes from BrowsingDataRemover::RemoveImpl().

This is the first step of the implementation plan. See the design doc for more
background and explanation of the next steps:
https://docs.google.com/document/d/1I6m4QwbTNhG6wdtazamhTnArJN-UMUGqpvwH6InBEaM/edit#heading=h.m5pzu7ah79n9

This change is covered by BrowsingDataRemoverTest and
BrowsingDataRemoverBrowserTest.

NOTES FOR REVIEWERS:
1. This CL tries to keep the diffs at minimum for easier review, even if the
method ordering could be improved. That will be improved in a follow-up CL.
2. However, the diffs widely differ in BrowsingDataRemover::RemoveImpl and
ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData. Fortunately, one can
convince themself that they are still equivalent by trusting the test coverage
(58 unittests and 6 browsertests).
3. One can convince themself that no datatype was left out by checking the
list of asynchronous tasks, such as "waiting_for_clear_cache_",
"waiting_for_clear_cookies_" etc. present in both .h files and in the AllDone()
method of both classes.
4. The distribution of datatypes might not be final. For example, downloads are
known to content but have a chrome/ dependency. Similarly, the DNS cache lives
in net/ but is retrieved via a class in chrome/. Future CLs might correct their
placement based on how strong the chrome/ dependencies are.

Patchset 3: Simplify the "bool waiting_for_clear_<type>" paradigm by encapsulating it to a SubTask class.

BUG=668114

Review-Url: https://codereview.chromium.org/2554413002
Cr-Commit-Position: refs/heads/master@{#438175}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d654057e..8d822ae6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2568213003
Cr-Commit-Position: refs/heads/master@{#438174}

Note this patch, while useful in it's own right, needs base messageloop
cancellation support for full effect.  Until that patch lands there may be
some pointless wakeups for canceled DoWorks. This is of particular concern
for using the scheduler on the compositor thread.

BUG=578176
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2546423002
Cr-Commit-Position: refs/heads/master@{#438173}

This change block user code from accessing cross-origin image data
from a placeholder canvas. The placeholder code was modified to
use StaticBitmapImage instead of Image to gain access to the
originClean() method without downcasting.

BUG=673348

Review-Url: https://codereview.chromium.org/2566313002
Cr-Commit-Position: refs/heads/master@{#438172}

The setting is not used anymore.
Remove it.

Review-Url: https://codereview.chromium.org/2576473002
Cr-Commit-Position: refs/heads/master@{#438171}

Internal types, no good reason to expose these to the outside.

R=
BUG=673645

Review-Url: https://codereview.chromium.org/2573783002
Cr-Commit-Position: refs/heads/master@{#438170}

Re-enable SSLUITest.TestGoodFrameNavigation since it's no longer flaky as of revision 2677ed35

BUG=668360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=agl@chromium.org

Review-Url: https://codereview.chromium.org/2569813002
Cr-Commit-Position: refs/heads/master@{#438169}

Also cleaned up the code a bit.

R=peria
BUG=673213

Review-Url: https://codereview.chromium.org/2568863003
Cr-Commit-Position: refs/heads/master@{#438168}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569713003
Cr-Commit-Position: refs/heads/master@{#438167}

BUG=672999
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=kbr@chromium.org,zmo@chromium.org

Review-Url: https://codereview.chromium.org/2569013005
Cr-Commit-Position: refs/heads/master@{#438166}

BUG=643746, 604369
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2
Review-Url: https://codereview.chromium.org/2555693005
Cr-Original-Commit-Position: refs/heads/master@{#437771}
Cr-Commit-Position: refs/heads/master@{#438165}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2566993002
Cr-Commit-Position: refs/heads/master@{#438164}

https://skia.googlesource.com/skia.git/+log/b399e38518c7..3b3bdafa8e3a

$ git log b399e3851..3b3bdafa8 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 borenet Delete swarm_trigger recipe

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2566283005
Cr-Commit-Position: refs/heads/master@{#438163}

We've reverted the bad rebaseline for this test, but still need to
update the results for SK_ANALYTIC_AA.

BUG=669643
TBR=liyuqian@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2571803002
Cr-Commit-Position: refs/heads/master@{#438162}

https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741

BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567173003
Cr-Commit-Position: refs/heads/master@{#438161}

In particular the session code going to ash isn't really wired up
correctly. As we don't plan on using this soon I'm going to remove it
for now. We can bring back when necessary.

R=ben@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2569953002
Cr-Commit-Position: refs/heads/master@{#438160}

Reland of https://codereview.chromium.org/2569713002/ that was reverted
with https://codereview.chromium.org/2567203002/ but turned out to not
be the reason for the failures.

Original CL description:

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569213002
Cr-Commit-Position: refs/heads/master@{#438159}

BUG=673729
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2572753002
Cr-Commit-Position: refs/heads/master@{#438158}

The goal is to compare usage patterns between the different days of the week.

BUG=665873

Review-Url: https://codereview.chromium.org/2563443004
Cr-Commit-Position: refs/heads/master@{#438157}

To move ImageResource out of core/fetch, remove unexpected dependencies
from ResourceFetcher to ImageResource.

BUG=655920

Review-Url: https://codereview.chromium.org/2510883003
Cr-Commit-Position: refs/heads/master@{#438156}

We're deprecating DOMWindowProperty, which is equivalent to ContextLifecycleObserver.
This CL does the replacement for Performance.

BUG=610176

Review-Url: https://codereview.chromium.org/2569153002
Cr-Commit-Position: refs/heads/master@{#438155}

BUG=658305
R=fs@opera.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2567113004
Cr-Commit-Position: refs/heads/master@{#438154}