GitLab

Also, patch contains a fix for a bug where file size was not set correctly in document feed.

We will also need a WebKit patch to fix the test, so until that is in, I'm disabling the test.

*NOTE: I was beaten with disabling the test, but still landing this, since it contains some fixes :)

TEST=None
BUG=128759

Review URL: https://chromiumcodereview.appspot.com/10411022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137907 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137906 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug caught by coverity.

BUG=128302
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10382222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137903 0039d316-1c4b-4281-b951-d872f2087c98

This is because python's subprocess.py excepts GetStdHandle(STD_INPUT_HANDLE) to return a valid handle and it seems ninja on Windows doesn't give one, causing the subprocess.call() to fail unless we request stdin to be redirected.

Also fix file handle lifetime in gypv8sh.py

When an exception is thrown, the file handle could still be open, causing an
exception while trying to remove it in the exception handler due to file locking
on Windows.

Note that the exception being generated is another problem but this exception in
the exception handler was masking the original error.

R=scr@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10388191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137902 0039d316-1c4b-4281-b951-d872f2087c98

Failing on Linux ChromeOS builds.

TBR=aa@chromium.org
BUG=128757
TEST=

Review URL: https://chromiumcodereview.appspot.com/10386216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137900 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137899 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10387191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137898 0039d316-1c4b-4281-b951-d872f2087c98

The hypothesis in comment #55 on the bug is that while setting up a
new channel to an already-connected plugin,
NPChannelBase::RemoveRoute() can be called on the earlier channel, so
the renderer and plugin channel mappings get out of sync.  This will
add a Breakpad key encoding the top stack frames when RemoveRoute() is
called within the scoped of WebPluginDelegateProxy::Initialize().

objc_zombies.mm already implemented the stackframe-encoding code, so I
pulled that to a central location.  That code can be left in place
when the other code is removed after some traces are generated.

BUG=97285
TEST=crash server.


Review URL: https://chromiumcodereview.appspot.com/10408004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10392152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128429
TEST=Run chrome ash/chromeos in a stub environment. It should be possible to 'connect' to 'Fake Wimax1'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137809

Review URL: https://chromiumcodereview.appspot.com/10407034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137892 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10407041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137891 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137890 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137883 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10392161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137882 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10332251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137881 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137880 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10408028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119965
TEST=LauncherViewTest.LauncherItemStatus

Review URL: https://chromiumcodereview.appspot.com/10386212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137878 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137877 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10409029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137876 0039d316-1c4b-4281-b951-d872f2087c98

Introduce IBusUtil::GetIBusAddressTest to get ibus-daemon address.

BUG=chromium-os:26334
TEST=chromes_unittest, unit_tests, dbus_unittests


Review URL: https://chromiumcodereview.appspot.com/10159004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=gbillock

Review URL: https://chromiumcodereview.appspot.com/10410002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137874 0039d316-1c4b-4281-b951-d872f2087c98

Also filter out unwanted protocols from the feed list.

This CL is a continuation of Mike West's changelist to convert the RSS extension to version 2 (with some additional code).

BUG=128256, 91986
TEST=RSS Extension (and automated tests) should work as before.
Review URL: https://chromiumcodereview.appspot.com/10407017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137873 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137872 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10411020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137871 0039d316-1c4b-4281-b951-d872f2087c98

are also visible.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10409016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108853

Review URL: https://chromiumcodereview.appspot.com/10389205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=units

Review URL: https://chromiumcodereview.appspot.com/10387189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137868 0039d316-1c4b-4281-b951-d872f2087c98

This significantly reduce the file size.

NOTRY=true
R=mad@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10411003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10388186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137866 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben
Review URL: https://chromiumcodereview.appspot.com/10383239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137865 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rtenneti
Review URL: https://chromiumcodereview.appspot.com/10411019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137864 0039d316-1c4b-4281-b951-d872f2087c98

This is in support of the pre-win8 -> win8 upgrade scenario.

BUG=128131,127734
TEST=manual: install on pre-win8 and confirm that the COM registration for the DelegateExecute handler is present in HKCR (Google Chrome: {5C65F4B0-3651-4514-B207-D10CB699B14B} or Chromium: {A2DF06F9-A21A-44A8-8A99-8B9C84F29160}) and that the start menu shortcut has the dual mode juju.


Review URL: https://chromiumcodereview.appspot.com/10386167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137863 0039d316-1c4b-4281-b951-d872f2087c98

R=xiyuan@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10408009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128724

Review URL: https://chromiumcodereview.appspot.com/10407039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67301

Review URL: https://chromiumcodereview.appspot.com/10332246

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128724

Disable InstantTest.OnCancelEvent and InstantTest.PreloadsInstant

BUG=91891

TEST=

Review URL: https://chromiumcodereview.appspot.com/10409027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10386172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137858 0039d316-1c4b-4281-b951-d872f2087c98

Instead of adding the enlarged thumbnail then image loaded empty hidden div is created.

BUG=128254
TEST=To simulate situation then new images replace old ones before firsts have completely loaded execute "FileManager.THUMBNAIL_SHOW_DELAY = 1" in DevTools.


Review URL: https://chromiumcodereview.appspot.com/10392155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137857 0039d316-1c4b-4281-b951-d872f2087c98

The term "Page" had a double meaning -- either a visit, or a portion
of the full list of visits. The term visit is more appropriate for
the former, and it better matches the terminology in the history
backend.

Also remove some unused code, and make a few style cleanups.

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10391052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137856 0039d316-1c4b-4281-b951-d872f2087c98