GitLab

Because we aren't using it for anything anymore.
Review URL: http://codereview.chromium.org/7538008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96238 0039d316-1c4b-4281-b951-d872f2087c98

This is from the old user data dir multi profile thingy that was removed ages
ago.

BUG=23581

Review URL: http://codereview.chromium.org/7497050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96236 0039d316-1c4b-4281-b951-d872f2087c98

The mini_installer is linked with /FIXED to avoid creating RELOCs, saving size (about 3K ... is it worth it?).

Review URL: http://codereview.chromium.org/7606005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96235 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96234 0039d316-1c4b-4281-b951-d872f2087c98

/bin/true doesn't exist on Mac OS X. However, true seems to be in the path on Linux and Mac OS X, so let's use that.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18665,chromium-os:18702
TEST=Should see createAccount/guestSignin links to the right of the gaia signin iframe. chrome://settings/accounts has checkboxes to control the visibility of these links. Clicking these links should work as you'd expect.
Review URL: http://codereview.chromium.org/7497060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96232 0039d316-1c4b-4281-b951-d872f2087c98

The new functions will be used to implement other classes
that will be added in a separate patch.

BUG=90036
TEST=run unit tests


Review URL: http://codereview.chromium.org/7569020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96231 0039d316-1c4b-4281-b951-d872f2087c98

Automation for step 1-9 testplan @ go/NACL-SDK-testing
BUG=89467, 89470, 89479, 89610, 89612
TEST=None

Review URL: http://codereview.chromium.org/7541046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96230 0039d316-1c4b-4281-b951-d872f2087c98

generation is a blocking operation.

BUG=88782
TEST=None

Review URL: http://codereview.chromium.org/7565023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96229 0039d316-1c4b-4281-b951-d872f2087c98

Remove carriage return characters and set "svn:eol-style" to "LF".

The commit bot will not handle patches to this file otherwise.

BUG=89730
TEST=none
Review URL: http://codereview.chromium.org/7612007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96228 0039d316-1c4b-4281-b951-d872f2087c98

Add a separate histogram label for GWS based prerendering.
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7605020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96227 0039d316-1c4b-4281-b951-d872f2087c98

blocked on an extension with a webrequest API event handler.

BUG=82618
TEST=no


Review URL: http://codereview.chromium.org/7523042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96226 0039d316-1c4b-4281-b951-d872f2087c98

When not signed in the wrench menu says "Sign in to Chrome". When signed in it says "Signed in to Chrome as pat@example.com".

BUG=91009
TEST=Ran and verified that the wrench menu updated after signing into sync.


Review URL: http://codereview.chromium.org/7604017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96225 0039d316-1c4b-4281-b951-d872f2087c98

This works around the fact that the Java2 plugin is no longer officially supported for 10.5, and is thus no longer included in the Internet Plug-Ins directories where we expect to find plugins.

BUG=89543
TEST=Open about:plugins on 10.5; Java should be listed.


Review URL: http://codereview.chromium.org/7601022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96224 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87094
TEST=none
Review URL: http://codereview.chromium.org/7612003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96216 0039d316-1c4b-4281-b951-d872f2087c98

Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host.

Original comments follow.

Numerous changes, including:
  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7529035

TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/7587003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96211 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96210 0039d316-1c4b-4281-b951-d872f2087c98

1. improve custom context menus (for all webui pages)
2. make dragged + clicked apps a little larger. They grow when you click 'em.

BUG=92180,92103
TEST=manual

Review URL: http://codereview.chromium.org/7611001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96209 0039d316-1c4b-4281-b951-d872f2087c98

This makes LoginUtilsImpl::OnProfileCreated() check that its
delegate is non-NULL before using it.  I'm hoping that this
will avoid a segfault that's apparently showing up during
testing when Chrome is killed during initialization.

Note that this is just a temporary workaround; the
underlying code is possibly still incorrect (or relying on
incorrect assumptions about the order in which things will
happen).

BUG=chromium-os:18269
TEST=none
TBR=altimofeev@chromium.org

Review URL: http://codereview.chromium.org/7590026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96208 0039d316-1c4b-4281-b951-d872f2087c98

820: Fixes a typo in PPC-only code
821: Removes an erroneous const that clang didn't like

BUG=91371
TEST=none

Review URL: http://codereview.chromium.org/7604037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96207 0039d316-1c4b-4281-b951-d872f2087c98

This is used by pyauto test perf.PerfTest.testV8BenchmarkSuite.
It is used without modification, unlike version 4 which is used
by other ui perf tests.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7590027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96206 0039d316-1c4b-4281-b951-d872f2087c98

* Don't update the model if no entry is committed.
* Don't focus the placeholder for AF lists, since it doesn't particularly make
  sense to add a second name right away.

BUG=92237
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7607027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91715
TEST=no
TBR=jochen

Review URL: http://codereview.chromium.org/7605031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no
R=kathyw@chromium.org

Review URL: http://codereview.chromium.org/7608001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90443
TEST=none


Review URL: http://codereview.chromium.org/7605028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96200 0039d316-1c4b-4281-b951-d872f2087c98

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95621

Review URL: http://codereview.chromium.org/7584004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96199 0039d316-1c4b-4281-b951-d872f2087c98

Changes startup / restore behavior to better match Lion resume expectations.  Chrome can get launched by the |loginwindow| process due to the resume feature on Lion.  In this case, if there were no windows open in Chrome when restarting, Chrome re-opens with no windows upon login.  This is also the expectation under previous OSs when Chrome is a login item, so that's been changed here too.

BUG=90249
TEST=Manual.  On Lion.  Turn Chrome session restore on, close all windows (but don't quit), restart computer.  Expect Chrome launches on startup with no open windows.

Review URL: http://codereview.chromium.org/7497056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96198 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise having an inner frame that matches the app's extent could mean that the process
is not swapped, even if we're not in an app process.

Difference from r94843 is that the popup window is 200x200, so that it results in a separate
Browser instance even on Chrome OS.

BUG=89272
TEST=no
R=creis@chromium.org

Review URL: http://codereview.chromium.org/7608015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96197 0039d316-1c4b-4281-b951-d872f2087c98

Fix plugin so that frames can still be painted after the decoder has
been destroyed.

BUG=NONE
TEST=gles2 consistently runs without crashing

Review URL: http://codereview.chromium.org/7607014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96196 0039d316-1c4b-4281-b951-d872f2087c98

multiple tests to fix flakiness.

Added some logging to figure out chromeos test failures.

BUG=91715
TEST=no
TBR=jochen

Original Review URL: http://codereview.chromium.org/7607003

Review URL: http://codereview.chromium.org/7606033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96195 0039d316-1c4b-4281-b951-d872f2087c98

Now that the Chrome downloads system is more stable since when this hook was originally written, the hook is now updated to work for all downloads (it previously did not work well for dangerous downloads, or downloads from an incognito window).

A new input to the automation hook also requires changes to several pyauto files that invoke the hook.

BUG=69738,91263
TEST=None

Review URL: http://codereview.chromium.org/7544026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96193 0039d316-1c4b-4281-b951-d872f2087c98

* Added GL surface and context support for Wayland.
* Updated ui/gfx files to allow Wayland support
* All Wayland code is behind the use_wayland gyp flag

This CL depends on http://codereview.chromium.org/7457023

BUG=
TEST=Compiled Chrome with use_wayland disabled to verify that
the changes didn't break anything


Review URL: http://codereview.chromium.org/7467007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96192 0039d316-1c4b-4281-b951-d872f2087c98

remove the bookmark bar visibility check because ntp4 doesn't use the floating bookmark bar.

(the ShouldShowBookmarkBar code will be ripped out soonish with the rest of ntp3)

BUG=none
TEST=waterfall

Review URL: http://codereview.chromium.org/7608031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96191 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=linux touch bot passes

Review URL: http://codereview.chromium.org/7604039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96189 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7552043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96187 0039d316-1c4b-4281-b951-d872f2087c98

I left a --new-tab-page-3 flag for testing purposes.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7600013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96186 0039d316-1c4b-4281-b951-d872f2087c98

TBR=chase@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7552042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96185 0039d316-1c4b-4281-b951-d872f2087c98