- 04 Jan, 2018 40 commits
-
-
Mohamad Ahmadi authored
Bug: 418827 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20fa5a45ed6a749d98cec691b6648798dfe68547 Reviewed-on: https://chromium-review.googlesource.com/835228Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526932}
-
Sasha Bermeister authored
Remove non-mojo QuotaStatusCode and StorageType enums and replace them with their mojo equivalents. This CL was created by: * Find-and-replace blink::QuotaStatusCode and blink::StorageType with mojom::blink::* instead * Add a `using` statement to third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp * Replace type #includes with the mojom.h header instead * Fix small # of remaining compile and presubmit errors * Removing the QuotaStatusCode and StorageType enums and their typemap files TBR: jsbell@chromium.org,kinuko@chromium.org Bug: 781643 Change-Id: Ifc9e5ae4084f3fc78a0a1131c04a81ea5c2c4515 Reviewed-on: https://chromium-review.googlesource.com/849772 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526931}
-
Renee Wright authored
Is it clearer and faster to hard-code the camel case name of a property into its property class - since we already have that value at hand at generation time - than to construct it at runtime when it is needed. Slight increase in code size in favor of simplicity and speed. Bug: Change-Id: Ib8f0c3b6c1dd892b94bea5b08c3d43695131b098 Reviewed-on: https://chromium-review.googlesource.com/831806 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#526930}
-
Jiaquan He authored
This commit removes all SearchBoxModel references from chrome by passing in a raw search query from Ash. Bug: 733662 Change-Id: I1d2b479260cb59f8858d48b9850a5935477f4b7d Reviewed-on: https://chromium-review.googlesource.com/849618 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526929}
-
Zhuoyu Qian authored
As the comment in PaintLayerScrollableArea.h by ymalik@, remove Box() and update callers to use GetLayoutBox() instead. BUG= Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I23540f3057040f992bbeb78c817e27f490da327d Reviewed-on: https://chromium-review.googlesource.com/848484Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#526928}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/487a7520b5c9..67cd9b273f8f $ git log 487a7520b..67cd9b273 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 fmalita Build fix post c75e2401a82640c35b0b5f80a5684d0892904530 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I5e790b16f6aa0210b2d957cbbd8fe397deada1e6 Reviewed-on: https://chromium-review.googlesource.com/849773Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526927}
-
Eric Karl authored
We've moved to 100% on finch. Switching this to always on. Bug: 704716 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4211a8a0b5a09dd2f8a86726da9d63186fb4ce47 Reviewed-on: https://chromium-review.googlesource.com/847969Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526926}
-
Zhuoyu Qian authored
As the TODO in frame_parts.h, Convert FrameParts to a class, hide the member variables, add getters/setters for them. BUG= Signed-off-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526925}
-
Victor Costan authored
Bug: 798868 Change-Id: Ifca3a9be15fdc396f60b205c830be4cae0541821 Reviewed-on: https://chromium-review.googlesource.com/849474Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Renee Wright authored
These accessors are not needed in CSSUnresolvedProperty at this stage. We want to constrain the functionality of CSSUnresolvedProperty to the bare minimum so as to discourage its usage. It is useful to know that a property representation is strictly a resolved property; thus we do not want CSSUnresolvedProperty used except where absolutely necessary. If it turns out that these are needed on CSSUnresolvedProperty in future then they can be moved back. Change-Id: I4bb8c0714d5cfffe8f4b0d353ae0b0931e665f8f Reviewed-on: https://chromium-review.googlesource.com/831375Reviewed-by:
-
Justin Cohen authored
Bug: 795683 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab78eeda08a1de8a56a662f8a0b2b4d4fe8696da Reviewed-on: https://chromium-review.googlesource.com/847429Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526922}
-
Darren Shen authored
This patch uses idlharness.js to test the CSSKeywordValue interface. Bug: 774887 Change-Id: I64bd459bcc199094fc0ce60c217110fc0f0cb17f Reviewed-on: https://chromium-review.googlesource.com/848117Reviewed-by:
-
Trent Apted authored
The HarfBuzz roll in r513541 improved Mac UI font support in the renderer by detecting UI fonts and invoking CTFontCreateUIFontForLanguage(). However, in chrome UI, there is already a CTFont wrapped in a gfx:: PlatformFont for UI fonts. So creating a new CTFont for every hb_shape call becomes unnecessary and expensive. hb_coretext_font_create() (after a hb_coretext_face_create()) allows the steps requiring the call to CTFontCreateUIFontForLanguage() to be skipped by associating the CTFont with the hb_font_t directly. Adds a new views_perftest target and LabelPerfTest.GetPreferredSize to track. On a Late 2013 Mac Pro perf improves from 1390 runs/second to 3300 runs/second. +250 runs/second of that comes from a related hotspot in gfx::internal:: CreateSkiaTypeface() which was deriving a new CTFont unnecessarily before sending it to gfx::CreateHarfBuzzFont(). Bug: 785522 Change-Id: Iccf57fe3fc9a93cd4b9de1e79e81fb84d2ad88bb Reviewed-on: https://chromium-review.googlesource.com/823743 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#526920}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I7e61970b4dbf9ad4a36af34c4112b69890d1bee8 Reviewed-on: https://chromium-review.googlesource.com/848540Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#526919}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/6df487ef1e61..47c8ea3fb265 $ git log 6df487ef1..47c8ea3fb --date=short --no-merges --format='%ad %ae %s' 2018-01-03 jmadill Vulkan: Fix looped clears. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Iaecbc475ea866e2d8db42fd28ae79b9be48dfcb3 Reviewed-on: https://chromium-review.googlesource.com/849703 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526918}
-
Tibor Goldschwendt authored
The snackbar provides the user with the functionality to apply a new background while in VR browsing mode. This change is based on vollick@'s https://chromium-review.googlesource.com/c/chromium/src/+/847732. Credit is due. Bug: 798531 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I60eae5fb37c6e9fea3192eb7e5f9b8bb0df6ee1d Reviewed-on: https://chromium-review.googlesource.com/849312 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#526917}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9fc53624a09f..487a7520b5c9 $ git log 9fc53624a..487a7520b --date=short --no-merges --format='%ad %ae %s' 2018-01-04 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6df487ef1..47c8ea3fb (1 commit) 2018-01-03 fmalita [sksg] Refine invalidation logic 2018-01-03 benjaminwagner In iOS recipe, uninstall before install. 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ fc3463da0..6df487ef1 (1 commit) 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 36937a64f..fc3463da0 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ib8ebe7a6542bebcb571d4115c01a5b3131a21777 Reviewed-on: https://chromium-review.googlesource.com/849416Reviewed-by:
-
Andrew Grieve authored
Downstream was updated. Bug: 792315 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d7ccf2494df803f831363ebea6bb63b075b5a72 Reviewed-on: https://chromium-review.googlesource.com/848079Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#526915}
-
Scott Violet authored
In mus ash::WindowManager is responsible for controlling NetworkConnect. This means NetworkStateNotifierTest shouldn't try to control it too. BUG=848272 TEST=test only change Change-Id: Ia0cefa0f59e4c25d85f2ebb62fea11c76280e4ab Reviewed-on: https://chromium-review.googlesource.com/849475Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526914}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f294c56d..0e59efcd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1aa5c67e8645172e721c4d1fbc6bb934a46ded26 Reviewed-on: https://chromium-review.googlesource.com/848041Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526913}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/cbd4410908e2..45da0f2d84c9 $ git log cbd441090..45da0f2d8 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 dsinclair Fold CXFA_FillData into CXFA_Fill 2018-01-03 dsinclair Fold CXFA_ImageData into CXFA_Image 2018-01-03 dsinclair Fold CXFA_LineData into CXFA_Line 2018-01-03 npm Remove unused methods from CPDF_VariableText 2018-01-03 dsinclair Fold CXFA_BindItemsData into CXFA_BindItems 2018-01-03 dsinclair Fold CXFA_BindData into CXFA_Bind 2018-01-03 dsinclair Convert CXFA_StrokeData to CXFA_Stroke 2018-01-03 dsinclair Fold CXFA_CaptionData into CXFA_Caption 2018-01-03 dsinclair Change CXFA_BoxData to CXFA_Box 2018-01-03 dsinclair Fold CXFA_OccurData into CXFA_Occur Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3bffcd6e6fff74192c64b3ad799fce821e0eb358 Reviewed-on: https://chromium-review.googlesource.com/849692 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526912}
-
Xiaohan Wang authored
It seems this function is not used anywhere. BUG=672327 Change-Id: I8c2f9ddb7d3099f769c33ef7885544fddcdc99af Reviewed-on: https://chromium-review.googlesource.com/849645Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#526911}
-
Xiaohan Wang authored
This class is exported, and inlining the constructor and destructor is causing compile errors on Windows when the CdmProxy is used by a component outside of media/. BUG=785563 Change-Id: Ic9e4866d8a9724fe2fdec5d0093a78bc931011d5 Reviewed-on: https://chromium-review.googlesource.com/849472Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#526910}
-
Miguel Casas-Sanchez authored
This CL cleans up a bit the casuistic around CreateForSoftwarePlanes() handling of the different formats, leaving it a bit clearer IMHO: - substitutes the big switch-case by a DCHECK() of supported formats and the explicit handling of LUMINANCE_F16 and R16_EXT. - Uses early-continue in the for-plane_resources loop (less indenting). - Simplifies the logic of |needs_conversion| (it is needed if: - the destination is LUMINANCE_F16 - the destination is LUMINANCE_8 or RED_8 and either: - |bits_per_channel| > 8 or - the origin and destination strides differ.) - Adds a few DCHECK()s. - Extracts a few variables for readability. The code should be equivalent, so it's covered by tests. Bug: 798485 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I46b74cf4b6e82556777d65fa565de52c21891644 Reviewed-on: https://chromium-review.googlesource.com/848648 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526909}
-
Brad Nelson authored
This reverts commit 81ffb00e. (Note partial revert, skipping wpt expectations.) Bug: chromium:798864 Change-Id: I6466c1428aeb5c37f3f7e7c0c12ced06445bc5f6 Reviewed-on: https://chromium-review.googlesource.com/849473Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526908}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9a6756b24ae..edac7184bc0b $ git log d9a6756b2..edac7184b --date=short --no-merges --format='%ad %ae %s' 2018-01-03 agable Let git_footers split final paragraphs in specific cases Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: If2c5e56b69543eaf0260a5c36f15cf940425109d Reviewed-on: https://chromium-review.googlesource.com/849427Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526907}
-
Zhuoyu Qian authored
Move the const value kFirstDynamicTableIndex from hpack_decoder_tables.h to http2_hpack_constants.h Remove the TODO. BUG= Signed-off-by:
-
Antoine Labour authored
After crrev.com/c/812525, crash_keys doesn't need to be a separate source_set duplicated in many components. Just make it part of the gpu component. Bug: 598854 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibaa2e994087401f267a685e0a3c3c7a8f930656d Reviewed-on: https://chromium-review.googlesource.com/849492Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526905}
-
Robert Sesek authored
Crash analysis shows this as a low-volume violation on stable. Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I1a077a5f1f3e975162138fc394766acc9354c9c7 Reviewed-on: https://chromium-review.googlesource.com/848643Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526904}
-
Caleb Rouleau authored
It took me a while to figure out that there was another script named generate_buildbot_json.py in an entirely separate folder used for gpu. Figured this would make it less confusing for the next person. Bug: 795306 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9268786cdbb8db3d84296a740a3039d0b72d3600 Reviewed-on: https://chromium-review.googlesource.com/848249Reviewed-by:
-
Robert Sesek authored
If the HFS volume header's reported variable-length node size is less than the size of a node's base header struct, the data are malformed. Bug: 790013 Change-Id: Ib61e48ad636170c935936fbb4795090c2f8c8f25 Reviewed-on: https://chromium-review.googlesource.com/849076Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526902}
-
Bo Liu authored
Background are things that can be arbitrarily delayed. Image decode doesn't sound like that. Change-Id: Icda58fe75cd21a78beec55cae123754945860993 Reviewed-on: https://chromium-review.googlesource.com/849513Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526901}
-
Chong Zhang authored
This CL: 1. Stores |StoragePartitionImpl*| in |URLLoaderFactoryGetter|, and re-creates |network_factory_| on connection error. 2. Adds basic 'content_browsertests' against |URLLoaderFactoryGetter| and |NavigationURLLoader|. Note: Other |URLLoaderFactoryGetter| consumers such as Service Worker and APP Cache should be able to survive the crash as well. Will add more tests in follow up CLs. Bug: 780956 Change-Id: I65678ece5c852b9454d9c800ff80e4d1cc2de178 Reviewed-on: https://chromium-review.googlesource.com/832947Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526900}
-
Peter Kasting authored
addLinkRange expects non-nil URL pointers to point to nonempty URLs. But infobars may have empty link URLs, for example if they're going to custom-handle the link click by doing something other than a simple navigation. So pass nil in those cases. This fixes a DCHECK exposed by adding infobar UI tests (yay!). BUG=686285 TEST=none Change-Id: I59235a12ea85cc300725e36fc815b07f845ec23e Reviewed-on: https://chromium-review.googlesource.com/849418 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#526899}
-
Tarun Bansal authored
Add histogram to record how frequently network quality is detected as meaningfully changed. Also, add DCHECKs to verify that the RTTs and throughput values are as unexpected. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 798488 Change-Id: Ie0bbf1f691a002a9257bff4c089e9dc8d0156b86 Reviewed-on: https://chromium-review.googlesource.com/846285Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526898}
-
Fady Samuel authored
Prior to this patch, ResizeDueToAutoResize does not always allocate a new LocalSurfaceId. In the case of extension popups, the window is not resized until loading the extension is done: See ExtensionViewViews::DidStopLoading. However, in the meantime, multiple resizes may occur. Surface synchronization expects that a new LocalSurfaceId is allocated every time a CompositorFrame is produced, even if those surfaces aren't referred to by any parent. In order to maintain that invariant, this CL allocates a new LocalSurfaceId on every auto-resize. Bug: 791154 Change-Id: I71cdf101351290276639f95e67f9ebb5d140ab65 Reviewed-on: https://chromium-review.googlesource.com/847942 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#526897}
-
Minh X. Nguyen authored
Bug: 722942 Change-Id: I9b164dda08861749c9d033ff32f4a82391bc0d0e Reviewed-on: https://chromium-review.googlesource.com/822760Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526896}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: Iac87a469d61d677e188a670a4bb8fd501abe914a Reviewed-on: https://chromium-review.googlesource.com/849642Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#526895}
-
Pedro Amaral authored
|LegacyPastePopupMenu#positionAt| expects the coordinates of the bottom of the selection caret not the bottom of the touch handle. Bug: 732742 Change-Id: Idc6d92076695bf865afc093c4980f10e1c48282e Reviewed-on: https://chromium-review.googlesource.com/849493Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#526894}
-
Ahmed Fakhry authored
Instead of pre-populating the feedback description of crash reports with text that ends up being sent to the server, we should instead add this text as a placeholder instruction to the user. BUG=756630 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86bbead3eed94d028277721239cc12fecd886484 Reviewed-on: https://chromium-review.googlesource.com/848501Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
-
