- 18 Sep, 2019 40 commits
-
-
Antonio Gomes authored
... off of content::RenderThreadImpl. This CL changes the ownership of blink::PeerConnectionDependencyFactory as per section 5.1.1 in the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Quoting the document: " PeerConnectionDependencyFactory is currently owned by RenderThreadImpl in content, which makes it a single object per renderer process. This ownership must be moved to a suitable place in Blink. A possibility is to keep it as a global object (using DEFINE_STATIC_LOCAL). The disadvantage of this approach is that PCDF would never be destroyed, whereas it is currently destroyed by the RenderThreadImpl destructor, but this is acceptable. " This move will allow a set of blink::Platform methods to be removed (follow up CL). BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie79f13cfd90c56fcbed50142802b0fcda480c43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807657 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#697750}
-
Jamie Madill authored
This will allow moving the SwiftShader Vulkan module to the root out folder. This in turn will enable more easily running TSAN and ASAN testers. Bug: angleproject:3876 Bug: angleproject:3912 Bug: b/140251624 Change-Id: I3ed8598ca396a445f46d5cddc4d19f997f4e61f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811317Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#697749}
-
rbpotter authored
- Autogenerate Polymer 3 version of managed-footnote and tests - Add to demo page - Add new build targets and browser test files as needed since this is the first CrComponent to be ported. - Also adding a way for the TestDataSource to serve an empty version of strings.m.js, for tests that need to override values in loadTimeData Bug: 965770 Change-Id: Id8ce7b102c8cb86d84e606a6bc9046cecd6f284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809747Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697748}
-
Sadrul Habib Chowdhury authored
Stop reporting the throughput metrics for the UI compositor, since it is currently bundled with the throughput metrics for the renderer. We could report these separately, but it's not clear that these would be used for monitoring the UI performance. BUG=1005226 Change-Id: Ia1572010737a66ecba114cfbb96239f822c1ea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810014Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#697747}
-
Vikas Soni authored
glCopyTexImage2D was causing crash in arm gpu driver for webview. This CL adds a gpu driver bug workaround to do texture to texture copy via drawing to the destination texture instead of doing glCopyTexImage2D. This workaround is applicable on android devices with Mali-T8* gpu. Bug: 991869 Change-Id: I56a011e1a1c21df763fd397467ec0888c4bdfb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803695 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697746}
-
Brandon Wylie authored
The issue here was that StatusMediator#updateLocationBarIcon is called before the state for the dse icon is setup in StatusMediator#updateSearchEngineStatusIcon. This results the google icon being inadvertently downloaded and used instead of the large google g. I added a flag to ensure that setup completes before attempting to show a dse icon. Bug: 1001659 Change-Id: I3b2c32c9710d81ccc6e4d498fb58a0e7ab0ae3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808188 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#697745}
-
Bruce Dawson authored
Thread names are great in general. They are specifically good when doing multi-process debugging because the names of the main threads are the best clue as to which process is which. The crashpad handler threads were notably missing names in a recent debugging session. This fixes that. This is being done in Windows specific Chromium code because that is where the benefit is greatest and because crashpad doesn't have a function to set thread names. Bug: 1004991 Change-Id: Id7163852c3a609856fc50b30932a313e3dd34a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808450Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697744}
-
Lucas Furukawa Gadani authored
This is a reland of cd4d366b Original change's description: > Convert SimpleURLLoader to use mojom types. > > This CL Converts the SimpleURLLoader to use the mojom URLResponseHead > struct instead of the native ResourceResponseHead struct. > > Change-Id: I016b0731930b4589ba6169aa2e24ad45dc6675cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790273 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Charles . <charleszhao@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697317} Change-Id: I51e7519f8ec48ee625ab9eed03b4829d7993e511 Tbr: kinuko@chromium.org, avi@chromium.org, khorimoto@chromium.org, sorin@chromium.org, charleszhao@chromium.org, bsazonov@chromium.org, hashimoto@chromium.org, rkaplow@chromium.org, tbansal@chromium.org, hajimehoshi@chromium.org, mmenke@chromium.org, danyao@chromium.org, dtrainor@chromium.org, zmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811199Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697743}
-
Sam Maier authored
Bug: 998231, 999186 Change-Id: If26cb58677341158e76bc2998bc24104db5fbbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803732 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697742}
-
Juanmi Huertas authored
We only have to disable deferral when it is enable to avoid issues with stack or with performance having to recreate resources and play the matrix transformations all over again. Bug: 1003124, 1001142, 997735 Change-Id: Ib5b60c89b1218dd50c0b97914c08ca921683435a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808276Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#697741}
-
Will Cassella authored
ScriptPromiseResolver has logic in its destructor to ensure that you've either resolved or rejected its promise (or not accessed the promise at all), to catch abandoned promise issues. This technically wasn't an issue for us because we were rejecting the promise via ExceptionState, but since we access the ScriptPromiseResolver's promise it thinks it was abandoned.
😢 Bug: 1003617 Change-Id: I276fde6ca0e2877cdc4793cb1674bca0821ca2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809598 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#697740}
-
Sean Gilhuly authored
Following crrev.com/c/1677233 |content_layer_| is always created in the constructor of DelegatedFrameHostAndroid. Checks to its existence will always be true, so remove them. Bug: 978640 Change-Id: I328519e7bbebb8b053af5f13eafca4cb2581c716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810013Reviewed-by:
-
liberato@chromium.org authored
When VideoFrameFactoryImpl started initializing the CodecImage itself rather than delegating to the SharedImageVideoProvider, the YCbCrInfo for Vulkan wasn't being set; the provider asked the (now uninitialized) CodecImage. This CL makes VideoFrameFactoryImpl cache the YCbCr info itself, using an extra thread hop to the gpu main thread. It does this just for the first few frames, until it receives the YCbCr info once. Then, it re-uses it for all subsequent frames. Change-Id: Ie167b4435b3ece6ec71dfd2f1a36250e7bc4d781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797107Reviewed-by:
Vikas Soni <vikassoni@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#697738}
-
Scott Violet authored
Prior to this patch WebLayer.init() must be called before super.onCreate() (from FragmentActivity), otherwise we hit NPEs. Two changes are necessary to get this working: . Remove call to ApplicationStatus.initialize(). . Supply false to ActivityWindowAndroid so that it doesn't listen to the activity. BUG=none TEST=none Change-Id: I24a80de016b9a8433f883f9d9e9a5c12808abc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810252Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697737}
-
Ivana Zuzic authored
PasswordUpdateDelegate has a new method for saving password changes. It will be used through the PasswordEditing Bridge in the future to save changes made in PasswordEntryEditor. Both PasswordManagerPresenter and the PasswordUpdateDelegate use the editing method from the newly created password_utils file. Bug: 377410 Change-Id: I1ee09fba8f815db99370c30d3c84acf32d1bdb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787507 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697736}
-
Tina Wang authored
- Rename the DeviceIconType attributes. - Remove default case of CreateDeviceIcon because of using desktop icon by default. Bug: 1003812 Change-Id: Ie1e1a9cc9ef397769c8b37d25b867dfd1018cf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802500 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
-
James Cook authored
Follow up for comments in: https://chromium-review.googlesource.com/c/chromium/src/+/1807777 If every settings-subpage is inside a settings-section, then we can clean up the while() loop a bit. Also added a test that an associated control gets a search bubble highlight, which is one of the side effects of this function. Bug: 1003970 Test: browser_tests Change-Id: Ib2509dc5e3ffff075e46c1e61823fdf67229ddea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808423 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697734}
-
Mandy Chen authored
Wrap a user facing string in ls so it's localizable. Bug: 941561 Change-Id: If4285af49d7fd3ca8b2b7c2a447c35900e9efae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793748 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697733}
-
Aidan Beggs authored
This CL updates the URL only for Android to no longer use an answer ID. P-links allow easier tracking and prevent us from deprecating a link that's still used in-product. Bug: 703445 Change-Id: I2bb405e99ef230229a38aab8fa01ae3e5995486d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810840Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Aidan Beggs <beggs@google.com> Cr-Commit-Position: refs/heads/master@{#697732}
-
Tomasz Śniatowski authored
Don't add a string to a list, as that creates a broken depfile with "deps" of single-character paths. Also while there make the depfile preserve the relative path passed in -- use abspath when it's needed instead of ahead of time. Change-Id: Ib61efc68dfc9ecfaac7f3dcb6007bafb9fb8af67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811252Reviewed-by:
-
chrome://flagsPeng Huang authored
Change-Id: Ieff9d96ceb1dc1af2e93b4e9cacd90a02c0b9ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802389 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697730}
-
David Tseng authored
Bug: 990425 Change-Id: I70006053906de020ae8e0ca7f5fda70285e5aeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810254 Commit-Queue: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/122f4535b1be..4599045c795c git log 122f4535b1be..4599045c795c --date=short --no-merges --format='%ad %ae %s' 2019-09-18 yshaul@google.com afdo: Add pupr chrome-profiles handler 2019-09-18 yshaul@google.com Preserve ebuild position and quotes during uprev 2019-09-18 yshaul@google.com Add multiversion support to packages api 2019-09-18 dburger@chromium.org Remove test config override for betty-nyc-arc-release. Created with: gclient setdep -r src/third_party/chromite@4599045c795c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6272f711bb83f5812b7190cc4911ba0b04074331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697728}
-
Abigail Klein authored
Convert the arguments passed to accessibility_ui.cc functions into a dictionary rather than a long list. Since the number of arguments passed to accessibility_ui.cc is expected to grow, this will keep the argument list easier to understand. Bug: 785493 Change-Id: I089e0e6621f57b9b453f650da6c2c9b14386a687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802198Reviewed-by:
-
Ryan Hamilton authored
Change-Id: Ia5780557422a98e990a188e6b538309c31d8dbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810771 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697726}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f9a0238ce40..3f79763629b4 git log 6f9a0238ce40..3f79763629b4 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 thakis@chromium.org Set core.trustctime=false during git checkout operations. Created with: gclient setdep -r src/third_party/depot_tools@3f79763629b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:330461,chromium:642711,chromium:746763,chromium:740301. Change-Id: Ibfd372e677ff40706e35e6f3a7590a7a7bd7d9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811343Reviewed-by:
-
Aran Gilman authored
The main consumer of DistillabilityResult on desktop, the Reader Mode icon, updates whenever the user switches tabs. However, the distillability service usually will not run again when the tabs are switched, so the icon will not update if it sees the web contents' distillability only when OnResult() is called. It needs to be retrieve the distillability of a given web contents in between calls to OnResult(), as well as keep track of which web contents the result belonged to. The simplest solution is to store the result in DistillabilityDriver, since it is already correctly scoped to a single web contents. Bug: 952042 Change-Id: I8a8633a52583f04b49298ee5186b24a5eb092fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788498Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#697724}
-
Patrick Monette authored
Bug: 1004324 Change-Id: I85a80a8d590c44f2f23659bbafb79c6c3b83e059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804513 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697723}
-
Nikunj Bhagat authored
Change-Id: Ib38e214d278c0b4629734e81cb1a473e5b18f5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589363 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#697722}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7259f61fb600..56f9ee6b49fc git log 7259f61fb600..56f9ee6b49fc --date=short --no-merges --format='%ad %ae %s' 2019-09-18 nicomazz@google.com Merge "Implement android traced_consumer socket comunication" Created with: gclient setdep -r src/third_party/perfetto@56f9ee6b49fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie7c745a0482844fac5bbb6f496035e6577428967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810247Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/795cab2777e2..377dbef2b5ab Created with: gclient setdep -r src-internal@377dbef2b5ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005170 Change-Id: I130ff5b06c6483422671e88198fe8380f25af89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697720}
-
Mandy Chen authored
This CL adds the following functions: * Runtime.getResourceURL: returns the request URL given resource name and request base URL (e.g. devtools://devtools/bundle/ or devtools://devtools/remote/serve_file/@010ddcfda246975d194964ccf20038ebbdec6084/) * (Runtime) module: return Runtime.Module object given module name * (Runtime.Module) fetchResource: make a request to load a script of the given name in the current module. This is in the Runtime.Module class so that the request can be adjusted based on if the module is remote or not. We can leverage these functions to request specific files. I'm planning to use them to request the appropriate locale file for lighthouse in the audits worker, e.g. `await self.runtime.module('audits_worker').fetchResource('lighthouse/locales/zh.json')`. Bug: 941561 Change-Id: Ib5c7bfdc46bef7d98533c89b12c7d365d4a26dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784981Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697719}
-
Matt Menke authored
SocketPosix::Close() was freeing the write buffer before destroying a socket. Unclear if this is the cause of the linked bug, but it seems not a great thing to be doing. Bug: 1005042 Change-Id: I2cc35154b6f9de8d272244456eeed5fb9465da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810321Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697718}
-
Wei-Yin Chen (陳威尹) authored
This should not increase the crash rate. Bug: 718153 Change-Id: I86915c51945db21cd5e528d7270150e648fbfc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810035 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#697717}
-
Adrienne Walker authored
This definitely looks extremely sketchy when reading code. Make the BlobReader owned by a callback itself instead of needing to document everywhere that a raw new is ok because the class is self-deleting. Ultimately, this ends up being the same, but is a readability improvement. Change-Id: I56f19679a97e3bf220a09fc7f84d3772972b52c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804821 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#697716}
-
Antonio Gomes authored
BUG=919392, 787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie40d53355cbcfeecd65e30f0bd25334e86ebf5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807716 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d5e8816..46e424ec Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I447a153f9a99df61093fa152fd0aba2c01317638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810723Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697714}
-
John Lee authored
The interactions and visual polish of drag and drop is still in flux but this CL adds basic functionality such that TabElements can be dragged to be re-ordered within the tab strip. This CL also only adds support for reordering tabs within the same pinned status. Bug: 989131 Change-Id: I93cd72ea527f53e2973c98ad1739abb11561e285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800914Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#697713}
-
danakj authored
Emulation only changes a few VisualProperties, and then calls SynchronizeVisualProperties(), which is a subset of OnSynchronizeVisualProperties(). This moves code from inside SynchronizeVisualProperties() to OnSynchronizeVisualProperties() when the emulator does not change those values. This helps to clarify which code needs to run from the emulator and which does not. R=avi@chromium.org Change-Id: Ia8253ab6a32d4fd2c5f0b69c1310536d75faa6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809604Reviewed-by:
-
siashah authored
Bug: 980716 Change-Id: Ib4222f1ab31ed135705a4d3cb3be0531a8ed81a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809408Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#697711}
-
