GitLab

The bookmark sync test case SC_AddFirstBMWithFavicon fails on the
mac_sync trybot.

This patch marks it as failing till such time that a fix is landed.

TBR=akalin@chromium.org
BUG=94941
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/7841014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99847 0039d316-1c4b-4281-b951-d872f2087c98

also change the cursor to pointer. Also make some graphical updates to the contents of the menu.

BUG=95043, 94784
TEST=manual

Review URL: http://codereview.chromium.org/7795025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Run PyAuto remote_host/chromoting_basic on Mac.

Review URL: http://codereview.chromium.org/7841010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99845 0039d316-1c4b-4281-b951-d872f2087c98

This will defer the load of app icons on non-selected apps pages until that page is selected. Anecdotally this provides a noticeable speedup when 50ish apps are loaded.

I don't think this is really covered by any NTP startup test as it requires a lot of apps installed to have any effect. In lieu of creating such a test (which should be a TODO), I  tested locally the time to finish painting by inserting debug statements in NewTabUI::PaintTimeout(). I conducted these tests with the most visited page as the default. For browser startup, this patch reduced paint times from ~560 to ~460 ms on my setup (paint times were pretty consistent across runs). For just NTP startup (without another NTP already open), this patch reduced paint times from ~395 to ~295 ms (and these times were extremely consistent, never varying by more than 10ms from the mean). For reference, I also tested ntp3 and found the browser startup case to be about 570ms and NTP startup to be around 495ms (meaning NTP4 is a win with or without this patch, but especially with this patch).

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7839013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99844 0039d316-1c4b-4281-b951-d872f2087c98

Replaced by hexa literal in the two ui_unittests that need it.

This will make any later changes easier to perform, and it also eliminates the
problem of having binary files which are ignored by patches in the repo.

BUG=none
TEST=ui_unittest:{DataPackTest.*, ResourceBundle.*}


Review URL: http://codereview.chromium.org/7779019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99842 0039d316-1c4b-4281-b951-d872f2087c98

Trivial fix of out of sync IDL files.

TEST= none
BUG= none
TBR= yzshen@chromium.org
Review URL: http://codereview.chromium.org/7789014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99841 0039d316-1c4b-4281-b951-d872f2087c98

Generalizes disabling of OptionsUITest.LoadOptionsByURL.  Seen on Linux.

BUG=64619
TEST=Valgrind goes green on Linux bot.
TBR=csilv@chromium.org

Review URL: http://codereview.chromium.org/7840016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99840 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7828055/ moved all sync test collateral
from chrome/tests to chrome/browser/sync/test.

This patch renames the browser/sync/test/live_sync directory to
browser/sync/test/integration, to differentiate the integration tests
from other test categories (like unit tests, sync engine tests, etc.)

It also renames the class LiveSyncTest to SyncTest, in keeping with the
name changes that went in with the recent sync integration test
framework refactor.

BUG=90905
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/7841007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60215
TEST=test_shell_tests,media_unittests

Review URL: http://codereview.chromium.org/7823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7248018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99837 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of unnecessary chrome_main_ files now that most of the code has been removed from them. I just kept the Mac one since we need a file that can include objective c files.
Review URL: http://codereview.chromium.org/7779018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99836 0039d316-1c4b-4281-b951-d872f2087c98

This makes it a lot easier to build with clang, since setting the GYP_DEFINES
is now the only thing one has to do. The rest is set automatically.
In preparation of setting clang=1 in build/common.gypi on mac.

Depends on http://codereview.chromium.org/7779041/ . Idea and xcode
part of the patch by Mark.

BUG=none
TEST= Set GYP_DEFINES=clang=1, create xcode and make projects
1.) Building with Xcode 3.2 uses clang
2.) Building with Xcode 4 gives functional fixits
3.) Building with make uses clang both for host and target
4.) Building with xcodebuild and goma still works on mac
5.) Building with make and goma still works

Review URL: http://codereview.chromium.org/7779039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99835 0039d316-1c4b-4281-b951-d872f2087c98

Revert 99802 - Valgrind test failures on Mac in test NPAPIVisiblePluginTester.DeletePluginInDeallocate

The exception this CL adds is no longer necessary since the test itself has been determined to be flaky on Mac.

BUG=95547
TEST=Mac Valgrind goes green.
TBR=wez@chromium.org

Review URL: http://codereview.chromium.org/7840009

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7840014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99834 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99833 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7841003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99832 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the plumbing to use the theme provider for panel windows:
- Updated the xib so the created window is a ThemedBrowserWindow, which knows how to delegate theming related calls to the window delegate.
- Implemented -[ThemedWindow themeProvider] for PanelWindowController.

BUG=none
TEST=no more yellow panel titlebars.

Review URL: http://codereview.chromium.org/7734003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99831 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/93947
TEST=none

Review URL: http://codereview.chromium.org/7839002
Review URL: http://codereview.chromium.org/7839002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99830 0039d316-1c4b-4281-b951-d872f2087c98

Expands test exclusion for failing test on TSAN / Mac bot.

BUG=93245
TEST=TSAN bot goes green.
TBR=allanwoj@chromium.org

Review URL: http://codereview.chromium.org/7839011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91840
TEST=BUILD


Review URL: http://codereview.chromium.org/7810001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87378
TEST=None
Review URL: http://codereview.chromium.org/7782012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95274
TEST=none
Review URL: http://codereview.chromium.org/7789007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99826 0039d316-1c4b-4281-b951-d872f2087c98

Revert 99648 - Reland 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages.

After the context is created, the remaining calls should be done on
the compositor thread. This CL adds a MaybeInitializeGL() method, which
we run on each call to makeContextCurrent().

Added asserts to RendererGLContext to check that it's always used on
the same thread.

Original review URL: http://codereview.chromium.org/7713015
Reverted due to buildbot errors: http://codereview.chromium.org/7745042
Review URL: http://codereview.chromium.org/7828046

TBR=husky@google.com
Review URL: http://codereview.chromium.org/7838008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99825 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95356
TEST=NULL


Review URL: http://codereview.chromium.org/7835042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99824 0039d316-1c4b-4281-b951-d872f2087c98

TEST= ./generator.py & try
BUG= http://code.google.com/p/chromium/issues/detail?id=89968
Review URL: http://codereview.chromium.org/7833031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99823 0039d316-1c4b-4281-b951-d872f2087c98

GpuChannelHost can actually outlive the GPUChannel instance (if there is still a context
referencing it). Therefore filter destruction can legally happen on IO, main, or
compositor thread. Put more explicit DCHECK()s to for the member function that must
be called on the IO thread instead.

BUG=95148


Review URL: http://codereview.chromium.org/7835010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95558

Review URL: http://codereview.chromium.org/7840011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99821 0039d316-1c4b-4281-b951-d872f2087c98

Inside driver change: http://codereview.chromium.org/7737032/

BUG= http://code.google.com/p/nativeclient/issues/detail?id=1554
TEST= build chrome, host files for "run_pnacl_example_browser_test" and "run_pnacl_bad_browser_test" from a nacl repo (since there is no pnacl toolchain downloaded in chrome repo) and load the test.

Review URL: http://codereview.chromium.org/7828088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95557
TEST=None
TBR=dmichael

Review URL: http://codereview.chromium.org/7837009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99819 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99818 0039d316-1c4b-4281-b951-d872f2087c98

copy over .pak files and it works on a clean build. Also define
NativeComboboxWrapper::CreateWrapper for aura.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7779053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99817 0039d316-1c4b-4281-b951-d872f2087c98

1028: Change how hard_dependencies of static_libraries are computed
1029: Change to the json backend
1030, 1031: make_global_settings support

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7839006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99816 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of a LazyInstance usage to get rid of code execution at static init time. This doesn't need to be thread safe.

BUG=94925
Review URL: http://codereview.chromium.org/7756015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99815 0039d316-1c4b-4281-b951-d872f2087c98

A stab at fixing a crashing bug and a bandaid to prevent the crash if that stab is in the wrong place.

BUG=94620
Review URL: http://codereview.chromium.org/7835023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99814 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/93947
TEST=none
Review URL: http://codereview.chromium.org/7839002

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7840010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99813 0039d316-1c4b-4281-b951-d872f2087c98

- DBus.SyncMethodCallTime: time spent to perform synchronos method calls
- DBus.AsyncMethodCallTime: time spent to perform asynchronos method calls
- DBus.SyncMethodCallSuccess: success ratio of synchronous method calls
- DBus.AsyncMethodCallSuccess: success ratio of asynchronous method calls
- DBus.ExportedMethodHandleTime: time spent to handle calls to export methods
- DBus.ExportedMethodHandleSuccess: success ratio of the exported method calls
- DBus.SignalHandleTime: time spent to handle signals
- DBus.SignalSendTime: time spent to send signals

BUG=chromium:90036
TEST=dbus_unittests

Review URL: http://codereview.chromium.org/7824054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99811 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/93947
TEST=none
Review URL: http://codereview.chromium.org/7839002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95317
TEST=Check that querying for mail.google.com in the HSTS debug UI (under about:net-internals), works.


Review URL: http://codereview.chromium.org/7739031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99809 0039d316-1c4b-4281-b951-d872f2087c98

This is neccessary to make the interface usable with stanzas generated
by JingleMessage::ToXml().

BUG=None
TEST=Unittests

Review URL: http://codereview.chromium.org/7809003

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7841006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99807 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7789008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99805 0039d316-1c4b-4281-b951-d872f2087c98

beta give 20 mins for shutdown.

BUG=95506
TEST=shutdown
R=jar

Review URL: http://codereview.chromium.org/7839003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99804 0039d316-1c4b-4281-b951-d872f2087c98