GitLab

Remaining usage of pending_navigation_params_ in renderer initiated
navigations where it is always false.

Bug: 789577
Change-Id: Ie8c214b01922f96f9bf3f8b5f6e6be4e82273bed
Reviewed-on: https://chromium-review.googlesource.com/1189804Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588801}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/2c8e6279a7bf..9789c75b1a6f

$ git log 2c8e6279a..9789c75b1 --date=short --no-merges --format='%ad %ae %s'
2018-09-04 wl More '...' vs. `...` fixes in API documentation.
2018-09-04 wl Make `/****...' comments in public headers uniformly end on column 77.
2018-09-03 apodtele * docs/DEBUG: s/trace_//.
2018-09-03 ramakrishnan.nikhil [docwriter] Don't break code snippets accross lines.
2018-09-03 wl include/freettype/config:*.*: Convert comments to Markdown syntax.
2018-09-03 wl */*: s/PSNames/psnames/.
2018-09-03 wl [sfnt] Fix heap buffer overflow in CPAL handling.
2018-09-01 wl Remove `FT_Outline_{New,Done}_Internal'.
2018-08-31 apodtele * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Check glyph format.
2018-08-31 prince.cherusker [errors] Refine the macro logic surrounding `FT_Error_String'.
2018-08-31 wl Whitespace.
2018-08-31 wl * src/base/ftdebug.c (FT_Throw): Restore missing `FT_UNUSED' calls.
2018-08-31 wl * src/base/ftdebug.c (FT_Throw): Reduce chattiness.
2018-08-31 wl Minor comments.
2018-08-31 wl Whitespace.
2018-08-31 wl Add link to OpenType's composite glyph description.
2018-08-31 wl * src/autofit/afhints.c (af_glyph_hints_reload): Add initialization.
2018-08-30 apodtele Consolidate bitmap presetting and size assessment.
2018-08-30 apodtele * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Correct mono.
2018-08-30 prince.cherusker [errors] Introduce a macro to control `FT_Error_String'.
2018-08-30 prince.cherusker [errors] Introduce `FT_Error_String'.
2018-08-30 wl [autofit] Trace `before' and `after' edges of strong points.
2018-08-30 wl Minor.
2018-08-30 apodtele [base] Overflow-resistant bitmap presetting.
2018-08-29 wl Doc fix.
2018-08-29 prince.cherusker Fix numeric overflows.
2018-08-29 wl ftoption.h: s/precendence/precedence/ in documentation (#54586).
2018-08-29 wl [cff] Fix handling of `roll' op in old engine.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1145
Change-Id: I5b11c49ad02a0919ea2de1162145c73994c388d3
Reviewed-on: https://chromium-review.googlesource.com/1204272
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588800}

The browser process is the sole responsible for shutting down its
renderer processes. Surprisingly, there was some logic in the renderer
process to request self shutdown.

Previous CL disabled renderer process initiated shutdown. This CL
removes associated logic to increment/decrement the reference counter.

Bug: 873541, 609963, 535246
Change-Id: I06bc6670d84dcad597bf98eea6c3e07242f341b6
Reviewed-on: https://chromium-review.googlesource.com/1177748Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588799}

The explanation line "Google Chrome may use web services..." is
removed from the Privacy & Security settings section when Unified
Consent is enabled.

Bug: 869683
Change-Id: Ic189edcc55a0c2bfc306d815e90fc78e6e09d087
Reviewed-on: https://chromium-review.googlesource.com/1204230Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588798}

This CL introduces a mechanism for handling "initial values" for SVG
properties. The initial value is stored in a new
|initial_value_storage_| field in SVGAnimatedPropertyBase. Subclasses
that need to store an initial value - for many cases a default
initialized object is sufficient - define what is stored in the allotted
number of bits (and thus indirectly how many bits that are required.)

The SetInitial method needs to be overloaded on the SVGPropertyBase
subclasses that the SVGAnimatedProperty holds, and is responsible for
resetting the value of the property (after "decoding" the value.)

This CL adds an implementation of the above for SVGAnimatedLength. For
this type, the initial value is stored as an index into a table of
values.

The 'fx' and 'fy' properties on SVGRadialGradientElement are updated to
have their initial values be 50% (matches Gecko.)

Bug: 225807, 474523
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ida144d6bed2d1946186e8fb3b3a0b9695ca81789
Reviewed-on: https://chromium-review.googlesource.com/1193822Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588797}

Rename OnFormActivity -> FormActivityRegistered
Rename DidSubmitDocument -> DocumentSubmitted

Bug: 823285
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4b02df2eb26e7af88e35dc92f24310220a2e57b6
Reviewed-on: https://chromium-review.googlesource.com/1193856Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588796}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I966cadf2a56fe70ca042e6cd1827592b0a00f40b
Reviewed-on: https://chromium-review.googlesource.com/1205603
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588795}

In the main settings page, there was no visible difference between the
"sync paused" state and sync unrecoverable errors. This CL adds the
distinction between the two.

In people handler, allow opening the Sync settings in all cases when
UnifiedConsent is enabled. Otherwise, it is not possible to reauthenticate
to fix an actionable Sync error (because the reauthentication requires
opening the sync settings, but they would instantly autoclose).

In the toolbar menu, the error was not removed on signout, because the
code was only checking for the internal sync errors and not for the
signin state.

Bug: 879503
Change-Id: I247dc3ca3cbf20e49177e1343a5e4db38aeb257e
Reviewed-on: https://chromium-review.googlesource.com/1199592Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588794}

Before this patch, devtools message for OCSP verification error was just
two integer status codes (OCSPVerifyResult and OCSPRevocationStatus enum
values). This patch converts these status codes to developer-friendly
error messages.

Bug: 815024
Change-Id: Ide3593c61698f0bebe87f8c5ef7a8c69f55afebf
Reviewed-on: https://chromium-review.googlesource.com/1205915Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588793}

Previously we used the *layout* viewport's rectangle to determine
if a certain node was visible or not. Let's use the *visual*
viewport instead. Now:

 A visible node is a node that intersects the visual viewport.

This logic is used by spatnav to rule out offscreen focus candidates
and an offscreen activeElement. When activeElement is offscreen,
spatnav doesn't use it as its search origin; the search will start
at an edge of the visual viewport instead.

For consistency, I replaced all other uses of LayoutViewport()
with GetScrollableArea() - even though fixing HasOffscreenRect()
was enough to fix Issue 823227.

Bug: 823227
Change-Id: I8a89cfc98d896998b899a5246f2c38e23fe0171b
Reviewed-on: https://chromium-review.googlesource.com/1204094
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588792}

This reverts commit 0ee23351.

Reason for revert: Top crash in canary and blocks dev release
per bug 880021.

Original change's description:
> Count number of active touches in TouchActionFilter
> 
> Right now we have a active_touch_in_progress_ to indicate whether there
> is an active touch or not. It is true when we receive ACK for touch
> start and false at touch end.
> 
> From the current crash report, we are seeing multiple consecutive ack
> for touch end, without any ack for touch start in between.
> 
> This CL changes the active_touch_in_progress_ to num_of_active_touches_.
> It is increased by one when we receive ack for touch start and decrease
> by one at touch end. At touch end, we only reset touch action when this
> number is zero.
> 
> In theory, touch start and associated touch end should arrive in pair.
> This CL does a DumpWithoutCrashing if this number is ever larger than
> one.
> 
> Bug: 851644
> Change-Id: I584f1aad56bf5bc5c08e20e3ae4ca36d5f9e3586
> Reviewed-on: https://chromium-review.googlesource.com/1196696
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587813}

TBR=dtapuska@chromium.org,xidachen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 851644, 880021
Change-Id: I265b573cef100ff6210683e7f5ec01dfcb28ea9f
Reviewed-on: https://chromium-review.googlesource.com/1205923Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588791}

https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout

Bug: 877104, 877300, 698165
Change-Id: I994550295c15f9b42273abc7d1b11f47dc0bb0c7
Reviewed-on: https://chromium-review.googlesource.com/1205917
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588790}

On 301/302/303 redirect, we may change the request method to "GET".
While that is done by net/ logic, we need to reset the body manually
in CORSURLLoader for some cases.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id864729a8adaa29af52bc4e7d8c3455b57e2528c
Reviewed-on: https://chromium-review.googlesource.com/1205974
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588789}

Cause of revert:
===============
A few MediaLauncherActivityTest don't run on the CQ. They were waiting
on SeparateTaskCustomTabActivity to finish, but it is no more used.

Original description:
=====================
Remove SeparateTaskcustomTabActivity for Android version > L.

Make SeparateTaskcustomTabActivity to be used only for Android version
pre L. The part used for Android version >= L is merged into
CustomTabActivity.

This is a prerequisite for skipping the ChromeLauncherActivity and
directly launch the CustomTabActivity.

TBR=tedchoc@chromium.org
R=lizeb@chromium.org

Bug: 681559
Change-Id: I121241a2f43f62c346a24adb153649bec3b80af3
Reviewed-on: https://chromium-review.googlesource.com/1201845Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588788}

 - send-redirect-bogus-sync.htm is not failing any more. Remove the
   entries.
 - send-authentication-existing-session-manual.htm and
   send-authentication-prompt-2-manual.htm are listed in
   NeverFixTests. Move the virtual/outoblink-cors[-ns] entries to the
   file as well.

Bug: 870173
Change-Id: I6c94bb6b3559727133b94a1915f0b8cc89705525
Reviewed-on: https://chromium-review.googlesource.com/1206052
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588787}

Change-Id: I32ea66dcd6d7466573c0ed143038d9edb241ac86
Reviewed-on: https://chromium-review.googlesource.com/1199763
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588786}

This reverts commit bde179ef.

Reason for revert: http://crrev.com/880583 : The ASan LSan problems disappeared even before the revert was included, and once revert was included there were no extra fix. Therefore relanding the CL.

Original change's description:
> Revert "Implement script and style attr/elem CSP directives"
> 
> This reverts commit b691cab2.
> 
> Reason for revert: http://crbug.com/880583 : ASan detected memory leaks, so speculatively reverting.
> 
> Original change's description:
> > Implement script and style attr/elem CSP directives
> > 
> > The functionality is behind the
> > ContentSecurityPolicyExperimentalFeaturesEnabled flag
> > 
> > I2IS: Coming Soon
> > 
> > Spec:
> > https://w3c.github.io/webappsec-csp/#directive-script-src-elem
> > https://w3c.github.io/webappsec-csp/#directive-script-src-attr
> > https://w3c.github.io/webappsec-csp/#directive-style-src-elem
> > https://w3c.github.io/webappsec-csp/#directive-style-src-attr
> > 
> > Change-Id: Ic1638cac15c7ec488fcc7a4c9f6261b97502090a
> > Reviewed-on: https://chromium-review.googlesource.com/1181050
> > Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> > Reviewed-by: Mike West <mkwst@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#588534}
> 
> TBR=mkwst@chromium.org,andypaicu@chromium.org
> 
> Change-Id: I385cd9eae7190412199496b3625dbf94d1fa45a6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1205392
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588674}

TBR=huangs@chromium.org,mkwst@chromium.org,andypaicu@chromium.org

Change-Id: Id0429ccdf59ec803077394f2300058051b0492c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1205478Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588785}

ThreadableLoader re-creates the request on redirect for some cases. We
need to remember whether we need notification for uploading.

Bug: 870173
Change-Id: Ic7e4847c4d4c9facb57cd09cb85b04ca78ddfca7
Reviewed-on: https://chromium-review.googlesource.com/1206170Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588784}

This CL aims to solve Issue 877341, which plans to replace
content::ChangedVersionAttributesMask with a new mojom type:
blink::mojom::ChangedVersionAttributesMask.

Bug: 877341
Change-Id: I2670e5ad52fce4e01281567dd8a7e55165ece51e
Reviewed-on: https://chromium-review.googlesource.com/1201350Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#588783}

This makes CORSURLLoaderFactory use OriginAccessList
to check the source origin and destination URL pairs in the
allowed list.

There is no caller in production code at this moment, but
patch set to support the legacy path and NetworkService will
follow respectively.

Bug: 870172
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iba37beb1d955edf05148ad9ac15731e64e58de1e
Reviewed-on: https://chromium-review.googlesource.com/1196702
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588782}

TBR=stevenjb@chromium.org

Bug: 879943
Change-Id: I2f6168bc46c5c5e42e422c7acd7af35618a27ffc
Reviewed-on: https://chromium-review.googlesource.com/1201623Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588781}

This CL removes the member |is_valid_| of
blink::WebServiceWorkerInstalledScriptsManager::RawScriptData, which
becomes easy to be replaced with
blink::InstalledScriptsManager::ScriptStatus for the next step when we
remove blink::WebServiceWorkerInstalledScriptsManager and move
content::WebServiceWorkerInstalledScriptsManagerImpl into Blink.

BUG=792778

Change-Id: I14fcdfbb276007fa87428b19a9029fb722b78647
Reviewed-on: https://chromium-review.googlesource.com/1200682
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588780}

Previously all touch events were ignored on Chrome side on child notification. But that caused the issue on scrolling (see the issue).

This CL changes the behabior to disable only top-level slide on child notifications so that scrolling is possible correctly even on them.

Bug: 876430
Test: manual (observe no issue)
Change-Id: Ieb88ad19a94f71612998039e3a9abe4e91fc3856
Reviewed-on: https://chromium-review.googlesource.com/1203757Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588779}

Change-Id: Idb5857427ebb5134ec7c273f266e1f798322dbd2
Reviewed-on: https://chromium-review.googlesource.com/1205922
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588778}

Calling UpdatePlaceholderVisibility on StyleDidChange makes us mark
style dirty in the middle of a layout tree rebuild.

Bug: 868810
Change-Id: I070e9fd576e21768099297767f2eddaaf401068c
Reviewed-on: https://chromium-review.googlesource.com/1205150Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588777}

Bug: 879943
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I66d8f9f539c27e908208a121882e5c5fb84eedc2
Reviewed-on: https://chromium-review.googlesource.com/1201504Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588776}

Bug: 872560
Change-Id: I58fbd5b4252eb6eae69e13a81ac5638cd27a83ec
R: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1189518Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#588775}

ServiceWorkerContextClient requests its termination when the worker gets idle.
However, when the browser knows DevTools is attached to the service worker, the
termination request is silently dropped. After that, even if
ServiceWorkerSubresourceLoader tries to trigger fetch events, those requests
will be queued indefinitely. This CL is to notify the renderer to run tasks
again when DevTools is attached.

Bug: 878667
Change-Id: Iefdc4382489b68aae28aab57b5a7c96520795d14
Reviewed-on: https://chromium-review.googlesource.com/1194820Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588774}

There are some tests that call testRunner.addOriginAccessAllowListEntry
even in navigation and security test directories.

They are expected to call it to bypass renderer-side security checks,
but let me run them in our outofblink-cors(-ns) virtual environments
just in case.

Also the security directory seems to contain many relevant tests
that rely on CORS check on ResourceFetcher.

Bug: 870172, 870173, 879991
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_mojo
Change-Id: I55c75b6766da6b98c7a2d816fbcfec555d181b68
Reviewed-on: https://chromium-review.googlesource.com/1193524Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588773}

R=sky

Change-Id: I3e922309a769c1a3f7c8d3aab8703652112bb3ac
Reviewed-on: https://chromium-review.googlesource.com/1205720Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588772}

Bug: 877043
Change-Id: Iab18132a8c4750de0f7f96601f6232c41e3aaf54
Reviewed-on: https://chromium-review.googlesource.com/1194544Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588771}

- Use DriveIntegrationService::GetMountPointPath() in
  GetDownloadLocationText() to get the Drive mount path.
- Update the test to explicitly cover DriveFS-enabled and
  DriveFS-disabled cases.
- Change DriveFsHost to return the expected mount path when unmounted.
- Make test-only ProfileHelper methods public, making the list of
  friends mostly unnecessary.

Bug: 879422
Change-Id: I162ef7e74d58b400d9242be599700c4491fba6c7
Reviewed-on: https://chromium-review.googlesource.com/1201632Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588770}

ChromeVox+O>E to enable logging.
ChromeVox+O>D to disable logging.

Bug: 880004
Change-Id: I25e618e1bb986432722b59cb7669808006bea354
Reviewed-on: https://chromium-review.googlesource.com/1201515Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#588769}

https://skia.googlesource.com/skia.git/+log/85f4e40c5481..72a02112a99f


git log 85f4e40c5481..72a02112a99f --date=short --no-merges --format='%ad %ae %s'
2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@72a02112a99f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Idec39d365bed5736c161d045f9a5e2ae7ac83e3c
Reviewed-on: https://chromium-review.googlesource.com/1205618Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588768}

Merge the two into content::GetAndroidOSInfo(), and update the

that it is not actually available on Chrome OS.

base: :SysInfo::HardwareModelName() header comment to reflect the fact
Change-Id: I68573105d1025d701ea6c4b457d9ee5e0c033e38
Reviewed-on: https://chromium-review.googlesource.com/1198568Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588767}

Some content settings types don't support embedded patterns, however
it's currently possible to set embedded patterns for these types.
https://chromium-review.googlesource.com/c/chromium/src/+/1173192 stops
this from being possible, however if these patterns were already written
to a pref then they will still be there. This CL deletes those patterns.

Bug: 802945
Change-Id: Ia7fd878ba3d1a635bb92215f0b6dbba04519a07c
Reviewed-on: https://chromium-review.googlesource.com/1175518Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588766}

The braille cursor (when content is wrapped) persists even after the content to which is pertains changes. Prevent this from happening by explicitly omitting the cursor when the start/end index of the cursor is -1.

Change-Id: I5a0dbeea9e73e3d60bef25e7fe68be2cc6d97f0d
Reviewed-on: https://chromium-review.googlesource.com/1200362Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588765}

Currently browser_tests on win7_chromium_rel_ng sometimes took more than 10 mins.
Let me increase the number of shards for such tests.

e.g
753s https://ci.chromium.org/b/8936390613165886176
732s https://ci.chromium.org/b/8936406831776876544
706s https://ci.chromium.org/b/8936396862731996176
704s https://ci.chromium.org/b/8936363432077079248

Bug: 868114
Change-Id: I9a7eb07ce2c58f5b03e5f39152dba7ac6101f11b
Reviewed-on: https://chromium-review.googlesource.com/1203519
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588764}

These macros don't add much besides saving a single GtkWidget* parameter to the
corresponding CHROMEG_CALLBACK macros.

R=sky

Change-Id: Ia64bb5b6f96df3f33d7adc61a50781f73bf0ae1c
Reviewed-on: https://chromium-review.googlesource.com/1205597Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588763}

Bug: 879943
Change-Id: I005e99857d2609ffed42bba5d5968c84a23ad7d5
Reviewed-on: https://chromium-review.googlesource.com/1201642Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588762}