- 11 Nov, 2020 40 commits
-
-
Evan Stade authored
Bug: 1146058 Change-Id: I1a1edd86cc077816f233fc9a9abde2399800009f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526734 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826501}
-
Majid Valipour authored
Previously when using the Auto backend no user prompt would be shown. This patch changes this logic to treat the Auto backend the same as the verification backend. Note that the Auto backend may use either of the GMS APIs which may or may not require the user prompt. A follow up patch [1] changes the prompt decision to be made per otp request and based on the actual API used instead of once based on the switch value. However treating the Auto similar to the Verification makes sense as a quick fix since Auto is most likely to use the Verification method anyway for the vast majority of cases. Worst case if the other backend is used we show two prompts (one native, one chrome) which is still better than no prompt. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530272 Bug: 1141024 Change-Id: I64ada09187281f99fe97770d7cfcaca8f5867adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532874 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826500}
-
Maggie Chen authored
This is to notify DirectCompositionSurfaceWin if there are display metrics change(s) such as desktop resolution on the monitor(s). DirectCompositionSurfaceWin needs the current monitor size. Bug: 1027046 Change-Id: I0df02aa4a566723468219d9333b5f26379688700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523903Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826499}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2517220 For Android, machines don't have CPU dimensions, so specifying arm64 results in matching nothing. For Windows, machines only have x86-64 dimension. Use those machines even for x86 case, because the binary built for x86 can be run on x64. Bug: 1121427 Change-Id: I0c3d86804903fba2ebca02e22eecba536d48eca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532018Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826498}
-
Mark Mentovai authored
dec31e17 (https://chromium-review.googlesource.com/c/2523446) was supposed to make memory allocations use MAP_JIT on macOS ≥ 10.14 whenever the hardened runtime wasn’t active, but a serious goof inverted the logic, causing MAP_JIT to be used whenever the hardened runtime was active. This is only feasible for processes that have the JIT entitlement, and not all do. Attempts to allocate memory in this way in affected processes would fail, which would appear as an out-of-memory condition, which isn’t quite accurate, but it’s definitely a memory allocation problem. Bug: 1144200, 1147831 Change-Id: I9c8f925ec7b311b2d655dd3a5f367fd01e80d7e2 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532728 Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#826497}
-
Clark DuVall authored
Change-Id: I26dbdb4de0232900aac095fc22c67beb7b7bdd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532868Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f3c829047220..3120d5ea0de8 2020-11-11 enga@chromium.org Track and destroy all child objects on wire client destruction If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: Iffd559d3771f61a972f7e6fc4230468ed8409c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826495}
-
Robert Sesek authored
This adds a process_stubs.cc implementation for iOS and NaCl to have an implementation of process.h. Bug: 1008512 Change-Id: I44a478a790bfe8c3aabc17298a2ddb99efb2bf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517924 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#826494}
-
Xi Han authored
When Instant Start is enabled, the visibility of voice_search_button is set pre-native. However, TasksSurfaceMediator#initWithNative() overwrites this value. In this CL, we move setting the default value of IS_VOICE_RECOGNITION_BUTTON_VISIBLE to the constructor of TasksSurfaceMediator. Bug: 1139026 Change-Id: I08fb94576a665975279ace075a6fa6b86874a30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523441 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826493}
-
Aya Elgendy authored
Add UI support for alphanumeric pins used on user login via smart cards. Previously, Latin letters were consciously ignored. Also added a unit test for non-digit pin inputs. Bug: 1144194 Change-Id: I556f1fd8a07fa1a8a1d76130ee116c3a0e86e2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518976Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Nader Elgendy <ayag@chromium.org> Cr-Commit-Position: refs/heads/master@{#826492}
-
Mei Liang authored
Without a deep dive investigation, I could not tell what is the root cause of this NPE. This CL adds a null check and skips the null tab to calm down the crash rate. A TODO is added to remind us to revisit this NPE. TBR=wychen@chromium.org Bug: 1146320 Change-Id: Iaeb5de83bf3fe95c1adafcd973c503acbfcf93aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532867 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826491}
-
Liquan (Max) Gu authored
This CL separates onPaymentDetailsNotUpdated into the common part and the chrome specific part. The common part is moved into PRService. Change-Id: I4252f0e1227c78b3100511076ac24826b441a321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533413 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826490}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bcwhite@chromium.org Bug: 1145565 Change-Id: I68423d748501ffba5239606311b518844e1c51a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532955 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#826489}
-
Evan Stade authored
MediaNotificationInfo.mediaSessionActions is changed such that it remains null when the notification is not associated with a web MediaSession (i.e. is for Presentation or media fling). Bug: 1126708 Change-Id: I026ebc2fc41cd3497f79ecce9d463141c7a020c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515050Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#826488}
-
Taylor Bergquist authored
Bug: 1145905 Change-Id: I59ae16d3b6a87f1341fdfb187588d8b99e5a3805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528182 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826487}
-
danakj authored
This is a reland of 6f8b5118 Original change's description: > Remove empty base/bind_helpers.h > > The contents moved to callback_helpers.h. > > Also renames a few new bind_helpers.h includes that have been added > in the meantime. > R=dcheng@chromium.org TBR= NOTRY=true > > Change-Id: Ia511a4939d60bd2ef5b474185e3716017543f8af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523545 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826387} Change-Id: If86adf5fc9760ac6785cbfdd211ef7ffeb940ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532967Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Show instructions and hide error details when entering the dino game via chrome://dino. Bug: 1138722 Change-Id: Iacfc5a5bb836230e0e7b115ae8f6bea504dc9655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527641 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#826485}
-
Dave Tapuska authored
There is no need that this API needs to exist on the FrameWidget, we can go directly to the the WebView from WebLocalFrameImpl when notifying of detaching the frame tree. BUG=1097816 Change-Id: Ida6fada222c2dd972d6f4661c8c8c6680f81205d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532668Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4ed9d3498dcf..e1012cfc791d 2020-11-11 srisser@google.com Add SPIR-V tools dependency to BUILD.gn files 2020-11-11 natsu@google.com Fix Android build 2020-11-11 amaiorano@google.com Add a unit test for bug fixed by swiftshader-cl/50008 2020-11-10 srisser@google.com Track SPIR-V version in VkConfig.hpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I90d30b75f3c41fe2f938d4a5954f2f4281c27e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533101Reviewed-by:
-
Jinsuk Kim authored
- Allow running from outside the repo (--git-dir) - Date range for how many days to look back (--past-days) - Write metadata about start and end date parameters Also moved the script under tools/android/modularization/loc Bug: 1146478 Change-Id: Ic63ea085836d8b5750ada2299ba992221d97b9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526863 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#826482}
-
Mehran Mahmoudi authored
This attepts to fix StartupPaintPreviewHelperTest#testDisplayOnStartup by waiting for activity to be destroyed first. Bug: 1145783 Change-Id: Icd949712cb348dc12829a6eddec17b86045d2c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533030Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826481}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=nancylingwang@chromium.org Bug: 1145565 Change-Id: Ia8d2596dcd98bf0762357de363585affa59dff57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532722 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#826480}
-
Austin Eng authored
Bug: 951558 Change-Id: I9692746c89e7a4af6d69864d1efadee3014fdb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530752Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#826479}
-
Eugene Zemtsov authored
Bug: 1146170 Change-Id: Idd807b7f6e2618c8b4e1f161a2c66d74b4b40374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531901Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826478}
-
Jamie Madill authored
The current tests take 16-20 minutes per shard to complete. Given that these tests are still increasing in time as we add new features to ANGLE we can double the shard count on Android from 10 to 20. Bug: angleproject:5323 Change-Id: I313b58576e22ae1fe3d05196e58b5076f6ae137b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533032Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#826477}
-
dpapad authored
Moving all IDR_WEBUI_HTML_* resources from webui_resources.grd to the auto-generated webui_generated_resources.grd. Bug: 1132403 Change-Id: Ib3230803549a8f49f6ee41f2644da3b91954b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519854 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#826476}
-
Liquan (Max) Gu authored
Separates CPRService#continueShow into two parts - PRService#continueShow and CPRService#continueShow. The former is shareable with WebLayer; the latter is chrome specific. Bug: 1131059 Change-Id: I68848a3c31b380282ecccd1aaa579ee50e537cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533137 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 1144279 Change-Id: Ie37c2e905006528d1c143990792b1c6706fa9ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533282Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#826474}
-
Alex Turner authored
Disables SubresourceFilterBrowserTest. PopupWithDocWriteAbortedLoadAndOpenerClosed_FilterChecked, which is flaky after recent changes in crrev.com/c/2515181. It appears the original test did not always have the expected sequence of navigations. Change-Id: I7fe3b2b5d5a181a69b86202b79853318a212dd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532968 Commit-Queue: Alex Turner <alexmt@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#826473}
-
Michael Chang authored
The purpose of this CL is to implement an integration between the browser and the new Chromium updater. Everything related to the Chromium updater is behind a build flag, so that the functionality can be easily turned on and off. This CL is more mac oriented in its implementation. Implementation ranges from installing the updater, promoting the updater to be the latest, registering the browser to the updater and requesting on-demand updates to the updater through chrome://settings/help page. Bug: 1063435,1048654 Change-Id: I36154dc6e93a31d491d81ad038e78b37e057116a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340874Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Bailey Berro authored
This change adds the CpuUsageDataObvserver to SystemDataProvider. A subsequent change will add throttling data to the CpuUsageData object JS-side implementation of observer: https://source.chromium.org/chromium/chromium/src/+/master:chromeos/components/diagnostics_ui/resources/cpu_card.js;l=58-69 Bug: 1128204 Change-Id: I7ef493691dea63460753c56f066f6744591dbea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518265Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#826471}
-
minch authored
- Live update the colors of splitview divider and splitview divider handler bar. - Remove RoundedRectView. Replace it with CreateRoundedRectBackground. Bug: 1131543 Change-Id: If0adeaa835aafb28b6d31ffb7a93f816a8900012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531188Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#826470}
-
James Cook authored
For lacros, some files there are being renamed from _ash to _chromeos. I'm an owner of _ash, so make myself an owner of _chromeos also. Bug: 1113900 Change-Id: I9d96bfa14fa7d52a2ce32b1bdc156b6be0f33930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533279 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605095997-0fa3ee75d8821b5496131dad83892a7849a68c0e.profdata to chrome-linux-master-1605115854-1e3902a349595a3aefdefcca21db1c4eb58b3341.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I830244181d1859fe6059607039272a27446445af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532985Reviewed-by:
-
yilkal authored
This cl updates the css and style related javascript code to ensure that: 1. we provide the right amount of space for the online flow. 2. the buttons are appropriately positioned. Screenshots: 1. Error page in-session: https://screenshot.googleplex.com/BurFBisi6LzZXmh 2. Gaia in oobe: https://screenshot.googleplex.com/8gnN8kGjdKbXQAL 3. Gaia in add person flow: https://screenshot.googleplex.com/7yqbR6d278rA3vv 3. Gaia in session: https://screenshot.googleplex.com/53mkzXwjzAxN6tb Bug: 1143470 Change-Id: Ic6228c2dbb11a5848971375b7a7c669d3479f6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523727Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826467}
-
David Black authored
Previously the holding space tray would be visible in the shelf if the user hadn't yet pinned anything or if the holding space was non-empty. Now, the holding space tray will be hidden until the user first adds something to their holding space. Once something has been added, the tray will be visible until the user has pinned their first file. Once they have pinned their first file, the holding space tray will only be visible in the shelf if the holding space is non-empty. Bug: 1138541 Change-Id: I6bb6dcdaae0699d9048f853a1e5b8afe48f21143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533116 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826466}
-
Tommy Li authored
Since the actual Flash binary has been removed from Chrome, our old code path to display the Flash is deprecated placeholder no longer works. This CL adds an alternate code path that directly checks the requested MIME type instead of looking for the plugin metadata (which is no loaded since the plugin is missing). This CL doesn't restore the infobar to show that Flash is deprecated for M88+. That's working as intended. TEST=I manually tested it on Linux with the official build. Bug: 1069833 Change-Id: I4c1758c5c7d4ed2026c59ae1407689468d85c1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532862Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826465}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bd3792de72cb..ff5d8700b3a7 2020-11-11 jlavrova@google.com Roll back #10487 fix (so now spaces always resolved in the main font) 2020-11-11 csmartdalton@google.com Don't limit pinch zooming in viewer 2020-11-11 jmbetancourt@google.com implement SkotieAnimation as an Animator to better work in an Android environment 2020-11-11 bungeman@google.com Update SkFont::measureText documentation. 2020-11-11 johnstiles@google.com Avoid over-allocation in SkTArray assignment and reserve_back. 2020-11-11 robertphillips@google.com Revert "Change UnrefDDLTask to just be the DDLTask" 2020-11-11 brianosman@google.com Runtime effects: Fix error when mutating main's coords 2020-11-11 robertphillips@google.com Remove the skipping of some GMs for the *ooprddl configs on the bots 2020-11-11 brianosman@google.com Improve Viewer on UNIX 2020-11-11 johnstiles@google.com Add unit tests for overflowing int and uint literal limits. 2020-11-11 brianosman@google.com Remove "output color" placeholder from PipelineStageArgs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1147634,chromium:1147650,chromium:1147659 Tbr: jlavrova@google.com Change-Id: I059f6f361a2385d44cd92a5633baaf57f25b4f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532979Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 1145565 Change-Id: I96cfee44f213c7a1aaa2f4605b93400a03f5df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532957 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826463}
-
Eric Orth authored
Previously worked only for address requests. Other request types (e.g. HTTPS), on seeing any unrecognized (and therefore unparsable) record type in the response, would fail the whole response as malformed. Bug: 1147247 Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#826462}
-
