GitLab

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_UninitializedPropertiesAccess'


Review URL: http://codereview.chromium.org/8816005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113227 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org

Review URL: http://codereview.chromium.org/8821027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113226 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113225 0039d316-1c4b-4281-b951-d872f2087c98

Part 1: http://codereview.chromium.org/8659033/
Part 2: http://codereview.chromium.org/8687027/

The basic design of the feature is that to add an input method object to DesktopHost to feed all KeyPress and KeyRelease events from the system message loop to the input method, and let the input method send IME results (e.g. composition text) to RenderWidgetHostViewAura or NativeWidgetAura as needed.

RenderWidgetHostViewAura: 
- Just like RWHVV, implement ui::TextInputClient interface so that RWHVA could receive an event such as 'SetComposition' and 'InsertChar' from an input method object owned by DesktopHost. 
- Send a notification to the input method object on focus, blur, text input type change, etc. 
- OnKeyEvent() handler is now able to handle a non-native key event, e.g. a VKEY_PROCESSKEY event, which is fabricated by the input method editor. 

NativeWidgetAura:
- Use views::InputMethodBridge instead of views::InputMethodIBus.
- InputMethodBridge, which implements ui::TextInputClient interface, just receives IME results (e.g. composition text) from ui::InputMethod and forwards them to UI (e.g. a text field).
- InputMethodBridge also receives a request like 'CancelComposition' from the UI and forwards the request to ui::InputMethod.

DesktopHostLinux: 
- Creates and owns a ui::InputMethodIBusAura object. If IBus-1.4 is not available (e.g. Goobuntu), creates an instance of ui::MockInputMethod. 
- In Dispatch(), send a KeyPress and KeyRelease aura event to the input method. 
- Implement ui::InputMethodDelegate interface so that DesktopHostLinux could receive an key press and key release event which should be sent to NWA or RWHVA. Note that an "is_char" event is always sent directly from the input method to a TextInputClient. the ui::InputMethodDelegate is not used for that purpose. 
- ShouldSendCharEventForKeyboardCode() is moved to ui::InputMethod since DesktopHostLinux no longer generates a Char event. 

DesktopHostWin: 
- IME is not supported yet. 

Supported platforms:
- Aura + Chrome OS (IME works!)
- Aura + Chrome OS + TOUCH_UI (compiles, but virtual keyboard is not shown since views::TextInputTypeTracker is not ported to Aura yet.)
- Aura + Linux, with and without IBus-1.4 
- Aura + Windows (compiles, but IME does not work. views::InputMethodWin is not ported to Aura yet.)

BUG=97261
TEST=ran aura_unittests


Review URL: http://codereview.chromium.org/8576005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113224 0039d316-1c4b-4281-b951-d872f2087c98

extensions to the command buffer and the WebGraphicsContext3D APIs.

BUG=106142
TEST=unittests 
Review URL: http://codereview.chromium.org/8772033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23803
TEST=


Review URL: http://codereview.chromium.org/8819013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95718
TBR=wtc@chromium.org
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/8816023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106552
TBR=sky@chromium.org
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/8821025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113219 0039d316-1c4b-4281-b951-d872f2087c98

These stats were originally introduced to gauge the use of Hunspell vs the native spellchecker on OS X.  Now that we know that Hunspell is hardly used, the code can be removed.

BUG=69944
TEST=None


Review URL: http://codereview.chromium.org/8805025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113218 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aa@chromium.org
BUG=106381


Review URL: http://codereview.chromium.org/8816022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113217 0039d316-1c4b-4281-b951-d872f2087c98

The new documentation is not using ezt anymore, so the filenames
should not have an ezt suffix.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8821022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106516
TEST=none

Review URL: http://codereview.chromium.org/8816003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113215 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=chromium-os:23767


Review URL: http://codereview.chromium.org/8822009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=43460
R=mirandac@chromium.org

Review URL: http://codereview.chromium.org/8822012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106549
TBR=asargent@chromium.org
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/8820018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106529
TBR=miket@chromium.org
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/8818016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113211 0039d316-1c4b-4281-b951-d872f2087c98

Was already marked Flaky for Linux.  Now failing ~5-10% of the time on Mac as well starting Friday December 2nd, first failure has Chrome blamelist 112587:112582.

TBR=yurys@chromium.org
BUG=103539


Review URL: http://codereview.chromium.org/8822011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113209 0039d316-1c4b-4281-b951-d872f2087c98

This has failed on the Linux ChromeOS Aura bot for 4 out of the last ~8 builds.

TBR=cmasone@chromium.org
BUG=106538


Review URL: http://codereview.chromium.org/8815012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113208 0039d316-1c4b-4281-b951-d872f2087c98

*) In Javascript, 'username' means canonical email and 'email' means displayed email.
*) In C++, both 'email' and 'username' refer to the canonical email (because it is
   used in all cases except passing to JS); 'display email' refers to the raw email
   as entered by user.

BUG=chromium-os:11328
TEST=Manual: after adding a user with dot in the email, dot should be preserved on the login screen, in Preferences, in the 'report bug' page, in the whitelist.

Review URL: http://codereview.chromium.org/8773046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113207 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mpcomplete@chromium.org
BUG=48833


Review URL: http://codereview.chromium.org/8820013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=No functionality change.  Simply renaming constants.

Review URL: http://codereview.chromium.org/8805022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49941
TEST=Generation of policy_templates still works


Review URL: http://codereview.chromium.org/8819015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=https://twitter.com loads

Review URL: http://codereview.chromium.org/8770048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113203 0039d316-1c4b-4281-b951-d872f2087c98

The mac header is using conditional compilation to become neutral for other platforms.
Unfortunately it won't work for all gyp backends, as the gyp file is removing the header
from the sources for non mac platforms. Better use conditionals in the few places
where we use it. That also spares us to explain the hack.


Review URL: http://codereview.chromium.org/8822010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113202 0039d316-1c4b-4281-b951-d872f2087c98

Make ShelfLayoutController a ShelfLayoutManager for launcher, status windows.

Relanding http://codereview.chromium.org/8743014/
win_aura buildbot just needed a clobber.

BUG=105661
TEST=Manual. Status area is represented with all icons on Aura.
TBR=sky

Review URL: http://codereview.chromium.org/8819016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=43460
R=mirandac@chromium.org

Review URL: http://codereview.chromium.org/8816001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113200 0039d316-1c4b-4281-b951-d872f2087c98

TaskManager: Added functionality to remember the size of the task manager dialog so that it can be restored with the same size in further launches.


BUG=105117
TEST=None


Review URL: http://codereview.chromium.org/8741010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113198 0039d316-1c4b-4281-b951-d872f2087c98

(by initializing its length_ to 0), and to return the number of bytes skipped
if buffer==null, rather than returning the offset.
Review URL: http://codereview.chromium.org/8800017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113197 0039d316-1c4b-4281-b951-d872f2087c98

by ThreadSanitizer. We don't need the suppression anymore.

BUG=106197
Review URL: http://codereview.chromium.org/8800012

TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/8819017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106531
TBR=glider
Review URL: http://codereview.chromium.org/8815009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113193 0039d316-1c4b-4281-b951-d872f2087c98

We don't run it yet it's slow and fails due to too-big PDB files on the bot
TBR=glider
Review URL: http://codereview.chromium.org/8816018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113192 0039d316-1c4b-4281-b951-d872f2087c98

Fix rare logdir races by adding "_logdirfilecount" to the 'PID' when generating a unique logdir path
TBR=bruening
Review URL: http://codereview.chromium.org/8816017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113191 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the Windows bots to have the suppression hashes available in
the build view as unique failures.
TBR=glider
Review URL: http://codereview.chromium.org/8816016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113190 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113183 - Revert 113177 - process all ui events before posting closure because menu depends on ui events to quit.
 Add new RunClosureAfterAllPendingUIEvents for toolkit views.

BUG=104359
TEST=BookmarkBarViewTest in interactive_ui_tests will pass


Review URL: http://codereview.chromium.org/8799020

Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/1514
Reason for un-revert: The test succeeded before the original revert, looks like it's just flaky.

TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/8821012

TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/8820010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106529
TBR=miket@chromium.org

Review URL: http://codereview.chromium.org/8820008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113188 0039d316-1c4b-4281-b951-d872f2087c98

We don't run sync_unit_tests now and it's so big and slow it affects both the
performance and the stability of building.
For example, it doesn't build on the Dr.Memory trybot now.

TBR=bruening
Review URL: http://codereview.chromium.org/8816015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113187 0039d316-1c4b-4281-b951-d872f2087c98

Make ShelfLayoutController a ShelfLayoutManager for launcher, status windows.

BUG=105661
TEST=Manual. Status area is represented with all icons on Aura.

Review URL: http://codereview.chromium.org/8743014

TBR=nkostylev@chromium.org
Review URL: http://codereview.chromium.org/8817016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113186 0039d316-1c4b-4281-b951-d872f2087c98

Make ShelfLayoutController a ShelfLayoutManager for launcher, status windows.

BUG=105661
TEST=Manual. Status area is represented with all icons on Aura.

Review URL: http://codereview.chromium.org/8743014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113185 0039d316-1c4b-4281-b951-d872f2087c98

This is a function for the bookmark manager, which wants to show the "Open in Incognito mode" option only if the incognito mode is available.

BUG=none
TEST=no


Review URL: http://codereview.chromium.org/8662008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113184 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113177 - process all ui events before posting closure because menu depends on ui events to quit.
 Add new RunClosureAfterAllPendingUIEvents for toolkit views.

BUG=104359
TEST=BookmarkBarViewTest in interactive_ui_tests will pass


Review URL: http://codereview.chromium.org/8799020

Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/1514

TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/8821012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113183 0039d316-1c4b-4281-b951-d872f2087c98