- 28 May, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I9b50b4f02c7ceb31a406464552d2c02613f6bf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210420 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772608}
-
Roman Sorokin authored
Bug: 1073095 Change-Id: I3de4ae351e8d305df649071056a903a935735d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196484 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a40740375ef..641fcb8099d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1085525 Tbr: tasak@google.com Change-Id: I905ba3accab22df5cb5083c68e5afee64ed5a1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219629Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772606}
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in content::mojom::Widget to allow asking the renderer to force a redraw, expecting a response when the process is completed. Bug: 1083405 Change-Id: I2ce44e25c8d82f56bc4a8d44572f8e04e60abda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207209Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#772605}
-
Kent Tamura authored
Font-size restriction for inset amount should be applied only to LayoutRubyText. Bug: 1069817 Change-Id: I82d6ac806e3eca0bc696517678d753e3c1a53d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217914 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772604}
-
Jan Wilken Dörrie authored
TBR=oshima Bug: 1087285 Change-Id: I93c8b6cdb057f387ef24a160429a9761e35d50db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219491Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772603}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc8caee164ef..5762221cb271 2020-05-28 fancl@chromium.org auto-bisect: Fix status update based on issue state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087240 Tbr: rmhasan@google.com Change-Id: Ic27860e9f1a041f3a8428efd0cc03d83c75c8c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772602}
-
Hugo Benichi authored
Main rational for migration: user UI override settings for marking a network metered or unmetered can only be obtained with the new kMeteredProperty. BUG=b:156302252 TEST=Flashed Chrome, connected the DUT to an Android hotspot with cell tethering and checked that ARC tags the wifi hotspot as metered. Change-Id: I83f4ca01521947edb39785053308cb88b658a69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217711 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772601}
-
Aleks Totic authored
I've copied AddChild code from Legacy, and modified it to work with NG. A lot of this code has to do with anonymous wrapping. I do not fully understand what it does, "just do what Legacy did" was what I was going for. Bug: 958381 Change-Id: I139e04154a03676ecbe5da1d794d0570bcd803d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212459 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#772600}
-
Clemens Arbesser authored
This CL unifies the handling of autofill format strings across all relevant actions (UseCreditCardAction, UseAddressAction, ShowGenericUi). This is a refactoring-only and should have no user-facing changes. Bug: b/145043394 Change-Id: Id533ed9e6faba7f0ec93481bbe7d9c85f24e889e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208989 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#772599}
-
Jan Wilken Dörrie authored
TBR=danakj Bug: 1083585 Change-Id: I21588d8ff2ea2fb7e4cb54cd915b4c984d2621e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219490Reviewed-by:
-
Wolfgang Beyer authored
This CL updates the tests which use SDK.networkLog to use the static instance() function instead. It also re-enables previously disabled tests. DevTools CL: https://crrev.com/c/2213439 CL disabling tests: https://crrev.com/c/2214952 Bug: chromium:1011811 Change-Id: I1843b16447ca480075f8a3e02abd8bf4ab715f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213534Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772597}
-
Jan Scheffler authored
CL that disables the test: crrev.com/c/2218051 Bug: chromium:1011811, chromium:1079233 Change-Id: Ie14ff7879b9128b7aad00ec02cdb90d2a6698783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218271Reviewed-by:
-
Rohit Agarwal authored
IncognitoDataTestUtils#launchUrlInTab is called when we want to load a URL in Chrome tabbed activity. This chrome tabbed activity is fired once in the setUp method of the incognito leakage tests and in subsequent calls to the launchUrlInTab method. The reason for firing activity in the launchUrlInTab method is to bring back the ChromeTabbedActivity (which was fired in the setUp method), if the previous activity fired was of type CustomTabActivity. To make the code more readable no checks were introduced and chrome tabbed activity was fired un-conditionally. However due to this we have some instances were the application was killed due to memory pressure. This CL adds the check to fire a ChromeTabbedActivity only if the previous activity which was fired was CustomTabbedActivity. Bug: 1081748, 1084709, 1035770 Change-Id: I1a232c44767821af17de2d7a859b4ecab50dbc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213525 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772595}
-
Nicholas Verne authored
This will ensure any processes which are holding dpkg locks release them. It is still possible that an init process in the container will grab the locks again before upgrade_container can run, so this doesn't ensure dpkg locks are always available, but it should fix the case of processes lingering and failing to release them. Bug: 1082075 Change-Id: I138d97b3a3f4ae1a1e4ce13232aef39cc75357a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217761 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#772594}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4771af96b5e..0c9fa494daad 2020-05-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I394d0027a15b17573419aa2b649af2086ff5a92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219634Reviewed-by:
-
Dominic Mazzoni authored
This reverts commit 41e56b19. Reason for revert: Causes crash - see stack trace in http://crbug.com/1087183 Original change's description: > Consolidated some text helper methods in AXNode > > This patch is a second precursor to a more substantial change that > would move hypertext computation to AXNode from AXPlatformNodeBase which will > in turn open the way for AXNodePosition to be merged with AXPosition and > for Views to be exposed as a tree of AXNodes. > See https://chromium-review.googlesource.com/2150294 > > Currently, we have multiple methods that compute inner text, IsLeaf and IsChildOfLeaf > one set in BrowserAccessibility and another in AXPlatformNodeBase. > We want to centralize all platform independent utility methods in AXNode and AXNodeData. > > There was some confusion in the existing codebase regarding what should be included in inner text. > Some code assumed that the name attribute of a leaf node could not be included, unless it was derived from its contents, > or its placeholder in the case of a text field. > Other parts of the codebase were more relaxed about this requirement. > > This patch adopts this requirement for the whole codebase, because the definition of inner text should only include visible > text that is present inside the node itself, but not text derived from an attribute, e.g. an ARIA label. > This is apparent from the name "inner text" itself, but it also stems out of the need > to support computing bounding boxes for character ranges in inner text. > If the name of an element is derived from an attribute such as an ARIA label, that attribute won't expose any bounding box information. > If the name of an element is derived from a related element, e.g. a figcaption or an HTML label, > the bounding box of that element is unrelated to the original element's inner text. > > APIs to compute bounding boxes are exposed in IAccessibleText, ATKText and ITextRangeProvider. > > See also the definition of IAccessibleText in the IAccessible2 Specification, > the definition of ATKText in the ATK Specification, or > the definition of ITextProvider in the UIA Specification. > 1. https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_text.html > "The IAccessibleText interface should be implemented by all components that present textual information on the display like > buttons, text entry fields, or text portions of the document window." > 2. https://developer.gnome.org/pygtk/stable/class-atktext.html > "... if the text is editable, multi-line, typically longer than three or four words, attributed, selectable, > or if the object already uses the 'name' ATK property for other information, the atk.Text interface should be used" > 3. https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nn-uiautomationcore-itextprovider > "Provides access to controls that contain text." > 4. https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtextandtextrange > "If an embedded object spans a range of text, the plain text should include the inner text of the object, but not the alternative text (the name property of the embedded object) > because it might be inconsistent with the descriptive inner text." > > RELNOTES: N/A > > R=dmazzoni@chromium.org, aleventhal@chromium.org > TBR=rsesek@chromium.org > > Bug: 1049261 > Change-Id: Ic39687eb98c3ef7575214de2c659eb28d6633466 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171436 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771809} TBR=dmazzoni@chromium.org,nektar@chromium.org,rsesek@chromium.org,aleventhal@chromium.org,virens@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049261, 1087183 Change-Id: Ie40cf51e33cbe4595513f0b5e94732650496c3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219395Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772592}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2f4f6793366..6065820c58da 2020-05-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5b4c627389a6 to 6a184fe947ed (14 revisions) 2020-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from bdc05c3d5fef to a3636ed8883d (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084580 Tbr: westont@google.com Test: Test: Test: CQ Change-Id: I8bcf1ea8a7a16ce5176875da48f466ee87887bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219632Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic09ff38240ec2167c9647fde2f2c8dde7f9c653e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219633Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit a95e3a91. Reason for revert: Likely culprit of https://crbug.com/1087277 Original change's description: > Deduplicate document policy violation report > > Most image policies can report multiple violations for a single cause(same image not following the rule) during layout, e.g. An unoptimized-lossless-image's bpp(byte per pixel) value can change multiple times if the image is being scaled in an animation. > > To avoid unnecessary duplicated reports being generated. This CL adds Hash method for DocumentPolicyViolationReport to uniquely identify each report and avoid the duplication by remembering these hash values in LocalDOMWindow and filter out reports that are in record. > > Some existing web tests rely on the fact that multiple copies of same report generated in same document. This CL also worked around that to either help make reports generated unique or isolate test cases to different documents(iframes). > > Bug: 924684, 926199 > Change-Id: I230e32801c77980573b5ed55064d46f94aed3060 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078837 > Commit-Queue: Charlie Hu <chenleihu@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jason Chase <chasej@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772406} TBR=dcheng@chromium.org,chasej@chromium.org,chenleihu@google.com Change-Id: I92e14abb1538a8983fa0c6b1248b355fab024707 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924684, 926199, 1087277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218833Reviewed-by:
-
Nicholas Verne authored
When a newly plugged in device reports multiple interfaces and at least one of them is "notifiable" we notify the user. Previously, all interfaces needed to be "notifiable". Bug: 1082075 Change-Id: Ic203f7ebce51966b53fbe27709a4c705a33561e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217521 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772588}
-
Hugo Benichi authored
This patch partially migrates away from ONC for populating the following fields in arc::mojom::NetworkConfiguration: - guid - connection state - tethering state - network type The equivalent shill properties directly cached in NetworkState are used in state. Migrating away from ONC and basing arc::mojom::NetworkConfiguration creation directly on shill properties will facilitate the migration of net.mojom outside of Chrome and into platform2/patchpanel. BUG=b:145960788 TEST=Flashed Chrome, tested various connectivity setup in ARC, tested scanning Apps. Change-Id: I3c4d821cb1064638deac2a65d6ba372ace1b836b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210298 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
-
Yuzu Saijo authored
This CL adds a test case to ensure that a page's ContentsMimeType is saved after being restored from bfcache. This should pass now because we store ContentsMimeType inside TakeLastCommitParams, but we would like to remove this in the long run. We would like to move ContentsMimeType to per-page / RVH as a next step. Bug: 1086862 Change-Id: I273909f97738047529d54b0baebc336fc4a52494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217494 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772586}
-
John Abd-El-Malek authored
Bug: 1085309 Change-Id: Idb58fa6e32de68c4b92760fcc8ca6298be0212f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216853 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772585}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Idfb8c73069f3b1d441cb7eef4a6f31bedb966b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212227 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
danakj authored
This puts the main frame and iframe into the same site so that the devtools inspector can watch its network requests. Also remove access-inspected-object.js from the not-site-per-process virtual test suite since it was fixed and enabled. The test will be run without site-isolation in the not_site_per_process_blink_web_tests bot step. R=yangguo@chromium.org Bug: 623268 Change-Id: I1ab5fd22ec988e2aa7de8cea52e207a6f6c4528c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218750 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772583}
-
Gauthier Ambard authored
The tests were marked as flaky but I can't repro. Re-enabling them. Fixed: 714303 Change-Id: If329171730bd10aa4a6ed9ed9c7458b10f3587e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213531Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#772582}
-
Koji Ishii authored
This patch fixes |NGLogicalLineItem::HasFragment| to return true for floating items. Logically speaking, it should return true, but the current code returns false. It looks like this does not seem to affect, but found in r771489 crrev.com/c/2212187 and it's better to fix before code starts to relying on the behavior. Bug: 982194 Change-Id: Ie4de3a7e68190d1db5589781abe2b913961d3213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217995Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772581}
-
danielng authored
Signalling to the user that they can't add a port that's already being stored in the port forwarding settings for Crostini. Also, touched up some of the browser tests. Tests: Added browser tests and tested changes locally Bug: 848127 Change-Id: Ia001380f6a08970f20f43029b6dc78acc47ccadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210339 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#772580}
-
Miriam Polzer authored
The update engine sends a flag for enterprise rollback. Instead of guessing whether the current update is an enterprise rollback using channels and versions, we use the rollback flag together with the powerwash flag to determine which kind of update is happening. Bug: 864672 Change-Id: Ia9a97b2bfe8abf5d795a2b530689321b9d585a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215058Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/192fcf03f956..dc8caee164ef 2020-05-28 fancl@chromium.org auto-bisect: Fix tags in auto-bisection request If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087228 Tbr: rmhasan@google.com Change-Id: I55ab6f99ecd2c9598e5ece589879128d0ff8c607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219630Reviewed-by:
-
Alex Danilo authored
Implements behavior of a <select> element using a <div> so that it can be styled for files-ng. Creates an absolutely positioned <div> to hold the <option> elements that would normally get inserted as children of <select>. Adds the styles needed for the files-ng case to apply to the <div> and its descendants. Points the initialization code that populates the <select> to use the <div> if files-ng is enabled. Adds event handling logic to mimic the behavior of <select> in regard to activation, keyboard events, etc. Fires a 'change' event on the <div> whenever an <option> is selected, that is needed so that the browser can match CSS :checked selectors that are targeting the emulated select (div) element. Sets the width of the <div> acting as host to the width of the absolutely positioned <div> hosting the <option> elements during selection to stop the host <div> changing width when different sized options are selected. Bug: 1002410 Change-Id: I5d7b227b561d96aaf61e88d9e206ac7de80d468e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201336 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772577}
-
Roman Sorokin authored
Also postpone focused pod hooks during screen locking until after the session state changes. Fixed: 914972 Change-Id: I8fc68a0f07be8a3eea9cde973eb0e203e47edd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215326Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Adam Rice authored
The quota-based WebSocket implementation would never fragment outgoing messages of 64KB or less as long as quota had time to be updated. Emulate this behaviour with the new datapipe-based implementation, to avoid the risk of breaking applications dependent on the old behaviour. The behaviour is controlled by the feature flag "WebSocketReassembleShortMessages" which defaults to enabled. This can be disabled for experiments to determine if the feature is really needed. No extra bytes are copied and no extra allocations are done. The main overhead of the feature is in extra code complexity. Add a web test, expect-unfragmented.html. This has been tested against the old quota-based implementation (passes) and with --disable-feature=WebSocketReassembleShortMessages (fails). BUG=1086273 Change-Id: I958dd5d99931e3023ee339481f101ffa56ed274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215383 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#772575}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22534f2098e7..a2f4f6793366 2020-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5749e77b to f752954c (450 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I433be2c2d66ca40f0ec207d34c8bb4c53a59e4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218585Reviewed-by:
-
Kent Tamura authored
Bug: crbug.com/1069817 Change-Id: Ie3b4bb52e9151939026df20e37459de596d78545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217714 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772573}
-
Yoshifumi Inoue authored
This patch changes "mathml-sanitizer-bypass.html" to check whether MathML enabled or not to choose valid expectation. As of May 2020, MathML is experimental feature and implemented on LayoutNG. When enabling EditingNG and pasting clipboard content into editable, MathML contents are rendered as MathML layout instead of non-MathML. For <math>B</math>, we have following layout tree: MathML enabled: LayoutNGMathMLBlock {math} at (0,0) size 0x0 LayoutText {#text} at (0,0) size 0x0 MathML disabled: LayoutInline {math} at (0,0) size 10x19 LayoutText {#text} at (0,0) size 10x19 text run at (0,0) width 10: "B" Bug: 707656 Change-Id: I722541655322cedda7ada53fa09e08d78fd2db5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217758 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590623692-442abbb1e080c04fab88844b2b8eca58e501203d.profdata to chrome-win64-master-1590637846-cf66cd399b4c48375ae2ad3d18827b7a5bc0b17a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd8ef8edefcb20833f6d17749d1d465f95747ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219628Reviewed-by:
-
Abhijeet Kandalkar authored
RenderViewHostTest.SetBackgroundOpaque test just checks whether mojo channel can be bound to a fake widget host and not testing any core functionality of RenderViewHost. This CL removes that test code from render_view_host_unittest.cc Bug: 1047469 Change-Id: I8a7aea5de90fd1711a50e496abd20623571d00e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216130Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97a2e2dd..4feef9cc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib54cc521c90367dfe3ab747642b900b5398a41ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218379Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772569}
-
