- 23 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iafb72e702abc732258a65ae8af19793670cf3c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791212}
-
Francois Beaufort authored
This CL makes sure pan, tilt, and zoom can only be set when page is visible. When page is hidden, applyConstraints will reject with a SecurityError for pan, tilt, and zoom only. Spec: https://github.com/w3c/mediacapture-image/issues/236 Bug: 934063 Change-Id: I442985fabe7337093e336cfd804e405f4c965a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302691Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#791211}
-
Chris Thompson authored
This adds SCT auditing enable/disable interfaces to NetworkContext to control auditing behavior on a per-NetworkContext basis, and a new SCTReportingService to monitor changes to the Safe Browsing Extended Reporting status per-profile (to gate SCT audit collection to users opting in to Extended Reporting). The SCTReportingService also receives the notifications about new SCTAuditReports sent to the NetworkContextClient. As this makes entries in the SCTAuditingCache visible to the browser, this also adds end-to-end tests covering the cache behavior. Bug: 1082860 Change-Id: I98922bbdc359cc641b920185fd0b4ccd8aea9eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252569 Auto-Submit: Christopher Thompson <cthomp@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791210}
-
arthursonzogni authored
Patch [3/N] modified blink windows's binding to call CheckCoopAccess() whenever a "CrossOrigin" attribute/methods was accessed. So far, so good. Nevertheless, some attributes are missing, because they have a custom implementation. CheckCoopAccess needs to be added manually for them. This patch fixes the accesses to "location". COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [7/N] this patch. Bug: chromium:1090273 Change-Id: I6509604950baf04e5a9b644981c58282ef5e7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309697 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791209}
-
Marc Treib authored
Bug: 1079297 Change-Id: I1cb15bd3e3b9cdafcc46bb8954f731fa8b35242b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300439 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#791208}
-
Sebastien Lalancette authored
This factory will be used by components to create UIAction instances and use these instances to populate the new Context Menus. The Factory's role is to decorate execution blocks with metrics collection along with providing consistent titles and images for these actions. Disclaimer about testing: UIAction does not expose the execution block. This means we cannot unit test UIAction instances' execution, we'll have to rely on EG tests for that. Bug: 1093302 Change-Id: I835bcceabeff53ecf65da54f6518eb1edd0d6d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303361Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#791207}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06d53faa7b72..7f89cfd4944e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: I1e43b82d098dc5865d725303c5368399075d592c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791206}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3aaaa5dab3a102d55c46ae1e3d9cf44e809bc67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316237Reviewed-by:
-
Rohit Rao authored
https://chromium-review.googlesource.com/c/chromium/src/+/2266476 modified this test to pass applicationActive:NO instead of YES. This invoked a different codepath in url_opener.mm that happens to always call |connectionInformation.startupParameters|. The test was only registering an expectation for this call when DCHECKs were enabled, causing a failure in Release builds. BUG=1102032 Change-Id: I30ea62892300cf9fa1cac453149acfa08ca1c159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315254Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791204}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af6416cd74c8..038b9b33775b 2020-07-23 kimanh@chromium.org Use setBreakpoint() only when creating a new breakpoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105172 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92717ea57b2483cb209067fd1811c212a72c9824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315207Reviewed-by:
-
Mike Dougherty authored
[LocationBarViewController visitCopiedLink] should log "Mobile.OmniboxContextMenu.VisitCopiedLink" instead of "Mobile.OmniboxContextMenu.SearchCopiedImage" Fixed: 1108682 Change-Id: Icec446acb57d6821f51c181352c0399dca170701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315224 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791202}
-
Guido Urdaneta authored
This CL makes CheckMediaAccessPermission pass the main RenderFrameHost of the embedder WebContents instead of the original RenderFrameHost. This makes it work similarly to RequestMediaAccessPermission(), which uses the embedder WebContents instead of the original WebContents, and fixes an issue with device enumerations when using ChromeOS logins, where the permission check always failed. Note that CheckMediaAccessPermission() originally used the embedder WebContents until the switch to RenderFrameHost in crrev.com/540967. Bug: 1086756 Change-Id: I5342c8d2617144caca7e451af0f12f31b5c6bb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294807Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#791201}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9803e14b0fb..33265b79e5b1 2020-07-23 eseckler@google.com ui: Clear traceProtoWriter between ADB recording sessions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0e98fdab9089973a6d1e35f44baaacb64f919417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315205Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 787b18d6. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I5cf73526e4d3b14b681eaac2d66f54ad5c3a241f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316036Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791199}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c9ffbfc..d192a324 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3d3d169e6e2d916b7e68c47e492c1c73b9792c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315302Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791198}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f359cb667cb9..201d43aed5f5 2020-07-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f272427bda39 to 6a8a74986c35 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Id4147fb6c9e7643111afb6fe8435e391402de78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315384Reviewed-by:
-
Victor Hugo Vianna Silva authored
|specifics| is not defined in this snippet. TBR=treib@chromium.org Bug: None Change-Id: I5654c0230340e672f1f24347c1a0b0eb35431c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315140Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#791196}
-
sandromaggi authored
The reason for making a "snapshot" check on the keyboard is (or was) to check against the following scenario: * Keyboard showed up * Keyboard was suppressed and hidden The "snapshot" does not guard better than the waiting in this case. Waiting for the keyboard should prove to be more stable because it also covers cases where the keyboard is not yet open but will appear in a short while. The case where the keyboard is suppressed is not properly covered in both cases. Bug: 1108350 Change-Id: I196782916c4d35376d8d2afd6ab46f91265e0f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314177Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#791195}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I044730d17ee2f23338c6ca8859c96a9cc7d92b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312701 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#791194}
-
Maksim Ivanov authored
Bug: none Change-Id: Iaa9be03d57fc1505dd6b85320c4ecf06b17012cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315137Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791193}
-
sandromaggi authored
Before this change, a missing entry of |overlay_image| would reset it. Now to unset it one needs to add an invalid (e.g. empty) setting for it. Bug: b/161870830 Change-Id: I9a7fa1b11fe437071a7e4bbea11b44fb95f3b1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315858Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#791192}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb2f73564cb5..af6416cd74c8 2020-07-23 bmeurer@chromium.org Remove deprecated `use_relative_hooks = True` from DEPS file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I63011ca7fb498a0a5815f54f6155c7f0bd9b0050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315917Reviewed-by:
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 Capture, plumb and use the SourceLocation for COOP access reporting. COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [6/N] this patch. Bug: chromium:1090273 Change-Id: I03047773f0353011b2a202b6792c900eac90c99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308715Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791190}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c633d9713fc..06d53faa7b72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: meredithl@google.com Change-Id: I557bf41db6f60d8c8021b13dabd3c1ddd939b0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315292Reviewed-by:
-
Keith Lee authored
Replaced with it's negative to not use a negative for readability. Change-Id: I9ba712ab0b8a9cf3089c9c5f6d6f09d8b3c73694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143026 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#791188}
-
Pavol Marko authored
Marking external/wpt/html/cross-origin-opener-policy/reporting/access-reporting/opener-accessed_openee-coop-ro.https.html as expected to fail - see ${BUG}. Following https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#waterfall-failures-caused-by-automatic-imports Bug: 1108728 TBR=clamy@chromium.org Change-Id: If1921bb903b990e4185ddaf45f5aefadc6802128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315679Reviewed-by:Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791187}
-
Anastasiia N authored
ProfileSyncServiceBundle declares test_url_loader_factory_ after identity_test_env_. When profile_sync_service_bundle.cc passes a TestURLLoaderFactory pointer to IdentityTestEnvironment constructor, it's still in undefined state. Fix this by moving declaration of test_url_loader_factory_. Change-Id: Ieb38b395becffc0c26400770057196987376df29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306259Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I21d8638cbff328affadcd7cdc4780b6f614304cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315805Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791185}
-
Andreas Haas authored
In the constructor of ArrayBufferContents, we did not create a V8::BackingStore if an byte array was provided, i.e. byte == nullptr. Without BackingStore, however, it was not possible to create a V8::ArrayBuffer for this ArrayBufferContents, as V8 expected that a BackingStore always exists. With this CL we always create a BackingStore, even though the data is nullptr. R=haraken@chromium.org, ulan@chromium.org Bug: chromium:1104580 Change-Id: I4a05de503f5916a9491dbe4595f699c0e834bb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302694Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791184}
-
Victor Hugo Vianna Silva authored
Although new users can't enter this state, a number of users still remain on it. "legacy" probably reflects better this scenario. Bug: None Change-Id: I1e61f6ed601bc6ea8bb51490ab5ebc00d4dd7efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312803Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#791183}
-
Jinsuk Kim authored
This CL tentatively reverts following 6 CL's as a speculative fix for an ANR issue around ProfileDestroyer: https://crrev.com/c/2171463 "Clean up ProfileDestroyer." https://crrev.com/c/2134019 "Add tracing to make it easier to debug shutdown behavior." https://crrev.com/c/2113391 "Android: Handle multiple ProfileDestroyers correctly" https://crrev.com/c/2032385 "Fix a crash in ProfileDestroyer due to delayed RPH destruction" https://crrev.com/c/2022791 Revert "Only CHECK for RPHs that outlive an OTR profile in release" https://crrev.com/c/1971031 "Android: Fix a bug when closing all incognito tabs for preview tab" The first CL(1071031) landed to fix Issue 1029677, and subsequent CL's handled the remaining/new issues reported after that. The ANR bug (1095078/1095548) is suspected to have to do with ProfileDestroyer destruction of incognito profile. Not having found good clues, this is trying to see if the series of these changes in the class caused it. With this, the state of ProfileDestroyer is restored back to M80 which had no issues. This is NOT a permanent solution for the problem. Will reland the above CL's if they are proven innocent, or find a right fix if they indeed are the culprit. TBR=msarda@chromium.org Bug: 1029677, 1040839, 1095078, 1095548 Change-Id: I761809a90cd4f3a866ae7754da4dab34640dcb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308616Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791182}
-
evliu authored
This is a reland of b01fb516 Reason for revert: Did not roll out internal DEPS (https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3179564) Original change's description: > Add SODA API Key > > This CL adds an API key for the Speech On-Device API (SODA). Usage of > the API key is outlined here: go/securing-soda-on-chrome. > > Bug: 1107615 > Change-Id: Ic92418407e17a88426559251e77797bd0b34818b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309133 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#790550} Bug: 1107615 Change-Id: Id15cbafdc68bf75a06d21c8b70bbfeb1a63db83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315237Reviewed-by:
-
Anders Hartvoll Ruud authored
They are no longer used by anything. Change-Id: Ibdfc66e8bc30841fc01292ca5961ecf522588c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310496 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791180}
-
dizg authored
Bug: 1105865 Change-Id: I8d2acf70dc1e24112961f4bc63595aaf6c326fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312798Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
-
Simon Zünd authored
As per guidance of base/containers/README.md. R=sigurds@chromium.org Change-Id: I2e078e0199cdebd98ef442f6e3bb2974f1666041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315017 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#791178}
-
Maksim Ivanov authored
Fix the flakiness in the VpnProviderApiTest.DestroyConnectedConfig test caused by the C++ side missing the JS test success notification. In a detail, the test was first deleting the VPN config - which triggers the "disconnected" vpnProvider.onPlatformMessage event and the test's test.succeed() call - and then creating a ResultCatcher afterwards. With unlucky timing, all of the steps, including the test.succeed() event arrival to the browser process, were happening before the ResultCatcher was constructed. The fix is therefore to move the construction of the ResultCatcher to happen earlier, before deleting the VPN config. Bug: 1108527 Test: run "browser_process --gtest_filter=VpnProviderApiTest.DestroyConnectedConfig" under stress a thousand times Change-Id: Ib26da605dc379240b8925f275bd22d96aadd99e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315337 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#791177}
-
Viktor Semeniuk authored
This change adds show/hide button near password field, which reveals or hides password value. Bug: 1075494 Change-Id: I336dbaa4f44d0136c7331fde5133a293c76fe5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302051 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
Bug: chromium:1105172 Change-Id: Ibec4c558a8d0f56c9275d8f0fc9aa1bb92ad6000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315856 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791175}
-
Anders Hartvoll Ruud authored
Instead of relying on calls to UaRules/UserRules/AuthorRules/AllRules, just check the origin at each vector index directly. This prepares for the removal of the rule ranges in a subsequent CL. Change-Id: I86f57ca1c2f04619db99f7cd1c62345b8f0f262a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310675 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Since it seems that we continue having problems with inflating vector graphics, I'm adding these two icons to the enum as a stop-gap to avoid blocking the PWM experience. Bug: b/145043394 Change-Id: I848ce65807d244fe49102a5ed1fef32aec474a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315138 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#791173}
-
