GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247836 0039d316-1c4b-4281-b951-d872f2087c98

Perform copy locally if the file is dirty or it doesn't have a resource ID.
Fix Copy()'s behavior to overwrite existing file.
Remove dependency from MoveOperationTest to CopyOperation.

BUG=260539,331985
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/149413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247834 0039d316-1c4b-4281-b951-d872f2087c98

Implements the new audio player of Files.app. See the issue for detail. Although it has still room to implement and improve, but basically it works.

BUG=273308
TEST=manually tested
R=dgozman@chromium.org, mtomasz@chromium.org

Review URL: https://codereview.chromium.org/144883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260539
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/148283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339094

Review URL: https://codereview.chromium.org/149723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247831 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=frankf@chromium.org

BUG=

Review URL: https://codereview.chromium.org/149543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247830 0039d316-1c4b-4281-b951-d872f2087c98

This checks with GAIA to reconfirm whether a given user is permitted
to log in to a device. The check complements the existing login
whitelist check based on device policy.

BUG=chromium:336284
TEST=Manual

Review URL: https://codereview.chromium.org/148843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247829 0039d316-1c4b-4281-b951-d872f2087c98

This is a prep CL to fix crbug.com/247517 and crbug.com/272583.

BUG=none
TEST=none
TBR=cevans@chromium.org

Review URL: https://codereview.chromium.org/148683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247828 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: remove BlockedWriterInterface from QuicPacketWriter.
No behavior changes.

Merge internal change: 60499316
https://codereview.chromium.org/135363006/


Properly trigger OnCanWrite processing from PacketDroppingTestWriter.
Re-enable the LargePostWithPacketLossAndBlockedSocket test.

Testing only.

Dialing back the loss from 30% to 10% seems to have stabilized the test.

Merge internal change: 60479729
https://codereview.chromium.org/131503016/


Use LOG_IF instead of LOG_IF_FIRST_N in a few places, as per avd's
suggestion.

Merge internal change: 60382807
https://codereview.chromium.org/149163004/


Change the default RTT from 60ms to 100ms, which is more typical of
internal server's.

Merge internal change: 60366147
https://codereview.chromium.org/146583006/


Remove an impossible check in QuicConnection for when a packet is
retransmitted before it is sent.

Updating the tests also found and fixed an edge case where a truncated
ack could cause the SentPacketManager to raise the high water mark above
a pending packet.

Merge internal change: 60169343
https://codereview.chromium.org/145123003/


Export primary insecure and secure QUIC config id via internal server
status pages.

Merge internal change: 60108488
https://codereview.chromium.org/137423015/


Export SCIDs, QUIC secret seed names and orbits to varz.

Merge internal change: 60107113
https://codereview.chromium.org/144033006/


Refactor QuicConnection to use explicit notification for getting onto
the write blocked list. Remove the PacketWriter interface from
QuicDispatcher.

Merge internal change: 60103466

Fix build. Build got broken by a race between presubmit tests and me
editing the file that was in the process of being submitted. :(

Merge internal change: 60104577
https://codereview.chromium.org/149263002/


Remove the word Payload from AddFrame methods in QUIC framer.

Merge internal change: 60101552
https://codereview.chromium.org/131513022/


Fixes QUIC's Cubic sender to use correct alpha when in Reno mode.

Merge internal change: 60088487
https://codereview.chromium.org/136453013/


Add DFATALs to QuicFramer branches where packet creation fails.

Merge internal change: 60077767

https://codereview.chromium.org/148073002/


Fix a QUIC bug where previously undecryptable packets were not decrypted
before sending out an ack when the encryption level changed.

Merge internal change: 60051502

Added logging for all frame types.

Added code to dump frames and packet_headers. Changes to make
QuicHttpStreamTest work.
https://codereview.chromium.org/144063012/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/146033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247827 0039d316-1c4b-4281-b951-d872f2087c98

In r239446 I carelessly inserted '.ico' to the array but
I should have not. The array is for indexing enum of metric
stat that need to match with remote side config.

Let me just revert the addition. I think we are not so eager
to count '.ico''s popularity.

BUG=339023
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/130803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247826 0039d316-1c4b-4281-b951-d872f2087c98

* Let ContentViewCore manage more than one GestureStateListener.
* Change GestureStateListener to be an empty implementation.
* ContentViewCore alerts its GestureStateListeners of any scrolls
  or flings, and alerts it of changes in the vertical scroll offset
  or extent.  That last bit is admittedly a bit strange to put in
  the GestureStateListener, but it's going to be listening to starts
  and stops already anyway...

Downstream CL that uses it: https://chrome-internal-review.googlesource.com/#/c/152640/
BUG=332281

Review URL: https://codereview.chromium.org/145953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247825 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338618

Review URL: https://codereview.chromium.org/145353014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338900

Review URL: https://codereview.chromium.org/145353013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247823 0039d316-1c4b-4281-b951-d872f2087c98

> Add UMA stats for ExtensionCache
> 
> Reported metrics:
> - number of extensions in cache
> - size of cache on disk
> 
> BUG=316371
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/148013004

This causes compile failures on ChromeOS. See comments on original CL for
details.
TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/139173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247822 0039d316-1c4b-4281-b951-d872f2087c98

Event-targeters (e.g. wm::EasyResizeWindowTargeter) now do the necessary work
for allowing a window to receive events outside of its bounds. So these methods
on aura::Window are no longer necessary.

BUG=318879
R=ben@chromium.org

Review URL: https://codereview.chromium.org/133873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247821 0039d316-1c4b-4281-b951-d872f2087c98

ui/gfx/ depended on net/ for two things, SortedDisplayURL and gfx::ElideUrl().
SortedDisplayURL was not used by anything other than its own unit test and is
deleted in this patch.  ElideUrl() is only used from
chrome/browser/ui/(gtk|cocoa|views), so this patch moves the functionality up
to chrome/browser/ui/elide_url.(h|cc) and the unit test to
chrome/browser/ui/tests/elide_url_unittest.cc.

R=sky

Review URL: https://codereview.chromium.org/143463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337122

Review URL: https://codereview.chromium.org/137263015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316168

Review URL: https://codereview.chromium.org/131003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247818 0039d316-1c4b-4281-b951-d872f2087c98

These warning showed up for me when trying to build
chromium using the gcc 4.8 ARM cross compiler in
Ubuntu/saucy.

Review URL: https://codereview.chromium.org/129683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247817 0039d316-1c4b-4281-b951-d872f2087c98

> Cache feedback reports to disk in case of send failure.
> 
> R=zork@chromium.org
> BUG=249853
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
> 
> Review URL: https://codereview.chromium.org/141433011

This introduced a race condition picked up by the TSAN bots.

BUG=339326
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/149993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247816 0039d316-1c4b-4281-b951-d872f2087c98

I looked through the cs.chromium.org results for

codedoutputstream -file:.pb.cc -file:.java -file:.pb.h

but don't see any other instances of this exact problem in
non-test code (and in fact, some with similar looking
constructs: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/protobuf/src/google/protobuf/io/coded_stream_unittest.cc&l=320 )

R=zea@chromium.org
BUG=338962

Review URL: https://codereview.chromium.org/149073006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247815 0039d316-1c4b-4281-b951-d872f2087c98

due to new static initializers in gl_bindings_autogen_gl.cc

> Ensure GL initialization only happens once, and provide common init path
> 
> Currently tests initialize GL by calling into methods that should be
> internal to the gl bindings code. Instead, everyone should go through
> GLSurface::InitializeOneOff.
> 
> Also GLSurface::InitializeOneOff early outs if it was already called,
> leading to a pattern of initializing GL all over the place just in case
> and not having a clear idea of where it should be set up. Instead, DCHECK
> that it is not called more than once, and move calls to this method to
> be during process startup for unit test suites instead of mid-test.
> 
> This adds two test variants of InitializeOneOff for tests to call, that
> set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
> 
> R=piman, sievers
> BUG=270918
> 
> Review URL: https://codereview.chromium.org/135213003

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/149953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230018
TEST=manual tests on Peppy

Review URL: https://codereview.chromium.org/144983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247806 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was misusing subprocess.Popen such that no output
was ever captured from checkperms.py.

Also, changed the check to use input_api.subprocess instead of importing subprocess.

R=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/143013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247805 0039d316-1c4b-4281-b951-d872f2087c98

Dependencies added in the range 247769-247777, I suspect 247775, a blink roll,
since that caused this last time, and was since reverted.

BUG=None
NOTRY=true
NOTREECHECKS=true
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/149443010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247802 0039d316-1c4b-4281-b951-d872f2087c98

Now that Aura is required for Windows, we can safely delete the non-Aura
mock theme code and simplify the logic for the other cases.

R=jam@chromium.org
BUG=330735

Review URL: https://codereview.chromium.org/139903015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247799 0039d316-1c4b-4281-b951-d872f2087c98

This was modified in r247446 to cover some new leaks which apperaed.
The modification narrowed the suppression which has made some old leaks
in crypto tests on Linux and ChromeOS start reappearing.

TBR=eugenis@chromium.org
NOTRY=true
BUG=321976

Review URL: https://codereview.chromium.org/132233061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247798 0039d316-1c4b-4281-b951-d872f2087c98

> Change default mode of extension install verification
> 
> Right now the default mode is to make requests against the server unless
> the experiment group says not to, and that may be contributing to some
> unexpected load we're seeing. So this CL changes it to not do that.
> 
> It also adds some histograms to help measure the success rate and
> sources of requests to the server.
> 
> BUG=335379
> R=finnur@chromium.org
> 
> Review URL: https://codereview.chromium.org/149353002

TBR=asargent@chromium.org

Review URL: https://codereview.chromium.org/147983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247797 0039d316-1c4b-4281-b951-d872f2087c98

The java test is fixed in https://codereview.chromium.org/147083010/

BUG=None
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/137423013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247796 0039d316-1c4b-4281-b951-d872f2087c98

Add flackr to ash/wm/overview/OWNERS

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/145973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247795 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates two descriptor leaks -- the downloaded nmf file, and
the nexe itself.  One socket (on Linux) still leak.  Because Unixes
always use the lowest available number and the leaked descriptor is
the highest numbered one while the F@H nexe is running, this implies
that this might be a PPAPI proxy related leak, since proxy hookup is
the last thing that happens before the application itself runs.

See /home/bsy/fd-leak-log for time-lapsed view of what happens when a
F@H NaCl module finishes and another starts up.

TEST= manually running F@H and checking /proc/<renderer>/fd/*
BUG= 335186
R=bbudge@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/147083014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247794 0039d316-1c4b-4281-b951-d872f2087c98

Currently tests initialize GL by calling into methods that should be
internal to the gl bindings code. Instead, everyone should go through
GLSurface::InitializeOneOff.

Also GLSurface::InitializeOneOff early outs if it was already called,
leading to a pattern of initializing GL all over the place just in case
and not having a clear idea of where it should be set up. Instead, DCHECK
that it is not called more than once, and move calls to this method to
be during process startup for unit test suites instead of mid-test.

This adds two test variants of InitializeOneOff for tests to call, that
set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.

R=piman, sievers
BUG=270918

Review URL: https://codereview.chromium.org/135213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247793 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/149193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247791 0039d316-1c4b-4281-b951-d872f2087c98

Right now the default mode is to make requests against the server unless
the experiment group says not to, and that may be contributing to some
unexpected load we're seeing. So this CL changes it to not do that.

It also adds some histograms to help measure the success rate and
sources of requests to the server.

BUG=335379
R=finnur@chromium.org

Review URL: https://codereview.chromium.org/149353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247790 0039d316-1c4b-4281-b951-d872f2087c98

Chrome for Android does not use chrome://help so we should not include
the strings for it.

BUG=326023
R=newt@chromium.org

Review URL: https://codereview.chromium.org/142573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247789 0039d316-1c4b-4281-b951-d872f2087c98

This moves ExtensionSystem to extensions/browser.
It also moves setting the channel for Features to ChromeExtensionsBrowserClient.
It also removes the duplicate ExtensionSystem::GetForBrowserContext.

BUG=337707
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/147923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323015
TBR=tonyg
NOTRY=True

Review URL: https://codereview.chromium.org/149773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247787 0039d316-1c4b-4281-b951-d872f2087c98

Mainly replacing bool parameters with enum values

BUG=none
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/149073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297132

Patch set 1 is the original CL:

https://codereview.chromium.org/137543002/

which broke tests on the memory bots. Path set 2 contains the fix for the test failure.

Review URL: https://codereview.chromium.org/148213010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247784 0039d316-1c4b-4281-b951-d872f2087c98

This refactors all the windows code out of external_protocol_dialog.cc
into the cross-platform ShellIntegration interface, and makes the
external_protocol_dialog.cc implementation use the existing
external_protocol_dialog_delegate.cc interface.

BUG=337660
R=sky@chromium.org

Review URL: https://codereview.chromium.org/132903018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247783 0039d316-1c4b-4281-b951-d872f2087c98