- 04 Oct, 2018 40 commits
-
-
David Tseng authored
This reverts commit e0ffa06d. Reason for revert: <INSERT REASONING HERE> Bug: 891889 Original change's description: > Remove unnecessary call to EnableFileSystemInGuestMode > > This call makes no sense. There's no reason that loading the > speech synthesis component extension should trigger enabling > the filesystem in guest mode for a related, but entirely different, > extension (ChromeVox). > > If ChromeVox needs EnableFileSystemInGuestMode, we should be calling > this from code that loads the ChromeVox component extension, but I suspect > that it doesn't need it at all. > > As far as I can tell this was accidentally added here as part of a > refactoring: > https://codereview.chromium.org/1162283002 > > Note that OnceClosure() would be better, but that'd require a big cleanup > of many other functions, so I don't want to do that as part of the same > change. > > Bug: none > Change-Id: I1f67b78548048fffa9194083b10e0ff5c5aaa863 > Reviewed-on: https://chromium-review.googlesource.com/1246364 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594463} TBR=dmazzoni@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: If18c5fcbdbc6be5b6ce8235afa612597792127ff Reviewed-on: https://chromium-review.googlesource.com/c/1261960Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596731}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5541a6c86a64..4e6f2aeac25a git log 5541a6c86a64..4e6f2aeac25a --date=short --no-merges --format='%ad %ae %s' 2018-10-04 brandon1.jones@intel.com Implement ANGLE_copy_texture_3d Extension Created with: gclient setdep -r src/third_party/angle@4e6f2aeac25a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If1ea700bc9b05d889e802452a67329660294a7f1 Reviewed-on: https://chromium-review.googlesource.com/c/1261419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596730}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/19c07731fce3..3b5960174f6d git log 19c07731fce3..3b5960174f6d --date=short --no-merges --format='%ad %ae %s' 2018-10-04 alanbaker@google.com Don't scalarize spec constant sized arrays 2018-10-04 stevenperron@google.com Make EFFCEE required (#1943) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3b5960174f6d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic4ea2c0140511a3b2f06e3428fabeebf78a51c0e Reviewed-on: https://chromium-review.googlesource.com/c/1261959Reviewed-by:
-
Becca Hughes authored
Remove AudioFocusManager in content as it has been moved to //services/media_session. BUG=875004 Change-Id: Iba9136c8b3854d5936067b86fead4e0d67659f0c Reviewed-on: https://chromium-review.googlesource.com/c/1207913 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596728}
-
David Trainor authored
It turns out that only setting the change animation duration to 0 doesn't tell the default ItemAnimator that it can reuse ViewHolders. This is because it still attempts to animate between the old and new ViewHolder Views. Setting a payload seems to bypass this as well though. This patch disables change animations completely for the Download Home v2 RecyclerView ItemAnimator. Change-Id: I633b6408a73c55da26a608d07ec564bf82737ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1260125Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596727}
-
file://static_top_25/yahoogames.htmlCaleb Rouleau authored
NOTRY=true TBR=nednguyen CC=vmpstr@chromium.org,wkorman@chromium.org Bug: 892223 Change-Id: I5517434aead61328bc6c131a0c9bbb81f14e1d79 Reviewed-on: https://chromium-review.googlesource.com/c/1261929Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#596726}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ia3e85d0138b315991d4ab09be1e22a94f3d48660 Reviewed-on: https://chromium-review.googlesource.com/c/1261521Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#596725}
-
Weidong Guo authored
1. Scale down apps grid view when it does not fit inside small display via transform. 2. Remove box layout in app list main view to avoid duplicate layouts in each dragging frame. 3. Update Y position of views instead of calling Layout function during dragging to avoid jitter issue due to rounding error. 4. Avoid resizing apps grid view in dragging and animation, which is an expensive operation. Bug: 881851 Change-Id: I78e2605727e8c7f0d93177bcf8877d796b746b86 Reviewed-on: https://chromium-review.googlesource.com/c/1259463 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596724}
-
Rayan Kanso authored
Simplify event dispatching code, and also allow for match/matchAll to be called with the abort event. Change-Id: I3a9d17102f176f7c68131ea144e555a44ffd6ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1261477 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#596723}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /components/omnibox. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=jdonnelly@chromium.org Bug: 890902 Change-Id: I186f707ed819c7f2b1db042f9db6d0ccde2c57e7 Reviewed-on: https://chromium-review.googlesource.com/c/1257853 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#596722}
-
Tatiana Buldina authored
Bug: chromedriver:1855 Change-Id: I701bf519b7c34e34a884d99e102fecc95ddd967c Reviewed-on: https://chromium-review.googlesource.com/c/1262155Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#596721}
-
Wez authored
SystemProfile.is_asan_build was previously only set for ASAN builds. In general we care about whether a build is standard, versus instrumented, regardless of the kind of instrumentation, so we re-use this field to also indicate DCHECK-enabled builds. The field will be renamed to is_instrumented_build up-stream, to better reflect its intended meaning. Bug: 889105 Change-Id: Ieb0c54dcf53db298a101d29447987791e9b085e1 Reviewed-on: https://chromium-review.googlesource.com/c/1260516Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#596720}
-
Wenzhao (Colin) Zang authored
This reverts commit f033b7d2. Reason for revert: crbug.com/891988 Original change's description: > [css-flexbox] Apply min-height: auto to nested flexboxes again > > To avoid the previous regression (see analysis in bug), we force > layout in the case where we otherwise would get an outdated result. > > This relands https://chromium-review.googlesource.com/c/chromium/src/+/1246730 > with an additional fix for the Chrome UI CSS. I also split out the > test change into its own patch. > > IF THIS BREAKS ANY FURTHER CHROME UI: > Please don't revert this patch; instead, add min-height: 0 to any > inner nested flexboxes that may be affected by this patch. This is > an important change for web interop with the other browsers. > > Bug: 596743,890100 > Change-Id: Ice629c2a7823ef07d075fa23b99022b4012c6200 > Reviewed-on: https://chromium-review.googlesource.com/1252682 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595225} TBR=cbiesinger@chromium.org,eae@chromium.org,wzang@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 596743, 890100 Change-Id: I8b3ce623a49fe476dbc309b9d780fee80b233c3e Reviewed-on: https://chromium-review.googlesource.com/c/1261919Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596719}
-
Andrey Kosyakov authored
This removes AllowBadCertsNetworkServiceClient which is instantiated but not otherwise used. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I51ea027d808e6c1d48860fab707a4bb8446ef4b3 Reviewed-on: https://chromium-review.googlesource.com/c/1260324Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596718}
-
Philip Rogers authored
This patch updates baselines for 5 failing tests. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7d4a571ec0129de442c1da0257e25ccdc0be3be Reviewed-on: https://chromium-review.googlesource.com/c/1259831Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596717}
-
Jonathan Metzman authored
Remove declaration of unused and unitialized variable "wpath", which caused compilation failure. Bug: 891867 Change-Id: Icea7336c31d3897b72323b646a97899c5c2b66d0 Reviewed-on: https://chromium-review.googlesource.com/c/1259827 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#596716}
-
Arthur Sonzogni authored
Some javascript function called in an infinite loop can cause the browser process to be flooded by IPC and become unresponsive. Limit the number of IPC sent to 10 per second per frame. This was already done for: - history.pushState() - history.replaceState() This is extended to: - history.back() - history.forward() - history.go() - navigations... 3 tests added. Bug: 882238 Change-Id: I821ff742307ab471ca52f27c6003d003ee978a46 Reviewed-on: https://chromium-review.googlesource.com/c/1230067 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596715}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bc2959072dc5..c0f26d458d3d git log bc2959072dc5..c0f26d458d3d --date=short --no-merges --format='%ad %ae %s' 2018-10-04 nisse@webrtc.org Drop unneeded inclusion of module_common_types.h 2018-10-04 sakal@webrtc.org Add checks to HW codecs to ensure unsupported features are not used. 2018-10-04 titovartem@webrtc.org Rename NetworkSimulationInterface into NetworkBehaviorInterface. 2018-10-04 ssilkin@webrtc.org Fix VP9 K-SVC full stack tests. 2018-10-04 sakal@webrtc.org Document methods that are only supported on a specific Android version. 2018-10-04 philipel@webrtc.org Parameterized full stack tests to test the new generic descriptor. 2018-10-04 ivoc@webrtc.org Add more NetEq information to NetEqState. 2018-10-04 danilchap@webrtc.org Temporarily increase visibility of pacing and call/rtp_interfaces 2018-10-04 mbonadei@webrtc.org Revert "Reland "Export symbols needed by the Chromium component build (part 1)."" 2018-10-04 gustaf@webrtc.org Avoid incorrect filter alignment due to call skew detection 2018-10-04 mbonadei@webrtc.org Temporarily increase visibility of publicly used build targets. 2018-10-04 mbonadei@webrtc.org Reland "Export symbols needed by the Chromium component build (part 1)." 2018-10-04 kwiberg@webrtc.org AudioCodingModuleTest.TestRedFec: Don't let the ACM create audio encoders 2018-10-04 srte@webrtc.org Adds check for uninitialized window start sequence. Created with: gclient setdep -r src/third_party/webrtc@c0f26d458d3d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:889017,chromium:892040 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibdce73c5a1edea4cc5568af04f8ae63992bdd754 Reviewed-on: https://chromium-review.googlesource.com/c/1261955Reviewed-by:
-
Matthew Jones authored
This patch removes the gatherTransparentRegion implementation from the BottomSheet in favor of attaching and detaching the sheet view from the hierarchy. Gathering the transparent region of a moving view is difficult since that method is only called on layout. By taking the view out of the hierarchy, the view is always "transparent" when it is not visible. Bug: 876097 Change-Id: I6073903d23b49b963bf2f4b570f6b51389430e42 Reviewed-on: https://chromium-review.googlesource.com/c/1252852 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Xi Han authored
This CL add a default implementation of ContentMainDelegate::PostEarlyInitialization() to create FeatureList, and remove the creation in BrowserMainLoop which happens after staring the TaskScheduler in CL (https://crrev.com/c/1174955). This fix browser tests failures when the TaskScheduler is starting before FeatureList is created. Bug: 848615, 729596 Change-Id: I9f9e85c785d41ad518db4170db53c4fc1d57e90d Reviewed-on: https://chromium-review.googlesource.com/c/1228615 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596712}
-
Lukasz Anforowicz authored
This CL expands the following 2 test cases from the CrossOriginReadBlockingExtensionTest test suite: 1) FromForegroundPage_NoSniffXml This CL adds coverage of a fetch performed from an about:srcdoc frame that belongs to an extension origin. 2) FromDeclarativeContentScript_NoSniffXml This CL adds coverage of a fetch performed from a content script injected into an about:blank page. In both cases above, the fetch is performed before the browser commits the frame. The new tests help ensure that in this scenario the extension scripts are still subject to relaxed CORB rules - because of the timing the relaxed CORB rules do not depend on URLLoaderFactoryManager::ReadyToCommitNavigation, but rather on having the renderer inherit the right URLLoaderFactory for the subframe. Bug: 846346 Change-Id: I45a4eba6d1351f2bf722f31fbcb7f201cd990d34 Reviewed-on: https://chromium-review.googlesource.com/c/1259291 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596711}
-
Ovidio Henriquez authored
This change creates a new UsbPolicyAllowedDevices class that reads the preference value for kManagedWebUsbAllowedDevicesForUrls and creates a mapping of the tuple (vendor_id, product_id) to a set of URL patterns. The class also provides a method to check if a pair of requesting and embedding origins are allowed to access a device with vendor_id and product_id. The design document for this feature can be found at: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I014849be2ef4779e45c28c6699ff34022d3e9b89 Reviewed-on: https://chromium-review.googlesource.com/c/1250060 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596710}
-
Hidehiko Abe authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/7d4f284ecdc0..2e1f8c671bd4 $ git log 7d4f284ec..2e1f8c671 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 xiaochu system_api: add update_engine proto for d-bus method parameter Created with: roll-dep src/third_party/cros_system_api Bug: 874735, 879313 Test: Try. Change-Id: Ieab49202022b6f823989b32eaa7b8c5519c8c5d7 Reviewed-on: https://chromium-review.googlesource.com/c/1261535Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596709}
-
Camille Lamy authored
Following the launch of PlzNavigate, this IPC is no longer useful: the browser process is fully responsible for setting a RenderFrame in a loading state and does need a notification from the renderer process. Bug: 789577 Change-Id: I18ea2965f0151170e765af4e225475ad7a2f6202 Reviewed-on: https://chromium-review.googlesource.com/c/1131739 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Bug: 889888 Change-Id: I2429361627ffea2e1b8d5a11eb0e34b0cbfa1abb Reviewed-on: https://chromium-review.googlesource.com/c/1249265Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Majid Valipour authored
Bug: 887659 Change-Id: I6b201d3eb3e75bbdc56429228d82e72830a96709 Reviewed-on: https://chromium-review.googlesource.com/c/1261981Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#596706}
-
Lukasz Anforowicz authored
This CL adds the following 2 test cases to the CrossOriginReadBlockingExtensionTest test suite: 1) FromForegroundPage_NoSniffXml This test performs the fetch from a foreground tab that has committed an extension page. This test is quite similar to the already existing FromBackgroundPage_NoSniffXml test, but might be worth keeping (e.g. in case background pages go away in the future, or in case the code handling background-vs-foreground page diverges). 2) FromServiceWorker_NoSniffXml This test covers the scenario where a fetch from a foreground tab is handled by the extension's service worker. This scenario means that CORB correctly handles the response from the network to the service worker - this response in the NetworkService world is handled by a URLLoaderFactory that is created separately from the factory created by RenderFrameHostImpl::CreateNetworkServiceDefaultFactoryInternal. Bug: 846346 Change-Id: Id8c1ac892b4c3f25ef2b37f980b234bb8f25b6e5 Reviewed-on: https://chromium-review.googlesource.com/c/1257151 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596705}
-
Arthur Sonzogni authored
There is a race in between: 1) The end of the test. 2) The XHR 'abort' event handlers executed. There is a PostTask in between: A) blink::XMLHttpRequest::HandleDidCancel() B) blink::XMLHttpRequest::HandleRequestError() FrameLoader::FinishedParsing may be interleaved in between A) and B). Make use of testRunner.{waitUntilDone, notifyDone} to get reliable results. Bug: 831155 Change-Id: Ibe1ad9020319aae7268f331b2dba0911035789e2 Reviewed-on: https://chromium-review.googlesource.com/c/1261520 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: -
chrome://sync-internalsMarc Treib authored
These should help with diagnosing some problems we've been seeing with Sync not properly starting up. While we're here, also rename "Token Request State" to "Last Token Request Result" which is closer to what this field actually means. Bug: none Change-Id: I4c72c654abb848afffa6aa64076f92cf28c859cc Reviewed-on: https://chromium-review.googlesource.com/c/1261817Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596703}
-
Marc Treib authored
Switching between ephemeral and persisted card storage in PersonalDataManager only worked in some cases: It worked correctly if it happened as part of a full restart, but NOT as part of a data type reconfiguration. The problem was that in the case of a reconfiguration, we weren't actually restarting the data types, so they had no chance to properly re-wire everything. This CL fixes that by restarting all data types in ModelAssociationManager if the storage option changed, i.e. calling DataTypeController::Stop followed by LoadModels. It also adds two integration tests. Bug: 885211 Change-Id: I58576f15da13055aab0f470a7433cadb56c4621a Reviewed-on: https://chromium-review.googlesource.com/c/1245795 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Mathias Carlen authored
Before this pach, the devtools client would log an error on every unkown event from the devtools host. Most of these events are not relevant for us and we should not give those a high visibility in logs. This change moves the unknown devtool event error logs to DVLOG(2). After this patch, in order to see these errors, a developer has to enable those via --v or --vmodule. R=rouslan@chromium.org, szermatt@chromium.org Bug: 806868 Change-Id: I166f9c09e2bb8b1c95fc26d339f2ca854ec21912 Reviewed-on: https://chromium-review.googlesource.com/c/1257829Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596701}
-
Ahmed Fakhry authored
Gesture scrolling starts before top-chrome starts sliding. During that small period, the `DoBrowserControlsShrinkRendererSize` bit should remain unchanged. This CL fixes this issue and adds a test to verify the state of the browser while top-chrome sliding is in progress. BUG=884440, 867063, 891516 TEST=Added new test Reviewed-on: https://chromium-review.googlesource.com/c/1249729Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595899} Change-Id: I63f101175c1ec1052d6e0bb55bbe760fd7a8b369 Reviewed-on: https://chromium-review.googlesource.com/c/1260105 Cr-Commit-Position: refs/heads/master@{#596700}
-
Sergio Villar Senin authored
IdentityManager::Observer now provides OnPrimaryAccountSigninFailed() offering the same functionality than the SigninManager equivalent API. Bug: 869418 Change-Id: I00d42b622a483bb9b763aaf04d10e4f639e39042 Reviewed-on: https://chromium-review.googlesource.com/c/1257835 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596699}
-
Guido Urdaneta authored
According to spec, if permission for at least one of the requested tracks is denied, the whole request should be denied. Before this CL, a getUserMedia() request for audio and video with one of the permissions blocked and one allowed, would succeed and return one track, which is against the spec. Drive-by: minor lint include fixes. Bug: 416162 Change-Id: Ibd49f4ccea00a042ccc1b5e7b546aa9ae55b84ab Reviewed-on: https://chromium-review.googlesource.com/c/1251125Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#596698}
-
Kyle Horimoto authored
Previously, the MultiDevice setup flow would make a connection to the Mojo service as soon as the flow was loaded. However, in OOBE mode, this means that the WebUI page requests a connection as soon as OOBE loads, which is before the user has signed in. Since the MultiDeviceSetup service is only created once the user has signed in, the strategy of connecting as soon as the page loads resulted in trying to connect to a service which had not yet been registered. This CL delays the process of connecting to the Mojo service; now, a connection is made only when the initializeSetupFlow() function is called or the "multidevice_setup.initializeSetupFlow" WebUI event is fired. Bug: 884065 Change-Id: I2dde7916ac400625677c45d6de1c0fc72afab976 Reviewed-on: https://chromium-review.googlesource.com/c/1259835 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596697}
-
Sahel Sharify authored
Calling PrgoressFling right after Processing GFS which landed in https://chromium-review.googlesource.com/1140912 was the root cause of this regression. This cl changes the fling controller logic to wait for the scheduler to call progress fling. The following browser tests are also added to make sure that the regression won't happen in the future. Bug: 884728, 249063 Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF Change-Id: I3018b32c9d40d36406b4f532dcab6cccf3ee3b97 Reviewed-on: https://chromium-review.googlesource.com/c/1252621 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596696}
-
edchin authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I39e87bd9e388663fed442cce86ed42e4fa38a7b0 Reviewed-on: https://chromium-review.googlesource.com/c/1259202Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596695}
-
Caleb Rouleau authored
NOTRY=true TBR=nednguyen@google.com Bug: 892184 Change-Id: I8df9415f42ee83de7dba675cbb8aeb1ec2db5f48 Reviewed-on: https://chromium-review.googlesource.com/c/1262195Reviewed-by:
-
Jonathan Metzman authored
Include <cctype> since it declares std::toupper, in order to fix build breakage on Windows. Bug: 891867 Change-Id: I856286b390e152592951ccb318ec2260a6514073 Reviewed-on: https://chromium-review.googlesource.com/c/1259828 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#596693}
-
Roman Sorokin authored
Removed default autocomplete to device domain. Removed message for device name input with regex. BUG=chromium:865474 TEST=manual Change-Id: Ib334f89ae0d4a27153cd69e5100253cce18f40a1 Reviewed-on: https://chromium-review.googlesource.com/c/1255730 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#596692}
-
