- 20 Nov, 2018 40 commits
-
-
Adam Rice authored
Enable ReadableStream objects to be transferred by postMessage(). Internally, the ReadableStream is converted to a MessagePortChannel and it is that that is transferred. This involves adding a "stream_channels" field to the TransferableMessage mojo struct for the channels that will be used by ReadableStream (and in future WritableStream and TransferableStream objects). Additional code is added to V8ScriptValueSerializer and V8ScriptValueDeserializer to recognise ReadableStream objects. SerializedScriptValue has new methods and an array of MessagePortChannels as a member variable to transfer them. The new code is behind the "TransferableStreams" Blink feature and must be explicitly activated. A set of new layout tests provides basic verification that postMessage() of ReadableStream objects work. They are run with the feature enabled via a new VirtualTestSuite. The changes are covered in more detail in the design doc: https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit Bug: 894838 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I032306415aa0c4e146af25439f42bcff70436416 Reviewed-on: https://chromium-review.googlesource.com/c/1315367 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609688}
-
Daniel Bratell authored
Jumbo is a unity build system for Chromium (see https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md ) which merges cc files at the build target level. The code in //ppapi needs roughly 15 CPU minutes to compile in my measurements, which is 2.3% of the total jumbo build time and one of the largest remaining non-thirdparty code blocks without jumbo support. This saves about 7.5 CPU minutes in a jumbo build, which is a bit over 1% of the total reference build time. It doesn't cover thunk which is most of the remaining compile time. There are too much generated code with reused symbol names in thunk for it to be trivially supported right now. Bug: 898475 Change-Id: I1ee592578ac765cbd58cb856fcd5f331d3dd8c50 Reviewed-on: https://chromium-review.googlesource.com/c/1297366Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609687}
-
Daniel Bratell authored
The documentation didn't include the crucial information that generate_linker_map has to be set to true in gn for the tool to work in Linux. Bug: 716209 Change-Id: I62919e26a80a0b5d592f6b8953762e35575142d2 Reviewed-on: https://chromium-review.googlesource.com/c/1338085Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609686}
-
Henrik Boström authored
This helper class keeps track of an offerer state and an answerer state and makes sure that the transitions between different states are valid. By having a single state that reports whether the call setup was successful or if (and in which step) it failed we can be sure to get trustworthy comparisons between % success and % failures, which is important for the Unified Plan experiments. Follow-up CL(s) will wire up RTCPeerConnection to use this helper class and make sure the states are reported with UMA. Bug: 906029 Change-Id: Iafb77533c66c7625269e3c6e33ef954d88e54cdb Reviewed-on: https://chromium-review.googlesource.com/c/1340299Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609685}
-
Kush Sinha authored
Context: https://sites.google.com/a/chromium.org/dev/flag-ownership Bug: 820046 Change-Id: I8c64fd39cd8624f0810e1300ee3a4bc0caa0791b Reviewed-on: https://chromium-review.googlesource.com/c/1343268Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609684}
-
Peter E Conn authored
It appears that changes to custom-tabs-client code are not synced to https://github.com/GoogleChrome/custom-tabs-client until they are included in Chrome's DEPS. This rolls the custom tabs client code to include fixes to a Trusted Web Activity utility class and to make it build with Java 8 (it was previously using Java 8 features, so technically this is a fix). Bug: 854603 Change-Id: I0937d2ed077cdf716293182c8b1bac6ef0895534 Reviewed-on: https://chromium-review.googlesource.com/c/1337489Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#609683}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e54003639e3..d11507507daa git log 1e54003639e3..d11507507daa --date=short --no-merges --format='%ad %ae %s' 2018-11-20 perezju@chromium.org [soundwave] Use explicit dtype's for DataFrame columns Created with: gclient setdep -r src/third_party/catapult@d11507507daa The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904876 TBR=sullivan@chromium.org Change-Id: Icb6e1555aca0dee52cf934d4c489034ae6b0d033 Reviewed-on: https://chromium-review.googlesource.com/c/1342690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609682}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: None Change-Id: Ifbff77761cb69ef2d5f8c765d4aea1df63906459 Reviewed-on: https://chromium-review.googlesource.com/c/1343074Reviewed-by:
-
Koji Ishii authored
This is a reland of 05672d8d The original change was reverted as suspected to cause Android CFI builder to fail: [ RUN ] RenderViewImplTest.PreferredSizeZoomed [FATAL:data_pack.cc(444)] Check failed: !handle->HasResource(resource_id). Duplicate resource 25400 with scale 1 I cannot find any relationship to the failure, and android_cfi_rel_ng trybot passes. Relanding to see if this was really the cause. Original change's description: > Normalize Katakana to Hiragana in ScriptRunIterator > > This patch normalizes Katakana to Hiragana in ScriptData, and > thus in ScriptRunIterator. > > There are 3 ICU script code for kana; USCRIPT_HIRAGANA, > USCRIPT_KATAKANA, and USCRIPT_KATAKANA_OR_HIRAGANA. However, > OpenType has only one 'kana' for all these 3 script codes. > > When shaping, HarfBuzz handles the normalization. However, > Blink splits the incoming string by the ICU scripts. > Splitting these 3 scripts is not useful but consumes CPU > and memory. > > By normalizing in ScriptRunIterator, all types of Kana are > in single run. > > timeToFirstContentfulPaint:layout shows ~3% improvements > https://pinpoint-dot-chromeperf.appspot.com/job/10d9760fe40000 > > though bink_perf.layout does not show much differences > https://pinpoint-dot-chromeperf.appspot.com/job/14f19c00140000 > > This is probably because Katakana characters are not used > much in `japanese-kokoro-insert` (written in ~100 years ago,) > while they are more used in modern pages. > > Bug: 636993 > Change-Id: If692bb575f2232b8fca10cd2ea87e3022debdf05 > Reviewed-on: https://chromium-review.googlesource.com/c/1337650 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609119} TBR=drott@chromium.org Bug: 636993 Change-Id: I1d741fa47556c5e7bf47e3badcdcf60a81fbc22b Reviewed-on: https://chromium-review.googlesource.com/c/1343583Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609680}
-
Maxim Kolosovskiy authored
TBR=wolenetz@chromium.org Bug: 689781 Change-Id: I432995526e5aa0a2e235bf2a8a496ed265cbff74 Reviewed-on: https://chromium-review.googlesource.com/c/1343086 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609679}
-
Maxim Kolosovskiy authored
This reverts commit 756bea38. Reason for revert: FindIt suspects that this is the culprit for a number of failures https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/18261 Original change's description: > v8binding: Do not hold a cross origin ScriptState in IDL callback function > > Make IDL callback function not hold a ScriptState of its > creation context when it's cross origin from the incumbent > realm. > > Not holding a cross origin ScriptState, there is much > less risk to access a cross origin context. > > IDL callback interface will follow the same approach in > a separate patch. > > Bug: 892755, 886588, 904218 > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1314023 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609662} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: Ic0e5a3006a43f8a95202ac1d890f365307068877 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892755, 886588, 904218 Reviewed-on: https://chromium-review.googlesource.com/c/1343093Reviewed-by:
-
Sami Kyostila authored
If we try to record a trace event during MessageLoop shutdown, we can get to a state where the MessageLoop is present but the thread task runner handle has been reset. Since we require both in order to initialize the thread local event buffer, this patch makes sure the initialization is skipped if that condition isn't met. Bug: 906795 Change-Id: I9ead620573387f8c329d954425ef43c60547bbef Reviewed-on: https://chromium-review.googlesource.com/c/1343263Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#609677}
-
Maxim Kolosovskiy authored
TBR=estark@chromium.org, elawrence@chromium.org Bug: 907061 Change-Id: I138f8a64717329d4141ee1c2d49289741e524707 Reviewed-on: https://chromium-review.googlesource.com/c/1343267Reviewed-by:
-
Varun Khaneja authored
Change-Id: I13f4b6e35dea5edcc18f3234755956014e85a6d7 Reviewed-on: https://chromium-review.googlesource.com/c/1343504Reviewed-by:
-
jdoerrie authored
This change modifies previous browser links to the passwords settings page to link to passwords.google.com instead, in case the the user is syncing passwords with normal encryption and the corresponding feature flag is set. Bug: 904821 Change-Id: Id3c8591921f1277d098bb7d8677dabc57af28547 Reviewed-on: https://chromium-review.googlesource.com/c/1341509Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#609674}
-
Zakhar Voit authored
DeviceDisplayResolution policy lets admin to enforce or recommend resolution or display scale settings for displays connected to a device. Example of the policy value: { "external_width": 1920, "external_height": 1080, "external_scale_percentage": 50, "internal_scale_percentage": 150, "recommended": true } It sets a 1920x1080 display mode for any external displays and scales them to 50%, also scales the built-in display to 150%. If "recommended" flag is set to true, user is able to override any settings via the settings page. Also refactored the code for DisplayRotationDefault policy to handle all the display related policies from one place. Bug: 499904 Change-Id: I50e135c5bc65b78ddb14dbfb40308e3e29a2b5a5 Reviewed-on: https://chromium-review.googlesource.com/c/1269533 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#609673}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed5a8caf60cf..316e4119ed88 Created with: gclient setdep -r src-internal@316e4119ed88 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I556d30043d757f33a2315461184994158ecaafb0 Reviewed-on: https://chromium-review.googlesource.com/c/1342688Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609672}
-
Morten Stenshorne authored
Being "placed" means that they should be added to the FloatingObjectTree, which is really only used consistently by the legacy engine. NG only messes with it by accident. Have LayoutNG stay out of that business more than before, by introducing a "has geometry" flag. I really doubt that it's a splendid idea to populate the FloatingObjectTree at all in LayoutNG formatting contexts, but it does happen sometimes when laying out legacy objects in an NG container that also has floats. See bug report for further analysis. Bug: 906077 Change-Id: Iacebf5b8ca64e16c954a25745c8c2b01a18e1440 Reviewed-on: https://chromium-review.googlesource.com/c/1341915Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#609671}
-
Carlos Caballero authored
Create a helper class to manage critical multi-threaded operations without locks. This class will be used to remove the lock in base/task/sequence_manager/task_queue_proxy.h and to replace similar code in base/task/task_scheduler/task_tracker.h, and base/message_loop/message_loop_impl.cc Inspired from MessageLoopImpl::Controller. Bug: 901345 Change-Id: I56d2f2143e396c7bc81a76a23fe4731d280455d1 Reviewed-on: https://chromium-review.googlesource.com/c/1335942 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#609670}
-
Antonio Gomes authored
[s13n] Migrate the IdentityTestEnvironmentProfileAdaptor clients that pass PrefService to use Builder variant The "build variant" is more powerful, than the one that takes a |prefs| as parameter. TBR=emaxx@chromium.org (chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc) BUG=905687 Change-Id: I622446888ad8e31ef3fd0d464ac5ab25375abf3c Reviewed-on: https://chromium-review.googlesource.com/c/1340889 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609669}
-
Egor Pasko authored
Just a tiny utility, because writing code (to invoke the upload) is easier than to read the code (to extract the right command). Bug: 893981 Change-Id: Iff50406f554c207384ab0c4119d22d4510e59fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1340267Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#609668}
-
Rob Buis authored
Be strict on request's Content-Type by only allowing whitespace before type and after subtype. Behavior matches Firefox. Bug: 902681 Change-Id: Id08c0c56076c5b4aa6e335893f663b7d91229da1 Reviewed-on: https://chromium-review.googlesource.com/c/1341508 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609667}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I76c99d90e1c957619676a135a1c9ad736f0f1995 Reviewed-on: https://chromium-review.googlesource.com/c/1342787Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit a8f4b170. Reason for revert: Suspect this CL caused a failure of org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testCloseButtonBehaviourWithDynamicModule https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3725 org.junit.ComparisonFailure: expected:<http[s://www.google.com/search?q=cat]> but was:<http[://127.0.0.1:37221/chrome/test/data/android/test.html]> at org.junit.Assert.assertEquals(Assert.java:115) at org.junit.Assert.assertEquals(Assert.java:144) at org.chromium.chrome.browser.customtabs.CustomTabActivityTest.testCloseButtonBehaviourWithDynamicModule(CustomTabActivityTest.java:1195) Original change's description: > Cleanup XR usage of EmbeddedTestServer > > Cleans up manual usage of EmbeddedTestServer in XR tests, which was both > adding a lot of duplicate code and had the potential to fail to clean up > the server if the test failed, which could then affect other tests. > > This is achieved by making EmbeddedTestServerRule lazy and applying it > to all ChromeActivityTestRules, not just WebappActivityTestRule. > > Bug: 901923 > Change-Id: I431dac3ce2488a1a5762a1ab1f5ec68aea16c9f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1320024 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609556} TBR=nyquist@chromium.org,pauljensen@chromium.org,bsheedy@chromium.org Change-Id: I676439292a0f90ee353dadef415437415d82bba4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901923 Reviewed-on: https://chromium-review.googlesource.com/c/1343265Reviewed-by:
-
Peter E Conn authored
Previously Digital Asset Link verification contacted a Google Server. This had the disadvantage that verification would only work with servers that were publicly accessible. By doing the verification locally it will work with non-publicly accessible servers (such as company internal sites). Bug: 905698 Change-Id: Iaf00ae3b0d6193349310359183f3154c7f1d84f6 Reviewed-on: https://chromium-review.googlesource.com/c/1338180 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609664}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/50b8426648f3..5f0099596439 git log 50b8426648f3..5f0099596439 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 srte@webrtc.org Using unit classes in AimdRateControl. Created with: gclient setdep -r src/third_party/webrtc@5f0099596439 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91c4ab664b89a1cb1cbd3e1fefe922fff31ec7dd Reviewed-on: https://chromium-review.googlesource.com/c/1342689Reviewed-by:
-
Yuki Shiino authored
Make IDL callback function not hold a ScriptState of its creation context when it's cross origin from the incumbent realm. Not holding a cross origin ScriptState, there is much less risk to access a cross origin context. IDL callback interface will follow the same approach in a separate patch. Bug: 892755, 886588, 904218 Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 Reviewed-on: https://chromium-review.googlesource.com/c/1314023Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609662}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57d5d1dc. With Chromium commits locally applied on WPT: 5ee777f6 "Fix test exclusion logic of wpt/referrer-policy test generator warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command." ec589a5c "Add referrer-policy module worker tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ib3f0583c6acb94da677257449d0f94079d46668b Reviewed-on: https://chromium-review.googlesource.com/c/1343570 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609661}
-
Peter E Conn authored
Chances are the user of a TWA already has an app installed for the site they are viewing. In this case we should not show the app install banner. Bug: 906673 Change-Id: Ic09242e902cb4a76cc3deb879a1dd62b71614bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1342618Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b0c143c8eb23..101c113f649b git log b0c143c8eb23..101c113f649b --date=short --no-merges --format='%ad %ae %s' 2018-11-20 stevenperron@google.com Remove long running cfg limit test. 2018-11-20 dj2@everburning.com Add missing override to ProcessLinesPass Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@101c113f649b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8e306b6bdff9ef1f9cd05c0ef364728e3500125a Reviewed-on: https://chromium-review.googlesource.com/c/1343189Reviewed-by:
-
Mikel Astiz authored
This component contains sync-specific logic and plumbing so let's follow the setup in other components/sync_* components and list the core sync team as owners. Bug: None Change-Id: I509a41e3b4738967188680771ae8c535c02ca7ef Reviewed-on: https://chromium-review.googlesource.com/c/1343261Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609658}
-
Eric Seckler authored
Adds preferences for configuring the tracing mode and enabled tracing categories to the mobile tracing preferences. Bug: 898512 Change-Id: I23583dd24868918ce29eebce68568344b7c3c2f0 Binary-Size: feature implementation, strings will not be translated. Reviewed-on: https://chromium-review.googlesource.com/c/1340300 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
jdoerrie authored
This change introduces the PasswordManager.HttpCrendentials histogram superseding the currently existing PasswordManager.HttpCredentialsWith* histograms. As discussed in https://crbug.com/899949#c3, the Password Manager team has an interest in monitoring the number of HTTP credentials in the long term, which due to https://crbug.com/899949#c5 is now done in one histogram. Bug: 899949 Change-Id: I9f9a492fbc1fc55028b00f4521c5aba69cd984bd Reviewed-on: https://chromium-review.googlesource.com/c/1333309 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609656}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21f7091b9a09..c6195df99b92 git log 21f7091b9a09..c6195df99b92 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 cjmcdonald@chromium.org cbuildbot: Add option to build config to skip BuildPackages stage 2018-11-20 zamorzaev@chromium.org Revert "Remove waterfall parameter from InsertBuild method" 2018-11-20 dburger@chromium.org Fix assertRaises call in cidb_integration_test 2018-11-20 dhanyaganesh@chromium.org gob_util.FetchUrl: Add an exponential backoff retry 2018-11-20 dburger@chromium.org Remove unused some_alerts_dispatcher 2018-11-20 saklein@chromium.org SetupBoardStage: remove update_chroot call 2018-11-20 saklein@chromium.org UpdateSDKStage: Add UpdateSDK stage to execute main update Created with: gclient setdep -r src/third_party/chromite@c6195df99b92 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3065643b4946acc8375ece55037e6113993193c0 Reviewed-on: https://chromium-review.googlesource.com/c/1342785Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit a1b9cd32. Reason for revert: Suspect this CL caused WebViewTest.InterstitialPageFocusedWidget failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16877 [ RUN ] WebViewTest.InterstitialPageFocusedWidget [20977:51975:1119/183258.737359:WARNING:notification_platform_bridge_mac.mm(512)] AlertNotificationService: XPC connection invalidated. [20977:775:1119/183258.919345:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20977:775:1119/183300.396209:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20977:775:1119/183300.901427:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20977:775:1119/183301.011438:INFO:CONSOLE(15)] "embedder.loadGuest: 49781", source: chrome-extension://cdeknlbiapideljomhnngchhffjgbmfc/embedder.js (15) [20977:775:1119/183301.011622:INFO:CONSOLE(21)] "guestSrcHTTPS: https://localhost:49781/extensions/platform_apps/web_view/interstitial_teardown/https_page.html", source: chrome-extension://cdeknlbiapideljomhnngchhffjgbmfc/embedder.js (21) ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:1953: Failure Expected: (interstitial_widget) != (content::GetFocusedRenderWidgetHost(guest_web_contents)), actual: 0x7fe90b092600 vs 0x7fe90b092600 Stack trace: 0 browser_tests 0x0000000103d7875b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 browser_tests 0x0000000103d78119 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 browser_tests 0x00000001026c1a62 WebViewTest_InterstitialPageFocusedWidget_Test::RunTestOnMainThread() + 466 3 browser_tests 0x00000001071d7f6b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491 4 browser_tests 0x0000000106c255c4 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4372 5 browser_tests 0x0000000106c243ed ChromeBrowserMainParts::PreMainMessageLoopRun() + 45 6 browser_tests 0x0000000104d913d2 content::BrowserMainLoop::PreMainMessageLoopRun() + 50 7 browser_tests 0x00000001051f8f07 content::StartupTaskRunner::RunAllTasksNow() + 39 8 browser_tests 0x0000000104d9000b content::BrowserMainLoop::CreateStartupTasks() + 683 9 browser_tests 0x0000000104d93615 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85 10 browser_tests 0x0000000104d8e402 content::BrowserMain(content::MainFunctionParams const&) + 178 11 browser_tests 0x00000001066ae490 content::ContentMainRunnerImpl::Run(bool) + 752 12 browser_tests 0x00000001099f5a4b service_manager::Main(service_manager::MainParams const&) + 3051 13 browser_tests 0x00000001066ad514 content::ContentMain(content::ContentMainParams const&) + 68 14 browser_tests 0x00000001071d7bbd content::BrowserTestBase::SetUp() + 2829 15 browser_tests 0x0000000106b96431 InProcessBrowserTest::SetUp() + 529 Original change's description: > Added committed ssl interstitials to testing_config > > Bug: 755632 > Change-Id: I7e156e2df3a3124a13a5b576b7d691d77dd9c08b > Reviewed-on: https://chromium-review.googlesource.com/c/1289687 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609543} TBR=nasko@chromium.org,mgiuca@chromium.org,alexmos@chromium.org,holte@chromium.org,emaxx@chromium.org,vakh@chromium.org,cthomp@chromium.org,dougt@chromium.org,carlosil@chromium.org Change-Id: I4832ced67d6d115ed43fdd155424469d1136d695 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755632 Reviewed-on: https://chromium-review.googlesource.com/c/1343084Reviewed-by:
-
Luciano Pacheco authored
Change quick view for audios and videos to allow to use tab to focus the audio and video HTML5 tag's controls, e.g.: play, slider and volume. Add a blue outline for focused elements inside audio and video HTML5 tags, as part of the accessibility to make visually clear what control is focused. Change audio to not show the download button since it's already in the file system and downloading doesn't make sense in that context. Change video to not show picture-in-picture since it doesn't work for quick-view. Bug: 627701, 801522, 848216 Change-Id: Ie46159bc90d2948bbac98d69acaf8b53e62d5e58 Reviewed-on: https://chromium-review.googlesource.com/c/1341777 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609653}
-
Yoshifumi Inoue authored
This patch implements LayoutNG version of |LayoutText:: {First,Last}CharacterAfterWhitespaceCollapsing()| with making a unit test, |CharacterAfterWhitespaceCollapsing| to run on both legacy and ng layout tree. This patch also changes legacy layout tree path of |LastCharacterAfterWhitespaceCollapsing()| to use |StringView::CodepointAt()| instead of |String::CharacterStartingAt()| to return last code point in string instead of trail part of surrogate pair. Bug: 906915 Change-Id: I364195c5b9366cf7ca890ba2738a4be37779a6bd Reviewed-on: https://chromium-review.googlesource.com/c/1341776 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Sergio Villar Senin authored
This is a follow up of crrev.com/c/1335567. The only missing bit pending to be migrated was some SigninManager API that is now replaced by the PrimaryAccountMutator API. Bug: 890817, 890818, 890819, 890820, 890820 Change-Id: I9c746457987038bc810163dbb69dafdba75a74f0 Reviewed-on: https://chromium-review.googlesource.com/c/1341537Reviewed-by:
-
Boris Sazonov authored
This CL replaces 'new Handler().post(...)' statements with 'ThreadUtils.postOnUiThread(...)'. This is safe, as all SigninManager methods are invoked on the UI thread. Bug: 906193 Change-Id: I9638a96074762b5db6e3cfb9d80ea48685b499f3 Reviewed-on: https://chromium-review.googlesource.com/c/1343257Reviewed-by:
-
Mikel Astiz authored
Recent changes (linked to the bug) are believed to have deflaked the test, so let's reenable it on all platforms. Bug: 873902 Change-Id: I9804fa4d83c3b1afb9b71356d134736b63b11298 Reviewed-on: https://chromium-review.googlesource.com/c/1343083Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609649}
-
