- 13 May, 2020 40 commits
-
-
Yichen Zhou authored
When window bounds changes (e.g. toggle between fullscreen mode and windowed mode), the content underneath the cursor changes. We found that the cursor didn't change correctly because this situation failed to trigger SynthesizeMouseMoveEvent(). We changed the condition of triggering PostSynthesizeMouseMove() and reset |synthesize_mouse_move_| when |move_hold_count| going to 0. We also found that the tooltip was wrong when toggling back to windowed mode. We updated tooltip not only when it's visible but also scheduled to show. Bug: 1041396 Change-Id: I1a51c0b658e97b2b67079f7be80afb4dc393efb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186362 Commit-Queue: Yichen Zhou <yichenz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768494}
-
Adam Langley authored
RSA keys could always pass through generically, but this change adds support to the virtual authenticator and for parsing them so that they can be exposed via getPublicKey[1] in the future. [1] https://github.com/w3c/webauthn/pull/1395 Change-Id: If927385dccd8c9bea9f1cc27f015c9cb3da2d8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197668 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#768493}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db76048acef1..fcbb1943453f Created with: gclient setdep -r src-internal@fcbb1943453f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1081356 Tbr: rogerta@google.com,dfried@google.com Change-Id: Ib57a591804bd92c91f752d18d3c10d90fbb188f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199425Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768492}
-
Clark DuVall authored
This runs the WebView compatibility tests in the bundle test suite in addition to the standard instrumentation test suite. I was worried bundles may mess something up here so want to make sure we have test coverage for both WebLayer and WebView loading in bundles. Bug: 1033098 Change-Id: I4a4bf3187d7328a7ba0481b20d80ca5d73966b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199685 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768491}
-
Nathan Zabriskie authored
Recent patches have added YUV to RGB conversion to RasterInterface to prepare for OOPR Canvas. This patch updates yuv_util to use this new capability and changes several call sites to match. Also consolidates PaintCanvasVideoRenderer::UpdateLastImage to create the result image in one location. Eventually the result image will conditionally be an SkImage based on the presence of GrContext. Bug: 1058992 Change-Id: Ibb24eb0518ffd440cf59c146cc928b3cca7077fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195002Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768490}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a3deb22..07d68fbc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6dc58624b0846df2312d669075334c462a093f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199543Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768489}
-
Manas Verma authored
If AutofillClient returns a nullptr for InternalAuthenticator, then treat that as IsUVPAA() == false, and avoid further calls to InternalAuthenticator. Bug: 949269 Change-Id: I2c9246844d1629426d5c89d81933e8e0253a248e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198646Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#768488}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c66681be4bc9..d748e1651af8 git log c66681be4bc9..d748e1651af8 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 sugoi@google.com Fix missing border update after Image blit Created with: gclient setdep -r src/third_party/swiftshader@d748e1651af8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I47b356bb56e339b8bc7e3ddbe6b711a956e3471e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768487}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8d7e0009824..dcfb2338586c git log b8d7e0009824..dcfb2338586c --date=short --first-parent --format='%ad %ae %s' 2020-05-13 adlai@google.com Enable kernel caching in GrMatrixConvolutionEffect 2020-05-13 bsalomon@google.com Add workaround for TecnoSpark 3 Pro MIP mapping 2020-05-13 egdaniel@google.com Add GrContext getter to SkSurface. 2020-05-13 michaelludwig@google.com Simplify GrClip::getConservativeBounds() signature 2020-05-13 brianosman@google.com SkRuntimeEffect: Support late bound uniforms in raster 2020-05-13 egdaniel@google.com A flush and submit apis to public headers. 2020-05-13 borenet@google.com [infra] chrome_release_branch: maintain the last 3 branches 2020-05-13 brianosman@google.com Plumbing SkMatrixProvider into the raster backend Created with: gclient setdep -r src/third_party/skia@dcfb2338586c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I671c7d47149c5b069e55fbe4bcd1967f8b6115a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199428Reviewed-by:
-
David Bertoni authored
DeveloperPrivateApiUnitTest.UpdateHostAccessCheck was disabled for flakiness on ChromeOS, but it's no longer flaky. It passed 3000 iterations on multiple ChromeOS configurations with no flakes. Bug: 937355 Change-Id: Ia407ac24e6a79167d6003b3b6e74075490370ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197506Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768485}
-
John Delaney authored
This is a reland of 87691864 This change was reverted on https://crrev.com/c/2199924 as it introduced a flaky test. This was due to a simple error of passing "false" as debug_mode to a test which expects "true". This change fixes that and modifies the test a bit so that it is more likely to flake. This is not much better, but the function being tested is cheap so running it a bit more is not problematic. Original change's description: > [conversions] Do not use a noise provider in debug_mode > > Fixes flakes in ConversionsBrowsertest caused by a real noise > provider being used on conversiondata. > > The ternary used to allocate a noise provider is backwards, and should > use a null NoiseProvider in debug mode. > > Bug: 1082236,1082168,1082134 > Change-Id: Ibaa23ed16aaed1a80aa90f9e25a9ba8fd211f4bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198367 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768354} Bug: 1082236, 1082168, 1082134 Change-Id: I04dcdf69cec5a1e18c0982ef63a0b013f6104e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199925Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768484}
-
Regan Hsu authored
Currently, hitting ctrl+F does not focus the new settings search input. This CL adds that functionality and resolves the assertion error. Fixed: 1079039 Change-Id: I6a8e518277b65ad675aacd98dbe828508993d9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199920Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768483}
-
David Bokan authored
The compositor does some basic hit testing on mouse moves in order to animate overlay scrollbars when the cursor is near the thumb. The way it does this is by hit testing a LayerImpl and then using FindScrollNodeForDeviceViewportPoint to find the associated scroller. However, FindScrollNodeForDeviceViewportPoint isn't well suited to this purpose. It's primarily used to target scrollers during a ScrollBegin and it accounts for whether or not a ScrollNode can be scrolled on the compositor. Scrollbar animations shouldn't be accounting for this. It also has some complex fallback behavior that is also likely wrong for scrollbars. Instead, we replace its use with a much simpler and self-contained HitTestScrollNode. This method simply returns a hit layer's ScrollNode, encapsulating the hit scrollbar case and correctly accounting for failed hit tests due to layer squashing. This is a small preparation for scroll unification as this method will be used for scroll targeting in that case. This change revealed a bug in the scrollbar animating code. Because FindScrollNodeForDeviceViewportPoint falls back to returning the viewport node if no layer is hit, hit tests outside the viewport would return the viewport scroll node. This is questionable for scroll targeting but definitely wrong for scrollbar animations. When the change was made, the ScrollBeforeMouseMove test started failing because it sets up a scrollbar outside the viewport and sends mouse moves to negative viewport coordinates. FindScrollNodeForDeviceViewportPoint is renamed to FindScrollNodeForCompositedScrolling to better reflect its behavior. Bug: 1047182 Change-Id: Idb20285872c0da0ef33a404cffca4fbe8347ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198598 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768482}
-
danakj authored
This moves the majority of TestRunnerForSpecificView methods over to TestRunnerBindings. Any methods that acted on the main frame or the focused frame are moved to act on the current frame instead to make them OOPIF compatible. R=nasko@chromium.org Bug: 866140, 1069111 Change-Id: I9af3666e6b56e27ca7cba7f37b9ce8594c9a3c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176102Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#768481}
-
Natalie Chouinard authored
Address lint issue by moving XML resource to the correct directory. Fixed: 1081236 Change-Id: I14a9cae34ee064e70bfe134afcac5e92842ef11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196833Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#768480}
-
Tom Anderson authored
libxcb has a separate length field for lists because it uses C-style arrays to implement lists. We use std::vector which has a length field built-in, so we can derive the length from that to send over the wire. However, the length field can actually be a general expression in xcbproto (eg. the sum of two other fields). In cases like these where it's tricky or impossible to derive fields from the length (eg. x + y = length has many solutions for x and y), the fields are left in the user-visible structures. BUG=1066670 R=sky Change-Id: I0db56e0b6582eddf903e7b8d8943533b2d7901f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189702 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Daniel Murphy authored
This CL adds a new method to AppRegistrarObserver, allowing clients to listen to when apps become locally installed (or not). This allows the app service to listen to this effect, and fire an app update appropriately with the new icon data. R=dominickn@chromium.org, loyso@chromium.org Bug: 1080370 Change-Id: Id138bbbc2035d046e6d11e342fe33b501652dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194335 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#768478}
-
Vincent Boisselle authored
Change-Id: I682665b6f914b786345b928b788bc5a9a39524a3 Bug: 1082457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199021Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#768477}
-
John Williams authored
This CL only makes it possible to start a presentation; more work is needed to make it possible to send message to the receiver. Bug: 1069126 Change-Id: Iffe72e3c142dd460817f08cc30f52a2651cfb181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180743 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768476}
-
Thomas Tellier authored
Bug: 1032507 Change-Id: Ia6edc78067edd96c8a3b5db3913bf89f6bdd1af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057263 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768475}
-
Christian Biesinger authored
For the default min-height/width, aspect-ratio should only be the minimum size, and the resulting inline size should grow to fit all the content: https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum This is the inline version of https://crrev.com/c/2186076 Bug: 1045668 Change-Id: I55eb523ef53df09a64f55ea2883abeb75e1d778c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197341 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#768474}
-
Ian Kilpatrick authored
There was a subtle bug with the measure layout result. We could get into a state previously where the "measure" layout result, was invalid (pointing to a previous layout). We'd then hit the cache using the "measure" slot, causing a UAF. This patch fixes this issue in two different ways: 1) Clears the measure slot when we are setting a layout result, and we needed layout. 2) Within ComputeMinMaxSizes use the "measure" cache-slot. An additional subtle issue was uncovered while investigating this, where it was possible to hit an incorrect layout result. Now the "measure" cache-slot should only be used, if it is guaranteed that a subsequent layout will occur for that node. Bug: 1081086 Change-Id: I08267eadedc7599075e4b6867d341223999ad9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198716Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#768473}
-
Avi Drissman authored
Google Chrome Mac Beta and Dev are getting icons. As part of that refresh, all Chrome/Chromium family icons are updated to match. Note that this new icon is slightly smaller than the old icon. This is intentional, as it now matches the size of the round macOS system app icons. The assets were obtained from UX, and compiled into icns files as per https://chromium.googlesource.com/chromium/src/+/master/docs/mac/icons.md. Bug: 846451 Change-Id: I29c4a6bf21339f6bac78f539143723496bcae6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198643 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#768472}
-
Mehran Mahmoudi authored
This addresses a problem where views shown by TabViewManager don't respect the toolbar height and and partially clipped by it. Bug: 1073948,1081628 Change-Id: I6d499a67c1378e8c18c1f4bc7849d9622cabbf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188212 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#768471}
-
Brandon Wylie authored
Shows the darkened search screen when the user's device is in night mode. design doc: go/clank-dark-search Bug: 1079074 Change-Id: I56632a6e579db488c2be2e9c5e7eeee47eb62989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186128Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#768470}
-
danakj authored
The size is set up for each test to have a different window size, which is not used. Remove it and use a constant. The browser also sends the size to the main frame widget in between each test through a visual properties sync. We don't need the renderer to do a synchronous resize between tests or when a new window is created. However on mac, the renderer lying about the size was required for it to "hear" about the window screen rect. The browser in headless mode does not resize an actual OS window, which means the browser doesn't end up hearing about the window's size or position. That results in the RenderWidgetHost telling the renderer the window screen rect is an empty rect. We fix this by subclassing the ShellPlatformDelegate for web tests (as the WebTestShellPlatformDelegate) and overriding the ResizeWebContent() method in headless web tests to tell the RenderWidgetHostViewMac directly, skipping past the OS notification cycle. This requires access to //content/browser which is why we must split it off into the web_test/ directory. While doing so, we move all headless code in ShellPlatformDelegate for mac over to the web test directory. We'd like to do this for all platforms and then the production code wouldn't need to know about headless, which is a web test feature. R=avi@chromium.org TBR=dcheng Bug: 866140 Change-Id: Ic18fb978c9f672ab124f631247cd549d663f20ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180920 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768469}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1041468 Change-Id: I5244a6eed73b9cbeb6336ef43d8550d4961dcc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172619 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#768468}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a5750efe1eed..fcfe7fad6f80 git log a5750efe1eed..fcfe7fad6f80 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 cnorthrop@google.com Capture/Replay: Fix MEC crash with Temple Run Created with: gclient setdep -r src/third_party/angle@fcfe7fad6f80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@chromium.org Change-Id: I25c404a73c7f7b8e2f721c412f7914147475aef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198954Reviewed-by:
-
Erik Staab authored
Bug: 1072810 Change-Id: I3d16c5f102ce5bafddde068b4635ea039096655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195200 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768466}
-
Mason Freed authored
These three tests fail when Web Components v0 features are removed. The WCv0 features are already adequately tested via layout tests, so these three should be ok to be removed. The WCv0 features are scheduled to be removed completely in M88. Bug: 937746 Change-Id: I000e1343a0b56f6b8442af0b9bb1e81786c0cf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199412Reviewed-by:
-
Michael Ershov authored
When inconsistent data error occurs, use the most recent certificate profile from preferences to retry. Bug: 1045895 Change-Id: I743cd6f8a956fdb39b66eaa8e5e3d80478fc68f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199109Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#768464}
-
Anastasia Helfinstein authored
Cleans up the Navigation Manager tests a bit in preparation for an upcoming refactor of the code. AX-Relnotes: n/a. Bug: None Change-Id: Ia564c9ed7444232426cb1c5d46ce10ac06809ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197861Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#768463}
-
Xing Liu authored
Query tiles code currently lives in components/query_tiles. This CL changes the namespace from upboarding to query_tiles. Bug: 1082052 Change-Id: Ia47e39e5c154c81c3e0510ce9ea18e9ab44008d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197959 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768462}
-
Pavol Marko authored
These strings will be used in the UI (under chrome://settings/certificatges) for the Chrome OS built-in certificate provisioning feature. For reference, screenshots of the UI are in https://crbug.com/1081396 . Individual screenshots with each string marked have been uploaded. Bug: 1045895, 1081396 Change-Id: Ie1fc79ac2b01f1f8ebd545f23e388494685fde4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199836 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#768461}
-
Alexander Timin authored
Convert the final user to DidStartNavigation and delete deprecated method. R=clamy@chromium.org TBR=ellyjones@chromium.org Change-Id: Ia69bb35233dbccf84a82acf36cb3efb53e501193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162736Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768460}
-
Lei Zhang authored
Add an off by default base::Feature for controlling how much rasterization to do when printing in EMF mode on Windows. This will reduce print job sizes in some cases. Since the feature caused printing regressions in the past, having a base::Feature toggle will allow the feature to be rolled out in a controlled manner. This CL includes: - Plumbing for the browser to tell the PdfToEmfConverter service to use the new printing modes. - New Printing.ConversionSize metrics to see how the new printing modes perform size-wise. Along the way, all Printing.ConversionSize metrics have been updated with secondary owners and actual expiration dates. - A very basic sanity test. Bug: 674771 Change-Id: I7ccd8d4c9320eb1c42f3c3040814ed41027f36bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194797 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#768459}
-
Rakib Hasan authored
This reverts commit fb714e98. Reason for revert: This change is breaking the wpt importer. Original change's description: > blinkpy: Create WPTExpectationsUpdater subclass that handles Android > > This CL will create a WPTExpectationsUpdater subclass that takes > JSON results from Android WPT bots and update browser specific > expectations files. > > Bug: 1050760, 1050754 > Change-Id: Iddff952a54923547eb7a6f32249ea2da113f7dac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147689 > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Reviewed-by: Luke Z <lpz@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#767998} TBR=lpz@chromium.org,robertma@chromium.org,rmhasan@google.com Change-Id: I03db9d214fc3de5485528ccccbd50dba1df03cbe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050760, 1050754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198718Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#768458}
-
Carlos IL authored
Adds a new PasswordManager.FillingAssistance.MixedForm histogram that gets logged when a form is mixed content (is on an HTTPS site, but has an HTTP target). Bug: 1081869 Change-Id: I37ab96d9bd51ef7b004d4132b6e8bd33624f1c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197262 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#768457}
-
Yusuke Sato authored
BUG=b:155128030 TEST=components_unittests Change-Id: I0198ad6009f17a0976047bc8c442c6fa5f2aeace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199858Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#768456}
-
Peter Wen authored
Lint no longer runs per-library so we need an apk to ensure these interface boundaries remain at minSdkVersion 14. Switch @TargetApi to @RequiresApi for lint. Add this apk to android_compile_dbg so that it is verified by the CQ. Bug: 1017190,1082319 Fixes: 1082319 Change-Id: I94064c781bd39b046fbfe9a1f03eb38292eeb24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199579 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
