GitLab

Revert of [webcrypto] Give more descriptive error messages on Linux for unsupported functionality. (https://codereview.chromium.org/343473004/)

Reason for revert:
This broke SharedCryptoTest:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/61059

Original issue's description:
> [webcrypto] Give more descriptive error messages on Linux for unsupported functionality.
> 
>  * If NSS version doesn't support AES-GCM
>  * If NSS version doesn't support RSA-OAEP
> 
> BUG=384485
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278230

TBR=rsleevi@chromium.org,eroman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384485

Review URL: https://codereview.chromium.org/348493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278258 0039d316-1c4b-4281-b951-d872f2087c98

This is the second of a three-sided change to remove
LegacyFrameProcessor from Blink and Chromium now that the new
FrameProcessor is stabilized.

R=acolwell@chromium.org
BUG=249422
TEST=No media_unittest or MSE layout test regression locally on Linux

Review URL: https://codereview.chromium.org/315483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278255 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a bug where auto-updating Chrome can cause the Address Book
permissions dialog to appear, even though the user has already granted/denied
Chrome access to the user's Address Book.

When the Chrome binary is updated, chrome_autofill_client now passes the
information to personal_data_manager, which will refrain from accessing the
address book, if doing so would cause a blocking dialog to appear.

BUG=381763

Review URL: https://codereview.chromium.org/334653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278254 0039d316-1c4b-4281-b951-d872f2087c98

The code was correctly deleting the main safe-browsing store in this
case, but left the associated filter file stranded.

BUG=none
R=tburkard@chromium.org

Review URL: https://codereview.chromium.org/341553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278253 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/343713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278252 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278246 0039d316-1c4b-4281-b951-d872f2087c98

When you moved the native viewport, the contents would move to an incorrect position due to an issue with non-client/client adjustment in native_viewport_win.

Also make the browser app open immediately on startup of the window manager, for convenience.

** Not tested as part of the main chrome integration test suite **

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/347433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278244 0039d316-1c4b-4281-b951-d872f2087c98

Adds URLResponse & body stream fields to NavigationDetails struct.

** not tested as part of the main chrome integration test suite **

R=aa@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/331323007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278243 0039d316-1c4b-4281-b951-d872f2087c98

This is a cleanup CL after https://codereview.chromium.org/335893002. Some method's signatures have changed, new unit tests for PasswordStoreX were added.

BUG=

Review URL: https://codereview.chromium.org/347583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278242 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/341973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278241 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the newly added test would crash because the ServiceRegistry asserted it had a ServiceConnector for anything allowed through by AllowIncomingConnection.  Nothing actually prevents this from happening, so this patch makes sure it is handled gracefully by placing the InterfacePtr into an error state.

BUG=None

Review URL: https://codereview.chromium.org/343473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278240 0039d316-1c4b-4281-b951-d872f2087c98

For backwards compatibility in the Android WebView, it should be
possible to pause the shared timer before the WebView has been
navigated, the net effect being the initial navigation takes place
with the timer suspended.

This was introduced by http://src.chromium.org/viewvc/chrome?view=revision&revision=256153

BUG= 321610

Review URL: https://codereview.chromium.org/341583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278239 0039d316-1c4b-4281-b951-d872f2087c98

You can set --force-fieldtrials="DirectWrite/Disabled/" to turn DirectWrite off.

R=cpu@chromium.org, jamesr@chromium.org, asvitkine@chromium.org
BUG=385778

Review URL: https://codereview.chromium.org/335223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278238 0039d316-1c4b-4281-b951-d872f2087c98

The RGB pixel components are flipped in the software decoder
implementation.

Also add latency calculation to example plugin.
Flip picture vertically (it was upside down).

BUG=281689

Review URL: https://codereview.chromium.org/346543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278237 0039d316-1c4b-4281-b951-d872f2087c98

This adds a function to PPB_View which allows plugins to know the scroll offset
of the page when they are in view. This is useful for OOP PDF which uses the
scroll offset of the window it is contained in to determine the document's
scroll location. A web page can send scroll location via postMessage but
this is slow. Sending the offset directly via view messages is much faster
and seems reasonable.

We don't send the scroll offset in the cases where the plugin is off screen
to avoid any more additional IPC traffic than what currently exists.

BUG=303491

Review URL: https://codereview.chromium.org/329033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278236 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up CL of r276344.

Currently, when audio and video decoders receive an EOS buffer, they do the following in order:
1, Flush the codec, return all internally buffered frames through the OutputCB.
2, Return a EOS frame through the OutputCB.
3, Return the DecodeCB.

Since the DecoderStream knows when an input buffer is an EOS, when the DecodeCB is returned, DecoderStream knows that decoding has finished. Therefore, step (2) is redundant.

This CL drops step (2) which simplifies a lot of code.

BUG=385872

Review URL: https://codereview.chromium.org/339653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278232 0039d316-1c4b-4281-b951-d872f2087c98

Added option to bookmarkManagerPrivate.getMetaInfo() to get meta info from all bookmarks in a one function call.
Needed to improve stars extension performance.

BUG=383600

Review URL: https://codereview.chromium.org/330983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278231 0039d316-1c4b-4281-b951-d872f2087c98

 * If NSS version doesn't support AES-GCM
 * If NSS version doesn't support RSA-OAEP

BUG=384485

Review URL: https://codereview.chromium.org/343473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278230 0039d316-1c4b-4281-b951-d872f2087c98

Since we don't keep track of the current entry when showing the dialog,
it should be dismissed on a navigation to avoid reading the wrong data.

BUG=384176

Review URL: https://codereview.chromium.org/335293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278229 0039d316-1c4b-4281-b951-d872f2087c98

Use the built-in bubble title and close button views.
Use the bubble's title insets for the other views.
Use BookmarkSyncPromoView colors for the UMA promo.
Use views layout constants for the spacing values.
Use default label/checkbox/bubble colors, not hard-coded.
(black/off-white + supports inversion for accessibility)
Fix the UMA promo separator line (wasn't fully extended).

Inline some BrowserRemovalObserver function implementations.
Other misc. code cleanup. See before/after pics on the bug.

BUG=384123
TEST=Session crashes bubble looks good, works well.
R=yiyaoliu@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/331353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278228 0039d316-1c4b-4281-b951-d872f2087c98

This CL was originally uploaded at
https://codereview.chromium.org/269513002 but was reverted due to a high
number of crash reports on Windows. The issue was that RTree::Insert()
would remove duplicate nodes before re-inserting them, but didn't handle
the corner case where the root node would end up as a non-leaf node with
only one child. RTree::Remove() did the right thing in this case, which
is to remove the root and replace it with its solitary child, but
RTree::Insert() did not. This lead to a situation with invalid trees
being created that would ultimately lead to a crash on a subsequent
call to RTree::Insert(). A short unit test that reproduced the crash
is included.

BUG=384736

Review URL: https://codereview.chromium.org/342723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879
TBR=noamsml

Review URL: https://codereview.chromium.org/345453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278226 0039d316-1c4b-4281-b951-d872f2087c98

This change propagates GCM connection state from GCMInvalidationBridge
to SyncNetworkChannel where based on this notification overall
invalidations state is updated.

This change still has issue that when GCM connection is down but HTTP request
succeeds then status is updated to NOTIFICATIONS_ENABLED. Fixing this
requires minor refactoring which I would like to pull into separate change.

BUG=378536
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/334253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278225 0039d316-1c4b-4281-b951-d872f2087c98

The aync CommitLayers() call will never be completed, if no layers changed since the last call to CommitLayers(). So we have to force a commit for each CommitLayers() call.

BUG=374383
R=bbudge@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/345443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278224 0039d316-1c4b-4281-b951-d872f2087c98

Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation.
Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test.
Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag.

BUG=357693
TBR=phajdan.jr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277605

Review URL: https://codereview.chromium.org/309843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278223 0039d316-1c4b-4281-b951-d872f2087c98

Move SkFontMgr::Factory to skia/ext so that we can use the warmed-up
sandbox version when using DirectWrite that's created by content/. This
avoids the previous default behaviour of creating a GDI SkFontMgr which
is always wrong when DirectWrite is being used (and causes crashes
when --enable_win32k_renderer_lockdown is enabled).

R=jamesr@chromium.org,bungeman@google.com
BUG=385926,356950,385717
TEST=http://www.effectgames.com/demos/canvascycle/ http://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_canvas_filltext and enabling FPS in about:flags with both --enable_win32k_renderer_lockdown and --disable-direct-write

Review URL: https://codereview.chromium.org/344653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278222 0039d316-1c4b-4281-b951-d872f2087c98

Also removes obsolete test cases which tested the behavior  before tooltips were toplevel windows on Linux

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/333333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326577

Review URL: https://codereview.chromium.org/340773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278220 0039d316-1c4b-4281-b951-d872f2087c98

Also, when we cleanup tilings on the active twin, we use the pending
twin's ideal contents scale. But when the twin !CanHavTilings() there
is no need to use that ideal scale and save tilings.

R=enne@chromium.org, enne

Review URL: https://codereview.chromium.org/334953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278219 0039d316-1c4b-4281-b951-d872f2087c98

webapp_build.py wasn't updated properly in r278198. As result main.html
wasn't properly package in the webapp.

TBR=wez@chromium.org
BUG=134215

Review URL: https://codereview.chromium.org/344753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383907

Review URL: https://codereview.chromium.org/332943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278217 0039d316-1c4b-4281-b951-d872f2087c98

An oversight, the histograms should have the UMA_ prefix.

BUG=385159

Review URL: https://codereview.chromium.org/343643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278215 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds implementation for GinJavaBoundObject class, which
is responsible for interacting with injected Java objects, and a helper
trivial class GinJavaBoundObjectDelegate which is used with GinJavaMethodInvocationHelper

Java interaction code is mostly taken from the existing implementation.
The main difference that the new implementation has, is that the relationship
between Java objects and JavaScript interface objects is now managed
by us, not by NPAPI.

This patch also contains the following fixes to the existing code
discovered after re-running tests:

 -- ART doesn't like when static Java methods are invoked using JNI calls
    for instance methods, so switched to use the right JNI calls;

 -- accessing 'window' object when adding JavaScript interface objects
    may cause DidClearWindowObject to be called, so guard against double
    entrance.

BUG=355644

Review URL: https://codereview.chromium.org/323403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278214 0039d316-1c4b-4281-b951-d872f2087c98

This is simple cleanup in preparation for a Label rewrite.
These overrides were supplying an extra gfx::Canvas flag.
Instead, add an explicit label flag for NO_SUBPIXEL_RENDERING.
Update some callers and the unit test.

TODO(followup): Update more Label::SetBackgroundColor callers.

BUG=240037
TEST=No exit warning or sticky keys label rendering changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/341713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278213 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of https://codereview.chromium.org/340523006/

BUG=384514
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/341623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278212 0039d316-1c4b-4281-b951-d872f2087c98

On startup and on network changes, a request is made to the data reduction proxy to warm the connection. This reduces the page load time for first loads.

BUG=354438

Review URL: https://codereview.chromium.org/338723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/341603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278209 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/212303003,
update_screen.cc doesn't need the command line switch related
headers anymore. So we can remove these.

BUG=349033

Review URL: https://codereview.chromium.org/334403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322395

Change-Id: Ie0376052892349f18db5d60737f6329b8c92eb1c

Review URL: https://codereview.chromium.org/333003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278206 0039d316-1c4b-4281-b951-d872f2087c98