- 05 Sep, 2014 40 commits
-
-
hjd authored
This change completes the removal of package_name from build/java_apk.gyp and removes it from all the places which still refer to it. 'package_name' used to be how you specified the intermediate directory when building an APK. Now we use the target name and includers no longer need to set the intermediate directory explicitly. However one use in java_apk for setting additional resources files seems to have crept through the refactoring. BUG=405963 Review URL: https://codereview.chromium.org/487223003 Cr-Commit-Position: refs/heads/master@{#293498}
-
mlerman authored
When the last profile is deleted, a new one is created automatically. BUG=410008 Review URL: https://codereview.chromium.org/532963004 Cr-Commit-Position: refs/heads/master@{#293497}
-
henrika authored
My idea was that the histogram could show if we do a very large number of short calls and how the length of the streams are related to the length of AudioTracks. If so, we might have issues in WebRTC clients or in how we create/destroy the input streams. BUG=405449 TEST=Manual testing using WebRTC clients. Review URL: https://codereview.chromium.org/537573002 Cr-Commit-Position: refs/heads/master@{#293496}
-
torne authored
Move the include of the Mac TargetConditionals.h file to after we've checked if we're building for Android. Apparently this file doesn't exist on all macs used to build android and the rest of android builds fine without it, so including it there causes the build to fail. It appears to only be used to test TARGET_OS_IPHONE which will never be true on android. BUG= Review URL: https://codereview.chromium.org/538563002 Cr-Commit-Position: refs/heads/master@{#293495}
-
hirono authored
The method will be called from FileSystemURLRequestJob class to redirect requests for the drive hosted documents. BUG=367027 TEST=manually; Add the method call to FileSystemURLRequestJob and open FileSystemURL in browser tab. Review URL: https://codereview.chromium.org/527773003 Cr-Commit-Position: refs/heads/master@{#293494}
-
vasilii authored
Move content_settings_pattern and content_settings_pattern_parser to the content_settings component. BUG=387079 TBR=nasko@chromium.org Review URL: https://codereview.chromium.org/518803009 Cr-Commit-Position: refs/heads/master@{#293493}
-
vasilii authored
BUG=404012,410798 Review URL: https://codereview.chromium.org/545433003 Cr-Commit-Position: refs/heads/master@{#293492}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/26abcf10a4994a0bb13a074d79baa85cd8d67b2c..7675fb23a0448448662567bf1d100e39bf7b5e65 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/542093002 Cr-Commit-Position: refs/heads/master@{#293491}
-
horo authored
If the request is a force refresh (shift+refresh) the request should not be handled by the ServiceWorker. https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-controller Currently we are checking LOAD_BYPASS_CACHE flag of net::URLRequest in ServiceWorkerControlleeRequestHandler::MaybeCreateJob(). But this flag is set not only when shift+refresh but also when devtool's "Disable cache" is checked. To distinguish them, I added skipServiceWorker flag to blink::WebURLRequest and blink::ResourceRequest in https://codereview.chromium.org/527703002/. This cl changes the follwings - Introduce skip_service_worker flag to content::RequestExtraData and ResourceHostMsg_Request. - Remove the check of LOAD_BYPASS_CACHE in ServiceWorkerControlleeRequestHandler::MaybeCreateJob(). - Check skip_service_worker flag in ServiceWorkerRequestHandler::InitializeHandler() and call provider_host->SetDocumentUrl() when the request is main resource request. TEST=none BUG=402093 Review URL: https://codereview.chromium.org/527713002 Cr-Commit-Position: refs/heads/master@{#293490}
-
vasilii authored
They are |display_name|, |avatar_url| and |federation_url|. BUG=400674 TBR=isherman@chromium.org Review URL: https://codereview.chromium.org/520583003 Cr-Commit-Position: refs/heads/master@{#293489}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/9a051c526402aedfa6bc73e6699838c777b679cf..e76e0d3c27477b816754225fcdbcae5c79f6940f TBR=arv@chromium.org,keishi@chromium.org Review URL: https://codereview.chromium.org/547573002 Cr-Commit-Position: refs/heads/master@{#293488}
-
joleksy authored
Event::flags() contains all the buttons that are being held down during the event, while MouseEvent::changed_button_flags() contains the buttons that are actually pressed/released during the event (and this is what we really are interested in). This fixes the issue with LMB being pressed while RMB is being held down. Without the fix, we always get blink::WebMouseEvent::ButtonRight in blink::WebMouseEvent::button. Review URL: https://codereview.chromium.org/302593002 Cr-Commit-Position: refs/heads/master@{#293487}
-
ygorshenin authored
Instantiation of OwnerKeyUtil is delegated to OwnerSettingsServiceFactory, as we're going to move as much as possible from OwnerSettingsService to components/ownership/* and because OwnerSettingsServiceFactory should do all platform-specific business. BUG=398856 TEST=existing browser_tests and unit_tests Review URL: https://codereview.chromium.org/516243002 Cr-Commit-Position: refs/heads/master@{#293486}
-
qsr authored
R=ppi@chromium.org Review URL: https://codereview.chromium.org/526303003 Cr-Commit-Position: refs/heads/master@{#293485}
-
carlosk authored
Allows navigation requests to be canceled before they are committed when they become stale. BUG=397998 Review URL: https://codereview.chromium.org/475783002 Cr-Commit-Position: refs/heads/master@{#293484}
-
treib authored
BUG=410824 Review URL: https://codereview.chromium.org/537993002 Cr-Commit-Position: refs/heads/master@{#293483}
-
michaeln authored
BUG=408431 Review URL: https://codereview.chromium.org/537123002 Cr-Commit-Position: refs/heads/master@{#293482}
-
thestig authored
Autocomplete: Fix a typo that flipped the extension keyword provider check for enabling in incognito mode. This is deliberately kept small for easy merging. BUG=409705 Review URL: https://codereview.chromium.org/537283002 Cr-Commit-Position: refs/heads/master@{#293481}
-
merkulova authored
BUG=402800 Review URL: https://codereview.chromium.org/519643002 Cr-Commit-Position: refs/heads/master@{#293480}
-
thestig authored
Change base/file_utils.h includes to base/files/file_utils.h in gin, google_apis, printing, sql, ui, and webkit. TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/529273002 Cr-Commit-Position: refs/heads/master@{#293479}
-
merkulova authored
BUG=399186 Review URL: https://codereview.chromium.org/491263002 Cr-Commit-Position: refs/heads/master@{#293478}
-
fukino authored
BUG=409490 TEST=manually Review URL: https://codereview.chromium.org/528263002 Cr-Commit-Position: refs/heads/master@{#293477}
-
skyostil authored
This patch conveys more information about frame timings to Blink. Specifically it adds the current deadline by which work should be finished as well as the expected interval between frames. The Blink scheduler will use this information to schedule lower priority work. We also notify Blink when a committed frame actually got composited, which means the current frame is done and lower priority work can be started immediately (i.e., before the scheduled deadline). BUG=391005 Review URL: https://codereview.chromium.org/521613002 Cr-Commit-Position: refs/heads/master@{#293476}
-
qsr authored
The embedder was initialized in the constructor of CoreImpl. This is not correct, because when it will be used in Chromium, the embedder is initialized by the native code. This remove the initialization from CoreImpl. Instead, for tests, initialize it when loading the native library. R=ppi@chromium.org Review URL: https://codereview.chromium.org/544603002 Cr-Commit-Position: refs/heads/master@{#293475}
-
tzik authored
* Don't count demoted dirty tracker as pending. * Notify observer of service state update when the initialization is completed. BUG=410675 Review URL: https://codereview.chromium.org/537883002 Cr-Commit-Position: refs/heads/master@{#293474}
-
reat authored
properly with invalid server's originator_cache_guid and originator_client_item_id. It checks UpdateBookmarkPositioning works fine. BUG= R=rlarocque@chromium.org Review URL: https://codereview.chromium.org/533113002 Cr-Commit-Position: refs/heads/master@{#293473}
-
iseki authored
The progress bar of sync status in Desktop Notification is not updated due to issue 400636. BUG=408931 TEST=manually 1. Copy local file to Drive 2. Start sync 3. Close Files.app 4. Observe the Notification Review URL: https://codereview.chromium.org/543973003 Cr-Commit-Position: refs/heads/master@{#293472}
-
hidehiko authored
Condition variables should be signaled inside the critical section. cf) http://www.chromium.org/developers/lock-and-condition-variable#inside BUG=None TEST=Ran trybots. Review URL: https://codereview.chromium.org/533823003 Cr-Commit-Position: refs/heads/master@{#293471}
-
noamsml authored
Remove noamsml@ from all OWNERS files. NOTRY=true Review URL: https://codereview.chromium.org/541943002 Cr-Commit-Position: refs/heads/master@{#293470}
-
aa authored
BUG= Review URL: https://codereview.chromium.org/537843002 Cr-Commit-Position: refs/heads/master@{#293469}
-
eakuefner authored
We have a plan in progress to upgrade the 'important' field to a combination of two fields 'primary' and 'improvement_direction'. This will be a two-sided patch that will require reworking the dashboard's handling of chart JSON. Since the dashboard has been modified to accept chart JSON with 'important' values, we want to update Telemetry to continue serializing values with this field for now. R=nednguyen Review URL: https://codereview.chromium.org/541253002 Cr-Commit-Position: refs/heads/master@{#293468}
-
ncbray authored
BUG=none Review URL: https://codereview.chromium.org/538263003 Cr-Commit-Position: refs/heads/master@{#293467}
-
isherman authored
BUG=none TEST=none R=asvitkine@chromium.org, jwd@chromium.org Review URL: https://codereview.chromium.org/541933002 Cr-Commit-Position: refs/heads/master@{#293466}
-
dtu authored
The DLL must match the executable, and the kernel driver must match the OS. Confusing, I know! BUG=336558 TEST=python tools/telemetry/run_tests msr # On a machine with 32-bit Python and 64-bit Windows, in a shell with Administrator privileges. R=tonyg Review URL: https://codereview.chromium.org/539303002 Cr-Commit-Position: refs/heads/master@{#293465}
-
rockot authored
This reverts HidService to being a singleton instance for now. BUG=401234 TBR=rpaquay Review URL: https://codereview.chromium.org/523743005 Cr-Commit-Position: refs/heads/master@{#293464}
-
alekseys authored
BUG=397741 Review URL: https://codereview.chromium.org/540183002 Cr-Commit-Position: refs/heads/master@{#293463}
-
mseaborn authored
This makes it easier for automated tools such as nacl_deps_bump.py to update the field. It also makes it easier to search the history for changes to the field. The field was removed by fd5ba194, which switched DEPS from SVN revisions to Git revisions. BUG=263848 TEST=trybots Committing with NOTRY=true due to race with updates to adjacent webkit_revision. Review URL: https://codereview.chromium.org/546453003 Cr-Commit-Position: refs/heads/master@{#293462}
-
brettw authored
TBR=jam@chromium.org Review URL: https://codereview.chromium.org/538863003 Cr-Commit-Position: refs/heads/master@{#293461}
-
perkj authored
Before this cl, VideoTrackAdapter.FramesReceived was logged for all types of MediaStreamVideoSources including remote video sources and pepper api sources. The indent of this UMA stat is to track if a video capture device output video frames or not. BUG= 409624 Review URL: https://codereview.chromium.org/529733002 Cr-Commit-Position: refs/heads/master@{#293460}
-
Daniel Cheng authored
The implicit conversion operator is being removed, because of the surprises it can cause. For example, one might write: scoped_refptr<Foo> CreateFoo(); to ensure that callers hold the result in a scoped_refptr. But the implicit conversion to T* means that a caller can accidentally hold the result in a Foo* and the compiler won't catch it. Since there are a large number of dependencies on this implicit conversion, the cleanup is being conducted by a combination of automated tooling and manual cleanup. It is also being staged on a platform by platform basis. All known dependencies on the implicit conversion on Linux (but not ChromeOS) have been removed, so this patch disables the conversion operator on Linux builds to prevent new dependencies on the implicit conversion. Finally, to help facilitate this transition, temporary operator overloads for comparison have been added. These will eventually be removed. BUG=110610 R=jyasskin@chromium.org, rsleevi@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/510323002 Cr-Commit-Position: refs/heads/master@{#293459}
-