GitLab

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/web_applications.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=dominickn@chromium.org

Bug: 874080
Change-Id: I82b1024084057eebf5425a8e42c5ee6b677f6b46
Reviewed-on: https://chromium-review.googlesource.com/1191788
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587684}

Original CL intention was:
This CL uses ScopedBlockingCall to mark blocking calls in /extensions/browser/api/system_storage.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=ningxin.hu@intel.com

Bug: 874080
Change-Id: Ia8cf19506aa212d07e8dad54a07940f6e878799c
Reviewed-on: https://chromium-review.googlesource.com/1191195
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587683}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/browser/snapshots.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=justincohen@chromium.org

Bug: 874080
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5df9b85d1914370ea2ada752c18bc5861f1591fc
Reviewed-on: https://chromium-review.googlesource.com/1191408Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587682}

This is needed to ensure that callbacks installed on
translate.js can be registered before element.js executes.

Change-Id: Idefe034e77879169b57185bcad88066d1917de82
Bug: 877706
Reviewed-on: https://chromium-review.googlesource.com/1189060
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587681}

This CL add the scroll snap data to ScrollNode for BGPT.

I manually tested scroll snap.

TEST=fast/scroll-snap/snap-scrolls-visual-viewport.html still flaky.

Bug: 877106
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4199e4a7474c08e1b27b5d54528b1b371164fd62
Reviewed-on: https://chromium-review.googlesource.com/1195106Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587680}

This is a reland of 025bf217

Original change's description:
> Remove Windows debug bots from consoles
> 
> They've been a bit flaky, and I don't want to bother sheriffs with them
> yet.
> 
> Bug: 878915
> Change-Id: Ia37db9742e3bf7e58a2efba8ab4032f7b121620e
> Reviewed-on: https://chromium-review.googlesource.com/1195926
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587409}

Bug: 878915
Change-Id: I65ea5aa215a235cdfc2b93c4804f69a93a953e95
Reviewed-on: https://chromium-review.googlesource.com/1196919Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587679}

Report the number of tabs/windows at regular interval, this'll be useful
to help measure if a given change affects how users use tabs.

Change-Id: Ic08861825c064afa736ecaeac98cc9855890f109
Reviewed-on: https://chromium-review.googlesource.com/1194871
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587678}

Fix lint errors as well.

BUG=537099

Change-Id: Ie36f7530d574229495f24119e74f15e0a1fb2d71
Reviewed-on: https://chromium-review.googlesource.com/1188640
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587677}

Move the media session and audio focus related switches to
the media session service.

BUG=875004

Change-Id: I54dad1eb47ac6288895ea3cac3824b181080f3e3
Reviewed-on: https://chromium-review.googlesource.com/1188747Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587676}

These tests are timing out periodically. Match the removal of
browser_tests, since the behavior is expected to be the same.

Bug: 876224
Change-Id: I76183e78fde8f10a1feae67db51ca4336a4c652e
Reviewed-on: https://chromium-review.googlesource.com/1197322Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587675}

This CL updates blink and chromium to support persistent-usage-record
session, which is behind a flag.

To enable the support, use the following command line flag:

--enable-blink-features=EncryptedMediaPersistentUsageRecordSession

ExternalClearKey key system is also updated to declare support
for this session type, even though in the implementation it doesn't do
anything special.

No other CDMs support this session type yet, which will be done later.

TBR=foolip@chromium.org

Bug: 856925
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: Iff38bc79f43e375144f045564e045a830d86699a
Reviewed-on: https://chromium-review.googlesource.com/1119565
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587674}

This way, callers that have a base::StringPiece[16] can avoid copying
the data into an {std::string, base::String16} just to call
GURL::Resolve().

Change-Id: I0c7d73ac55d102bc0bc39afe36efccc33e938e14
Reviewed-on: https://chromium-review.googlesource.com/1195740Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587673}

We are adjusting these based on user feedback.  Many users found that
10 minutes was not enough time to complete common tasks which requried
assistance.  Based on usage data, 30 minutes should be enough for
the majority of sessions.  Also increasing the timeout for the
continue window to give the person being helped more time to find and
click the continue button.

Change-Id: I9a55568363e2bf79d6a82523c1a520364fbd3507
Reviewed-on: https://chromium-review.googlesource.com/1183539
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587672}

r372827 allowed chrome/browser/ to include components/, at the top
level, so there are now many rules inside chrome/browser/ that are
redundant.

Change-Id: I73a7c2c191f4511e64dc14ed4f4ecaa0f2790fcc
Reviewed-on: https://chromium-review.googlesource.com/1195737Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587671}

This CL uses ScopedBlockingCall to mark blocking calls in /chromeos/printing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 874080
Change-Id: Ic3048f1874bd6d575a061c5f9f773df4850d6d32
Reviewed-on: https://chromium-review.googlesource.com/1191099Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587670}

Bug: 868068
Change-Id: I339a79b5709425b2e7d0d4d50f0bfa0602afc7ab
Reviewed-on: https://chromium-review.googlesource.com/1170171Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587669}

Migrate dupplicate experiments which exists in both
autofill_experiments.* and autofill_features.* to
become features.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I322b2aaf66433c0f5b3e8d84e975c403ce6bc273
Reviewed-on: https://chromium-review.googlesource.com/1197105Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#587668}

This CL is based on: https://chromium-review.googlesource.com/c/chromium/src/+/1150725

Design doc: https://docs.google.com/document/d/1yh_-ayeaFV0EjuR51U641zbrPAB0Baqj6UrC9bT9iqQ/edit#heading=h.y7amr11fn0tb

This CL implements "intrinsicSize" attribute for HTMLVideoElement.
The value of "intrinsicSize" overrides the intrinsic size:

1. When no width and (or) height is specified, the value of
"intrinsicSize" will be used to determine the area to layout the video
content.

2. videoWidth and videoHeight will return the value defined by
"intrinsicSize".

See explainer: https://github.com/ojanvafai/intrinsicsize-attribute/blob/master/README.md

Bug: 874629
Change-Id: If4aeceee2299c50aa7b4c9bdf8fef7cb3e7eea70
Reviewed-on: https://chromium-review.googlesource.com/1191926
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587667}

No change for Google Chrome builds, but Chromium builds will switch from
"Browse the web" to the (until now) unused string "Access the Internet"
in chromium_strings.grd.

This is another step toward getting rid of BrowserDistribution.

BUG=none
R=chengx@chromium.org
TBR=bauerb@chromium.org

Change-Id: I0ec49957d6b6b930593549bcfd17fec1fa013ccf
Reviewed-on: https://chromium-review.googlesource.com/1196036
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587666}

If credit card upload is not offered, Chrome can fall back to offering
local save instead.  It shouldn't do this for existing local cards.

Bug: 878177
Change-Id: I84ba77525864000a34aaa14b51305e854cd23c99
Reviewed-on: https://chromium-review.googlesource.com/1192405
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587665}

Bug: 876690, 876682, 879154
Change-Id: Ia72f26e9d7e0402868dd628fa2e10492b46a2cee
Reviewed-on: https://chromium-review.googlesource.com/1194728
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587664}

This reverts commit 66a05dbb.

Reason for revert: The null checks are not solving the crash. Must be a deeper issue where the style object is garbage

Original change's description:
> [Media Controls] Switch to using GetLayoutObject Style
> 
> This CL modifies the zoom calculation in the overlay play button to use
> GetLayoutObject's Style instead of ComputedStyleRef. This will
> (hopefully) prevent a crash we're seeing when accessing
> ComputedStyleRef.
> 
> Bug: 870490
> Change-Id: Id830798f1c781ef1eddffe153875be21f128237e
> Reviewed-on: https://chromium-review.googlesource.com/1192139
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586482}

TBR=beccahughes@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870490
Change-Id: I7027f2da320588650e9f683914e53d8a349821bd
Reviewed-on: https://chromium-review.googlesource.com/1197163Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587663}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/175653356591..e2807b42c18d


git log 175653356591..e2807b42c18d --date=short --no-merges --format='%ad %ae %s'
2018-08-30 derat@chromium.org chromeos_config: Increase TastVMTest timeout to 30 minutes.
2018-08-30 dgarrett@google.com push_image: Make --buildroot adjustable.
2018-08-30 achuith@chromium.org chrome_chromeos_lkgm: Use commandline.ArgumentParser instead.


Created with:
  gclient setdep -r src/third_party/chromite@e2807b42c18d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I29919e3876a91fa9bd9c099172413f317910e1c1
Reviewed-on: https://chromium-review.googlesource.com/1196687Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587662}

Using "use_jumbo_build=true" args in GN, speed up builds in
components/cdm.

Bug: None
Change-Id: I179d6d4bfa22ddbe1025aa396b31f2e3598ba7e3
Reviewed-on: https://chromium-review.googlesource.com/1193722
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587661}

Context: https://github.com/web-platform-tests/wpt/pull/12606

Change the logic of should.throw() so we can handle 3 cases -

should(someExpression).throw();
should(someExpression).throw(TypeError);
should(someExpression).throw(DOMException, 'NotSupportedError');

The generic error (except for DOMException) can be passed without
the second argument, but this change will enforce the second arg
when the expected error is a DOMException type.

This touches many test files, so the work will be done in several
steps:

1. Change audit.js, audionodeoptions.js on both locations.
  (wpt, non-wpt)
2. Update affected test files with the script.
3. Update the rest of test files which can't be updated
  programmatically.

Bug: 865614
Test: All layout tests pass.
Change-Id: I16acacb26c194a0ff950aca05e931195bf55167f
Reviewed-on: https://chromium-review.googlesource.com/1184146
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587660}

Bug: 866601
Change-Id: I3c877531e274804220ff820cf6309207c8a86234
TBR: reillyg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1197142Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587659}

These tests normally run fairly fast but some bots (tsan) can occasionally hit
the timeout.

BUG=angleproject:2783

Change-Id: I96aa1b724ffd93aa9df92f828f21048994bc3dfd
Reviewed-on: https://chromium-review.googlesource.com/1194323Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587658}

With Views, the control key is used for manipulating
selection in the tabstrip. Given the platform convention
on the Mac of using the command key for this, as well as
how on the Mac a control-click triggers a contextual menu
invocation, switch to a command key in those cases.

BUG=856698

Change-Id: Ic4d04f092503792da3b9bde8d6b6ed2800956697
Reviewed-on: https://chromium-review.googlesource.com/1195823Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587657}

Using wpt-import in Chromium e328a9ad.
With Chromium commits locally applied on WPT:
29a89cda "Import all remaining cookie tests into WPT"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23662

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org:
  external/wpt/cookies

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I53e898173d2fbb88caa172fe60488e033dbd4550
Reviewed-on: https://chromium-review.googlesource.com/1196908
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587656}

This adds the existing UMA container_names::MediaContainerName
enum value to UKM to help us understand media consumption for
both local and online cases better.

This only adds the metric for src= playbacks, it's much harder
to add for MSE since a MSE playback may have multiple formats
at a given time. The UMA we have for this is currently
sufficient.

Privacy approval complete at http://go/ukm-media

BUG=877697
TEST=updated tests.

Change-Id: I2baeb04010ab3c4708ca54b756229d92d69f6c51
Reviewed-on: https://chromium-review.googlesource.com/1192134
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587655}

This CL makes two previously-asynchronous API functions synchronous,
which drastically improves the ease of using this class.

The two functions are GetHostStatus() and GetFeatureStates(). With this
CL, the class now caches the most recent value received from the service
and returns in synchronously. If the service's values change, the
changes will be reflected in the client class.

This change unblocks several sub-tasks which use the client, including
setup code for EasyUnlock, Instant Tethering, and AWM.

Bug: 875980, 824568
Change-Id: I29430f614ce17206692b916d66b0cf57ec09f636
Reviewed-on: https://chromium-review.googlesource.com/1196030Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587654}

In particular, when the fetch actually completes in the window between
Abort() and DestroyURLLoaderOnIOThread()

Bug: 879150
Change-Id: I0331af60d89e6142ed00f255aea391237403c215
Reviewed-on: https://chromium-review.googlesource.com/1196962Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587653}

This reverts commit a6f6697e.

Reason for revert: suspect breaking BrowserViewTest.GetAccessibleTabModalDialogTitle

BUG:879253

Original change's description:
> Tab modal dialog title should be accessible window title
> 
> Tab modal dialogs (ui::MODAL_TYPE_CHILD) should report their title
> to AT (insert+T on JAWS and NVDA) when active. To accomplish this,
> BrowserView::GetAccessibleWindowTitle should report the title of
> the dialog when one is active.
> 
> Bug: 775680
> Test: browser_tests.exe --gtest_filter=BrowserViewTest.GetAccessibleTabModalDialogTitle
> Change-Id: Ie693e1627c87e4d97eede64381d80dab31635642
> Reviewed-on: https://chromium-review.googlesource.com/1184039
> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587371}

TBR=avi@chromium.org,dmazzoni@chromium.org,sky@chromium.org,jamwalla@chromium.org

Change-Id: I92d90e704a80de07a85cc223fbe13e55fc763a71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775680
Reviewed-on: https://chromium-review.googlesource.com/1197327Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587652}

Bug: 877896
Change-Id: I008e41233bf9378370b592425e5a928a0b97301f
Reviewed-on: https://chromium-review.googlesource.com/1195745Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587651}

To do otherwise means some state lasts longer than the objects created by
Ash. This causes problems with single-process-ash.

BUG=874090
TEST=test only changes

Change-Id: I359dbd5b3be90c1733bc9c94c6ea1c57f4e39513
Reviewed-on: https://chromium-review.googlesource.com/1196921Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587650}

The home launcher notch is shown normally to indicate that the launcher
can be dragged. This draggability is behind the HomeLauncherGestures
flag.

If this flag is disabled and the device is in tablet mode, do not draw
the notch.

Bug: 878937
Change-Id: I17b60cc689f39658edcb22bfb55be7ad53b26e34
Reviewed-on: https://chromium-review.googlesource.com/1195935
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587649}

This CL removes the following test steps:
- not_site_per_process_content_browsertests
- not_site_per_process_content_unittests
- not_site_per_process_components_browsertests
- not_site_per_process_components_unittests
- not_site_per_process_extensions_browsertests
- not_site_per_process_extensions_unittests

These test steps are not needed as explained in
https://crbug.com/870761#c6 (it is sufficient to test with the default
mode: site-per-process on desktop, and not-site-per-process on Android,
Cast).

Bug: 870761
Bug: 852442
Change-Id: I120057abbe85e425fb141d35dcea8045db881234
Reviewed-on: https://chromium-review.googlesource.com/1194335
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587648}

This CL updates JavaScriptDialogTestCase to use embedded test servers
rather than the deprecated HttpServer.

The flake in the referenced bugs are not reproducible locally; this
CL is a speculative fix that is meant to reduce flake by using non-
deprecated testing fixtures.

Bug: 871679, 871685
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0c5c32c1420c5f7da70951d108de96bde8df893a
Reviewed-on: https://chromium-review.googlesource.com/1196230
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587647}

This cl changes the fling scheduler mac to get the root view for oopifs so
that it has BrowserCompositor. Without this change fling|autoscroll inside
an oopif on mac would not work when viz is enabled.

On Non-mac platforms GetNativeView() in GetCompositor() takes care of going
through the nested oopifs.

The added browsertests will fail without this patch when viz is enabled.

Bug: 249063
Test: BrowserSideFlingBrowserTest.(Touchpad|Touchscreen)FlingInOOPIF
Change-Id: I3ccf3fc4356c6c467bb5714110e88d284b0d559a
Reviewed-on: https://chromium-review.googlesource.com/1195655
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587646}

First in a series of changes to the interstitial pages bringing
them in line with the Google Material styling.

- Button styling update for mobile devices.
- Formatting of error code.

Bug: 871861
Change-Id: I34c4063559746fd99680b30d228e842fb2c5b9a5
Reviewed-on: https://chromium-review.googlesource.com/1194125Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587645}