- 11 Jan, 2019 40 commits
-
-
Marc Treib authored
It's flaky due to an SQLite data race. Bug: 920738, 917380 Change-Id: I3ed269d487daa25ebd973bda8b1689ebd22977ec Reviewed-on: https://chromium-review.googlesource.com/c/1406708 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#621968}
-
Yutaka Hirano authored
As a preparation to move more properties to FrameResourceFetcherProperties, this CL passes FrameOrImportedDocument, not LocalFrame, to FrameResourceFetcherProperties. Bug: 914739 Change-Id: Ib56c7013eeb2c7cb66d5d6651e832f7d475bd58c Reviewed-on: https://chromium-review.googlesource.com/c/1405161 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#621967}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6fb2d7633e67..2d0af9555211 Created with: gclient setdep -r src-internal@2d0af9555211 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8edb4e4e3b659695d6db8430adb7ef8e9db04666 Reviewed-on: https://chromium-review.googlesource.com/c/1405816Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621966}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0486f0914f1c..0554368eedf9 git log 0486f0914f1c..0554368eedf9 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 nisse@webrtc.org Delete method DecoderDatabase::RegisterPayload(...NetEqDecoder...) Created with: gclient setdep -r src/third_party/webrtc@0554368eedf9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0d26c02d2b8156534493243d48317a501c161ea Reviewed-on: https://chromium-review.googlesource.com/c/1405597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621965}
-
Tanja Gornak authored
Metric Sync.InvalidationPerModelType is recorded two times. Remove one of them. Bug: 801985 Change-Id: I6b04cfe38dc29fc03cf317daf946376c06e36725 Reviewed-on: https://chromium-review.googlesource.com/c/1405050Reviewed-by:
-
Henrik Boström authored
This is a member in both RTCRtpContributingSource and the derived dictionary RTCRtpSynchronizationSource. For SSRCs, this value must always be present, either from the RFC6464 header extension data or obtained through calculations, though the third_party/webrtc implementation only does the former. For CSRCs, this value is optional depending on if the RFC6465 header extension is present. Currently, the third_party/webrtc implementation does *not* fill in the audio level in the CSRC case, but this CL takes care of the plumbing for both SSRCs and CSRCs based on whether or not audio_level() is present in the webrtc layer. The getSynchronizationSources() test now passes. Demo page: https://codepen.io/anon/pen/xmJVoy?editors=1010 Bug: 893172 Change-Id: I9c3fac818c271875e6b14cf062057df034a5fc71 Reviewed-on: https://chromium-review.googlesource.com/c/1401521 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#621963}
-
Sylvain Defresne authored
All observers of that method were UI components that refreshed themselves when notified. Since they then fetch the data from the AccountTrackerService, and does the same refresh when the account is updated, it is simpler to just use OnAccountUpdated for both events. Bug: 914783 Change-Id: I4d085baceb72373eda1c11e169d04ce55a2ac8e2 Reviewed-on: https://chromium-review.googlesource.com/c/1402568Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#621962}
-
Thomas Tangl authored
- Fix the illustration layout on Windows. Before, when the illustration didn't fit inside the dialog, it was repeated, seen here: https://screenshot.googleplex.com/p0yMY9BHTp4.png - Fix the overall layout of the dialog when there is a scrollbar. The content width is automatically adjusted to fit inside the viewable area. Screenshots before: https://drive.google.com/file/d/1Mjmy8fLCMOoFeK6QaORLLWt_yfbXuC7d/view?usp=sharing https://drive.google.com/file/d/13ZABys6U5Ee7mRi7wQpbQ47ozuORhTt5/view?usp=sharing Screenshots after: https://drive.google.com/file/d/1GmYFkX4p33F1hVHMQk760ENHtq2EPR00/view?usp=sharing https://drive.google.com/file/d/18_vHzM9PU6NIfwKtrrTu2GfBBJj-KwPi/view?usp=sharing Bug: 919743 Change-Id: I8338b199b4afb9d4e62bfb09b05c7a6862185b86 Reviewed-on: https://chromium-review.googlesource.com/c/1400806 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#621961}
-
Marc Treib authored
Currently these tests are all very flaky on TSan because of a data race related to the global FeatureList instance. This CL changes the tests to avoid the problematic pattern (overriding the FeatureList from the test body). For one test (CannotDecryptScryptKeyEncryptedDataWhenScryptDisabled), it's not easy to avoid the bad pattern, so this test is disabled on TSan. Bug: 915219 Change-Id: Ic04db73c6a40b426f52fbf4a170d661c2a1ebe93 Reviewed-on: https://chromium-review.googlesource.com/c/1404084 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#621960}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4720e59f..1dbc85c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f7929b0ddb963d064581eba84d5feb1fedd827e Reviewed-on: https://chromium-review.googlesource.com/c/1406571Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621959}
-
Justin Cohen authored
This reverts commit ddae444d. Reason for revert: A quick survey of other app store apps shows no one else is setting the INIntentDefaultImageName value. It's possible the 'ghost icon' won't appear when the app comes from the app store. And when we do set INIntentDefaultImageName, the image gets shown alongside the app icon (which is identical) leading to two chrome icons showing up twice. Siri Shortcuts are broken regardless if you delete the app, so I think showing the ghost icon is 'ok'. Original change's description: > [ios] Set AppIcon as default intent image. > > Bug: 916994 > Change-Id: I93d0e6264e842fb445c30b5b73396695823ade6c > Reviewed-on: https://chromium-review.googlesource.com/c/1387044 > Reviewed-by: Peter Lee <pkl@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618248} Bug: 916994, 920189 Change-Id: I1113f7638d4a29d9c20d2aa1ddb91030ce4432d3 Reviewed-on: https://chromium-review.googlesource.com/c/1406164Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#621958}
-
Dominik Röttsches authored
In Windows layout tests we populate a set of sideloaded fonts to the FontCache. These were not covered by local unique matching, even though some tests rely on for example matching src: local(Ahem). Fix this with a test-only implementation based on retrieving the PostScript name from FreeType. This fixes http/tests/css/css-resources-referrer-srcdoc.html http/tests/css/css-resources-referrer.html http/tests/webfont/fontface-style-change.html when enabling local unique font name matching. Bug: 889864 Change-Id: I5284b2fc186cff03d2da9475ccd081cb3632dbc6 Reviewed-on: https://chromium-review.googlesource.com/c/1404089 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#621957}
-
Yutaka Hirano authored
FrameFetchContext works for a frame and an imported document. I'm planning to split more classes from FrameFetchContext which will need the same logic. This CL introduces FrameOrImportedDocument for the shared logic to avoid future code duplication. Bug: 914739 Change-Id: I75d59e5e53ae99cd945ed5e160142681d7f5f5c0 Reviewed-on: https://chromium-review.googlesource.com/c/1404902 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
After https://webrtc-review.googlesource.com/c/src/+/99660, this file will not be compiled anymore, this CL removes it. Bug: webrtc:9754 Change-Id: Ibc82b125f05ad459c5f1af2f05971695cb48a873 Reviewed-on: https://chromium-review.googlesource.com/c/1226147Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#621955}
-
Benoît Lizé authored
ParkableString compression allocates a temporary buffer inside GzipCompress using UncheckedMalloc(). From a finch experiment (see bug), there is a statistically significant increase in malloc() footprint on Android, even though the only allocations are temporary. To mitigate the regression, use PartitionAlloc to allocate the temporary data. This changes: - compression_utils.cc: take an external output buffer for compression. - parkable_string.cc: Allocate the temporary buffer with PartitionAlloc, on the buffer partition. Bug: 920194 Change-Id: I57c42f67ea0b09e1ae9137beade4dd0d3c6ef258 Reviewed-on: https://chromium-review.googlesource.com/c/1404083Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#621954}
-
Alex Clarke authored
This reverts commit 8e92e732. Reason for revert: Forgot to upload final patchset :( Original change's description: > Add a top level traits bag comment and improve unittest > > Change-Id: Ica9aaefb29261df3e741f12880c12e4ebfed948d > Reviewed-on: https://chromium-review.googlesource.com/c/1403130 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621521} TBR=dcheng@chromium.org,gab@chromium.org,alexclarke@chromium.org Change-Id: I39cc89dff8417fd7c7985ec668f239e9f0ff3be0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1406245Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#621953}
-
Yuzu Saijo authored
This CL adds calls to ContextDestroyed from ForciblyPurgeV8Memory to do cleanup operations in various observer classes. Because of this change, the life time of document and execution context could differ (i.e. execution context is destroyed but document is not shut down yet). This CL also includes a bug fix because of the change. Change-Id: Ib46b3ec6cce2e55edc59001466181131d5987b3a Bug: 917293 Reviewed-on: https://chromium-review.googlesource.com/c/1386071 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#621952}
-
Kent Tamura authored
Some tests passed nullptrs to such pointer arguments. This CL passes dummy Element or CustomElementDefinition instances for them. Change-Id: I13e64f18a7f33159776a0b1fc78f7343e042888a Reviewed-on: https://chromium-review.googlesource.com/c/1404898Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#621951}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/977cd17316ea..0486f0914f1c git log 977cd17316ea..0486f0914f1c --date=short --no-merges --format='%ad %ae %s' 2019-01-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8c0cc380..783044b7 (621736:621838) 2019-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e2ded71..8c0cc380 (621632:621736) 2019-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6e83997c..2e2ded71 (621525:621632) 2019-01-10 benwright@webrtc.org Minor change to the Json Config format for the replay file. 2019-01-10 jakobi@webrtc.org Add PeerConnection option to enable RTX handling in the audio jitter buffer. 2019-01-10 danilchap@webrtc.org Remove TaskQueue::PostAndReply as unused 2019-01-10 nisse@webrtc.org Add data() accessors to EncodedImage 2019-01-10 ilnik@webrtc.org Refactor FrameBuffer to store decoded frames history separately 2019-01-10 nisse@webrtc.org Delete method StreamInterface::GetSize 2019-01-10 stefan@webrtc.org Enable quality scaling in video_loopback. 2019-01-10 terelius@webrtc.org Parse logs without RTX SSRC even if there is an RTX payload type. 2019-01-10 eladalon@webrtc.org Make FrameBuffer support an unlimited number of dependents per frame Created with: gclient setdep -r src/third_party/webrtc@0486f0914f1c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8a3070a773b2a75b8a55f6fd8405552281c2d0d Reviewed-on: https://chromium-review.googlesource.com/c/1406393Reviewed-by:
-
Jan Krcal authored
This CL adds functions needed by the new wallet metadata sync bridge. Bug: 853688 Change-Id: I4b1e1c7aee0b5016eae4d7b3dd3c790d3ccf5a54 Reviewed-on: https://chromium-review.googlesource.com/c/1405509 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621949}
-
vasilii authored
The password manager UI uses the icons as well and they are to be pinned. Bug: 916199 Change-Id: Ic2e1472d2373d3ab53cbf8aa6a93b15c9cd7a3b7 Reviewed-on: https://chromium-review.googlesource.com/c/1386853Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#621948}
-
Kenichi Ishibashi authored
Before this CL, we generate eager code cache only for scripts which are put in CacheStorage during install events. This CL adds another strategy which generates eager code cache in idle tasks if scripts are put into CacheStorage outside install events. To control the way to generate eager code cache, this CL adds an experiment parameter that can be one of following: - dontgenerate: do not generate eager code cache even in install event - installevent: the current behavior - idletask: generate eager code cache in idle tasks when script is cached outside install event The default is installevent, which is the current behavior. Change-Id: I18cdf560b89c8a21ee3f49ca587bae278010cf9e Reviewed-on: https://chromium-review.googlesource.com/c/1368860Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#621947}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7204ff3e43f3c3b00d20a39b4496cb313e276f2a Reviewed-on: https://chromium-review.googlesource.com/c/1405596Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8a6725d0ee8e8b720ef14d48ac91d6c8906331d9 Reviewed-on: https://chromium-review.googlesource.com/c/1406508Reviewed-by:
-
Yutaka Hirano authored
This is a reland of commit 83624e50. The original change was reverted because it breaks loading some sites (see https://crbug.com/920066). That was caused by bad implementation in BytesConsumer::Tee, so this CL fixes the bug. Original change's description: > Introduce BufferingBytesConsumer > > The fetch spec requires us to relieve backpressure when updating the > HTTPS cache. This has been implemented in content/renderer/loader as > SharedMemoryDataConsumerHandle::BackpressureMode, but this CL moves the > implementation to blink/renderer/core/fetch in order to deprecate > WebDataConsumerHandle. > > Bug: 911036 > Change-Id: Ia0161a7c5f1dbd17a994c11865cf035816235bb0 > Reviewed-on: https://chromium-review.googlesource.com/c/1364972 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618449} Bug: 911036 Change-Id: I912b84d5934a6f14c9295a2512a720c8464beeef Reviewed-on: https://chromium-review.googlesource.com/c/1404894Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This CL switches task runners at CacheStorage from per-thread to per-frame. The purpose of this change is to make it possible to freeze CacheStorage tasks for bfcache. bfcache is a new feature to freeze a tab for quick back-forwarding. When a tab goes frozen, we can stop per-frame task runners while we cannot per-thread task runners since per-thread task runners can be shared between multiple tags/pages. As a frozen tab must not execute any JavaScript, all JavaScript execution must be on per-frame task runners, which can be suspended. Bug: 913912 Change-Id: I2510c8c8f8ace86e0c0297a258b2192508947cfa Reviewed-on: https://chromium-review.googlesource.com/c/1404899 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Niels Möller authored
To be deleted in https://webrtc-review.googlesource.com/c/src/+/114983 Bug: webrtc:5791 Change-Id: I49a8bdf7b9940a9972701d4eb684d77834ad97c9 Reviewed-on: https://chromium-review.googlesource.com/c/1384364Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#621942}
-
Esmael El-Moslimany authored
Bug: 866562 Change-Id: I9a11c07c5c3c8680f4cb50e21371de666eab9f04 Reviewed-on: https://chromium-review.googlesource.com/c/1403680Reviewed-by:
-
Azhar Shaikh authored
commit 6f1309ef ("media/gpu/vaapi: Relax the version check for VA-API") added the VA_CHECK_VERSION to relax the VA-API version check. But it still does the same thing as the previous check. VA_CHECK_VERSION will return 'true', only when the VA-API version is greater than or equal to the parameters passed to it. So in this case when the major and minor version were passed from vaInitialize() output, it did the same strict check as earlier. When trying to update libva to a newer version, there will still be a mismatch, since vaInitialize() would return the updated/newer libva version installed on the system, but the chromium would still be built with older version (libva-2.1.0 as of now). To fix this and actually relax the check, make sure the system version of libva is greater than the libva version with which the browser is built, since libva is backward compatible. This will allow any future libva updates without breaking existing code. Fixes: 6f1309ef ("media/gpu/vaapi: Relax the version check for VA-API") Bug: 905814 TEST=Below scenarios were tested and h/w acceleration is working successfully. TEST=Build chromium with libva-2.3.0 and system version 2.3.0 TEST=Build chromium with libva-2.1.0 and system version 2.3.0 TEST=Build chromium with libva 2.1.0 and system version 2.1.0 Signed-off-by:
Azhar Shaikh <azhar.shaikh@intel.com> Change-Id: I1ec14aabed21b7d6b6fc55080bbac17233c40ec0 Reviewed-on: https://chromium-review.googlesource.com/c/1376716 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#621940}
-
Vadym Doroshenko authored
This metrics tries to understand how good is Chrome Password Manager in helping the user to sign in. It's recorded only on submissions that are considered to be successful. This CL contains: 1.Implementation the metric calculation in PasswordFormManagerRecorder 2.Propagating all necessary information for calculation. Bug: 918846 Change-Id: I53d71a2dcad0c33480157d69e275047138d2df0f Reviewed-on: https://chromium-review.googlesource.com/c/1400691Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#621939}
-
David Bokan authored
Fragment anchors will soon become more complicated and involved than they already are, see https://crbug.com/919204. Currently, fragment anchor scrolling is implemented inside LocalFrameView. There's a significant amount of code here and implementing new additions here will be rather complicated. As a first step, this CL consolidates and moves all the related logic into a new FragmentAnchor class owned by LocalFrameView. This CL should not have any behavioral changes. Bug: 919204 Change-Id: I01cd4d08ac8df64eb4fe92f030c466349bf5b96f Reviewed-on: https://chromium-review.googlesource.com/c/1395893Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#621938}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc7c140975f6..cb42fc0dc56f git log dc7c140975f6..cb42fc0dc56f --date=short --no-merges --format='%ad %ae %s' 2019-01-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@cb42fc0dc56f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I5afa657f0d89d31bb958dc1b01f3ee220f5325b6 Reviewed-on: https://chromium-review.googlesource.com/c/1406424Reviewed-by:
-
Nate Fischer authored
This updates Android build documentation for the `target_cpu` option, and provides guidance for how to determine this value. This setting is arm-by-default for Android development. Although this is OK for Chrome for Android developers, it doesn't work for several use-cases: * Doesn't work for WebView on arm64 devices (which are increasingly popular) * Doesn't work for tests on arm64 devices (e.g., webview_instrumentation_apk) * Doesn't work for non-arm at all (e.g., x86-based emulator) Although there's a low cost to setting `target_cpu`, there's a high cost to omitting it (a mistake requires a full rebuild). And, since it's not obvious when the default is insufficient, this provides guidance for how to set it correctly for a given device. This also changes from `gn gen --args` to `gn args`. The motivation is: * It's convenient to call out `target_cpu` with an inline comment * `gn args` is a convenient command for complex configs, and isn't significantly worse for the recommended simple config * IMO it's easier to find docs for `gn args` (`gn help args`) than `--args` (it's not obvious it's a global option, and lives under `gn help switches`) This edits a bullet about default settings. Although it's true that `target_os` and `target_cpu` default to `host_os` and `host_cpu`, this is not relevant to Android development, since we always override these values. R=agrieve@chromium.org Bug: 918221 Test: N/A Change-Id: Ie4b8eab491fd8b860420dbba6dac6badc16b9f76 Reviewed-on: https://chromium-review.googlesource.com/c/1401981 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#621936}
-
Chris Morin authored
crrev.com/c/1395297 broke ARC++ opt-in dialog. Partially revert it to unblock ARC++ development. Add comment to disable ESLint check at original commiters request. BUG=792774 BUG=b:122692988 TEST=Ensure arc opt-in dialog can be opened TBR=dpapad@chromium.org Change-Id: Iad64d4f3965dfb73097d0a806231dc4ee1fc5e5b Reviewed-on: https://chromium-review.googlesource.com/c/1406242Reviewed-by:
Christopher Morin <cmtm@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Decide in Factory's GetBrowserContextToUse whether to bypass creation of WebAppMetrics service for a given profile. This is a much cleaner and more efficient way to do so, No behavior change. Bug: 907353 Change-Id: I925977faca2e5dd917fe16a910bd65110215257a Reviewed-on: https://chromium-review.googlesource.com/c/1405163Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#621934}
-
CJ DiMeglio authored
This CL changes the play button to use by aria attributes instead of explicitly creating accessibility nodes. Bug: 836549 Change-Id: I08d2b5fd59424388d93ec485a4e3fd7fa7e98e9e Reviewed-on: https://chromium-review.googlesource.com/c/1394714 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621933}
-
liberato@chromium.org authored
Previously, the unittest would mock out just the supported feature levels for D3D11VideoDecoder::IsPotentiallySupported. Decoder init would fail. This CL mocks out much more, so that init can succeed. Due to some structural changes to permit injection, the decoder now checks the ANGLE D3D11 device rather than creating its own. This is likely better anyway, since we use the ANGLE device when creating the decoder. Change-Id: I16b49339ba1e0546ec78f0804c46d0d6307a99bb Reviewed-on: https://chromium-review.googlesource.com/c/1387693 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#621932}
-
Rune Lillesveen authored
We used to skip caching of parsed stylesheets for the same resource but for different documents because the RuleSet would be different for different media query evaluations. For instance, if you have a top frame with two sub iframes running in the same renderer and the two iframes link to the same stylesheet, but have different sizes, we could have different active RuleSets if the media queries evaluated differently in the two iframes. However, we could cache the StyleSheetContents and clone that instead of reparsing the stylesheet for every instance. That is what was implemented behind the flag. This feature is not web exposed, so no intent to ship should be required. Bug: 472923 Change-Id: Icc70c43664f6e5feea9f34c5fc8d97be364826cd Reviewed-on: https://chromium-review.googlesource.com/c/1405051Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#621931}
-
Koji Ishii authored
Change-Id: I3c56b78b4da6a758931c2efbab3818de37ce50bb Reviewed-on: https://chromium-review.googlesource.com/c/1405125Reviewed-by:
-
Hajime Hoshi authored
JavaScript Execution on per-thread task runners must be forbidden for bfcache. This CL passes per-frame task runners for such tasks like mojo bindings. This is part of https://chromium-review.googlesource.com/c/chromium/src/+/1379794 Bug: 870606 Change-Id: Iea22b5af3874f34453b8eaa0e9941cf482d9c9b8 Reviewed-on: https://chromium-review.googlesource.com/c/1400430Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
