GitLab

Revert of Ensure WebView notifies desktop automation on creation, destruction, and change (patchset #20 id:510001 of https://codereview.chromium.org/880063002/)

Reason for revert:
Broke interactive_ui_tests on Linux Chromium OS ASan LSan Tests bot.

TestAsNormalAndGuestUser/SpokenFeedbackTest.EnableSpokenFeedback/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.EnableSpokenFeedback/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.TouchExploreStatusTray/0
GuestSpokenFeedbackTest.FocusToolbar
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNavigateAndSelect/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.VolumeSlider/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.VolumeSlider/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNavigateAndSelect/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.TouchExploreStatusTray/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.TypeInOmnibox/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.TypeInOmnibox/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateAppLauncher/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateAppLauncher/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1

Example test output:

TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 (run #1):
[ RUN      ] TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0
[5662:5662:0130/162946:ERROR:browser_main_loop.cc(171)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[5662:5662:0130/162946:WARNING:chrome_browser_main_chromeos.cc(290)] Running as stub user with profile dir: test-user
[5662:5662:0130/162946:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
Xlib:  extension "RANDR" missing on display ":9".
[5662:5691:0130/162946:ERROR:owner_key_util_impl.cc(27)] Could not get size of /tmp/.org.chromium.Chromium.2P0kWj/dmjRgRA/stub_owner.key
[5662:5691:0130/162946:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists.
[5662:5662:0130/162946:WARNING:data_reduction_proxy_settings.cc(345)] SPDY proxy OFF at startup
[5662:5673:0130/162946:WARNING:freezer_cgroup_process_manager.cc(58)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[5698:5698:0130/162946:ERROR:renderer_main.cc(205)] Running without renderer sandbox
[5708:5708:0130/162947:ERROR:renderer_main.cc(205)] Running without renderer sandbox
[5662:5662:0130/162948:INFO:CONSOLE(0)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.", source:  (0)
[5662:5662:0130/162949:INFO:CONSOLE(2069)] "Uncaught TypeError: Cannot read property 'appendChild' of null", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2069)
[5708:5708:0130/162949:WARNING:logging_native_handler.cc(62)] 43 is not in the cache and not the new root.
[5708:5708:0130/162949:WARNING:logging_native_handler.cc(62)] unserialization failed
[5662:5662:0130/162950:INFO:CONSOLE(2020)] "Starting ChromeVox.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (2020)
[5662:5662:0130/162950:INFO:CONSOLE(1235)] "Uncaught TypeError: Cannot read property 'query' of undefined", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (1235)
[5662:5662:0130/162950:INFO:CONSOLE(0)] "calling getTree() callback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/cvox2/background/background.html (0)
[5662:5662:0130/162950:INFO:CONSOLE(1453)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162950:INFO:CONSOLE(2197)] "Injecting into 2", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2197)
[5662:5662:0130/162950:INFO:CONSOLE(0)] "calling getTree() callback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/cvox2/background/background.html (0)
[5662:5662:0130/162951:INFO:CONSOLE(2020)] "Starting ChromeVox.", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (2020)
[5662:5662:0130/162951:INFO:CONSOLE(0)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.", source:  (0)
[5662:5662:0130/162951:INFO:CONSOLE(1252)] "Warning: ChromeVox external script loading for data:text/html;charset=utf-8,\u003Cscript>window.setInterval(function() {  try {    cvox.Api.speak('ready');  } catch (e) {}}, 100);\u003C/script> stopped after failing to install https://ssl.gstatic.com/accessibility/javascript/ext/loader.js", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1252)
[5662:5662:0130/162951:INFO:CONSOLE(1453)] "Speak (Q) "ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162951:INFO:CONSOLE(1454)] "  using endCallback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1454)
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4720:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2217:(snd_pcm_open_noupdate) Unknown PCM default
[5662:5667:0130/162951:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4720:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2217:(snd_pcm_open_noupdate) Unknown PCM default
[5662:5667:0130/162951:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[5662:5662:0130/162951:INFO:CONSOLE(2189)] "Earcon TASK_SUCCESS", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2189)
[5662:5662:0130/162951:INFO:CONSOLE(2020)] "Starting ChromeVox.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (2020)
[5662:5662:0130/162951:INFO:CONSOLE(0)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.", source:  (0)
[5662:5662:0130/162951:INFO:CONSOLE(2303)] "processing load complete!", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2303)
[5662:5662:0130/162951:INFO:CONSOLE(1453)] "Speak (Q) category=nav "Click me"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162951:INFO:CONSOLE(1453)] "  using startCallback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162951:INFO:CONSOLE(1453)] "Speak (Q) category=nav "Button"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162951:INFO:CONSOLE(1454)] "  using endCallback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1454)
[5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)]
Keyboard event: ET_KEY_PRESSED
 Key code: 17, Flags: 1048580, Is char: 0
[5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)]
Keyboard event: ET_KEY_PRESSED
 Key code: 186, Flags: 1048580, Is char: 0
[5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)]
Keyboard event: ET_KEY_RELEASED
 Key code: 186, Flags: 1048580, Is char: 0
[5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)]
Keyboard event: ET_KEY_RELEASED
 Key code: 17, Flags: 1048576, Is char: 0
[5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)]
Keyboard event: ET_KEY_PRESSED
 Key code: 191, Flags: 1048576, Is char: 0
[5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)]
Keyboard event: ET_KEY_RELEASED
 Key code: 191, Flags: 1048576, Is char: 0
[5662:5662:0130/162951:INFO:CONSOLE(1252)] "Warning: ChromeVox external script loading for data:text/html;charset=utf-8,\u003Cbutton autofocus>Click me\u003C/button> stopped after failing to install https://ssl.gstatic.com/accessibility/javascript/ext/loader.js", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (1252)
[5662:5662:0130/162952:INFO:CONSOLE(1455)] "Stop", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1455)
[5662:5662:0130/162952:INFO:CONSOLE(1455)] "Stop", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1455)
[5662:5662:0130/162952:INFO:CONSOLE(1455)] "Stop", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1455)
[5662:5662:0130/162952:INFO:CONSOLE(1453)] "Speak (I) "Find in page."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162952:INFO:CONSOLE(1453)] "Speak (Q) ", "", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162952:INFO:CONSOLE(1453)] "Speak (Q) "Enter a search query."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453)
[5662:5662:0130/162952:INFO:CONSOLE(2189)] "Earcon OBJECT_OPEN", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2189)

=================================================================
==5662==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x4d9e69 in operator new(unsigned long) (/tmp/run_tha_testJgo5Vp/out/Release/interactive_ui_tests+0x4d9e69)
    #1 0x2bf0069 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:449:7
    #2 0x2be4653 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329:3
    #3 0x2be2def in AutomationManagerAsh::SendEvent(content::BrowserContext*, views::AXAuraObjWrapper*, ui::AXEvent) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:114:3
    #4 0x2be3314 in AutomationManagerAsh::HandleEvent(content::BrowserContext*, views::View*, ui::AXEvent) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:63:3
    #5 0x21b9486 in views::View::NotifyAccessibilityEvent(ui::AXEvent, bool) ui/views/view.cc:1277:5
    #6 0x92bc0de8 in views::WebView::GetWebContents() ui/views/controls/webview/webview.cc:52:5
    #7 0x2bf55c9 in AXTreeSourceAsh::SerializeNode(views::AXAuraObjWrapper*, ui::AXNodeData*) const chrome/browser/ui/ash/accessibility/ax_tree_source_ash.cc:104:9
    #8 0x2befa22 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:419:3
    #9 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #10 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #11 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #12 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #13 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #14 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #15 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #16 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #17 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #18 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5
    #19 0x2be4653 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329:3
    #20 0x2be2def in AutomationManagerAsh::SendEvent(content::BrowserContext*, views::AXAuraObjWrapper*, ui::AXEvent) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:114:3
    #21 0x2be2acf in AutomationManagerAsh::Enable(content::BrowserContext*) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:33:3
    #22 0xd275b4b in extensions::AutomationInternalEnableDesktopFunction::Run() chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:357:3
    #23 0xaaeae8d in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback\u003Cvoid (ExtensionFunction::ResponseType, base::ListValue const&, std::string const&)> const&) extensions/browser/extension_function_dispatcher.cc:400:5
    #24 0xaaea20f in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:314:3
    #25 0xaada7c4 in OnRequest extensions/browser/extension_host.cc:353:3
    #26 0xaada7c4 in DispatchToMethodImpl\u003Cextensions::ExtensionHost, void (extensions::ExtensionHost::*)(const ExtensionHostMsg_Request_Params &), ExtensionHostMsg_Request_Params, 0> base/tuple.h:246
    #27 0xaada7c4 in DispatchToMethod\u003Cextensions::ExtensionHost, void (extensions::ExtensionHost::*)(const ExtensionHostMsg_Request_Params &), ExtensionHostMsg_Request_Params> base/tuple.h:253
    #28 0xaada7c4 in Dispatch\u003Cextensions::ExtensionHost, extensions::ExtensionHost, void, void (extensions::ExtensionHost::*)(const ExtensionHostMsg_Request_Params &)> extensions/common/extension_messages.h:582
    #29 0xaada7c4 in extensions::ExtensionHost::OnMessageReceived(IPC::Message const&) extensions/browser/extension_host.cc:341
    #30 0x44246c4 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:491:11
    #31 0x42d099d in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:878:7
    #32 0x42b2f8a in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1529:10
    #33 0x3ff6060 in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:282:3

-----------------------------------------------------
Suppressions used:
  count      bytes template
      9        736 libfontconfig
      1         24 libnssutil3
-----------------------------------------------------

SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s)

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

Original issue's description:
> Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Currently, when a caller requests a desktop tree and then opens a new windowthe new WebViewmight have an unloaded child root web area because the tree id sent on construction may be stale by the time automation gets it. Adding a notification in WebView::RenderViewHostChanged appears to work properly.
>
> This also allows ChromeVox to add one set of listeners on the desktop node.
>
> TEST=With ChromeVox Next set to use automation,
> - navigate within a tab
> - switch to several tabs and navigate
> - open new windows and navigate
> Result should be that events fire properly when tabbing within the new page.
>
> Committed: https://crrev.com/3475be275ec7342907a64e3e66cad085b9be8c33
> Cr-Commit-Position: refs/heads/master@{#314017}

TBR=dmazzoni@chromium.org,aboxhall@chromium.org,sadrul@chromium.org,sky@chromium.org,dtseng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/887203002

Cr-Commit-Position: refs/heads/master@{#314044}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/395f4d8..234f749

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/891073002

Cr-Commit-Position: refs/heads/master@{#314043}

Check interface for wireless extensions to determine if it is a wifi connection. Check SIOCETHTOOL for ethernet. GetCurrentConnectionType will return the CONNECTION_UNKNOWN unless all connections are the same type.

R=pauljensen@chromium.org
BUG=160537

Review URL: https://codereview.chromium.org/739983005

Cr-Commit-Position: refs/heads/master@{#314042}

This change:

- Re-introduces U+200C and U+200D as illegal characters since these are
  ignored on HFS+ and can interfere with filename sanitization. All code
  points in the Cf general category are now considered illegal in a
  filename.

- Leading and trailing WSpace and '.' characters are now considered
  illegal.

- Due to being confused for short names on VFAT filesystems, the tilde
  ('~') is now considered illegal.

- Prior to this change, only ASCII whitespace were trimmed from
  filenames on Mac OSX. All UTF-8 encoded WSpace characters are now
  handled on Mac OSX.

- Instead of trimming leading and trailing whitespace, they are now
  replaced by the replacement character. Trimming could cause a
  previously hidden extension or basename to be exposed.

BUG=444102
BUG=446538

Review URL: https://codereview.chromium.org/869823003

Cr-Commit-Position: refs/heads/master@{#314041}

This CL allows app_shell to use chrome.alarms.

Also it includes the following changes related to unit tests:
- Moved chrome.alarms tests to extensions/
- Moved a helper function CreateEmptyExtensionWithLocation()
  from extension_function_test_utils.h to api_test_utils.h.
- Moved CreateBackgroundPage() from extension_api_unittest.h to
  api_unittest.h.
- Creates WebContents for the extension that can be used to associate
  a RenderViewHost in extension unit tests.

BUG=443622

Review URL: https://codereview.chromium.org/789643004

Cr-Commit-Position: refs/heads/master@{#314040}

Not in gcl, which probably these days nobody working on Chromium uses.

BUG=None
R=maruel@chromium.org
TBR=maruel@chromium.org
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/887033002

Cr-Commit-Position: refs/heads/master@{#314039}

BUG=422489
TBR=mmenke

Review URL: https://codereview.chromium.org/889653004

Cr-Commit-Position: refs/heads/master@{#314038}

$ git log d863df383..c698ea2a7 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-01-30 maruel Add back -H since it's actively used.
2015-01-28 maruel Remove 1_local.py as it was not relevant anymore.
2015-01-28 maruel Rename --hash to --isolated and -i to -s.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/884473007

Cr-Commit-Position: refs/heads/master@{#314037}

BUG=424762

Review URL: https://codereview.chromium.org/880393002

Cr-Commit-Position: refs/heads/master@{#314036}

This allows all GuestView types to have access to a color picker.

BUG=451737

Review URL: https://codereview.chromium.org/889873004

Cr-Commit-Position: refs/heads/master@{#314035}

Revert of media: Enable Opus support in Clank <video> and MSE (patchset #5 id:100001 of https://codereview.chromium.org/866573004/)

Reason for revert:
This is breaking downstream builders on L:

C 1029.038s Main  [FAIL] MediaCanPlayTypeTest.CodecSupportTest_webm:
C 1029.038s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1029.039s Main  [WARNING:proxy_service.cc(898)] PAC support disabled because there is no system implementation
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:278: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp8, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.039s Main  Expected: kOpusProbably
C 1029.039s Main  Which is: ""
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:279: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp8.0, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.039s Main  Expected: kOpusProbably
C 1029.039s Main  Which is: ""
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:285: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp9, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.039s Main  Expected: VP9AndOpusProbably
C 1029.039s Main  Which is: ""
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:287: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp9.0, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.040s Main  Expected: VP9AndOpusProbably
C 1029.040s Main  Which is: ""
C 1029.040s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:296: Failure
C 1029.040s Main  Value of: CanPlay("'audio/webm; codecs=\"opus\"'")
C 1029.040s Main    Actual: "probably"
C 1029.040s Main  Expected: kOpusProbably
C 1029.040s Main  Which is: ""
C 1029.040s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:297: Failure
C 1029.040s Main  Value of: CanPlay("'audio/webm; codecs=\"opus, vorbis\"'")
C 1029.040s Main    Actual: "probably"
C 1029.040s Main  Expected: kOpusProbably
C 1029.040s Main  Which is: ""

Spoke with vigneshv@ and reverting for now is the best thing to do while a fix is prepared.

Original issue's description:
> media: Enable Opus support in Clank <video> and MSE
>
> Opus audio codec is supported by the android platform starting from Lollipop.
> This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus
> in Clank. This brings Opus feature parity with Desktop Chromium.
>
> BUG=318436
>
> Committed: https://crrev.com/95fcf214b5a9ba718d53efbf509c9d92e2514e4f
> Cr-Commit-Position: refs/heads/master@{#313549}

TBR=tomfinegan@chromium.org,wolenetz@chromium.org,rsleevi@chromium.org,qinmin@chromium.org,jschuh@chromium.org,vigneshv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=318436

Review URL: https://codereview.chromium.org/889053003

Cr-Commit-Position: refs/heads/master@{#314034}

Sometimes CRLF sneak into SQLite's code, and then causes patch errors
when landing in Chromium.  Add an import step for cleaning this up and
clean things up.

None of these files are in the Chromium build.  They just gum up the
works.

BUG=340757
TBR=michaeln@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/880533004

Cr-Commit-Position: refs/heads/master@{#314033}

Review URL: https://codereview.chromium.org/893693002

Cr-Commit-Position: refs/heads/master@{#314032}

Review URL: https://codereview.chromium.org/874033003

Cr-Commit-Position: refs/heads/master@{#314031}

Profiles in bluez are not specific to a device.
When client code tries to connect to two different devices, only
one profile is created, managed by BluetoothAdapterChromeOS.

dbus messages are multiplexed based on the device desired using new
class BluetoothAdapterProfileChromeOS.

This is a resubmit with bugfixes after https://codereview.chromium.org/851123002/ was reverted by
https://codereview.chromium.org/868753006/

BUG=421207

Review URL: https://codereview.chromium.org/888913002

Cr-Commit-Position: refs/heads/master@{#314030}

BUG=453955

Review URL: https://codereview.chromium.org/888993002

Cr-Commit-Position: refs/heads/master@{#314029}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ae50934..395f4d8

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/886143002

Cr-Commit-Position: refs/heads/master@{#314028}

It is not used at all.

Note that I didn't change any logic at all except
1) Get rid of NonCachedProgramInfoManager.
2) Merge CachedProgramInfoManager into ProgramInfoManager.
3) Get rid of the Create() function.
4) Add ~VertexAttrib() ~UniformInfo() ~Program() as required by compiler.

BUG=453127
TEST=no change at all
R=piman@chromium.org

Review URL: https://codereview.chromium.org/893713002

Cr-Commit-Position: refs/heads/master@{#314027}

Previously PolicyWatcher allowed initialization on a thread
different from the one it runs on. It's no longer necessary.
Also for It2Me it was initialized on UI thread, but was given
task runner for the network thread, which causes the DCHECK in the
linked bug.

Now PolicyWatcher is marked as NonThreadSafe. It's initialized on
UI thread for It2Me host and on NetworkThread for the me2me host.
Also the file thread is used for blocking operation when reading
policies.

BUG=453615

Review URL: https://codereview.chromium.org/886913002

Cr-Commit-Position: refs/heads/master@{#314026}

The 256x256 and 512x512 pngs are not used anywhere, so I deleted them.

BUG=453510

Review URL: https://codereview.chromium.org/890883005

Cr-Commit-Position: refs/heads/master@{#314025}

The precise order (or number) of some of these messages doesn't matter, so just handle them in a loop.

Review URL: https://codereview.chromium.org/888693004

Cr-Commit-Position: refs/heads/master@{#314024}

BUG=453523

Review URL: https://codereview.chromium.org/870053008

Cr-Commit-Position: refs/heads/master@{#314023}

This is the Accessibility Developer Tools suggested color
for a 4.5 contrast ratio (minimum for AA rating[1] /
audit to stop barking).

R=kalman@chromium.org
BUG=439227

[1] http://www.w3.org/WAI/WCAG2AA-Conformance

Review URL: https://codereview.chromium.org/893603006

Cr-Commit-Position: refs/heads/master@{#314022}

This causes crashes if the shutdown path is used on iOS, because on
iOS there's already a higher-level autorelease pool by the time this
code can be run.

BUG=None

Review URL: https://codereview.chromium.org/891843002

Cr-Commit-Position: refs/heads/master@{#314021}

This pulls in the following Native Client changes:

f02226b: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug...
6bc00f6: (dschuff@chromium.org) Update upstream compiler_rt to HEAD and use official git mirror
55d212c: (phosek@chromium.org) Updates the tools Makefile to work with Git
ccc9c66: (shyamsundarr@chromium.org) Add all remaining avx2 instructions except vgather.
9595661: (jfb@chromium.org) Enable -Werror for LLVM build
aa51c35: (pcc@google.com) Disable -flto when compiling nacl_bootstrap_lib.
476c662: (jfb@chromium.org) PNaCl: Update Subzero and LLVM revision in pnacl/COMPONENT_REVISIONS
2f388a0: (dschuff@chromium.org) Enable SCons testing of arm-nacl-clang on the bots
fea15c4: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug...

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/867463008

Cr-Commit-Position: refs/heads/master@{#314020}

Fix buffer overflow due to unbounded strlen over the non-null terminated audio policy string. Caught by asan.

BUG=

Review URL: https://codereview.chromium.org/890683002

Cr-Commit-Position: refs/heads/master@{#314019}

This reverts commit 3952cc42.

Retvield messed up in https://codereview.chromium.org/885743003/ and only
reverted part of the CL https://chromiumcodereview.appspot.com/889683002/

TBR=newt@chromium.org,tedchoc@chromium.org
NOTRY=true
BUG=407781

Review URL: https://codereview.chromium.org/892573006

Cr-Commit-Position: refs/heads/master@{#314018}

Currently, when a caller requests a desktop tree and then opens a new windowthe new WebViewmight have an unloaded child root web area because the tree id sent on construction may be stale by the time automation gets it. Adding a notification in WebView::RenderViewHostChanged appears to work properly.

This also allows ChromeVox to add one set of listeners on the desktop node.

TEST=With ChromeVox Next set to use automation,
- navigate within a tab
- switch to several tabs and navigate
- open new windows and navigate
Result should be that events fire properly when tabbing within the new page.

Review URL: https://codereview.chromium.org/880063002

Cr-Commit-Position: refs/heads/master@{#314017}

Also adds better support for zoom/wrapping.

BUG=438815
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/887803003

Cr-Commit-Position: refs/heads/master@{#314016}

Adds functionality to create_installer_archive.py to generate a .d file
that includes all of the files that it packages into chrome[.packed].7z.
This is done by tracking the source of all the files that are copied
into the staging dir that is given to 7za to package the .7z file.

The depfile is then used in a gyp 'depfile' to correctly specify the
implicit dependencies for the mini_installer target. Previously it used
a fake output of 'xxx2.out' to cause it to rebuild every time (which is
what we're trying to avoid in this change).

Additionally, switch from a rule to an action in gyp -- gyp currently
only supports 'depfile' on actions, and as there's only one file being
built here, they're equivalent.

BUG=342974,451499

Review URL: https://codereview.chromium.org/887673003

Cr-Commit-Position: refs/heads/master@{#314015}

This CL changes the argument of GetCanonicalSuffix() from HostPortPair to
std::string (both const&) to better document the fact that GetCanonicalSuffix
only operates on that field.

BUG=392575

Review URL: https://codereview.chromium.org/868753007

Cr-Commit-Position: refs/heads/master@{#314014}

- Top level folders are now all the sub folders of
  Bookmark Bar, Mobile, and Others nodes.
- We no longer use Uncategorized.

BUG=453024

Review URL: https://codereview.chromium.org/869193008

Cr-Commit-Position: refs/heads/master@{#314013}

BUG=452266

Review URL: https://codereview.chromium.org/887763003

Cr-Commit-Position: refs/heads/master@{#314012}

This CL implements the following four methods:
- getHeaderFields()
- getHeaderField(String key)
- getHeaderField(int pos)
- getHeaderFieldKey(int pos)

BUG=398997

Review URL: https://codereview.chromium.org/784853004

Cr-Commit-Position: refs/heads/master@{#314011}

Without this, ChannelMojo doesn't work.

R=inferno@chromium.org, tsepez@chromium.org
TBR=jamesr@chromium.org
BUG=453571

Review URL: https://codereview.chromium.org/867903006

Cr-Commit-Position: refs/heads/master@{#314010}

If the bitmap wasn't allocated, return false instead.

BUG=411505

Review URL: https://codereview.chromium.org/879143002

Cr-Commit-Position: refs/heads/master@{#314009}

Avoids ninja expecting an import .lib to be generated so that it doesn't
continually rebuild because the import lib is "missing".

To be landed after gyp roll at https://codereview.chromium.org/890043003/ lands.

R=robertshield@chromium.org
BUG=342974,451499

Review URL: https://codereview.chromium.org/886123002

Cr-Commit-Position: refs/heads/master@{#314008}

This updates the permission prompt (infobar and permission bubble)
icons with the new icons provided by sgabriel@:
https://drive.google.com/a/google.com/folderview?id=0B-Vmdj5n-
YddWktRd1BMeHZYWWs&usp=sharing

BUG=451490

Review URL: https://codereview.chromium.org/893603003

Cr-Commit-Position: refs/heads/master@{#314007}

ScheduleAndForget is a thin wrapper around ScheduleTask that hides
a base::Bind() call and passing the HistoryBackend pointer as the
first parameter.

As they are templated function, they prevent splitting HistoryService
into a pure virtual interface and a implementation interface that
would improve the componentization velocity.

BUG=370850
R=droger@chromium.org

Review URL: https://codereview.chromium.org/865443005

Cr-Commit-Position: refs/heads/master@{#314006}

For GuestView types in the browser, such as <webview> in WebUI and
<extensionoptions> in WebUI, we would live status messages to appear
in the browser. This CL plumbs that information out to the embedder.

ContentsMouseEvent, LoadingStateChanged, and UpdateTargetURL are calls out to the content embedder that are used by Browser to update status indicators such as the spinner, and status text.

This CL plumbs those calls out from the guest to the embedder. This is a bit racy because guest status and embedder status can interleave but that's OK because these status texts are transient and eventually they'll settle and disappear so there's no long lasting raciness of consequence.

BUG=453216
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/880983006

Cr-Commit-Position: refs/heads/master@{#314005}