- 16 May, 2018 40 commits
-
-
Jonathan Backer authored
Bug: 829469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idc108797849100053d534c014538b602345f26df Reviewed-on: https://chromium-review.googlesource.com/1060028Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559061}
-
Aldo Culquicondor authored
This UI element is used to build the scrollable overflow menu. Bug: 839488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I930b2b13f61e1533d74df6c5a4aab60089987450 Reviewed-on: https://chromium-review.googlesource.com/1055987Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#559060}
-
Simon authored
Landing this for eakuefner@ since he's OOO this week. This CL switches various small (mostly V8 "press") benchmarks to the histogram pipeline. Bug: 744736 Change-Id: I2391ed93f53bd5471498513c9dc6effa8c25dfba Reviewed-on: https://chromium-review.googlesource.com/1059586 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559059}
-
Lucas Furukawa Gadani authored
This CL removes the typemaps for CacheStorage and converts the browser usage of CacheStorage types to mojo types. Bug: 612287 Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 Reviewed-on: https://chromium-review.googlesource.com/1058334Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559058}
-
Marina Ciocea authored
Reset ref factory in destructor to call ref factory's quit closure before other members get destroyed. Change-Id: Idbb7e22c60c309a2d72aa69af098a33f4b966fe2 Reviewed-on: https://chromium-review.googlesource.com/1060059 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559057}
-
Colin Blundell authored
Sylvain is ramping up to full co-ownership of the Identity Service. Add him as an OWNER now to allow him to make straightforward changes when the two existing OWNERS are both OOO. He will of course defer to the existing OWNERS for complex changes (either making or reviewing) while ramping up. Change-Id: I287b712c402c04dcbf384e3d78b6842f90b3fafc Reviewed-on: https://chromium-review.googlesource.com/1061459Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#559056}
-
Peter E Conn authored
My last attempt at solving this [1] didn't work. I suspect it may be to do with rounding errors, but have no data to back this up. Since the bug is a release block stable, I'll catch the error so we stop crashing. After merging this to branch, I'll commit another change to trunk causing this to throw, but with extra diagnosis information. [1] https://chromium-review.googlesource.com/c/chromium/src/+/908557 Bug: 842897 Change-Id: Iacbb4011cdb0acd92f6c2e0cca3ff5fe8ccc19d1 Reviewed-on: https://chromium-review.googlesource.com/1061313Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#559055}
-
W. James MacLean authored
Tooltips aren't used on Android, and neither are CursorManagers. This CL removes a CursorManager null-dereference in RenderWidgetHostViewChildFrame that occurs on Android. Bug: 842410 Change-Id: I737d7c4ab6a5befda660a9df5598469ac2802fe6 Reviewed-on: https://chromium-review.googlesource.com/1057993Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#559054}
-
Bruno Kim Medeiros Cesar authored
The "usm" service flag is not sent in IdToken. After USM support is launched, we'll want to delete this setting entirely. Bug: 836246 Change-Id: I4981132619ff1bd580bd10a6a47d7aa088394825 Reviewed-on: https://chromium-review.googlesource.com/1059457Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559053}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: Iee4f0a51ee32cc66d4a56620d181d2f090486041 Reviewed-on: https://chromium-review.googlesource.com/1061235Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559052}
-
Noel Gordon authored
Mash does not support the BasicDrive tests causing flakes on the CQ in mash_browser_tests (with patch). Exclude them in Mash. MultiProfileFileManagerBrowserTest.BasicDrive MultiProfileFileManagerBrowserTest.PRE_BasicDrive Tbr: fukino No-Presubmit: true Bug: 836254, 842442 Change-Id: Ie03fce011bcdb6ba1b20bf2d832aedee0e792feb Reviewed-on: https://chromium-review.googlesource.com/1061433 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559051}
-
Boris Sazonov authored
This CL implements a flow to add an account in SigninFragmentBase. It uses a different approach from the one of AccountSigninView, as it overrides onActivityResult to get the result of the activity that actually adds accounts. Intent used by AccountAdder doesn't return any results to onActivityResult, so this CL also adds AccountManagerFacade.createAddAccountIntent to get a proper intent from Android AccountManager. See https://crbug.com/814728#c50 for more details. Bug: 814728 Change-Id: I4d77f8685fff496a01d9e48c91659dc7355bf505 Reviewed-on: https://chromium-review.googlesource.com/1059518Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#559050}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I3d407c60b853ce62c37d00d97673d18e9b288b24 Reviewed-on: https://chromium-review.googlesource.com/1061236Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/10e7e5013c41..80c32ccbbcc6 $ git log 10e7e5013..80c32ccbb --date=short --no-merges --format='%ad %ae %s' 2018-04-25 jiawei.shao ES31: Add extra transform feedback rules in EXT_geometry_shader Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I12dc3a21299ac557944e3330d23d63d12b5d066b Reviewed-on: https://chromium-review.googlesource.com/1061333 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559048}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I6e6e5acba61aa3f48bdf4770d6deab998f4723f3 Reviewed-on: https://chromium-review.googlesource.com/1061233Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/982a3ae5..41835253 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5c98f922655cb298ef472dcdb36aecd92ea004dd Reviewed-on: https://chromium-review.googlesource.com/1061095Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#559046}
-
Manuel Rego Casasnovas authored
An element with "contain: layout" should be the containing block of any absolutely or fixed positioned descendants. The spec is very clear regarding this (https://drafts.csswg.org/css-contain/#containment-layout): "The element acts as a containing block for absolutely positioned and fixed positioned descendants." The patch just adds a new condition to ComputedStyle::CanContainFixedPositionObjects(). We already had the condition for paint containment before, so this takes advantage to add WPT tests to verify that case too. This patch causes that contain-layout-005.html starts to fail, but that's because of crbug.com/843329. There are more failing tests related to that bug, so TestExpectations is modified to reference it. BUG=785212 TEST=external/wpt/css/css-contain/contain-layout-006.html TEST=external/wpt/css/css-contain/contain-layout-007.html Change-Id: I8bb1d637bd7742961a414a5007b8ee8a8d3e66ea Reviewed-on: https://chromium-review.googlesource.com/1059557Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#559045}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I361dc479f0e8bdb1054107bc9caf60b476608116 Reviewed-on: https://chromium-review.googlesource.com/1061253Reviewed-by:
-
Gabriel Charette authored
TBR=danakj@chromium.org, kylechar@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0d9637bd1a7ef0c7096482d0e612f67da3a8dc1d Reviewed-on: https://chromium-review.googlesource.com/1055887Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559043}
-
Guido Urdaneta authored
Bug: 843149 Change-Id: Ic7504928e13de7e19e286f351997d28b19e0e18f Reviewed-on: https://chromium-review.googlesource.com/1059625 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559042}
-
Noel Gordon authored
This creates Tasks/FileManagerBrowserTest. Move old fixtures into this new fixture. The old fixtures now go the way of the Dodo and Flakiness Dashboard will stop getting data from them. That's fine - the new test fixture provides the "tasks" test data. These test are not supported on mash: add mash test exclusions. Remove the "CanHandle type" comment: that bug was fixed. QuickView must still be excluded in my testing: retain its exclusion. Tbr: slangley No-Presubmit: true Bug: 843030 Change-Id: I7b3d9a1d3cd30d5934289ddc3a3ba0cd473246db Reviewed-on: https://chromium-review.googlesource.com/1060936 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559041}
-
Sami Kyostila authored
Use the "Chrome" product when uploading crash reports in headless mode. In order to make the headlessness of these reports easier to spot, we also set a permanent "headless=true" crash key. BUG=824850 Change-Id: I389134f46ce101c6cb88bd15a885cf1877a70483 Reviewed-on: https://chromium-review.googlesource.com/1059621Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#559040}
-
Kristoffer Erlandsson authored
This test was converted to a layout test in https://crrev.com/c/1057249. BUG=chromium:840737 Change-Id: Iebed1ea6f8707928e3b5cfcb2fff5e21bb8c159b Reviewed-on: https://chromium-review.googlesource.com/1061174Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Cr-Commit-Position: refs/heads/master@{#559039}
-
Alexander Alekseev authored
This is a reland of b3216ae7 after Chrome-only resources landed. Original change's description: > Chrome OS OOBE: Update Sync Consent screen. > > > This CL adds new UI only, no C++ bindings. > > > Bug: 822889 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I849880b096f7305903f17b2389aa2f9fc731698b > Reviewed-on: https://chromium-review.googlesource.com/1053156 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558918} TBR=michaelpg@chromium.org Bug: 822889 Change-Id: Ic84d29bf65739e012ccaa4189173f97a95c99b56 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1061213Reviewed-by:
-
Hajime Hoshi authored
The name TaskRunnerImpl no longer makes sense. This CL renames the class with a more obvious name. Change-Id: I34926805f0f560d2b0fb58bb3ba68cfa0078f4a7 Reviewed-on: https://chromium-review.googlesource.com/1060776 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Colin Blundell authored
As a step toward completely eliminating the usage of ProfileIdentityProvider in //components/gcm_driver, this CL replaces direct usage of ProfileIdentityProvider in AccountTracker with equivalent usage of SigninManager. Note that it is easy to verify that the usage is equivalent: - The IdentityProvider instance passed in to AccountTracker is always a ProfileIdentityProvider instance. - The IdentityProvider method calls are replaced with their implementations in profile_identity_provider.cc. The production changes are straightforward, but substantial changes are required to the GCMAccountTracker and AccountTracker unittests to have them use FakeSigninManager(Base) where they were previously using FakeIdentityProvider. In particular, the GCMAccountTracker unittest now requires an explicit separation of when an account being added is the primary account vs. a secondary account (whereas FakeIdentityProvider was happy to simply override its value for the active account, SigninManager does not allow for signing in when there is already a signed-in account). The goop required to set up this fake infrastructure in the unittests will be substantially simplified when we complete the process of converting the production code to talk entirely to IdentityManager. Note that for the moment IdentityProvider is still used by AccountTracker to access the token service. A followup CL will pass in the token service directly and completely eliminate AccountTracker's usage of IdentityProvider. Full design doc here: https://docs.google.com/document/d/1OmNrIiMDkF7eOYVB4RIiDvY7pQz3zUrOf-D4TVwdRQA/edit?ts=5aa6b936# Bug: 809923 Change-Id: Ifef69551a215571362610167c3a4cb38c932ff70 Reviewed-on: https://chromium-review.googlesource.com/1046587Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#559036}
-
Greg Kraynov authored
Bug: 783309 Change-Id: Ibfd73d8bd6f6f2c7640e345e0292f3bad0946b83 Reviewed-on: https://chromium-review.googlesource.com/1057329Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#559035}
-
btolsch authored
The mojom gn template provides visibility_blink to control the visibility of mojo binding targets to be used by blink separately from the normal binding targets generated by the template. This change removes some visibility_blink targets that were added for unused, but template-generated, targets. Bug: None Change-Id: If158d4cd4f2ebeb5376ce9be8013a1be5d34ee60 Reviewed-on: https://chromium-review.googlesource.com/1054612Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#559034}
-
Bruce Dawson authored
This change switches the VS 2017 package to use VS 2017 Update 7.1 while using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR features, and to stop forcing external developers to install an old ([Spring] Creators Update) SDK. This change will also bring in a new linker and other build tools, but the version of clang-cl will be unchanged. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading VS 2017 Update 7.1, from https://www.visualstudio.com/vs/, and then passing these parameters to the installer: --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add the Debuggers package. Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17134.0 Bug: 773476 Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b Reviewed-on: https://chromium-review.googlesource.com/1054027Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559033}
-
Alexander Timin authored
Split FrameScheduler::ThrottlingState::kThrottled into kHidden (first 10 seconds after backgrounding) and kThrottled (after 10 seconds in background, after full-scale throttling applies). BUG=776416 R=alexclarke@chromium.org,haraken@chromium.org,kinuko@chromium.org Change-Id: I5692bfbcbf19cca10a89678f4ab0a9c77c9162d0 Reviewed-on: https://chromium-review.googlesource.com/1059553Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Marc Treib authored
This cleans up a "temporary workaround" that was put in place for M29, which doesn't seem to be needed anymore: Before this CL, ProfileSyncService would set the access token to "credentials_lost" instead of leaving it empty. AFAICT, there's no reason to do this anymore; anyway I wouldn't know what the semantic difference between this dummy token and an empty token would be. Bug: 273096 Change-Id: I4936251e629e8e8b416ad2b0b49f8cfe60b424ae Reviewed-on: https://chromium-review.googlesource.com/1051242 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559031}
-
Bernhard Bauer authored
The histogram was never mapped in histograms.xml, so nothing useful has been done with it. Bug: 642629 Change-Id: I1ad0158929f3367e876ec7d74f536238c53db949 Reviewed-on: https://chromium-review.googlesource.com/1054072Reviewed-by:
-
Arthur Hemery authored
This CL introduces a new flag to enable the use of per navigations mojo interfaces and allow for progressive rollout of the feature. See bug for the feature design doc. * Add content::feature PerNavigationMojoInterface Bug: 784904 Change-Id: I5bb97a9ea0dbec5b34fe3d247d0c40f05a145fd7 Reviewed-on: https://chromium-review.googlesource.com/1057674 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#559029}
-
Jan Krcal authored
This CL moves the ModelTypeControllerDelegate interface out of the ModelTypeSyncBridge interface. The interface is now directly implemented by ClientTagBasedModelTypeProcessor wich is the more natural thing to do as most of the functionality is anyway already implemented there. This is part of the bigger effort to hide the bridge interface from the internals of sync. Bug: 819993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I74152497d46a389d127ca09a3678510b6a0efb9d Reviewed-on: https://chromium-review.googlesource.com/1025893 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Benoit Lize authored
Library prefetch sometimes fails on some Android x Chrome versions. Adding a detailed histogram to get the root cause. See the attached bug for details. Also a bit of cleanup: - Move the broad histogram recording to native - Change a few function's signatures accordingly. Bug: 843102 Change-Id: I5952141c541f51975aca908ab800d389bac1a183 Reviewed-on: https://chromium-review.googlesource.com/1059619 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#559027}
-
Andy Paicu authored
This feature is getting to big for a single code review so I'm splitting it up. This is all behind the experimental CSP features flag. What is covered: The 'navigate-to' directive is now parsed and understood The navigation relevant directives are passed as part of common params A navigation csp context is created out of the navigation relevant directives This navigation csp context is used to perform the 'navigate-to' checks What is not covered but I will cover in future CRs: securitypolicyviolation events are raised on the wrong host because we don't know what the initiator is CSP reports are sent using the current frame host as an intermediary which has negative security implications There are no WPT tests for the 'unsafe-allow-redirects' flag, only unit tests I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EJ4xF_DwZyk Spec: https://w3c.github.io/webappsec-csp/#directive-navigate-to Bug: 805886 Change-Id: Iaab324163dbe7389dcd440afa1ee51c0de215401 TBR=jochen@chromium.org Change-Id: Iaab324163dbe7389dcd440afa1ee51c0de215401 Reviewed-on: https://chromium-review.googlesource.com/957726 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#559026}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01433c15..982a3ae5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifd944dcf5b9a30e01c7d5a966a106fb4e7b082a4 Reviewed-on: https://chromium-review.googlesource.com/1060914Reviewed-by:
-
Christos Froussios authored
Currently, we upload a crowdsourcing vote every time the user corrects the password manager's save prompt, because it detected that the value from a wrong password field should be saved. However, passwords are obscured as dots. The vote is untrustworthy, unless we also know that the user has viewed the actual value of the password. With this CL, we add to the vote whether the user asked to see the actual password values. Bug: 817750 Change-Id: I5bf02d31c3bcc0dcdb3828c0ed167c287c191085 Reviewed-on: https://chromium-review.googlesource.com/1013579Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#559024}
-
Tsuyoshi Horo authored
The cl "5e1b52dd" which made ThreadableLoader use DocumentThreadableLoader for sync loading from worker thread had broken existing site. https://crbug.com/840348 This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't support CORS after redirect. It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously() support it. So This CL revives WorkerThreadableLoader for sync XHR. Bug: 840348, 706331 Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537 Reviewed-on: https://chromium-review.googlesource.com/1060793 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Kristoffer Erlandsson authored
Does the connection setup in a specific sequence that historically triggered a deadlock (https://crbug.com/736725). The test simply verifies this specific sequence completes without errors or timeout. Verified it fails on the deadlock by running the test on the parent commit (2485344d) of the original bug fix. BUG=chromium:840737 Change-Id: I93d9d8cb50cad9629268971520de489450d8649b Reviewed-on: https://chromium-review.googlesource.com/1057249Reviewed-by:
-
