- 09 Dec, 2020 40 commits
-
-
Asami Doi authored
Currently, a warning message logs to the DevTools console when the offline capability check fails in the "warn_only" mode. This CL enables to show the message in Application > Manifest > Installability in DevTools too (only when the mode is "warn_only"). `WARN_NOT_OFFLINE_CAPABLE` doesn't affect the result of whether or not showing install prompts. Bug: 965802 Change-Id: Iadb169230fe3a82821d011551ad98cd221b259d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576980 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835053}
-
Moe Ahmadi authored
Both OmniboxLocalZeroSuggestForAuthenticatedUsers and OmniboxZeroSuggestCaching are enabled by default and should be disabled in the fieldtrial testing config Bug: 1136654, 1136649 Change-Id: I1ae031c14d932ce56265414a92da7faa7ac9e425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580781 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#835052}
-
Ken Buchanan authored
This change: - Appends a 'Sec-WebID' header to flag what kind of traffic this is to the IDP and guard against CSRF. - Restricts WebID to potentially trustworthy origins rather than URLs - Fixes a crash in OnWellKnownLoaded Bug: 1141125 Change-Id: I13d55c67ee79a8060f1947baec778350b4f5b872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579823 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835051}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I8535b49f7291e601e041ca062f4490efdd12b329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580586Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835050}
-
Bao-Duy Tran authored
Almost all of input_methods.txt [1] is obsolete; it's on track for complete deprecation and hopefully removal. It's a remnant from before the migration to extension-based input methods, approx 9 years ago. This CL further trims gen_input_methods.py (follow-up to [2]), hence also the C++ code it autogens, to the minimal that Chrome-on-CrOS still needs from input_methods.txt nowadays -- i.e. an allowlist of XKB layout IDs for login and lock screens. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=8cbe6597e4cc8457f4e33ef2ad189f0553f59f54 [2] https://crrev.com/c/2569231 Bug: 1134526 Change-Id: I69c12fed9c3c20c3e77428a4e4a4dcda7496a365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576301 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#835049}
-
Alexander Timin authored
R=shaseley@chromium.org BUG=1155905 Change-Id: I80c643923a0c607f49e48a3e8813d197f696ec2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580524 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#835048}
-
Mark Schillaci authored
This CL is the sixth part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. ---------- This CL adds the following: - kExperimentalAccessibilityLabels flag to chrome://flags - Enables feature flag by default on Android Note: There is no change to: tools/metrics/histrograms/enums.xml as we will reuse the existing values: <int value="-1942057472" label="ExperimentalAccessibilityLabels:enabled"/> <int value="575380532" label="ExperimentalAccessibilityLabels:disabled"/> ---------- AX-Relnotes: Enables experimental accessibility labels feature flag by default on Android, and includes it in chrome://flags. Bug: 1057169 Change-Id: Ia8fab4f112b905a5a7b6ce05e45d7c345dc8b0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575727Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#835047}
-
David Black authored
This is part two of a series of CLs that will expose file change events to observers of a new browser context keyed service. In this CL, the new service is notified of copy and move events originating from Chrome OS specific file system operations which are created by the Chrome OS file system backend. This involved creation of a new chromeos::FileSystemOperation class serving as a thin extension to the default file system operation impl. This thin extension allows changes to storage// code to be minimal. Additional file change events will be wired up in a follow up CL following the same pattern. Design: http://shortn/_xrD1GHuIf1 Bug: 1136173 Change-Id: I9b906b309a1fd6b3d3f5b189c683ae6ffdd65f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551636 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#835046}
-
Robbie McElrath authored
BrowserFragmentImpl extending FragmentHostingRemoteFragmentImpl means we have a FragmentController (and therefore a FragmentManager) available to us in the main WebLayer UI. Upcoming page info changes will use this FragmentManager, and mediarouter could be refactored to use this as well instead of creating its own RemoteFragment. Bug: 1077766 Change-Id: Id659555b827feed4293b062f8b0d8c6f4889daba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575753 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835045}
-
kenkangxgwe authored
* Extract original implementation from display_settings_manager_impl.cc to screen_power_controller_aura.cc * This allows the display to be enabled/disabled when allow_screen_power_off_ is set to be false/true after screen is off. * This handles multiple power requests at the same time (e.g. SetScreenOn() and SetScreenOff() at the same time). * Add logs when screen is successfully powered on/off. * Add unittest to ScreenPowerControllerAura. Bug: b/162546246 Bug: b/173504008 Test: cast_display_settings_unittests --single-process-tests --gtest_filter=ScreenPowerControllerAuraTest.* Test: logcat | grep "screen_power_controller", mute the mic, in low light: display off mode, and toggle the display timeout on and off. Logs should show that "Screen is powered on/off". Change-Id: If470d72eeb11c53e6dea8eefbd63f71e0f6c4dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391333 Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#835044}
-
Alan Screen authored
Bug: 1151726 Change-Id: I294554670b0ee4fe4281389d0c87cfbae87b1a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580878Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835043}
-
Chong Gu authored
Bug: 1156885 Change-Id: I7474d2e833a41e6ccbb40828abac9523fcded533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581002 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#835042}
-
Xing Liu authored
This CL implements the core code for weekly notification. 1. When chrome starts, if we have unread page and no notification is scheduled, schedule a new one. 2. Before showing the notification, update the unread page count text. And schedule a new one if needed. The code to open bookmark UI from notification is not implemented in this CL. Bug: 1139073 Change-Id: I7b723ac3b6457ca1cd9c4302316806aa22db8e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558960 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#835041}
-
Mei Liang authored
The TabProperties.TAB_CLOSED_LISTENER and TabProperties.TAB_SELECTED_LISTENER properties can be null when Instant Start is enabled. This CL fixes the crash by performing a null check. Bug: 1153604 Change-Id: If1539f457023bff3de18e6a337e97daa53c6fc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580399 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835040}
-
Peng Huang authored
This is a reland of bc24c252 add failed vulkan related test in the filter. Original change's description: > Disable Vulkan for LACROS > > Bug: 1155622 > Change-Id: I8def57cef648ec4881f666aec614200d13eac972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577815 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834507} Bug: 1155622 Change-Id: I9dde50222a5d947eab2c8b63bbcd6c5d8f4409fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578170 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835039}
-
Xianzhu Wang authored
Previously we discard subpixel accumulation for all transform animations in case that the transform animation may apply a transform though which the subpixel accumulation can't be propagated, e.g. scale, rotation. However, for a translation-only animation, this caused different pixel-snapped offset of the element from the pixel-snapped offset before the animation and maybe 1 pixel glitch at start/end of the animation. Now check if the transform animation is translation only, and if yes, allow propagation of the subpixel accumulation. Bug: 1155029 Change-Id: I0cf759721b6c121f22310a445b679c7283973889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578387Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835038}
-
Brian Sheedy authored
Adds a new version of the GPU unexpected pass finder script backed by ResultDB. This allows it to now detect cases of a test expected to be flaky but passing 100% of the time, along with a number of other improvements such as outputting to a more readable HTML file. Bug: 998329 Change-Id: I96dec74a355c075bfd4badc7bc4e5c5107b950d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548644 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#835037}
-
Frank Tang authored
Make IOS smaller https://chromium.googlesource.com/chromium/deps/icu.git/+log/6a33b647c..8bb622 TBR=jshin@chromium.org Bug: 1133219 Change-Id: I7e39dbe68b6ef51b1dadca867e2cfd1c0b1cb0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580108Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835036}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99b0e4a5f4c0..0e323e7bff96 2020-12-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9a01c2d7dc575fc6ab76f0798faef071dc6eb8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835035}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/963b0a6bd915..66f231597428 2020-12-09 miu@chromium.org Remote virtual connections [2/3]: Add Open/CloseRemoteConnection(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib6ae966a41edcf8d556fcef7a7728b627200f04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581065Reviewed-by:
-
WangHui authored
Update AndroidProtocolHandler to use GURL. BUG=783819 Change-Id: I0fc389fe4190b4263562566e35d6525c32837dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578876 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607417661-b29be925ba4468c1cb5f7aba9df03f08f5d1a452.profdata to chrome-win64-master-1607450253-68d0fa295c41f196aa098d193a0a21605dcba7f2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id43bab467d3d7e9394c320b41a03283baad4b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580579Reviewed-by:
-
Noel Gordon authored
Remove redundant (non-files-ng) file_types.css filter rule. CL:2094516 removed this CSS filter rule use in files-ng for reference. Bug: 1102263 Change-Id: I1160d2a2ac332010164456c20362425d191d1dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581158Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835031}
-
James Vecore authored
The nearby-preview element was missing it's mojo deps html imports. It was passing tests when optimize_webui=true because other files were resolving the dependency in the bundle. Fixed: 1156833 Change-Id: Idf3022f74475c7ca2de021fc15d974104425b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580909 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#835030}
-
Liquan (Max) Gu authored
Motivation: * Context is the low level details that PaymentUiService should not care about, so this CL delegate the context getter to its callers. * Chrome is moving away from unnecessarily depending on ChromeActivity, so this CL replaces some ChromeActivity use cases with Context. Bug: 1154371 Change-Id: I826d2c531b986ec1498435e175b5b0834112de0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580084Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835029}
-
Julie Jeongeun Kim authored
This CL adds checking if PrintCompositeClient exists on PrintViewManagerBase::SetAccessibilityTree() since it could be null with oopif configuration. Bug: 1155909 Change-Id: I15e6b073b60f7a1889ff5b97e4ab27039538a3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574643Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#835028}
-
Joe Mason authored
Eliminate the dependency on content/ by passing a callback to bind the mojo interface instead of looking up the RenderThread. This unblocks the removal of the components/renderer/performance_manager directory. R=bgeffon Change-Id: Id2d8ebe02e1234e30a9befc824927ac4bfc3b57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575604Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607450253-17283bab00baae11cd74f4b35406a0ad23f10e88.profdata to chrome-linux-master-1607471901-85f06a8978ebf1d40d9cf80572b77a4ab0bcfbe1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1e52fdfc7a11e5dca6a3e65679a987f49af95c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580051Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607450253-216f09df6b61ffe8dbd79a2c1e7354b5e42173e1.profdata to chrome-mac-master-1607471901-3e959809a33b2895908083a52c31919f2827c11a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idda6bd8435a3153fa753f511161b4dfaf9b2301f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580050Reviewed-by:
-
John Chen authored
This reverts commit a6b685e4. Reason for revert: Bug https://crbug.com/1142286 has been fixed. Original change's description: > [Perf] Disable startup.mobile/cct:coldish:bbc > > Disable failing perf story startup.mobile/cct:coldish:bbc on two > Android platforms: > * https://ci.chromium.org/p/chrome/builders/ci/Android%20Nexus5%20Perf > * https://ci.chromium.org/p/chrome/builders/ci/android-pixel2-perf > > Notry: true > TBR: wenbinzhang@google.com > Bug: 1142286 > Change-Id: Ie742c8570505bcf100b804ed4686285143aebf5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570857 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833188} TBR=johnchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142286 Change-Id: Iaefecf53f849bd9b61b8039088c101a825e67e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578752Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835024}
-
Kunihiko Sakamoto authored
This field is set by the Network Service, for resources loaded from WebBundles. In follow-up CLs, this field will be used by the browser process to determine site isolation / network isolation keys for subframe loading with urn:uuid resources from WebBundles. Bug: 1082020 Change-Id: Ibeb8f9b35649a99d29e117104f7d960b44a305b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576310 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835023}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to https://chromium.googlesource.com/chromium/src.git/+/master/docs/lacros.md#gn-var-and-c_macros-for-lacros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I17c77521ce2902225352e425cc4a6dfb94a939b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536429Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch adds a new structure CounterStyleMap to each tree scope. There is also one map for user rules, and one map to user agent rules. CounterStyleMap indexes all the counter styles defined in the tree scopes, and also has logic for: - Given a tree scope and a name, resolving the tree-scoped reference following proposal [1] - Resolve and update 'extends' and 'fallback' references after active style changes Note that we cannot share CounterStyleMap between tree scopes even if they have the same rule set. This is because the same rule may have its 'extends' and 'fallback' resolved differently when used in different tree scopes. The complicated parts are: - We must resolve references in parent scope before child scopes, but ScopedStyleResolver::AppendActiveStyleSheets() is not called in the tree order - We need to update references when active style changes. Moreover, an active style change in one tree scope may affect references in the child scopes, and it's hard to keep track which tree scopes are affected. So we end up updating all unconditionally - We need to detect cycles in 'extends' Therefore, the reference resolution and update is done for all tree scopes at the end of StyleEngine::UpdateActiveStyleSheets(). [1] https://github.com/w3c/csswg-drafts/issues/5693#issuecomment-736868418 Bug: 687225 Change-Id: Ib907103438c5c996f6abfc81f4ff22fd932a827a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574064 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835021}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607417661-75f85540ed87ef8a12b8b8faecb9dcd6afc972b8.profdata to chrome-win32-master-1607450253-e5743bc31deb2e7a7a12ff155c587ac00d61c43d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37b914a5482894738c9ac5f66c1a8c74647b3b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579829Reviewed-by:
-
Josh Nohle authored
After the user selects a device to send a payload to, but before the payload transfer commences, the sending device initiates the creation of a secure connection to the receiving device via the Nearby Connections library. In this CL, we track whether this attempt to establish a connection succeeds, fails, or is cancelled by the user. For successful attempts, we also track the time needed to set up the connection. Because the sender initiates the connection, these metrics are only logged for outgoing connections. Manually verified for successful, failed, and cancelled attempts. Bug: 1105579 Change-Id: Ife7a5f23e59f657f5c4310a586b004ffe81d1d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580705 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#835019}
-
Mohsen Izadi authored
To be able to report compositor thread event dispatch breakdowns for EventLatency metrics, this CL adds relevant timestamps to cc::EventMetrics. The actual breakdowns will be added to UMAs and UKMs in follow-up CLs. Since we expect all events have non-null timestamps, this CL updates some tests to use non-null timestamps for events they create. Bug: 1054009 Change-Id: I106e535fe12e255055d21edf22295f8e94f5fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554398Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835018}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: I7d5a32b43de29f65478b0b20a8d61052262f8cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578018 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#835017}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf980426002..a737e5f65ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idc7cc66bdff8ad777cccb838bebe7a8148eb7382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580911Reviewed-by:
-
Jason Lin authored
The old implementation is based on an older version of UX mock which shows two notifications (one camera and one mic) in this situation. Bug: b/167491603 Change-Id: I15ace40efec18509b971e7e2d8cb2b1b0c197eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576232 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#835015}
-
Alan Cutter authored
web_app_frame_toolbar_view.cc contains too many classes for comfort (7). This CL puts it (and related classes) under a frame_toolbar/ directory and splits the classes out to the following files: - web_app_content_settings_container.h/cc - web_app_frame_toolbar_utils.h/cc - web_app_navigation_button_container.h/cc - web_app_toolbar_button_container.h/cc This is a code move with no changes to behaviour. Any additional changes are to keep up with current style rules (e.g. using base::ScopedObservation over base::ScopedObserver). Bug: 1155421 Change-Id: I28abd997ff87d9e4e96e1f5a3bea21c029ae3fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576988Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#835014}
-
