Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 08 Jun, 2018 31 commits
  3. 07 Jun, 2018 9 commits
    • dpapad's avatar
      WebUI Polymer 2: Update Polymer.Templatizer usage in settings-idle-load. · 29d93f0b
      dpapad authored 
      Need to override |_forwardHostPropV2| method for Polymer 2. |_forwardParentProp|
and |_forwardParentPath| can be removed after Polymer 2 migration is done.

Bug: 849788
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic77854582a5184fa41fe5dca02724c9f2cc7dc7d
Reviewed-on: https://chromium-review.googlesource.com/1091653Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565470}
      29d93f0b
    • Mark Cogan's avatar
      [iOS] Tweak tab grid segmented control backgrounds. · 9f95184b
      Mark Cogan authored 
      This CL makes the background separators for the segmented control
transparent (by making the background view itself transparent). It also
adds an alpha parameter for the background color in anticipation of
making the background itself somewhat transparent.

Bug: 849647, 849646
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia17c32297a73de9de2a4903a84829f6c5f4dae75
Reviewed-on: https://chromium-review.googlesource.com/1091536Reviewed-by: default avataredchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565469}
      9f95184b
    • Kyle Horimoto's avatar
      [CrOS MultiDevice] Add SharedResourceScheduler. · f8c77740
      Kyle Horimoto authored 
      This class is used to prioritize incoming connection requests according
to their priority and time that they were received.

This CL will be used in the upcoming BleAdvertiser class, but it is
named generically so that it can be easily reused for future connection
mediums that require shared resources.

Bug: 824568, 752273
Change-Id: I9a21997f3e03cc439412c3bb8db398a5a448e146
Reviewed-on: https://chromium-review.googlesource.com/1088152Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565468}
      f8c77740
    • Min Qin's avatar
      Escape json string for download tracing · 337748e4
      Min Qin authored 
      The filename and URL may contain special characters that require escaping
Or otherwise the json file won't open

BUG=850734

Change-Id: Ic4164cd0512c0ba288b6039b2b4bd8dc4f63bb0d
Reviewed-on: https://chromium-review.googlesource.com/1091391Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565467}
      337748e4
    • Xiaohan Wang's avatar
      media: Improve Widevine EncryptedMediaTest.PolicyCheck · 7d3fff95
      Xiaohan Wang authored 
      This CL adds more detailed test case for EncryptedMediaTest.PolicyCheck
when using Widevine key system. Note that the test is bypassed on
ChromeOS since Widevine CDM on ChromeOS doesn't support this API yet.

Bug: 849846
Test: Add more detailed test case.
Change-Id: Iae08027f8fae25710dd5b997ff4942c234c04192
Reviewed-on: https://chromium-review.googlesource.com/1087438
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: default avatarJohn Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565466}
      7d3fff95
    • John Abd-El-Malek's avatar
      Fix DCHECK in NetworkServiceTestHelper on network process shutdown because... · caf0d18b
      John Abd-El-Malek authored 
      Fix DCHECK in NetworkServiceTestHelper on network process shutdown because bindings are destructed on the wrong thread.

Bug: 846445
Change-Id: I765b613ea68201382da3f437e9f6a57904839bba
Reviewed-on: https://chromium-review.googlesource.com/1091806Reviewed-by: default avatarJay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565465}
      caf0d18b
    • danakj's avatar
      Keep ClientResourceProvider alive forever in LayerTreeHostImpl · b90335db
      danakj authored 
      Instead of creating and destroying the ClientResourceProvider with
the LayerTreeFrameSink, create it once and keep it around until the
LayerTreeHostImpl is destroyed. This allows ResourceIds to remain
valid when the LayerTreeFrameSink is replaced while software
compositing (which can happen if the viz service crashes).

We add a method ShutdownAndReleaseAllResources() on
ClientResourceProvider that will release any exported resources,
marking them as lost, instead of doing so in the destructor,
so that the owner of the class can control the timing more without
needing to heap-allocate the class.

We also take away the allowance for importing a ResourceId and
not removing it before destroying the ClientResourceProvider (or
calling ShutdownAndReleaseAllResources()). Instead we have it
DCHECK() if this occurs, reporting the stack trace from where
the resource was imported. We do this because marking resources
that are not exported as lost is silly, since they were imported
they could have been removed. A bunch of unit test changes are done
to remove resources that were imported because of this.

Two unit tests that tested the case of destroying the
ClientResourceProvider while imported resources were present are
removed since it is no longer supported.

When the CompositorFrameSink is lost, the LayerTreeHostImpl loses
the ability to receive back resources it had previously exported.
We add a method ReleaseAllExportedResources() on
ClientResourceProvider to handle this case, which removes the
export count on all resources, releasing any marked for deletion
previously. When software compositing, they do not need to be
marked lost, but when gpu compositing they do since the display
compositor modifies texture metadata in order to use them. Tests
for the new method are added, as well as to verify that in
LayerTreeHostImpl, when the CompositorFrameSink is replaced, that
the ResourceIds are not kept around.

The software-resources-aren't-lost distinction is not important in
this CL, since LayerTreeHostImpl destroys all its resources
regardless when it tears down the ResourcePool and
RasterBufferProvider. However for external clients which provide a
resource through TextureLayer, the ResourceId can remain valid in
software compositing.

R=piman@chromium.org

Bug: 826886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I85a867c2830c31d39796ff971e01a221e5716812
Reviewed-on: https://chromium-review.googlesource.com/1083617Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565464}
      b90335db
    • Trent Apted's avatar
      Cocoa: Mark the bookmark draggable button action as fired _before_ performing the action. · b2f5b3a6
      Trent Apted authored 
      Opening an entire bookmark folder with more than 20 bookmarks in it
from the bookmarks bar using Cmd+Click on a Cocoa browser is currently
broken. This happens in the bookmark draggable button's action.

The action may run a nested loop, which may see the mouse "up" event and
cause the action to be performed again, inside the nested loop. We also
need to ensure the bookmark button doesn't enter its _own_ nested run
loop, since the mouse up has already been eaten by the nested run loop
inside the action.

Failure to do so causes the action to happen twice, which results in the
nested run loop of the action spawning another, nested, run loop within
itself, which never exits. This puts the browser into a very weird state.

TEST=On Mac (chrome://flags/#views-browser-windows DISABLED), have a folder
     on the bookmarks bar with >20 items and Cmd+Click it. Accept the dialog.
     Bookmarks should open.

Bug: 849135, 840387
Change-Id: I7e1eaf57dff956647cbdcf2cb449bb971cada074
Reviewed-on: https://chromium-review.googlesource.com/1090513
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565463}
      b2f5b3a6
    • Nick Harper's avatar
      Set SSLConfig.channel_id_enabled for the proxy config · 25a0c4ba
      Nick Harper authored 
      Prior to crrev.com/c/1026630, SSLConfig.channel_id_enabled defaulted to
true, meaning that the proxy SSLConfig had Channel ID enabled. That CL
flipped SSLConfig.channel_id_enabled to default to false, but only set
channel_id_enabled on the server config, not also the proxy config. This
change should restore the behavior of Channel ID on proxies to what it
was before crrev.com/c/1026630.

Bug: 848953
Change-Id: Ibfde08309803e4bebac622b0d6366a2256ff2b58
Reviewed-on: https://chromium-review.googlesource.com/1089859Reviewed-by: default avatarSteven Valdez <svaldez@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565462}
      25a0c4ba