GitLab

BUG=790343,864817

Change-Id: Ia6bbae90334828022d5ec994d5ab82427c1cb66d
Reviewed-on: https://chromium-review.googlesource.com/c/1284769
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600132}

This CL enables presentation in iPads as a popover instead of above the keyboard.
This follows the UX design for Manual Fallback.
- Makes sure the accessory bar for iPad is always added when Manual Fallback is Enabled.
- The responsibility of not showing the accessory bar when other UI is presenting the
keyboard is now fully own by the input accessory bar view controller.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ife13cc44b4912084ccb10376ee9c53039dc00548
Reviewed-on: https://chromium-review.googlesource.com/c/1256793
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600131}

Bug: 670615
Change-Id: I2a7592581cc251b9f1a21171416ea3492932e218
Reviewed-on: https://chromium-review.googlesource.com/c/1281047Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600130}

This is UI side code to handle buttons in assistant notification.

Bug: b/117295934
Test: manual.
Change-Id: I61144f418ba7af127c09892707ba442e8c5f5e65
Reviewed-on: https://chromium-review.googlesource.com/c/1274826
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600129}

https://docs.google.com/document/d/1dzjfTfiTf_wVq_cwH85i2VQWDjKWt3ZsiqokZg21jjw/edit?usp=sharing

Bug: b/117274233
Change-Id: I9ac16364a62cb8f55925dc8d5d04fdc5ce425ae9
Reviewed-on: https://chromium-review.googlesource.com/c/1277844Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Leo Liu <luciferleo@google.com>
Cr-Commit-Position: refs/heads/master@{#600128}

This CL adds support for Vulkan on windows but disables it in builds.
This makes it easy to enable and test.

BUG=850724

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8396b2f59133df5d72d1086cf22e154dba0bb15e
Reviewed-on: https://chromium-review.googlesource.com/c/1270098
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600127}

We used to have the touch adjustment range as 32dip in diameter (16dip
in radius) for Android. After the zoom-for-dsf change, the pointerevent
width & height became in physical pixel. It makes the actually range in
dip much smaller on Android.

This CL changes the adjustment range to be 32 CSS pixel, and apply the
zoom_factor before compare with the pointerevent width&height.

On Android, there is no ctrl +/- page zoom, so CSS pixel is dip. There
is no change in behavior.
On Desktop (aura), the adjustment upperbound is affected as it wasn't
consider zooming before but now it does. Therefore, the bound will be
affected by zoom_factor.
On aura, there wasn't an upper bound for adjustment range before the
unified touch adjustment change, which means the adjustment range is
always the pointerevent width & height (physical pixel not changed).
When we zoom in, the upper bound is increased, but the adjustment range
will follow the finger size. So I think it's ok to make the bound
changing with zooming as well on aura.

Bug: 894961
Change-Id: I466d6b187359f13c82c62860086cb9eeef8cb2a5
Reviewed-on: https://chromium-review.googlesource.com/c/1279204
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600126}

4c984bc7 requires angle to call a script
in build/util/, but this directory is in src/ in chromium, and ./ in
angle.  Similar to how angle_root was defined to point to the right
directory in each project, src_root is added to point to src/ or ./
depending on the project as well.

This is necessary for angle to be able to roll its dependencies forward.

Bug: angleproject:2892
Change-Id: I691d378c76bb238071a59db2298206eba55278bb
Reviewed-on: https://chromium-review.googlesource.com/c/1283830Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600125}

Makes ToolbarActionView::DoShowContextMenu use GetAnchorBoundsInScreen
which insets into the view to match the visible inkdrop hover effects.

Bug: chromium:800372
Change-Id: Ibe2bfe93547bae75590c87214e2c1ed0b73aa37b
Reviewed-on: https://chromium-review.googlesource.com/c/1281919Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600124}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3f52fd0306b..baa4e9b9a71c


Created with:
  gclient setdep -r src-internal@baa4e9b9a71c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1304fe2a9b18c769175ae4f601d2aab92c2aa168
Reviewed-on: https://chromium-review.googlesource.com/c/1284429Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600123}

This metric should be the number of queries fired per each entry point,
e.g. keyboard, OKG, launcher button, longpress applist. This includes
the first query fired immediately after each entry point and follow up
queries before window close.

Test: local compile and manually test.
Bug: b:117517666
Change-Id: I77c906ab95598a1e819f261462c50372c3aa07ea
Reviewed-on: https://chromium-review.googlesource.com/c/1278149
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600122}

https://pdfium.googlesource.com/pdfium.git/+log/bb3f58dbcb71..c3da36973048


git log bb3f58dbcb71..c3da36973048 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 thestig@chromium.org Use unique_ptr in CFX_FolderFontInfo::ScanFile().


Created with:
  gclient setdep -r src/third_party/pdfium@c3da36973048

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9aa38e275f26822a58ce7c52fffb6526f94455d6
Reviewed-on: https://chromium-review.googlesource.com/c/1283515Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600121}

Hides Play Store in Demo Mode by default, because it doesn't show the
right view yet.

To test Play Store in Demo Mode after this CL, use the flag:
  --show-play-in-demo-mode

Bug: 885370
Change-Id: I7119a208742caf3fd2884ac73176a9bbc19a2bde
Reviewed-on: https://chromium-review.googlesource.com/c/1277841Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600120}

Use of TransientWindowClient and ActivationClient allow the same
implementation to work in both classic and Mash.

Bug: 640365
Change-Id: I10324dce04bb014c09d04f45c0be6e691017a648
Reviewed-on: https://chromium-review.googlesource.com/c/1271403Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600119}

Change-Id: I42a856d35b0fcee1b6340cebd766a3149d0d85db

Reviewed-on: https://chromium-review.googlesource.com/c/1283475Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600118}

In Network Quality Estimator (NQE), remove the logic to compute
increase in RTT since this is not being used anymore.

Change-Id: Icf1785cf5a11152c529ac40da7da43110dce382e
Bug: 895878
Reviewed-on: https://chromium-review.googlesource.com/c/1279946
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600117}

In https://chromium-review.googlesource.com/c/chromium/src/+/754130 we
switched to populating the is-repeat flag of ui::KeyEvent solely based
on the flags in the underlying native event, if present.

In the case of a key event triggering a pop-up window to appear, this
caused the first auto-repeat of that event to be dispatched without the
repeat flag set.

To address this we restore the "fallback" path to manually determine
whether an event should be flagged as a repeat, in the case of where a
native event does not itself have the repeat flag set.

Bug: 895266
Change-Id: Ia224e38768d67bf0dc74d60d7e5ed7b6b6663d80
Reviewed-on: https://chromium-review.googlesource.com/c/1281874Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600116}

This CL changes JpegImageDecoder so that it doesn't advertise that it
can support smaller decode sizes if the original size cannot fit a whole
number of MCUs in both dimensions. This is done to prevent artifacts
from showing up when downscaling certain images.

dark line at the bottom.

Test: opened the JPEG attached to the bug and verified that there is no
Bug: 890745
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I884edcefc4bbd0612e621109c24aedc09cad3452
Reviewed-on: https://chromium-review.googlesource.com/c/1274845Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600115}

This is to reflect a change in the design doc.

Bug: 887991
Change-Id: I8dbc058549ffd6bc9fbaf9d0d20d0d8d6ce30158
Reviewed-on: https://chromium-review.googlesource.com/c/1283938Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600114}

Bug: 872343
Change-Id: Icb7aef94a64039b45f2284fc9ff9fe2dba33296e
Reviewed-on: https://chromium-review.googlesource.com/c/1284062Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600113}

Sometimes when the user is not signed in on debug builds, only ~5
destinations show up in the "Print destinations" list. Fix this by
firing iron-resize when all destinations are done loading.

Bug: None
Change-Id: Id406b8aaaeccffd3a6419ea30a3396fc6ca7d157
Reviewed-on: https://chromium-review.googlesource.com/c/1282034Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600112}

Android truncates long logs in __android_log_write. This is useful
to avoid too verbose logs and save cpu/memory, but we do need some
complete verbose logs for debugging.

Now if DCHECK_IS_ON(), split long logs by new lines and call
__android_log_write for each line to avoid the truncation.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib19c718a8f1d2fe1f2e155c38e1106174b38ae02
Reviewed-on: https://chromium-review.googlesource.com/c/1281883
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600111}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab45d6915434..b407163ef346


git log ab45d6915434..b407163ef346 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 stevenperron@google.com Checks for variable pointers (#1976)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@b407163ef346

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id4af123bcdb7f3bba922473ce27837100ebbbf56
Reviewed-on: https://chromium-review.googlesource.com/c/1284013Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600110}

This is failing on the N9 FYI bot, see issue 895945.

TBR=kbr@chromium.org

Bug: 895945
Change-Id: Ib735cbfcc04e334cc9204acf8ccc2792239323c5
Reviewed-on: https://chromium-review.googlesource.com/c/1283952Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600109}

This may happen if all windows other than the app in question are
minimized because overview tells app list to slide in/out if all windows
are minimized (the dragged app is excluded from overview).

Test: manual
Bug: 888149
Change-Id: Ib883b138939991195c1dc939a1a5b513384a8cfb
Reviewed-on: https://chromium-review.googlesource.com/c/1241562Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600108}

Partial revert of crrev/c/1189044.

Bug: 894006
Change-Id: I2c2fea22a417f6ae1b97289a4f261263333d5864
Reviewed-on: https://chromium-review.googlesource.com/c/1284055
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600107}

CachedLayoutResult is cleared in the early phase of layout
if NeedsLayout(). This makes hard to re-use part of cached
fragments for inline layout.

The clearing seems no longer necessary, as FinishLayout()
always SetCachedLayoutResult before it calls
CopyFragmentDataToLayoutBox(), which calls ComputeOverflow().

Bug: 35619, 844751
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Id728deb5bc5c5b29e73c0835d6ffc5b22ee92121
Reviewed-on: https://chromium-review.googlesource.com/c/1282802Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600106}

Bug: 895700
Change-Id: I4d62c1c4550609db7433b3109f920524f8aab77d
Reviewed-on: https://chromium-review.googlesource.com/c/1283948
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600105}

Bug: 670615
Change-Id: Ia42b62d84082a431e615721cb0065d5d6b43fdd3
Reviewed-on: https://chromium-review.googlesource.com/c/1280856Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600104}

Some GTK themes respond to the "prefer dark mode" preference.  Reset all colors
when this preference changes to play nicely with these themes.

BUG=None
R=pkasting

Change-Id: I7758bab27e99e7f88df4ffcfb3ff0cf6a18530d5
Reviewed-on: https://chromium-review.googlesource.com/c/1284269
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600103}

This reverts commit c19106d1.

Reason for revert: Causing multiple mac gpu fyi failures crbug.com/895984

Original change's description:
> Remove WaitSyncTokenCHROMIUM command
> 
> After migrating InProcessCommandBuffer to use GPU scheduler, most tasks
> are scheduled after their sync token dependencies are satisifed (see
> crrev.com/c/1157874).
> 
> The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer
> for pepper, which specifies a sync token, and waits while handling the
> message.
> 
> Change ReturnFrontBuffer to contain the sync token, and use it to
> specify the dependency to the scheduler.
> 
> Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are
> specified as task metadata in all cases.
> 
> Make other cleanups such as removing unnecessary sync token tests, and
> make sure the sync token code paths are not used where unsupported by
> using NOTREACHED.
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272
> Bug: 778753
> Reviewed-on: https://chromium-review.googlesource.com/c/1168155
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599849}

TBR=dcheng@chromium.org,boliu@chromium.org,sunnyps@chromium.org,piman@chromium.org

Change-Id: I87347c05dded27955410b08e40f37388a484d5f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778753, 895984
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1284394Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600102}

This patch changes PositionFloats to have
NGPositionedFloatVector* to return the positioned floats,
instead of it to return the vector.

NGPositionedFloatVector has inline buffer that returning
it involves a bit of memory copy overhead.

Pinpoint shows slight improvement. We could see them within
errors, but mostly positive, and running twice shows similar
trends.
https://pinpoint-dot-chromeperf.appspot.com/job/11f3134ce40000

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I29c23e370b398f54a9acc1745f37ea9ffcb1b2fc
Reviewed-on: https://chromium-review.googlesource.com/c/1282689Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600101}

Change-Id: Ie36b88ba98d7190fab4bc613c7ad8714d7b1c118
Reviewed-on: https://chromium-review.googlesource.com/c/1282223Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600100}

Bug: b/117567490
Test: Manual Test
Change-Id: Iff6f062791e32810a54b83e35d0801cf03429f24
Reviewed-on: https://chromium-review.googlesource.com/c/1277683Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600099}

This CL actually makes use of the NUX modules in the onboarding welcome
page, instead of the placeholder pages. There will be follow-up CLs to style
them to mock.

Bug: 874151
Change-Id: Iac750fac5ec744e658770937adab69f0b81f8309
Reviewed-on: https://chromium-review.googlesource.com/c/1256010
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600098}

Add an ability to subscribe to the notifications about
ScopedTaskEnviroments being created and destroyed, which should help
with content unittests, where we have multiple ScopedTaskEnvironments
changing under one SequenceManager.

R=gab@chromium.org
CC=alexclarke@chromium.org
BUG=892139

Change-Id: Ib56fd0f1b465edd3a6dd6693b36ef3d8b9234140
Reviewed-on: https://chromium-review.googlesource.com/c/1251449
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600097}

This CL moves the memory dump internals into SharedImageBacking, which
will allow for new backing types to implement their own dump logic.

Bug: 891059
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4f239ab76e75d3b51fe3a120e7c34b20376f559c
Reviewed-on: https://chromium-review.googlesource.com/c/1279167
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600096}

The timer notification fires a deep link to initiate a text query
within Assistant to stop the firing timer.

The pending query was set before the view was fully initialized so
view state was not in sync with model state.

When this happened, we would eventually try promote the pending query
view to be the committed query view, but the pending query view did
not exist.

To fix this, we need to sync view state with the model state to ensure
that a pending query view always exists when there is a pending query
in the interaction model.

Bug: b:117771379
Change-Id: I7ad05836c95ffdd8973f11fae67051603dbfa76f
Reviewed-on: https://chromium-review.googlesource.com/c/1281169Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#600095}

Currently when view tree is updating, we visit each view in this subtree
and for each view we rebuild the subtree with that view as root and
recurse. This causes very complicated view tree, e.g. ChromeOS launcher
to flood the HTTP websocket server and overrun the buffer.

Now we avoid rebuilding subtree if we already visited it, and only send
view tree update on the root view which covers the whole subtree.

Bug: 894107
Test: locally build and run devtools with ChromeOS launcher
Change-Id: I53c87813729eb4983ce613628ae2b83e86adcd30
Reviewed-on: https://chromium-review.googlesource.com/c/1279357Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600094}

If a child surface's activation is throttled then use the system default
deadline as the lower bound for the throttling. This ensures that even if a
child does not have activation dependencies, it will still be throttled
by at least the system default deadline.

This CL also adds some debugging methods and comments on FrameDeadline.

Bug: 672962, 890767
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If675908fb2657d5d83b5717339a4060e1eb95f77
Reviewed-on: https://chromium-review.googlesource.com/c/1284050Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600093}