- 24 Nov, 2020 40 commits
-
-
Torne (Richard Coles) authored
Previous CL marked Android.WebView.ExtraHeaders.Valid as obsolete, which is incorrect; the UMA which was removed was ExtraHeadersRedirect. Bug: 1038002 Change-Id: I4508958e02a3da78edd89077efd9418f415fa7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553860 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#830611}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ife278a458c9151724a8426541063ae7d3261a49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555042 Commit-Queue: Kartik Hegde <khegde@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#830610}
-
Tomasz Wiszkowski authored
This change improves clarity of the suggestion headers by updating the text style used to render the group title. Bug: 1123740 Change-Id: I77c9b89adbc8f4cd5477deef022db3912d9d1ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556215 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830609}
-
Maksim Ivanov authored
Fix bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Icfdf8af891b11942d24bda43fb1e203333d3bd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556679 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#830608}
-
Yi Gu authored
The test BookmarkNodeDataTest.WriteToClipboardEmptyFolder has been flaky on LaCrOS: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests%20(with%20patch)&tests=BookmarkNodeDataTest.WriteToClipboardEmptyFolder TBR=erikchen@chromium.org Bug: 1010185 Change-Id: Ic30748b2c9ea93d01f794554ff0b973f00d4c396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558163Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830607}
-
Mikel Astiz authored
Adding a bookmark to a model has -obviously- the side effect that BookmarkModel gets modified, and there is no reason to enforce that the caller must hold a reference to the created node. Change-Id: I8d1ba62aa4ae61053a4ba7dea65348904a04b304 Bug: 1150829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557639 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#830606}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ff956a8..4dbfe439 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If8b35ebf9ed522246b10c051e28fea5752d629bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556567Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830605}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da303cba1a43..740b9c2b4984 2020-11-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-24 chinglinyu@chromium.org usergroup_baseline: Expect traced-probes in debugfs-access. 2020-11-24 mmortensen@google.com Rename SymbolFileTuple field names to better reflect meaning and usage. 2020-11-23 andrewlamb@chromium.org Don't use 'main' as manifest branch if builder uses manifest-internal. 2020-11-23 vapier@chromium.org git: handle worktrees If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2403aeeca7db5c0d6aa93f8e856b9c32e0bce043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830604}
-
Jesse McKenna authored
Change-Id: Ib19a8f3fb9430adb03e9b7fe16ffa20a15626369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556983Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#830603}
-
Vasilii Sukhanov authored
The builder will be able to create a foreign key and migrate the child table properly. Bug: 1137775 Change-Id: I8ce7a979e96761bc2dcd74329c101d4318662da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552918 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#830602}
-
Alice Wang authored
This CL extracts an interface for SigninManager. Bug: 1150388 Change-Id: I3be6e3b2514b39c3d9edfb4e8b3f498973c502a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550401 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#830601}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011240600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/0KTan3JjAK3TKZLqwQfdI9v6kFtn1w-lwzUN2LIDnHQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/153024363,b/171153566,b/173559681 Tbr: media-app@grotations.appspotmail.com Change-Id: I12f775419404ab11208f420787351470e77b283e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557910Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830600}
-
Illia Klimov authored
This CL reduces call sites for ContentSettingsType::PLUGINS. Bug: 1149393 Change-Id: I248c4088c4de0d6396404175e2337a76645ec189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540666Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830599}
-
edchin authored
Design doc: go/bling-phishguard Prepares files to move to /core folder. The WebContents is mostly a pass-through object (not including CSD) in PasswordProtectionRequest, except for the MIME type. This CL passes the MIME type in so that we don't need to conditionally compile calls to WebState and WebContents for this value. Bug: 1147967 Change-Id: Ic7ba3180af78806a90df0f776cf6d984553af3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553386Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830598}
-
Olesia Marukhno authored
Delete duplicated manager unit tests Change-Id: If4b400dc6a3262363cd68f0d92b7efdffcd21438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550816 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830597}
-
Yi Gu authored
The test is very flaky on linux tsan: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests%20(with%20patch)&tests=SignedExchangePageLoadMetricsObserverTest.WithSignedExchangeBackground TBR=ksakamoto@chromium.org Bug: 1082135 Change-Id: I48c41234e3d46fdb51f724f6a07dee2b743cb51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558164Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830596}
-
Anthony Cui authored
Bug: 1151492 Change-Id: I8e205b8eb39fb7ce54cec9373834980344252f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556658Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#830595}
-
arthursonzogni authored
The normal navigation code path is in the browser process. However, some edge cases were using an alternative path: CommitSyncNavigation. Not using the normal code path is a problem. Over time, we removed all of them (except one): [MHTML document]: https://chromium-review.googlesource.com/c/chromium/src/+/1547521 [srcdoc] https://chromium-review.googlesource.com/c/chromium/src/+/1547522 [blank] https://chromium-review.googlesource.com/c/chromium/src/+/1543258 One remained: the "fake" navigation to commit the "fake" initial empty document. This patch simply rename it, to make it more explicit what this is about. Bug: 936696 Change-Id: Ie44c879abe64b8a71902fb68693895e6cbfb1878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551125 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#830594}
-
Scott Lee authored
Please find the context at https://crbug.com/1148921#c3. R=robertma@chromium.org CC=chanli@chromium.org,nodir@chromium.org Change-Id: I2b037dd6c3fdc4d0e4adb322d5f3bc1fcee100ab Bug: 1148921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553532 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#830593}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4685cb937df..4c3d711704c1 2020-11-24 pfaffe@chromium.org [TS] Heap Snapshots: Type-check all the things 2020-11-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-24 janscheffler@chromium.org [Storage] Only delete first party cookies by default 2020-11-24 changhaohan@chromium.org Fix css-shadow-swatch re-register issue 2020-11-24 tvanderlippe@chromium.org Replace remaining title property setters with Tooltip.install 2020-11-24 jacktfranklin@chromium.org Revert "[Loc] Migrate changes tool to localization V2" 2020-11-24 janscheffler@chromium.org [Recorder] Add support for iframes 2020-11-24 pfaffe@chromium.org [TS] Heap Snapshots: Refactor Grid Nodes 2020-11-24 pfaffe@chromium.org [TS] Heap Snapshots: Refactor ComparatorConfigs 2020-11-24 janscheffler@chromium.org [Cookies] Add option to show url decoded cookies 2020-11-24 kimanh@chromium.org [ts] Typescript-ify TimelineModel.js 2020-11-24 yangguo@chromium.org Remove bogus hidden visibility in profile selector 2020-11-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-11-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-23 andoli@chromium.org Revert "Migrate elements/ extensions of type 'view'" 2020-11-23 chrche@microsoft.com [Loc] Migrate changes tool to localization V2 2020-11-23 janscheffler@chromium.org [DataGrid] Fix creation node 2020-11-23 tvanderlippe@chromium.org Replace title property setter with Tooltip install invocation 2020-11-23 jacktfranklin@chromium.org [Dark Mode] New colours for Breadcrumbs 2020-11-23 vidorteg@microsoft.com Fixes i18n logs show on unit tests. 2020-11-23 andoli@chromium.org Migrate elements/ extensions of type 'view' 2020-11-23 andoli@chromium.org Adds experiments compatibility to new extension registration system If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1012337,chromium:1122511,chromium:1134103,chromium:1136655,chromium:1149302,chromium:1150762,chromium:1151805,chromium:1152362,chromium:997625 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I129074e9307401c7b598a02f1c5ad09e07ddcaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830592}
-
Oleh Lamzin authored
Replace "system" by "device", because we use both "system" and "device" in the policy description which is confusing. Bug: b:174061781 Change-Id: Idaecbd4c5fe88070e2eee31944a70304104ee51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557503Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#830591}
-
Maria Kazinova authored
Moved the check to the point where submission is actually detected in order to have more meaningful Finch data. Bug: 1152433 Change-Id: Ic436fb00307098866dca1aefd27dcd92ae43ad6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556682Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#830590}
-
Roman Sorokin authored
In case new renamed policy has lower priority (for example it's the enterprise default value) and the old policy is set -- the old value should be used. Also modified a policy->pref mapping test. The issue was introduced in crrev.com/c/2507771 Bug: 1151109, 1138572 Change-Id: I3fae90729a8aad1fbc946017b1f7a5134b727826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555058 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830589}
-
Yi Gu authored
Test is also flaky on win: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=MediaFeedsBrowserTest.ResetMediaFeed_WebContentsDestroyed TBR=beccahughes@chromium.org Bug: 1124983 Change-Id: I66798e3fc1fbee904b22389f6f60c8cec5058e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558161Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830588}
-
Yi Gu authored
The test has been very flaky recently: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=MediaGalleriesGalleryWatchApiTest.RemoveListenerAndModifyGallery TBR=dbertoni@chromium.org Bug: 1150017 Change-Id: Ie5167d6db5477348b22d36d3e6198a7a3863b6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557916Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830587}
-
yjliu authored
This flag has been renamed from |can_use_backdrop_filter_cache| (for quads) and |can_use_cached_backdrop_filter_result| (for render surfaces) so that it would be more generic for use of other optimization purposes in the compositing and aggregating stages in the rendering pipeline. The name change caused the flag to take the opposite meaning, as logically if a quad intersects damage under, the backdrop filter cache on it should not be used. All relevant test cases have been updated accordingly. Bug: 1142892 Change-Id: I3ff19051f91d4b111ffedec2b544151c203f1c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556338 Auto-Submit: Jun Liu <yjliu@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830586}
-
Yi Gu authored
Per #2 from the linked bug, this could also be related to crbug.com/1138060. TBR=bsheedy@chromium.org Bug: 1149237 Change-Id: I753dfe6f364f93d9dd01314357cbb6ee8c67924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557906Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3df719619f0a..68ac3b9ec3ca 2020-11-24 brianosman@google.com Revert "Move GL's SkSL::Compiler to the GPU (like all other backends)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I3735638bc2d05e69397fb432a73801eaf3c09d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830584}
-
Yunke Zhou authored
Bug: 1133745 Change-Id: Iaf52caf6640151723c74aadbf6641504d7210089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557082 Commit-Queue: Yunke Zhou <yunkez@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830583}
-
Justin Donnelly authored
Change-Id: Ib8c3ca64d59175dd85f393acfe35c7806783da95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555472Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#830582}
-
Rahul Goyal authored
Changed "base::android::ConvertUTF8ToJavaString" to "ConvertUTF8ToJavaString" in ui_controller_android.cc, as a followup of https://crrev.com/c/2532079 Bug: b/171963823 Change-Id: Ib3dab63e863c99a1d6f1ae6d4d808ede63689d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551126Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#830581}
-
Colin Blundell authored
This CL renames the OverrideUrlLoadingResult enum to OverrideUrlLoadingResultType in preparation for introducing an OverrideUrlLoadingResult object that will package this enum together with other state about the result of an invocation of ExternalNavigationHandler.shouldOverrideUrlLoading(). Bug: 1145983 Change-Id: Ife1effecdf44dde5bb6fb3f9afe840d280e9c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556960Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#830580}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/784170929fae..185795f02ceb 2020-11-24 miu@chromium.org Fix supported_address_families DCHECK in ServiceInstance ctor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0754f5efae8b25c3be06437c9ca0047565fe7ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830579}
-
Ehimare Okoyomon authored
Make strikethrough thickness relative to icon size and introduce a bias to shift the line to only one side of the transparent line, in order to match mocks. Screenshot: crbug.com/1077766#c106 Bug: 1077766 Change-Id: I0a4730d8aba05b6f266da1b0ba53dba254cc4000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552861 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#830578}
-
Yi Gu authored
The test http/tests/inspector-protocol/service-worker/network-extrainfo-main-request.js has been flaky for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=http/tests/inspector-protocol/service-worker/network-extrainfo-main-request.js TBR=shimazu@chromium.org NOTRY=True Bug: 1087242 Change-Id: I6e2ee8020f2e67f0ca4f271929bad68776d5672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558160Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830577}
-
Alice Wang authored
This CL renames accountId to accountEmail to have consistent name for account email variable. Bug: 1131344 Change-Id: Id58ad100883473d136a9c6ccb3530cce138d0eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554600Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830576}
-
Nektarios Paisios authored
Clarifies the meaning of a document object and the names of methods that navigate to the boundaries of the whole content In the accessibility codebase, the word "document" has a confusing meaning. For a start, our definition of a "document" erroneously included an object with an ARIA role="document" even though what we really meant by the definition was the root of a web area. Our definition is not even compatible with what HTML considers to be the document object. Secondly, the method names in AXPosition that are used to navigate to the start / end of the whole content, such as the start / end of the whole webpage or PDF, were confusingly using the same "document" nomenclature. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I06a5383bd6cfbfa9a51f96547d02b83a3ac210a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538175 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830575}
-
Yi Gu authored
This test has been very flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&tests=org.chromium.chrome.browser.omnibox.suggestions.mostvisited.MostVisitedTilesTest#keyboardNavigation_highlightingNextTileUpdatesUrlBarText TBR=ender@google.com Bug: 1152246 Change-Id: I2a7fc32342a8394fad75db05368e4a5b62382308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557904Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830574}
-
Yi Gu authored
The test has been flaky on CrOS. See linked bugs for details. TBR=josiahk@google.com Bug: 1150753 Change-Id: I6941f47c7951a4a93e94529675e370edcaa2a9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557914Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830573}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/47a03e8743c9..3f77eb468fc4 2020-11-24 dmorilha@twilio.com fixing build for when HAVE_WEBRTC_VIDEO is not defined 2020-11-24 landrey@webrtc.org Fix authentication error while polling for upload results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If71039cb3a5bf20b4f9aa84f1d10d716e4e3fb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830572}
-